From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E3A1A04DB; Fri, 16 Oct 2020 16:34:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F1A91EC1A; Fri, 16 Oct 2020 16:32:48 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 45D7B1EC1A for ; Fri, 16 Oct 2020 16:32:47 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 2A8DD949; Fri, 16 Oct 2020 10:32:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 16 Oct 2020 10:32:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= d/BN/gLJEkqj/D35c7qfnJhz8TZonsd5aSdfMQ955fI=; b=NKFRve77AoL0OcXf LqrjS8rvFzahUutffbWhHxI/SY8kZPmE8pLciobVgWCV5IkM2dOi91o8rgjEjGfX xkP5HAEQp/4NW7y4copQraDBUDX2YibGn6Ldf40irvBrK9DmGMbVNOt4SWPVmPb0 Wa+N9QwD6L2aTbEbBdcvk+LurHtnLsHk7soUDqrS88QB3NABYTeeSzn9qayBr6w/ PrrD9RkmgEJyEBJTdJgkW5okQCdRaMgDQkIqMw5LYHuc/mQQGnz5iaXIcprd5f3X izfipHYHtD0pA+LOMqwGQSbZJPM/JJQeGDMno5ifXZ2BCLPaQPrjyRgW97Hil2SY aNs1+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=d/BN/gLJEkqj/D35c7qfnJhz8TZonsd5aSdfMQ955 fI=; b=eaIin39ZzXamvqdYVV5aQhryejLfxaz83x6dNflx1Agg7/ZWI+gG5QEdl ex8dSpUTNwnUgfZbtAxZAllMPClLGTppujsBR3RqQl1He8w4i+A2fBGesmA0tv7A 8/yqBZt8hqYpefbG51QQfqxxsk8rruObrgy45tPTU80P9lqjDBuGP1rmnuZASumi eLF76ci8loWm5RVY/0d4+LWu/Ua+b3g8h/g0bEjyIo/HUgXhUePZ9zYaitQnO9t5 7aICdyt4M4WA5wf8KvsSN+vYbpGOds2EZKDW75DiyEAj7x6h6n7InODMCaJ4Y0bO KvSH7Qz+O6smWAdxQK/ifR+PFSDLA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrieehgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 57124328005E; Fri, 16 Oct 2020 10:32:43 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Andrew Rybchenko , dev@dpdk.org, dev@dpdk.org, "Min Hu (Connor)" , "Wei Hu (Xavier" Date: Fri, 16 Oct 2020 16:32:42 +0200 Message-ID: <5239286.r6oyNDfoyL@thomas> In-Reply-To: <0d8f6cf8-66e0-8754-f700-aa7dfbff9aba@intel.com> References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <20201014022649.2165524-1-ferruh.yigit@intel.com> <0d8f6cf8-66e0-8754-f700-aa7dfbff9aba@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/10/2020 14:16, Ferruh Yigit: > On 10/14/2020 3:26 AM, Ferruh Yigit wrote: > > Queue stats are stored in 'struct rte_eth_stats' as array and array size > > is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. > > > > As a result of technical board discussion, decided to remove the queue > > statistics from 'struct rte_eth_stats' in the long term. > > > > Instead PMDs should represent the queue statistics via xstats, this > > gives more flexibility on the number of the queues supported. > > > > Currently queue stats in the xstats are filled by ethdev layer, using > > some basic stats, when queue stats removed from basic stats the > > responsibility to fill the relevant xstats will be pushed to the PMDs. > > > > During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' > > device flag is created. Initially all PMDs using xstats set this flag. > > The PMDs implemented queue stats in the xstats should clear the flag. > > > > When all PMDs switch to the xstats for the queue stats, queue stats > > related fields from 'struct rte_eth_stats' will be removed, as well as > > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. > > Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be > > removed. > > > > Signed-off-by: Ferruh Yigit > > Hi Thomas, Andrew, > > What do you think having the patch for this release? Acked-by: Thomas Monjalon