From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DBEDA0545; Mon, 3 Aug 2020 20:51:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CA322BD8; Mon, 3 Aug 2020 20:51:11 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 382502952 for ; Mon, 3 Aug 2020 20:51:10 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 5A49858041D; Mon, 3 Aug 2020 14:51:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 03 Aug 2020 14:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= hUkb+0F8E1I7gSaWZdj7SuoOqP6Gd9goJdTug2OE4ZE=; b=IY08A3uRjJMadFmU YF+zyIu/AqkCaKSSCZRYoQdvXMKa3EPsWELqDTs0VGlKTkH5d70yiv3J798Ergtk LNIBdNjtzuq6g28ZGNzLZSWMEUQMTpF6C6vMTMtOjSgxUipmvY0+FEQX0MvRH8EO +vfWkAhVSgCi060z9lsyHbXuUD3BVWdKz+qb+3wZTq0pH+JdXLuQuRD/Bu9FirQO 4S6Rdb9C5Riku5kBSkPHJPJXGe3LkqpEx/rJREScQ7y/9Hk0eUGNF1xb2LKuaXwP QB9e1HtpmISHYXhKAVyaUwzFHAkIdfa2YPvm6kfmOio74DtEyXkhjclm1F7ev534 jQKsIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=hUkb+0F8E1I7gSaWZdj7SuoOqP6Gd9goJdTug2OE4 ZE=; b=KNO1/a9hrTNqNtCylPnetHGfZd6PZ4Rsuq3NCd3LFmMZjJ1N4s5KZXgvz nPm+bQtV5hwXwSjU49K04ZLavDJ64YGaJWg94Gon2a2YzbHUIvZBVkJLPK6UDJAJ CYYO11jhaocTxBtSoeR6Nh/aNBtBGdm2aKaXso2AAhbMHKHobCYzFI/uKXMCgtfj hDt27RUkydgTLS5OSuPEkqeR6SyDIKNoEKSrxWs4vn7QD/8sVWKMvsx9WNJK5kAm e+eN7XV2Q/92pNgG62UgfMQiF64FZBn1wQ3EI8kW05nZTAl1ZhYc/kYRUC8lM2da QBm7buO4AgFc1NTye4/lAgY3Wh8pg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeeggddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 17E0C3280066; Mon, 3 Aug 2020 14:51:00 -0400 (EDT) From: Thomas Monjalon To: "John W. Linville" , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Matt Peters , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , Rahul Lakkireddy , Hemant Agrawal , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Qiming Yang , Ferruh Yigit , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Jerin Jacob , Bruce Richardson , Andrew Rybchenko , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Zhihong Wang , Yong Wang , Anatoly Burakov , Beilei Xing , Jingjing Wu Cc: Rosen Xu , dev@dpdk.org, Ciara Loftus , Steven Webster , Somalapuram Amaranath , xavier.huwei@huawei.com, Sachin Saxena , Wei Zhao , Jeff Guo , Igor Chauskin , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Alfredo Cardigliano , Jakub Grajciar , Viacheslav Ovsiienko , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Nithin Dabilpuram , Kiran Kumar K , Akhil Goyal Date: Mon, 03 Aug 2020 20:50:58 +0200 Message-ID: <5248162.j6AOsuQRmx@thomas> In-Reply-To: <30528485.5cHeq7CNxZ@xps> References: <30528485.5cHeq7CNxZ@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] CALL to eth PMD maintainers: complete closing of port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/04/2019 12:59, Thomas Monjalon: > Hi all, > > Since DPDK 18.11, the behaviour of the close operation is changed > if RTE_ETH_DEV_CLOSE_REMOVE is enabled in the driver: > port is released (i.e. totally freed and data erased) on close. > This new behaviour is enabled per driver for a migration period. > > Looking at the code, you can see these comments: > /* old behaviour: only free queue arrays */ > RTE_ETHDEV_LOG(DEBUG, "Port closing is using an old behaviour.\n" > "The driver %s should migrate to the new behaviour.\n", > /* new behaviour: send event + reset state + free all data */ > > You can find an advice in the commit: > http://git.dpdk.org/dpdk/commit/?id=23ea57a2a > " > When enabling RTE_ETH_DEV_CLOSE_REMOVE, > the PMD must free all its private resources for the port, > in its dev_close function. > It is advised to call the dev_close function in the remove function > in order to support removing a device without closing its ports. > " > > It would be great to complete this migration for the next LTS > version, which will be 19.11. For the record, it did not happen in 19.11. > It means the work should be ideally finished during the summer. > > The migration to the new behaviour is done in 4 drivers: > git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 > ena > enic > mlx5 > vmxnet3 > > Following drivers should be migrated: > ( find drivers/net -mindepth 1 -maxdepth 1 -type d | cut -d/ -f3 ; git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers | cut -d/ -f3 ) | sort | uniq -u [...] The progress in April 2019 was 4 of 46 (9%). > Please let's progress smoothly on this topic, thanks. More than one year later, the progress is 26 of 53 (49%). > The concerned maintainers (Cc) can be found with the following command: > devtools/get-maintainer.sh $(( find drivers/net -mindepth 1 -maxdepth 1 -type d | cut -d/ -f-3 ; git grep -l RTE_ETH_DEV_CLOSE_REMOVE drivers ) | sort | uniq -u) We cannot wait forever. Temporary cannot be longer than 2 years. I am going to send a deprecation notice to remove the "temporary" flag RTE_ETH_DEV_CLOSE_REMOVE. It will break drivers which are not migrated. It will probably help to find motivation in new priorities. More details on what to do can be found in this mail thread: http://inbox.dpdk.org/dev/1748144.UFpUr2FPnr@xps/