DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Fan Zhang <roy.fan.zhang@intel.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix bracket
Date: Mon, 30 Apr 2018 14:57:51 +0200	[thread overview]
Message-ID: <5249193.zgQrW8SLgo@xps> (raw)
In-Reply-To: <20180430103601.32356-1-roy.fan.zhang@intel.com>

30/04/2018 12:36, Fan Zhang:
> Coverity issue: 233232
> Coverity issue: 233237
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>

2 comments, Fan:

1/ I think it the v2 of a previous commit.
Please update the patchwork status (superseded),
use -v option for revision numbering,
and add a changelog.

2/ The title must give the scope of the change,
or give an idea of the impact of the patch.
Example:
	fix symmetric ciphering
The root cause (bracket location) is better in the
commit message than the title.

Thanks

  parent reply	other threads:[~2018-04-30 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 10:36 Fan Zhang
2018-04-30 10:46 ` Maxime Coquelin
2018-04-30 12:57 ` Thomas Monjalon [this message]
2018-05-04 15:13 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5249193.zgQrW8SLgo@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).