From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 8F5541C0B for ; Mon, 30 Apr 2018 14:57:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 62B4C228D7; Mon, 30 Apr 2018 08:57:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 30 Apr 2018 08:57:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=aC3zoB1z6j3U35cSISbAfkAShM WwBYLBotBqRVqjXVc=; b=QSqRsd2lYBw3tsxubbbXKR2eGl60MxWTqyTMJhgeTX 2l/wUncfhHy0u2P00abWdQ9YCEzm4OdY5OTh5Pm//l+aQNlxhrWBK1W7sKytg9Oz 7cVSqcmFkedskCGkDgYLzqCGY656bpbOJGX/yy4f1aEv3vk34qNInkHcWSHliwrb 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=aC3zoB 1z6j3U35cSISbAfkAShMWwBYLBotBqRVqjXVc=; b=fQvLvxjmlIGbxWxyRPSHUx gqZt/NPSTWlZ8rOurWPw9Ednp3lJahazvosQMKYSO7FwgA4XhN7QoOV/NkLQQvEt nswSkEJRoz+x2abBr22QFpda2yZxBw2/Ttc/guPd6V655lVWvgPSdEEns+Kq8kGG UjClJXpi3HjRcpwm5TGC497YUHXsWrbd/GX1JFdpkJteOE/7A8iuVlrbf5wrennI msAWHiLbfib9wuq+enrXMEdjQPWcCuTNAMS5KgJpx+gJmvRHE4E+zgc5Xsz4P5nv QPo2UL6YvFdzj1JpjQjycdj5cKBOGcCIToQ9+FzKAmBDRJqzPJwRZOhkNBT9snOA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AAA12E43E8; Mon, 30 Apr 2018 08:57:52 -0400 (EDT) From: Thomas Monjalon To: Fan Zhang Cc: dev@dpdk.org, maxime.coquelin@redhat.com, ferruh.yigit@intel.com Date: Mon, 30 Apr 2018 14:57:51 +0200 Message-ID: <5249193.zgQrW8SLgo@xps> In-Reply-To: <20180430103601.32356-1-roy.fan.zhang@intel.com> References: <20180430103601.32356-1-roy.fan.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix bracket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 12:57:54 -0000 30/04/2018 12:36, Fan Zhang: > Coverity issue: 233232 > Coverity issue: 233237 > Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") > > Signed-off-by: Fan Zhang 2 comments, Fan: 1/ I think it the v2 of a previous commit. Please update the patchwork status (superseded), use -v option for revision numbering, and add a changelog. 2/ The title must give the scope of the change, or give an idea of the impact of the patch. Example: fix symmetric ciphering The root cause (bracket location) is better in the commit message than the title. Thanks