From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00A9BA0A03; Sun, 17 Jan 2021 18:45:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7714D140D35; Sun, 17 Jan 2021 18:45:56 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 39D24140D34; Sun, 17 Jan 2021 18:45:55 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D5C455C00E2; Sun, 17 Jan 2021 12:45:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 17 Jan 2021 12:45:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= oGNw7ukDhQXA6dubMZg/k9dyBy/JrkByY1VWQgcKm1A=; b=0gVxJnp6Qreu66DY fPlQC15BZEL69UlYZxAwtw3k9j45Qg45yfsRb6T/vESscedsQvF4x9zhBSEy9kwT aEOW4mXVxLyZKRKPj1xqTO7P3nys6NqydOqZ4DOwAJKt4t7lNpyfoAxspzCi3dDC TAaUtxMwc9Ao64X9Jky9kbp5Tp/ZrcA1mK/VELCtt1UP2ixye2WWvgu22Gjkc0yS aRiiwApQ3xlZXRsGg8w0WvdRqAR9L4oQqijOuwIjezL7w8PhPSQdW9AT4fTKhC+a scWWrzJB7gVmM8AW3jEohoA9dyf9U/yEhO2byH4BQH1LmSR2PXoVHv2pLD8t18wj Wvw1qw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=oGNw7ukDhQXA6dubMZg/k9dyBy/JrkByY1VWQgcKm 1A=; b=QYVqmDjfAtSfXFPoehpzCF5azFp6TXa/t5MKnTeIJerQ3PRKyv0+ZoqZn rYdkY4jfwhQyKOYELKFfEfMEhF3lJ5g4x+UxEtwodRvSlDvvtGqJ2VxBfkXj5e6M 04fTAyqHI5lJTYVcV4saLAdrBoCWQ4jRRDHMZ01I0RMWSll0cw9SedDIZtRtqtKg dk6sWKpNig50pPPXqKTG0qRN1Q1b5yQnWb5WB8CfRY0p3xara+5P4Ps6NR2UN3Et 8ONlE0PlNdoOTff3wtfgjaeoMH+eGHd7KmRKVyfNHByRFeJwN4F9XhlyaR1WLKW8 dnXbVbXOVllJsHqoJhyslffHgNQFA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdeigddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8FD3C240057; Sun, 17 Jan 2021 12:45:53 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: "Richardson, Bruce" , "De Lara Guarch, Pablo" , dev@dpdk.org, "stable@dpdk.org" , "Van Haaren, Harry" Date: Sun, 17 Jan 2021 18:45:51 +0100 Message-ID: <5251750.8YWXGV3c11@thomas> In-Reply-To: References: <20210114164537.28936-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test: don't break terminal settings when running tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/01/2021 18:01, Van Haaren, Harry: > > From: Stephen Hemminger > > Sent: Thursday, January 14, 2021 4:46 PM > > To: Richardson, Bruce ; Van Haaren, Harry > > ; De Lara Guarch, Pablo > > > > Cc: stable@dpdk.org; dev@dpdk.org; Stephen Hemminger > > > > Subject: [PATCH] test: don't break terminal settings when running tests > > > > When running one test (via DPDK_TEST) the test program > > would leave the terminal in raw mode. This was because > > it was setting up cmdline to do interactive input. > > > > The fix is to use cmdline_new() for the interactive > > case. > > > > This also fixes a memory leak because the test > > runner was never calling cmdline_free(). > > > > Fixes: 9b848774a5dc ("test: use env variable to run tests") > > Cc: harry.van.haaren@intel.com > > Signed-off-by: Stephen Hemminger > > Tested-by: Harry van Haaren Applied, thanks