From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f48.google.com (mail-lf0-f48.google.com [209.85.215.48]) by dpdk.org (Postfix) with ESMTP id 1B23A1E20 for ; Wed, 5 Apr 2017 17:06:44 +0200 (CEST) Received: by mail-lf0-f48.google.com with SMTP id x137so10944087lff.3 for ; Wed, 05 Apr 2017 08:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=j6jCbxkgRZJ1JSQTqroDSZDaqzE00ezqrjFPCX0QJes=; b=kW0Gsq7+etGAQ1SSovB76lr290Wd1H48qXYps52bE4TaUCG5DlK3vKlyh4dIFeZkl9 Q5iGbntFFxxZa3tvEBrTaaozE14UoVasvDSVC9Vd0+VsBlZYMSc+cBw01AagTCFgPEZc 2exOd9q08IHqmiVu06aInH63jkQDM+6Bdw3SUWwMXx47NJEfzswWHfAOW+ZgV3p0+fFQ C79SAP1rXFeBN/5X0LIBDfZavYDbCdm4iMFLZrUFjxDDNtmm03e1wq8SWfoVZ8xPgmAE 2E5JhIyNqvUHw0dd9O5kKkP7dswfEmA8VSplPMMMjZqErdEIomdh8aTcoGSTdZW3gWSQ 8fCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=j6jCbxkgRZJ1JSQTqroDSZDaqzE00ezqrjFPCX0QJes=; b=QctEjLreK+yA/d//6zWB57yihMW0A5glKgIs6EgQ6OLTGPuyCWp3ys7UzL2nrlBhza jSPE26rkvb0aUUrHoQA6SrH6r3owFoEMNOH4IPuXVPKw71tNzIWEwndppIfrT55BDx+o Xd46Gn2ZMN6Rd+VDMCT2OuXDG9Cu3J+caVcbFOu1QVU8zvhcF9jjWDHlIPq9ML2GdyZZ aAmT0OBDW9Fkdgqg5Fpy9IMsNwAUAAkI/RFKLDdKZpnNkvQJJCjqDkO5HZU36kWgUjOX lEcTYwpde1dnGEzPirKFCGgSsgQ5P4XKTBipk4lXZA3wAlRPIGNGmQreuCN3fRvjXqmb gJJA== X-Gm-Message-State: AFeK/H1UHyMgOxkQyl4/3jnkEDYJUFZV3rVTi/XR6yZf19fIP9Dzq1rt vpgg5VuM4H1w7T2q X-Received: by 10.28.35.151 with SMTP id j145mr19482759wmj.50.1491404803618; Wed, 05 Apr 2017 08:06:43 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id f62sm8089925wmh.33.2017.04.05.08.06.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 08:06:42 -0700 (PDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org Date: Wed, 05 Apr 2017 17:06:41 +0200 Message-ID: <5252491.9gF4pOle3c@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <195ebf71-69a7-fca2-ce95-8912ad7ef51a@intel.com> References: <1490907662-27666-1-git-send-email-remy.horton@intel.com> <165712131.qiFBceb8LK@xps13> <195ebf71-69a7-fca2-ce95-8912ad7ef51a@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v14 1/6] lib: add information metrics library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 15:06:44 -0000 2017-04-05 15:46, Remy Horton: > > On 05/04/2017 14:39, Thomas Monjalon wrote: > > 2017-03-30 22:00, Remy Horton: > >> --- a/mk/rte.app.mk > >> +++ b/mk/rte.app.mk > [..] > >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_METRICS) += -lrte_metrics > > > > It should not be added here in --whole-archive as it is not going to be > > used by plugins (drivers). > > > > I suggest moving it upper with rte_jobstats. > > Ok. > > As an aside, there seems to have been recent changes to the build > system, so I suspect there might be a few redundant Makefile additions > lying around the patchset. Do you mean DEPDIRS-$(CONFIG_RTE_LIBRTE_METRICS) et al? I can remove them if you confirm.