DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Finn Christensen <fc@napatech.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH] ntnic: add PMD driver
Date: Mon, 29 Aug 2016 12:04:11 +0200	[thread overview]
Message-ID: <5255275.7GO0ucYScp@xps13> (raw)
In-Reply-To: <8cec6b8c3d6c4a7f85ac117d2d90fd7e@napatech.com>

2016-08-29 06:22, Finn Christensen:
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > What is the license of this driver suite?
> 
> The driver suite is a closed-source driver, which is not free downloadable.
> 
> > IMHO the upstream DPDK shouldn't be a platform for non-free driver suites.
> 
> This is our first steps towards opensource, and our upcoming NIC is
> partly build on HW and SW from our Accelerator products.
> And since we already bypasses the kernel effectively in our driver,
> this first solution for a DPDK PMD driver, has been built on top of
> that software suite.
> We like the idea of opensource, but we will need to do the transition
> stepwise, considering our NIC product.

I think the first step should be to free the lowest level, here the
code you build your drivers on.

> We have seen large performance improvements (x4-x7 times with 64 byte
> packets compared to a std NIC in a phy-ovs-vm-ovs-phy setup utilizing
> a modified DPDK), and this is the main motivation to go forward and
> try to push our contribution to DPDK upstream.
> This is the first step of contributions that we want to make.
> This DPDK PMD solution is not compileable unless you have our driver.

Not being able to compile the PMD is a real problem for maintenance.
The PMD would be considered as dead code, so is forbidden.

> We may need to make that possible, so that a free downloadable driver
> can be retrieved.
> 
> Once this is said, we thought that the DPDK was BSD licensed and I must
> admit that we have failed to see this limitation that you are mentioning.
> Is there another license or agreement text that we need to read?

Maybe you'll find some interesting parts in the contributing guide.
But honestly, I think you have already done the right thing in your case:
you sent some code and open the discussion :)
Now you just need to enable a free compilation environment for your patch.
Thanks

  reply	other threads:[~2016-08-29 10:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 13:44 Finn Christensen
2016-08-26 14:44 ` Thomas Monjalon
2016-08-26 16:32   ` Finn Christensen
2016-08-27  9:07     ` Thomas Monjalon
2016-08-26 16:54 ` Stephen Hemminger
2016-08-29  6:22   ` Finn Christensen
2016-08-29 10:04     ` Thomas Monjalon [this message]
2016-08-29 12:00       ` Finn Christensen
2016-09-08 11:14 ` [dpdk-dev] [PATCH v2] " Finn Christensen
2016-09-08 13:49   ` Neil Horman
2016-09-08 14:22     ` Finn Christensen
2016-09-09 12:48   ` [dpdk-dev] [PATCH v3] " Finn Christensen
2016-09-09 13:51     ` Neil Horman
2016-09-10  7:58       ` Finn Christensen
2016-09-10  8:20         ` Thomas Monjalon
2016-09-10 18:31           ` Stephen Hemminger
2016-09-12  8:08             ` Finn Christensen
2016-09-12 12:33             ` Neil Horman
2016-09-12  7:34           ` Finn Christensen
2016-11-21 13:47             ` Ferruh Yigit
2016-11-21 13:55               ` Finn Christensen
2016-09-12 12:32         ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5255275.7GO0ucYScp@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=fc@napatech.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).