From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8747CA0471 for ; Mon, 12 Aug 2019 11:43:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 58DE84C72; Mon, 12 Aug 2019 11:43:52 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 33A7C3257 for ; Mon, 12 Aug 2019 11:43:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 02:43:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,377,1559545200"; d="scan'208";a="259725917" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.78]) ([10.237.220.78]) by orsmga001.jf.intel.com with ESMTP; 12 Aug 2019 02:43:46 -0700 To: Thomas Monjalon , Hemant Agrawal , Gagandeep Singh Cc: dev@dpdk.org, David Marchand , Olivier Matz , Andrew Rybchenko , Nipun Gupta , honnappa.nagarahalli@arm.com, Steve Capper , jerinj@marvell.com, bruce.richardson@intel.com, gavin.hu@arm.com, konstantin.ananyev@intel.com, drc@linux.vnet.ibm.com References: <20190807101204.21614-1-g.singh@nxp.com> <52183700.OczlixnxyG@xps> <15982978.NnXy4IA2Yx@xps> From: "Burakov, Anatoly" Message-ID: <525631f9-c367-336e-7caf-dbb886193fc6@intel.com> Date: Mon, 12 Aug 2019 10:43:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <15982978.NnXy4IA2Yx@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08-Aug-19 8:31 AM, Thomas Monjalon wrote: > 07/08/2019 15:28, Hemant Agrawal: >> HI Thomas, >> >>>>> DPDK currently is supporting maximum 3 hugepage, sizes whereas >>>>> system can support more than this e.g. >>>>> 64K, 2M, 32M and 1G. >>>> >>>> You can mention ARM platform here, and that this issue starts with >>>> kernel 5.2 (and I would try to mention this in the title as well). >>>> This is better than an annotation that will be lost. >>>> >>>> >>>>> Having these four hugepage sizes available to use by DPDK, which is >>>>> valid in case of '--in-memory' EAL option or using 4 separate mount >>>>> points for each hugepage size; >>>>> hugepage_info_init() API reports an error. >>>> >>>> Can you describe what is the impact from a user point of view rather >>>> than mentioning this internal function? >>> >>> Yes please, we need to understand how much it is critical. >>> Should we Cc stable@dpdk.org for backport? >>> Should it be merged at the last minute in 19.08? >> >> VPP usages in-memory option. So, VPP on ARM with kernel 5.2 wont' work without this patch. > > Do you want to send a v2 with a better explanation? > > I would suggest to restrict the change to Arm only with an ifdef, > in order to limit the risk for this release. > We can think about a dynamic hugepage scan in the next release. > I don't see how this is necessary. The 3 is an arbitrary number here, and the ABI isn't broken as this is an internal structure. We could increase it to 16 for all i care, and it wouldn't make any difference to the rest of the code - we never populate more than we can find anyway. -- Thanks, Anatoly