From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 405C35B40
 for <dev@dpdk.org>; Wed, 25 Apr 2018 14:24:02 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id A0C81213C4;
 Wed, 25 Apr 2018 08:24:01 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Wed, 25 Apr 2018 08:24:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=Sg7Vn/MQLVfe9zftu39nMcdMhj
 lQs/DdaiBgCAtpvpI=; b=izQPxNwXzu87g+2fe0DdLjqQri+VonG7WrHxYQEDtv
 RKeXYlqXmrrb3IXl1nK3IIAwtKF4R7epVnREPHLw4GOS01TNIbEZV/MZGzCnQ5lj
 gtyDxRwkPE+XwaZsZKzblQ+G5/jWK2TTO38QPjK3/DQ1UGTUNR9/9mhV1VxNTukF
 E=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Sg7Vn/
 MQLVfe9zftu39nMcdMhjlQs/DdaiBgCAtpvpI=; b=AjJHgGUQq6mSDo0Vo81Vzk
 OgFAaAWtmUy5mTe+66juxIJyGpreuVo6hepglTOfTq2FlGzWlq81ByjS4E5YuQ+2
 i8lH8xgSEPtIfVxJtICYEFsTKLSfEVrTGNyt8YYtnFVyrjDfmaiNe3K/+6tkjoZ3
 kJWAqnqSGkJRtAz5/QbZI0Dpa3EKPy82G2l34StiVPl7svfFRb4PX6ChSKDvN01V
 5flTiH3A7TeMK5j3IMgtFCNFgIGFC57phjXgA4GdOGIFsREfev7QuuPjSwd6Dlds
 wDYJ9yrOKyN8hqfWMsbWfFWnRVf/i7WdSRZgIcZmcScrlFkJRZdPRe6hrD5ALK4w
 ==
X-ME-Sender: <xms:YXPgWl1llwNg3C75KC1cDtEiwn95OszM92-xOrDjJasFjSCJk_MC7Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id ABEA0E4120;
 Wed, 25 Apr 2018 08:24:00 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Doherty, Declan" <declan.doherty@intel.com>
Cc: qi.z.zhang@intel.com, dev@dpdk.org,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Shahaf Shuler <shahafs@mellanox.com>
Date: Wed, 25 Apr 2018 14:23:59 +0200
Message-ID: <5265650.YqjcpsQ2DK@xps>
In-Reply-To: <c7019992-91a1-481c-9fc4-85b34bc0670a@intel.com>
References: <20180328135433.20203-1-declan.doherty@intel.com>
 <190601101.P8xlxIF3tq@xps> <c7019992-91a1-481c-9fc4-85b34bc0670a@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v7 4/9] ethdev: Add port representor device
	flag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2018 12:24:02 -0000

25/04/2018 14:17, Doherty, Declan:
> On 24/04/2018 8:37 PM, Thomas Monjalon wrote:
> > I think dev_capa and dev_flags are the same thing.
> > They could be merged.
> 
> Do you have a preference for which one to keep, as dev_flags within
> rte_eth_dev_data is widely used by PMDs and passing this same 
> information out through rte_eth_dev_info makes sense to me?

I think a big cleanup in ethdev structures is required.
We could avoid copying fields from one struct to the other.
But I don't want to block this patch, so go ahead and we will clean
this mess later.