From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD2A6A034D; Sun, 6 Mar 2022 23:52:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 425BC407FF; Sun, 6 Mar 2022 23:52:34 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id CE1C74068F; Sun, 6 Mar 2022 23:52:32 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 249F55C0192; Sun, 6 Mar 2022 17:52:32 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 06 Mar 2022 17:52:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=3ajT8GpvwGNn9u 4IjDuJ0sajCw3Mj7uQa4P/M2LTX10=; b=g8in03yirQYXGffq5EwNgzfqlqHB+W HRl/I75AOIBYD4xO6NIiJpVUCqRTn4F79mDQ/u3nSspqc4bhX95ud4QyTZs90dD9 BrYc7TkU2gaaRHd7OahSd22kSt6W25PuF/RUBWokU+R/nSFKLvunQmiiFybSSrto erVHrVMR02c7kOGqYLSUm2DcQ8K3BkgC976igImgia5fbsMjb7tlFxsauTNZKarI N6tTs9Jn7DxoPPNBzhgFaj1H3lEx6rlSaXSEz/dIWIusTFUhADmWl2n+/9yL08BU kuBRZ2FQULwPPdNuPrvckqmDbk4vLO+0zdYklcbjOsPCxktDT0tdiCRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3ajT8GpvwGNn9u4IjDuJ0sajCw3Mj7uQa4P/M2LTX 10=; b=WlXNOymdgPHcIBXcLxZecVSZXbiXzbQB14DJkpBilZoufm6e3jsmocGIF j6bvTflEMiURNISX+Pva4qlXgE4q0WETD5B+/7LuwdJ4BI7p3D3e7V8oHLlXAfn0 hw18lFWu4MvSpWNuc3m1Ne+E+NYJjFumLvx9+t8oJRXkQve6etrSCOrm6rTqFCUx LotTPI+JXyMPjl9xayEXRPDGqzF3MAmAZNAS3Zjs5/8oFKJzXe6uoL38KdS5AbQG ZoRBsBSzWs/zJr4u2clDBbt5r2BDYPCQ9VIj+hcGXFscPEXh9uzr/Ax4YlX72WWb YXx6QnOVQCL7xYUS5xx7tQ5rqF/0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddufedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 6 Mar 2022 17:52:30 -0500 (EST) From: Thomas Monjalon To: "Zhang, Yuying" , "Min Hu (Connor)" Cc: "dev@dpdk.org" , Huisong Li , "stable@dpdk.org" , "Li, Xiaoyun" , "Singh, Aman Deep" , Ajit Khaparde , Andrew Rybchenko , Ferruh Yigit Subject: Re: [PATCH v5] app/testpmd: add help messages for multi-process Date: Sun, 06 Mar 2022 23:52:28 +0100 Message-ID: <5269403.vfdyTQepKt@thomas> In-Reply-To: <1a9abf77-b0ed-d454-2c41-cca738712e08@intel.com> References: <20220228032617.46618-1-humin29@huawei.com> <1a9abf77-b0ed-d454-2c41-cca738712e08@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/03/2022 16:35, Ferruh Yigit: > On 3/4/2022 9:11 AM, Zhang, Yuying wrote: > > From: Min Hu (Connor) > >> From: Huisong Li > >> > >> This patch adds help messages for multi-process. > >> --num-procs , where N is the total number of symmetric_mp instances > >> that will be run side-by-side to perform packet processing. This parameter is > >> used to configure the appropriate number of receive queues on each > >> network port. > >> > >> --proc-id , where n is a numeric value in the range 0 <= n < N (number of > >> processes, specified above). This identifies which symmetric_mp instance is > >> being run, so that each process can read a unique receive queue on each > >> network port. > >> > >> Fixes: a550baf24af9 ("app/testpmd: support multi-process") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Huisong Li > >> Signed-off-by: Min Hu (Connor) > > > > Acked-by: Yuying Zhang > > > > Updated 'symmetric_mp' -> 'multi-process', with this change > Reviewed-by: Ferruh Yigit > > Applied to dpdk-next-net/main, thanks. Why not reusing these defines? #define PARAM_PROC_ID "proc-id" #define PARAM_NUM_PROCS "num-procs" Why not having "N" in the help messages like others? I won't pull it in main. Please rework and try to improve the description to make it shorter and easier to understand.