[dpdk-dev] 19.11.4 patches review and test

[dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

Hi all,

Here is a list of patches targeted for stable release 19.11.4.

The planned date for the final release is August 31st.

Please help with testing and validation of your use cases and report
any issues/results with reply-all to this mail. For the final release
the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1

These patches are located at branch 19.11 of dpdk-stable repo:
    https://dpdk.org/browse/dpdk-stable/

Thanks.

Luca Boccassi

---
Adam Dybkowski (7):
      test/crypto: fix asymmetric session mempool creation
      crypto/qat: fix AES-XTS capabilities
      crypto/qat: handle mixed hash-cipher requests on GEN3
      test/crypto: add mixed encypted-digest
      common/qat: get firmware version
      crypto/qat: handle mixed hash-cipher on GEN2
      common/qat: fix uninitialized variable

Akhil Goyal (4):
      crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
      crypto/dpaax_sec: fix inline query for descriptors
      crypto/dpaa2_sec: fix HFN override
      common/dpaax: fix 12-bit null auth case

Alan Dewar (1):
      sched: fix port time rounding

Alexander Kozyrev (3):
      net/mlx5: fix vectorized Rx burst termination
      net/mlx5: do not select legacy MPW implicitly
      net/mlx5: fix descriptors number adjustment

Ali Alnubani (2):
      net/mlx5: fix typos in meter error messages
      doc: fix a typo in mlx5 guide

Alvin Zhang (1):
      net/i40e: fix queue pairs configuration in VF

Andrew Rybchenko (1):
      net/sfc: do not enforce hash offload in RSS multi-queue

Ankur Dwivedi (2):
      common/cpt: fix encryption offset
      test/crypto: change cipher offset for ESN vector

Apeksha Gupta (2):
      app/eventdev: fix capability check in pipeline ATQ test
      event/dpaa2: add all-types queue capability flag

Archana Muniganti (2):
      examples/fips_validation: fix TDES interim callback
      examples/fips_validation: fix count overwrite for TDES

Archit Pandey (1):
      sched: fix 64-bit rate

Arek Kusztal (4):
      drivers/qat: improve multi process on qat
      drivers/qat: add multi process handling of driver id
      drivers/qat: add handling of capabilities in multi process
      crypto/qat: add minimum enq threshold

Ayuj Verma (1):
      examples/fips_validation: fix parsing of TDES vectors

Bruce Richardson (12):
      test: fix build with ring PMD but no bond PMD
      mem: fix 32-bit init config with meson
      rawdev: allow getting info for unknown device
      rawdev: fill NUMA socket ID in info
      rawdev: export dump function in map file
      doc: rebuild with meson whenever a file changes
      build: always link whole DPDK static libraries
      devtools: test static linkage with pkg-config
      build/pkg-config: move pkg-config file creation
      build/pkg-config: output drivers first for static build
      build/pkg-config: improve static linking flags
      build/pkg-config: prevent overlinking

Chas Williams (1):
      net/netvsc: fix crash during Tx

Chenbo Xia (1):
      net/virtio-user: check tap system call setting

Chengchang Tang (5):
      net/hns3: clear promiscuous on PF uninit
      net/hns3: remove unsupported VLAN capabilities
      net/hns3: fix VLAN strip configuration when setting PVID
      net/hns3: remove restriction on setting VF MTU
      net/hns3: fix adding multicast MAC address

Chenmin Sun (1):
      net/i40e: fix flow director Rx writeback packet

Ciara Loftus (1):
      net/af_xdp: remove mempool freeing on umem destruction

David Marchand (7):
      eal/windows: fix symbol export
      eal: remove redundant newline in alert message
      net/mlx5: remove redundant newline from logs
      net/mvpp2: fix non-EAL thread support
      devtools: fix path in forbidden token check
      lib: remind experimental status in headers
      net/bonding: fix socket ID check

Dekel Peled (2):
      net/mlx5: fix VLAN pop with decap action validation
      net/mlx5: fix VLAN push action on hairpin queue

Devendra Singh Rawat (1):
      net/qede: fix multicast drop in promiscuous mode

Dong Zhou (1):
      net/mlx5: fix LRO checksum

Dongyang Pan (1):
      net/bonding: delete redundant code

Fady Bader (1):
      meter: remove inline functions from export list

Feifei Wang (1):
      test/ring: fix statistics in bulk enq/dequeue

Ferruh Yigit (4):
      net/iavf: fix uninitialized variable
      net/ixgbe/base: remove dead code
      ethdev: fix log type for some error messages
      drivers/net: fix exposing internal headers

Fiona Trahe (3):
      common/qat: remove tail write coalescing
      common/qat: move max inflights param into qp
      common/qat: support dual threads for enqueue/dequeue

Gaurav Singh (1):
      net/i40e: remove duplicate tunnel type check

Georgiy Levashov (1):
      examples: add flush after stats printing

Gregory Etelson (1):
      net/mlx5: fix tunnel flow priority

Guinan Sun (5):
      net/ixgbe/base: fix host interface shadow RAM read
      net/ixgbe/base: fix x550em 10G NIC link status
      net/ixgbe/base: fix infinite recursion on PCIe link down
      net/ixgbe: fix MAC control frame forward
      net/ixgbe: fix flow control status

Haiyue Wang (6):
      bus/pci: fix VF memory access
      eal: fix uuid header dependencies
      net/ice: fix TCP checksum offload
      net/ice: calculate TCP header size for offload
      net/ice: fix Tx hang with TSO
      net/ice: revert fake TSO fixes

Hao Chen (1):
      net/hns3: optimize default RSS algorithm

Harman Kalra (4):
      eal/linux: fix epoll fd list rebuild for interrupts
      net/octeontx2: fix DMAC filtering
      common/octeontx2: fix crash on running procinfo
      eal: fix parentheses in alignment macros

Harry van Haaren (1):
      examples/eventdev: fix 32-bit coremask

Heinrich Kuhn (1):
      net/nfp: fix RSS hash configuration reporting

Hemant Agrawal (1):
      rawdev: remove remaining experimental tags

Hongbo Zheng (4):
      net/hns3: ignore function return on reset error path
      net/hns3: fix unintended sign extension in dump operation
      net/hns3: clear residual hardware configurations on init
      net/hns3: get link status change through mailbox

Hongzhi Guo (3):
      net: fix IPv4 checksum
      net: fix unneeded replacement of TCP checksum 0
      net: fix checksum on big endian CPUs

Honnappa Nagarahalli (5):
      eal/armv8: fix timer frequency calibration with PMU
      app/testpmd: use clock time in throughput calculation
      app/testpmd: fix burst percentage calculation
      doc: fix some typos in Linux guide
      test/hash: move lock-free tests to perf tests

Hrvoje Habjanic (1):
      sched: fix subport freeing

Ian Dolzhansky (1):
      net/failsafe: fix RSS RETA size info

Igor Romanov (1):
      service: fix lcore iteration

Jecky Pei (1):
      net/kni: set packet input port in Rx

Jeff Guo (1):
      net/e1000: fix crash on Tx done clean up

Junfeng Guo (2):
      net/ice/base: fix RSS removal for GTP-U
      net/ice/base: fix memory leak on GTPU RSS

Junyu Jiang (2):
      net/iavf: fix RSS RETA after restart
      net/ice: fix bytes statistics

Kalesh AP (5):
      net/bnxt: remove unused enum declaration
      net/bnxt: fix unnecessary HWRM command
      net/bnxt: fix flow error on filter creation
      net/bnxt: fix freeing filters on flow creation failure
      net/bnxt: fix logical AND in if condition

Kevin Traynor (1):
      vhost: remove zero-copy and client mode restriction

Konstantin Ananyev (2):
      test/bpf: fix few small issues
      bpf: fix add/sub min/max estimations

Levend Sayar (1):
      service: fix C++ linkage

Lijun Ou (5):
      net/hns3: add RSS hash offload to Rx configuration
      net/hns3: fix key length when configuring RSS
      net/hns3: fix RSS configuration on empty RSS type
      net/hns3: remove unnecessary branch
      app/testpmd: remove hardcoded descriptors limit

Long Li (3):
      bus/vmbus: fix ring buffer mapping
      net/netvsc: fix underflow when Rx external mbuf
      net/netvsc: fix chimney index

Lukasz Wojciechowski (1):
      service: fix core mapping reset

Mao Jiang (2):
      net/i40e: fix binding interrupt without MSI-X vector
      net/i40e: fix flow director MSI-X resource allocation

Matan Azrad (1):
      vhost: fix features definition location

Maxime Coquelin (3):
      bus/dpaa: fix iterating on a class type
      bus/fslmc: fix iterating on a class type
      vhost: fix virtio ready flag check

Michael Baum (11):
      net/mlx5: remove needless Tx queue initialization check
      net/mlx5: fix unreachable MPLS error path
      common/mlx5: fix code arrangement in tag allocation
      net/mlx5: fix iterator type in Rx queue management
      net/mlx5: fix initialization of steering registers
      net/mlx5: fix crash in NVGRE item translation
      net/mlx5: remove ineffective increment in hairpin split
      net/mlx4: optimize stack memory size in probe
      net/mlx5: fix unnecessary init in mark conversion
      net/mlx5: fix hairpin Tx queue creation error flow
      net/mlx5: fix hairpin Rx queue creation error flow

Muhammad Bilal (1):
      bus/vdev: fix a typo in doxygen comment

Nipun Gupta (2):
      bus/fslmc: fix getting FD error
      net/dpaa: fix FD offset data type

Pablo de Lara (1):
      drivers/crypto: add missing OOP feature flag

Parav Pandit (1):
      common/mlx5: fix void parameters in glue wrappers

Patrick Fu (1):
      vhost: fix double-free with zero-copy

Pavan Nikhilesh (2):
      event/octeontx2: fix device reconfigure
      event/octeontx2: fix sub event type

Pavel Ivashchenko (1):
      net/i40e: fix getting EEPROM information

Phil Yang (5):
      eventdev: fix race condition on timer list counter
      eventdev: use C11 atomics for lcore timer armed flag
      eventdev: remove redundant reset on timer cancel
      eventdev: relax SMP barriers with C11 atomics
      app/testpmd: fix CPU cycles per packet stats on Tx modes

Qi Zhang (7):
      net/ice/base: fix return value
      net/ice/base: fix memory leak on error path
      net/ice/base: fix reference count on VSI list update
      net/ice/base: fix initializing resource for field vector
      net/ice/base: fix VSI ID mask to 10 bits
      net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
      net/ice/base: fix RSS interference

Rahul Gupta (1):
      net/bnxt: fix performance for Arm

Rahul Lakkireddy (3):
      net/cxgbe: fix CLIP leak in filter error path
      net/cxgbe: fix double MPS alloc by flow validate and create
      net/cxgbe: fix L2T leak in filter error and free path

Raslan Darawsheh (3):
      net: fix pedantic build
      net/mlx5: fix flow items size calculation
      net/mlx5: fix VF MAC address set over BlueField

Ruifeng Wang (8):
      net/i40e: enable NEON Rx/Tx in meson
      eal/arm: add vcopyq intrinsic for aarch32
      net/ixgbe: fix include of vector header file
      test: allow no-huge mode for fast-tests
      test/cycles: restore default delay callback
      crypto/armv8: remove debug option
      crypto/armv8: use dedicated log type
      net/i40e: support aarch32

Sarosh Arif (3):
      doc: fix typo in bbdev test guide
      examples/packet_ordering: use proper exit method
      doc: fix ethtool app path

Shougang Wang (2):
      net/ice: fix error log in generic flow
      net/i40e: fix filter pctype

Shy Shyman (3):
      app/testpmd: fix error detection in MTU command
      net/mlx5: fix flow META item validation
      net/mlx5: fix HW counters path in switchdev mode

Stephen Hemminger (8):
      net/netvsc: fix warning when VF is removed
      net/netvsc: do not query VF link state
      net/netvsc: do not spin forever waiting for reply
      eal: fix lcore accessors for non-EAL threads
      cfgfile: fix stack buffer underflow
      rib: add C++ include guard
      kni: fix reference to master/slave process
      doc: fix reference to master process

Suanming Mou (3):
      net/mlx5: fix secondary process resources release
      net/mlx5: fix interrupt installation timing
      net/mlx5: fix counter query

Tal Shnaiderman (2):
      build: fix drivers library path on Windows
      pci: fix address domain format size

Thomas Monjalon (1):
      doc: update build instructions in the Linux guide

Tianfei Zhang (2):
      raw/ifpga/base: fix SPI transaction
      raw/ifpga/base: fix NIOS SPI init

Timothy Redaelli (1):
      test: fix rpath for drivers with meson

Viacheslav Ovsiienko (3):
      net/mlx5: fix UAR lock sharing for multiport devices
      common/mlx5: fix queue doorbell record size
      net/mlx5: fix metadata storing for NEON Rx

Vladimir Medvedkin (1):
      doc: add RIB and FIB into the API index

Wei Hu (Xavier) (12):
      net/hns3: fix Tx less than 60 bytes
      net/hns3: fix VLAN tags reported in Rx
      app/testpmd: fix stats error message
      net/hns3: fix flow director error message
      net/hns3: fix unintended sign extension in fd operation
      net/hns3: fix Rx buffer size
      net/hns3: check multi-process action register result
      ethdev: fix data room size verification in Rx queue setup
      ethdev: fix VLAN offloads set if no relative capabilities
      net/bonding: fix error code on device creation
      net/bonding: fix MAC address when switching active port
      net/bonding: fix MAC address when one port resets

Wei Zhao (4):
      net/ice: fix switch action number check
      net/ixgbe: report 10Mbps link speed for x553
      net/ice: add input set byte number check
      net/i40e: enable QinQ stripping

Weifeng Li (1):
      net/bonding: change state machine to defaulted

Xiao Wang (1):
      net/virtio-user: fix status management

Xiaolong Ye (6):
      mbuf: remove unused next member in dynamic flag/field
      test/mbuf: fix a dynamic flag log
      mbuf: fix boundary check at dynamic field registration
      mbuf: fix error code in dynamic field/flag registration
      mbuf: fix free space update for dynamic field
      mbuf: fix dynamic field dump log

Xiaoyun Wang (5):
      net/hinic/base: check output of management sync channel
      net/hinic/base: remove unused function parameters
      net/hinic: fix setting promiscuous mode
      net/hinic: optimize Rx performance for x86
      net/hinic/base: avoid system time jump

Yicai Lu (1):
      net/bonding: fix LACP negotiation

Yunjian Wang (12):
      app/testpmd: fix memory leak on error path
      vfio: remove unused variable
      net/af_packet: fix check of file descriptors
      net/af_packet: fix memory leak on init failure
      net/af_packet: fix munmap on init failure
      bus/fslmc: fix memory leak in secondary process
      hash: fix out-of-memory handling in hash creation
      event/dpaa: remove dead code
      net/qede: remove dead code
      net/hinic: check memory allocations in flow creation
      net/ice: fix memory leak when releasing VSI
      net/ice: add memory allocation check in RSS init

Zhiguang He (1):
      net/bonding: fix dead loop on RSS RETA update

Zhihong Peng (2):
      net/i40e: report VLAN filter capability
      net/e1000: report VLAN extend capability

Zhike Wang (1):
      mempool: fix allocation in memzone during retry

Re: [dpdk-dev] 19.11.4 patches review and test

[Christian Ehrhardt]

On Tue, Aug 18, 2020 at 8:12 PM Luca Boccassi <bluca@debian.org> wrote:
>
> Hi all,
>
> Here is a list of patches targeted for stable release 19.11.4.
>
> The planned date for the final release is August 31st.
>
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
>
> A release candidate tarball can be found at:
>
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1

Build tested on all Ubuntu architectures and pushed through some
OVS-DPDK based tests on x86.
Working fine in these setups.

> These patches are located at branch 19.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
>
> Thanks.
>
> Luca Boccassi
>
> ---
> Adam Dybkowski (7):
>       test/crypto: fix asymmetric session mempool creation
>       crypto/qat: fix AES-XTS capabilities
>       crypto/qat: handle mixed hash-cipher requests on GEN3
>       test/crypto: add mixed encypted-digest
>       common/qat: get firmware version
>       crypto/qat: handle mixed hash-cipher on GEN2
>       common/qat: fix uninitialized variable
>
> Akhil Goyal (4):
>       crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
>       crypto/dpaax_sec: fix inline query for descriptors
>       crypto/dpaa2_sec: fix HFN override
>       common/dpaax: fix 12-bit null auth case
>
> Alan Dewar (1):
>       sched: fix port time rounding
>
> Alexander Kozyrev (3):
>       net/mlx5: fix vectorized Rx burst termination
>       net/mlx5: do not select legacy MPW implicitly
>       net/mlx5: fix descriptors number adjustment
>
> Ali Alnubani (2):
>       net/mlx5: fix typos in meter error messages
>       doc: fix a typo in mlx5 guide
>
> Alvin Zhang (1):
>       net/i40e: fix queue pairs configuration in VF
>
> Andrew Rybchenko (1):
>       net/sfc: do not enforce hash offload in RSS multi-queue
>
> Ankur Dwivedi (2):
>       common/cpt: fix encryption offset
>       test/crypto: change cipher offset for ESN vector
>
> Apeksha Gupta (2):
>       app/eventdev: fix capability check in pipeline ATQ test
>       event/dpaa2: add all-types queue capability flag
>
> Archana Muniganti (2):
>       examples/fips_validation: fix TDES interim callback
>       examples/fips_validation: fix count overwrite for TDES
>
> Archit Pandey (1):
>       sched: fix 64-bit rate
>
> Arek Kusztal (4):
>       drivers/qat: improve multi process on qat
>       drivers/qat: add multi process handling of driver id
>       drivers/qat: add handling of capabilities in multi process
>       crypto/qat: add minimum enq threshold
>
> Ayuj Verma (1):
>       examples/fips_validation: fix parsing of TDES vectors
>
> Bruce Richardson (12):
>       test: fix build with ring PMD but no bond PMD
>       mem: fix 32-bit init config with meson
>       rawdev: allow getting info for unknown device
>       rawdev: fill NUMA socket ID in info
>       rawdev: export dump function in map file
>       doc: rebuild with meson whenever a file changes
>       build: always link whole DPDK static libraries
>       devtools: test static linkage with pkg-config
>       build/pkg-config: move pkg-config file creation
>       build/pkg-config: output drivers first for static build
>       build/pkg-config: improve static linking flags
>       build/pkg-config: prevent overlinking
>
> Chas Williams (1):
>       net/netvsc: fix crash during Tx
>
> Chenbo Xia (1):
>       net/virtio-user: check tap system call setting
>
> Chengchang Tang (5):
>       net/hns3: clear promiscuous on PF uninit
>       net/hns3: remove unsupported VLAN capabilities
>       net/hns3: fix VLAN strip configuration when setting PVID
>       net/hns3: remove restriction on setting VF MTU
>       net/hns3: fix adding multicast MAC address
>
> Chenmin Sun (1):
>       net/i40e: fix flow director Rx writeback packet
>
> Ciara Loftus (1):
>       net/af_xdp: remove mempool freeing on umem destruction
>
> David Marchand (7):
>       eal/windows: fix symbol export
>       eal: remove redundant newline in alert message
>       net/mlx5: remove redundant newline from logs
>       net/mvpp2: fix non-EAL thread support
>       devtools: fix path in forbidden token check
>       lib: remind experimental status in headers
>       net/bonding: fix socket ID check
>
> Dekel Peled (2):
>       net/mlx5: fix VLAN pop with decap action validation
>       net/mlx5: fix VLAN push action on hairpin queue
>
> Devendra Singh Rawat (1):
>       net/qede: fix multicast drop in promiscuous mode
>
> Dong Zhou (1):
>       net/mlx5: fix LRO checksum
>
> Dongyang Pan (1):
>       net/bonding: delete redundant code
>
> Fady Bader (1):
>       meter: remove inline functions from export list
>
> Feifei Wang (1):
>       test/ring: fix statistics in bulk enq/dequeue
>
> Ferruh Yigit (4):
>       net/iavf: fix uninitialized variable
>       net/ixgbe/base: remove dead code
>       ethdev: fix log type for some error messages
>       drivers/net: fix exposing internal headers
>
> Fiona Trahe (3):
>       common/qat: remove tail write coalescing
>       common/qat: move max inflights param into qp
>       common/qat: support dual threads for enqueue/dequeue
>
> Gaurav Singh (1):
>       net/i40e: remove duplicate tunnel type check
>
> Georgiy Levashov (1):
>       examples: add flush after stats printing
>
> Gregory Etelson (1):
>       net/mlx5: fix tunnel flow priority
>
> Guinan Sun (5):
>       net/ixgbe/base: fix host interface shadow RAM read
>       net/ixgbe/base: fix x550em 10G NIC link status
>       net/ixgbe/base: fix infinite recursion on PCIe link down
>       net/ixgbe: fix MAC control frame forward
>       net/ixgbe: fix flow control status
>
> Haiyue Wang (6):
>       bus/pci: fix VF memory access
>       eal: fix uuid header dependencies
>       net/ice: fix TCP checksum offload
>       net/ice: calculate TCP header size for offload
>       net/ice: fix Tx hang with TSO
>       net/ice: revert fake TSO fixes
>
> Hao Chen (1):
>       net/hns3: optimize default RSS algorithm
>
> Harman Kalra (4):
>       eal/linux: fix epoll fd list rebuild for interrupts
>       net/octeontx2: fix DMAC filtering
>       common/octeontx2: fix crash on running procinfo
>       eal: fix parentheses in alignment macros
>
> Harry van Haaren (1):
>       examples/eventdev: fix 32-bit coremask
>
> Heinrich Kuhn (1):
>       net/nfp: fix RSS hash configuration reporting
>
> Hemant Agrawal (1):
>       rawdev: remove remaining experimental tags
>
> Hongbo Zheng (4):
>       net/hns3: ignore function return on reset error path
>       net/hns3: fix unintended sign extension in dump operation
>       net/hns3: clear residual hardware configurations on init
>       net/hns3: get link status change through mailbox
>
> Hongzhi Guo (3):
>       net: fix IPv4 checksum
>       net: fix unneeded replacement of TCP checksum 0
>       net: fix checksum on big endian CPUs
>
> Honnappa Nagarahalli (5):
>       eal/armv8: fix timer frequency calibration with PMU
>       app/testpmd: use clock time in throughput calculation
>       app/testpmd: fix burst percentage calculation
>       doc: fix some typos in Linux guide
>       test/hash: move lock-free tests to perf tests
>
> Hrvoje Habjanic (1):
>       sched: fix subport freeing
>
> Ian Dolzhansky (1):
>       net/failsafe: fix RSS RETA size info
>
> Igor Romanov (1):
>       service: fix lcore iteration
>
> Jecky Pei (1):
>       net/kni: set packet input port in Rx
>
> Jeff Guo (1):
>       net/e1000: fix crash on Tx done clean up
>
> Junfeng Guo (2):
>       net/ice/base: fix RSS removal for GTP-U
>       net/ice/base: fix memory leak on GTPU RSS
>
> Junyu Jiang (2):
>       net/iavf: fix RSS RETA after restart
>       net/ice: fix bytes statistics
>
> Kalesh AP (5):
>       net/bnxt: remove unused enum declaration
>       net/bnxt: fix unnecessary HWRM command
>       net/bnxt: fix flow error on filter creation
>       net/bnxt: fix freeing filters on flow creation failure
>       net/bnxt: fix logical AND in if condition
>
> Kevin Traynor (1):
>       vhost: remove zero-copy and client mode restriction
>
> Konstantin Ananyev (2):
>       test/bpf: fix few small issues
>       bpf: fix add/sub min/max estimations
>
> Levend Sayar (1):
>       service: fix C++ linkage
>
> Lijun Ou (5):
>       net/hns3: add RSS hash offload to Rx configuration
>       net/hns3: fix key length when configuring RSS
>       net/hns3: fix RSS configuration on empty RSS type
>       net/hns3: remove unnecessary branch
>       app/testpmd: remove hardcoded descriptors limit
>
> Long Li (3):
>       bus/vmbus: fix ring buffer mapping
>       net/netvsc: fix underflow when Rx external mbuf
>       net/netvsc: fix chimney index
>
> Lukasz Wojciechowski (1):
>       service: fix core mapping reset
>
> Mao Jiang (2):
>       net/i40e: fix binding interrupt without MSI-X vector
>       net/i40e: fix flow director MSI-X resource allocation
>
> Matan Azrad (1):
>       vhost: fix features definition location
>
> Maxime Coquelin (3):
>       bus/dpaa: fix iterating on a class type
>       bus/fslmc: fix iterating on a class type
>       vhost: fix virtio ready flag check
>
> Michael Baum (11):
>       net/mlx5: remove needless Tx queue initialization check
>       net/mlx5: fix unreachable MPLS error path
>       common/mlx5: fix code arrangement in tag allocation
>       net/mlx5: fix iterator type in Rx queue management
>       net/mlx5: fix initialization of steering registers
>       net/mlx5: fix crash in NVGRE item translation
>       net/mlx5: remove ineffective increment in hairpin split
>       net/mlx4: optimize stack memory size in probe
>       net/mlx5: fix unnecessary init in mark conversion
>       net/mlx5: fix hairpin Tx queue creation error flow
>       net/mlx5: fix hairpin Rx queue creation error flow
>
> Muhammad Bilal (1):
>       bus/vdev: fix a typo in doxygen comment
>
> Nipun Gupta (2):
>       bus/fslmc: fix getting FD error
>       net/dpaa: fix FD offset data type
>
> Pablo de Lara (1):
>       drivers/crypto: add missing OOP feature flag
>
> Parav Pandit (1):
>       common/mlx5: fix void parameters in glue wrappers
>
> Patrick Fu (1):
>       vhost: fix double-free with zero-copy
>
> Pavan Nikhilesh (2):
>       event/octeontx2: fix device reconfigure
>       event/octeontx2: fix sub event type
>
> Pavel Ivashchenko (1):
>       net/i40e: fix getting EEPROM information
>
> Phil Yang (5):
>       eventdev: fix race condition on timer list counter
>       eventdev: use C11 atomics for lcore timer armed flag
>       eventdev: remove redundant reset on timer cancel
>       eventdev: relax SMP barriers with C11 atomics
>       app/testpmd: fix CPU cycles per packet stats on Tx modes
>
> Qi Zhang (7):
>       net/ice/base: fix return value
>       net/ice/base: fix memory leak on error path
>       net/ice/base: fix reference count on VSI list update
>       net/ice/base: fix initializing resource for field vector
>       net/ice/base: fix VSI ID mask to 10 bits
>       net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
>       net/ice/base: fix RSS interference
>
> Rahul Gupta (1):
>       net/bnxt: fix performance for Arm
>
> Rahul Lakkireddy (3):
>       net/cxgbe: fix CLIP leak in filter error path
>       net/cxgbe: fix double MPS alloc by flow validate and create
>       net/cxgbe: fix L2T leak in filter error and free path
>
> Raslan Darawsheh (3):
>       net: fix pedantic build
>       net/mlx5: fix flow items size calculation
>       net/mlx5: fix VF MAC address set over BlueField
>
> Ruifeng Wang (8):
>       net/i40e: enable NEON Rx/Tx in meson
>       eal/arm: add vcopyq intrinsic for aarch32
>       net/ixgbe: fix include of vector header file
>       test: allow no-huge mode for fast-tests
>       test/cycles: restore default delay callback
>       crypto/armv8: remove debug option
>       crypto/armv8: use dedicated log type
>       net/i40e: support aarch32
>
> Sarosh Arif (3):
>       doc: fix typo in bbdev test guide
>       examples/packet_ordering: use proper exit method
>       doc: fix ethtool app path
>
> Shougang Wang (2):
>       net/ice: fix error log in generic flow
>       net/i40e: fix filter pctype
>
> Shy Shyman (3):
>       app/testpmd: fix error detection in MTU command
>       net/mlx5: fix flow META item validation
>       net/mlx5: fix HW counters path in switchdev mode
>
> Stephen Hemminger (8):
>       net/netvsc: fix warning when VF is removed
>       net/netvsc: do not query VF link state
>       net/netvsc: do not spin forever waiting for reply
>       eal: fix lcore accessors for non-EAL threads
>       cfgfile: fix stack buffer underflow
>       rib: add C++ include guard
>       kni: fix reference to master/slave process
>       doc: fix reference to master process
>
> Suanming Mou (3):
>       net/mlx5: fix secondary process resources release
>       net/mlx5: fix interrupt installation timing
>       net/mlx5: fix counter query
>
> Tal Shnaiderman (2):
>       build: fix drivers library path on Windows
>       pci: fix address domain format size
>
> Thomas Monjalon (1):
>       doc: update build instructions in the Linux guide
>
> Tianfei Zhang (2):
>       raw/ifpga/base: fix SPI transaction
>       raw/ifpga/base: fix NIOS SPI init
>
> Timothy Redaelli (1):
>       test: fix rpath for drivers with meson
>
> Viacheslav Ovsiienko (3):
>       net/mlx5: fix UAR lock sharing for multiport devices
>       common/mlx5: fix queue doorbell record size
>       net/mlx5: fix metadata storing for NEON Rx
>
> Vladimir Medvedkin (1):
>       doc: add RIB and FIB into the API index
>
> Wei Hu (Xavier) (12):
>       net/hns3: fix Tx less than 60 bytes
>       net/hns3: fix VLAN tags reported in Rx
>       app/testpmd: fix stats error message
>       net/hns3: fix flow director error message
>       net/hns3: fix unintended sign extension in fd operation
>       net/hns3: fix Rx buffer size
>       net/hns3: check multi-process action register result
>       ethdev: fix data room size verification in Rx queue setup
>       ethdev: fix VLAN offloads set if no relative capabilities
>       net/bonding: fix error code on device creation
>       net/bonding: fix MAC address when switching active port
>       net/bonding: fix MAC address when one port resets
>
> Wei Zhao (4):
>       net/ice: fix switch action number check
>       net/ixgbe: report 10Mbps link speed for x553
>       net/ice: add input set byte number check
>       net/i40e: enable QinQ stripping
>
> Weifeng Li (1):
>       net/bonding: change state machine to defaulted
>
> Xiao Wang (1):
>       net/virtio-user: fix status management
>
> Xiaolong Ye (6):
>       mbuf: remove unused next member in dynamic flag/field
>       test/mbuf: fix a dynamic flag log
>       mbuf: fix boundary check at dynamic field registration
>       mbuf: fix error code in dynamic field/flag registration
>       mbuf: fix free space update for dynamic field
>       mbuf: fix dynamic field dump log
>
> Xiaoyun Wang (5):
>       net/hinic/base: check output of management sync channel
>       net/hinic/base: remove unused function parameters
>       net/hinic: fix setting promiscuous mode
>       net/hinic: optimize Rx performance for x86
>       net/hinic/base: avoid system time jump
>
> Yicai Lu (1):
>       net/bonding: fix LACP negotiation
>
> Yunjian Wang (12):
>       app/testpmd: fix memory leak on error path
>       vfio: remove unused variable
>       net/af_packet: fix check of file descriptors
>       net/af_packet: fix memory leak on init failure
>       net/af_packet: fix munmap on init failure
>       bus/fslmc: fix memory leak in secondary process
>       hash: fix out-of-memory handling in hash creation
>       event/dpaa: remove dead code
>       net/qede: remove dead code
>       net/hinic: check memory allocations in flow creation
>       net/ice: fix memory leak when releasing VSI
>       net/ice: add memory allocation check in RSS init
>
> Zhiguang He (1):
>       net/bonding: fix dead loop on RSS RETA update
>
> Zhihong Peng (2):
>       net/i40e: report VLAN filter capability
>       net/e1000: report VLAN extend capability
>
> Zhike Wang (1):
>       mempool: fix allocation in memzone during retry



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [dpdk-dev] [dpdk-stable] 19.11.4 patches review and test

[Luca Boccassi]

On Mon, 2020-08-24 at 15:22 +0200, Christian Ehrhardt wrote:
> On Tue, Aug 18, 2020 at 8:12 PM Luca Boccassi <bluca@debian.org> wrote:
> > Hi all,
> > 
> > Here is a list of patches targeted for stable release 19.11.4.
> > 
> > The planned date for the final release is August 31st.
> > 
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> > 
> > A release candidate tarball can be found at:
> > 
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> 
> Build tested on all Ubuntu architectures and pushed through some
> OVS-DPDK based tests on x86.
> Working fine in these setups.

Thank you!

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] 19.11.4 patches review and test

[Pei Zhang]

Hello Luca,

Testing with dpdk 19.11.4-rc1 from Red Hat looks good.

We cover below 16 scenarios and and all get PASS on RHEL8 testing:

(1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS
(2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS
(3)Guest with device assignment(VF) throughput testing: PASS
(4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
(5)PVP vhost-user 2Q throughput testing: PASS
(6)PVP vhost-user 1Q - cross numa node throughput testing: PASS
(7)Guest with vhost-user 2 queues throughput testing: PASS
(8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS
(9)PVP 1Q live migration testing: PASS
(10)PVP 1Q cross numa node live migration testing: PASS
(11)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
(12)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
(13)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
(14) Allocate memory from the NUMA node which Virtio device locates: PASS
(15)Host PF + DPDK testing: PASS
(16)Host VF + DPDK testing: PASS

Versions:

kernel 4.18
qemu 5.1
dpdk: git://dpdk.org/dpdk-stable remotes/origin/19.11
# git log
commit bb00cdf6cdcf690001ef4154a5aaad8c0dc5d9b9 (HEAD, tag: v19.11.4-rc1, origin/19.11)
Author: Luca Boccassi <bluca@debian.org>
Date:   Tue Aug 18 19:00:36 2020 +0100

    version: 19.11.4-rc1
    
    Signed-off-by: Luca Boccassi <bluca@debian.org>


NICs: X540-AT2 NIC(ixgbe, 10G)

Best regards,

Pei


----- Original Message -----
> From: "Luca Boccassi" <bluca@debian.org>
> To: stable@dpdk.org
> Cc: dev@dpdk.org, "Abhishek Marathe" <Abhishek.Marathe@microsoft.com>, "Akhil Goyal" <akhil.goyal@nxp.com>, "Ali
> Alnubani" <alialnu@mellanox.com>, "benjamin walker" <benjamin.walker@intel.com>, "David Christensen"
> <drc@linux.vnet.ibm.com>, "Hemant Agrawal" <hemant.agrawal@nxp.com>, "Ian Stokes" <ian.stokes@intel.com>, "Jerin
> Jacob" <jerinj@marvell.com>, "John McNamara" <john.mcnamara@intel.com>, "Ju-Hyoung Lee" <juhlee@microsoft.com>,
> "Kevin Traynor" <ktraynor@redhat.com>, "Pei Zhang" <pezhang@redhat.com>, "pingx yu" <pingx.yu@intel.com>, "qian q
> xu" <qian.q.xu@intel.com>, "Raslan Darawsheh" <rasland@mellanox.com>, "Thomas Monjalon" <thomas@monjalon.net>, "yuan
> peng" <yuan.peng@intel.com>, "zhaoyan chen" <zhaoyan.chen@intel.com>
> Sent: Wednesday, August 19, 2020 2:12:22 AM
> Subject: 19.11.4 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 19.11.4.
> 
> The planned date for the final release is August 31st.
> 
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> 
> These patches are located at branch 19.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> Adam Dybkowski (7):
>       test/crypto: fix asymmetric session mempool creation
>       crypto/qat: fix AES-XTS capabilities
>       crypto/qat: handle mixed hash-cipher requests on GEN3
>       test/crypto: add mixed encypted-digest
>       common/qat: get firmware version
>       crypto/qat: handle mixed hash-cipher on GEN2
>       common/qat: fix uninitialized variable
> 
> Akhil Goyal (4):
>       crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
>       crypto/dpaax_sec: fix inline query for descriptors
>       crypto/dpaa2_sec: fix HFN override
>       common/dpaax: fix 12-bit null auth case
> 
> Alan Dewar (1):
>       sched: fix port time rounding
> 
> Alexander Kozyrev (3):
>       net/mlx5: fix vectorized Rx burst termination
>       net/mlx5: do not select legacy MPW implicitly
>       net/mlx5: fix descriptors number adjustment
> 
> Ali Alnubani (2):
>       net/mlx5: fix typos in meter error messages
>       doc: fix a typo in mlx5 guide
> 
> Alvin Zhang (1):
>       net/i40e: fix queue pairs configuration in VF
> 
> Andrew Rybchenko (1):
>       net/sfc: do not enforce hash offload in RSS multi-queue
> 
> Ankur Dwivedi (2):
>       common/cpt: fix encryption offset
>       test/crypto: change cipher offset for ESN vector
> 
> Apeksha Gupta (2):
>       app/eventdev: fix capability check in pipeline ATQ test
>       event/dpaa2: add all-types queue capability flag
> 
> Archana Muniganti (2):
>       examples/fips_validation: fix TDES interim callback
>       examples/fips_validation: fix count overwrite for TDES
> 
> Archit Pandey (1):
>       sched: fix 64-bit rate
> 
> Arek Kusztal (4):
>       drivers/qat: improve multi process on qat
>       drivers/qat: add multi process handling of driver id
>       drivers/qat: add handling of capabilities in multi process
>       crypto/qat: add minimum enq threshold
> 
> Ayuj Verma (1):
>       examples/fips_validation: fix parsing of TDES vectors
> 
> Bruce Richardson (12):
>       test: fix build with ring PMD but no bond PMD
>       mem: fix 32-bit init config with meson
>       rawdev: allow getting info for unknown device
>       rawdev: fill NUMA socket ID in info
>       rawdev: export dump function in map file
>       doc: rebuild with meson whenever a file changes
>       build: always link whole DPDK static libraries
>       devtools: test static linkage with pkg-config
>       build/pkg-config: move pkg-config file creation
>       build/pkg-config: output drivers first for static build
>       build/pkg-config: improve static linking flags
>       build/pkg-config: prevent overlinking
> 
> Chas Williams (1):
>       net/netvsc: fix crash during Tx
> 
> Chenbo Xia (1):
>       net/virtio-user: check tap system call setting
> 
> Chengchang Tang (5):
>       net/hns3: clear promiscuous on PF uninit
>       net/hns3: remove unsupported VLAN capabilities
>       net/hns3: fix VLAN strip configuration when setting PVID
>       net/hns3: remove restriction on setting VF MTU
>       net/hns3: fix adding multicast MAC address
> 
> Chenmin Sun (1):
>       net/i40e: fix flow director Rx writeback packet
> 
> Ciara Loftus (1):
>       net/af_xdp: remove mempool freeing on umem destruction
> 
> David Marchand (7):
>       eal/windows: fix symbol export
>       eal: remove redundant newline in alert message
>       net/mlx5: remove redundant newline from logs
>       net/mvpp2: fix non-EAL thread support
>       devtools: fix path in forbidden token check
>       lib: remind experimental status in headers
>       net/bonding: fix socket ID check
> 
> Dekel Peled (2):
>       net/mlx5: fix VLAN pop with decap action validation
>       net/mlx5: fix VLAN push action on hairpin queue
> 
> Devendra Singh Rawat (1):
>       net/qede: fix multicast drop in promiscuous mode
> 
> Dong Zhou (1):
>       net/mlx5: fix LRO checksum
> 
> Dongyang Pan (1):
>       net/bonding: delete redundant code
> 
> Fady Bader (1):
>       meter: remove inline functions from export list
> 
> Feifei Wang (1):
>       test/ring: fix statistics in bulk enq/dequeue
> 
> Ferruh Yigit (4):
>       net/iavf: fix uninitialized variable
>       net/ixgbe/base: remove dead code
>       ethdev: fix log type for some error messages
>       drivers/net: fix exposing internal headers
> 
> Fiona Trahe (3):
>       common/qat: remove tail write coalescing
>       common/qat: move max inflights param into qp
>       common/qat: support dual threads for enqueue/dequeue
> 
> Gaurav Singh (1):
>       net/i40e: remove duplicate tunnel type check
> 
> Georgiy Levashov (1):
>       examples: add flush after stats printing
> 
> Gregory Etelson (1):
>       net/mlx5: fix tunnel flow priority
> 
> Guinan Sun (5):
>       net/ixgbe/base: fix host interface shadow RAM read
>       net/ixgbe/base: fix x550em 10G NIC link status
>       net/ixgbe/base: fix infinite recursion on PCIe link down
>       net/ixgbe: fix MAC control frame forward
>       net/ixgbe: fix flow control status
> 
> Haiyue Wang (6):
>       bus/pci: fix VF memory access
>       eal: fix uuid header dependencies
>       net/ice: fix TCP checksum offload
>       net/ice: calculate TCP header size for offload
>       net/ice: fix Tx hang with TSO
>       net/ice: revert fake TSO fixes
> 
> Hao Chen (1):
>       net/hns3: optimize default RSS algorithm
> 
> Harman Kalra (4):
>       eal/linux: fix epoll fd list rebuild for interrupts
>       net/octeontx2: fix DMAC filtering
>       common/octeontx2: fix crash on running procinfo
>       eal: fix parentheses in alignment macros
> 
> Harry van Haaren (1):
>       examples/eventdev: fix 32-bit coremask
> 
> Heinrich Kuhn (1):
>       net/nfp: fix RSS hash configuration reporting
> 
> Hemant Agrawal (1):
>       rawdev: remove remaining experimental tags
> 
> Hongbo Zheng (4):
>       net/hns3: ignore function return on reset error path
>       net/hns3: fix unintended sign extension in dump operation
>       net/hns3: clear residual hardware configurations on init
>       net/hns3: get link status change through mailbox
> 
> Hongzhi Guo (3):
>       net: fix IPv4 checksum
>       net: fix unneeded replacement of TCP checksum 0
>       net: fix checksum on big endian CPUs
> 
> Honnappa Nagarahalli (5):
>       eal/armv8: fix timer frequency calibration with PMU
>       app/testpmd: use clock time in throughput calculation
>       app/testpmd: fix burst percentage calculation
>       doc: fix some typos in Linux guide
>       test/hash: move lock-free tests to perf tests
> 
> Hrvoje Habjanic (1):
>       sched: fix subport freeing
> 
> Ian Dolzhansky (1):
>       net/failsafe: fix RSS RETA size info
> 
> Igor Romanov (1):
>       service: fix lcore iteration
> 
> Jecky Pei (1):
>       net/kni: set packet input port in Rx
> 
> Jeff Guo (1):
>       net/e1000: fix crash on Tx done clean up
> 
> Junfeng Guo (2):
>       net/ice/base: fix RSS removal for GTP-U
>       net/ice/base: fix memory leak on GTPU RSS
> 
> Junyu Jiang (2):
>       net/iavf: fix RSS RETA after restart
>       net/ice: fix bytes statistics
> 
> Kalesh AP (5):
>       net/bnxt: remove unused enum declaration
>       net/bnxt: fix unnecessary HWRM command
>       net/bnxt: fix flow error on filter creation
>       net/bnxt: fix freeing filters on flow creation failure
>       net/bnxt: fix logical AND in if condition
> 
> Kevin Traynor (1):
>       vhost: remove zero-copy and client mode restriction
> 
> Konstantin Ananyev (2):
>       test/bpf: fix few small issues
>       bpf: fix add/sub min/max estimations
> 
> Levend Sayar (1):
>       service: fix C++ linkage
> 
> Lijun Ou (5):
>       net/hns3: add RSS hash offload to Rx configuration
>       net/hns3: fix key length when configuring RSS
>       net/hns3: fix RSS configuration on empty RSS type
>       net/hns3: remove unnecessary branch
>       app/testpmd: remove hardcoded descriptors limit
> 
> Long Li (3):
>       bus/vmbus: fix ring buffer mapping
>       net/netvsc: fix underflow when Rx external mbuf
>       net/netvsc: fix chimney index
> 
> Lukasz Wojciechowski (1):
>       service: fix core mapping reset
> 
> Mao Jiang (2):
>       net/i40e: fix binding interrupt without MSI-X vector
>       net/i40e: fix flow director MSI-X resource allocation
> 
> Matan Azrad (1):
>       vhost: fix features definition location
> 
> Maxime Coquelin (3):
>       bus/dpaa: fix iterating on a class type
>       bus/fslmc: fix iterating on a class type
>       vhost: fix virtio ready flag check
> 
> Michael Baum (11):
>       net/mlx5: remove needless Tx queue initialization check
>       net/mlx5: fix unreachable MPLS error path
>       common/mlx5: fix code arrangement in tag allocation
>       net/mlx5: fix iterator type in Rx queue management
>       net/mlx5: fix initialization of steering registers
>       net/mlx5: fix crash in NVGRE item translation
>       net/mlx5: remove ineffective increment in hairpin split
>       net/mlx4: optimize stack memory size in probe
>       net/mlx5: fix unnecessary init in mark conversion
>       net/mlx5: fix hairpin Tx queue creation error flow
>       net/mlx5: fix hairpin Rx queue creation error flow
> 
> Muhammad Bilal (1):
>       bus/vdev: fix a typo in doxygen comment
> 
> Nipun Gupta (2):
>       bus/fslmc: fix getting FD error
>       net/dpaa: fix FD offset data type
> 
> Pablo de Lara (1):
>       drivers/crypto: add missing OOP feature flag
> 
> Parav Pandit (1):
>       common/mlx5: fix void parameters in glue wrappers
> 
> Patrick Fu (1):
>       vhost: fix double-free with zero-copy
> 
> Pavan Nikhilesh (2):
>       event/octeontx2: fix device reconfigure
>       event/octeontx2: fix sub event type
> 
> Pavel Ivashchenko (1):
>       net/i40e: fix getting EEPROM information
> 
> Phil Yang (5):
>       eventdev: fix race condition on timer list counter
>       eventdev: use C11 atomics for lcore timer armed flag
>       eventdev: remove redundant reset on timer cancel
>       eventdev: relax SMP barriers with C11 atomics
>       app/testpmd: fix CPU cycles per packet stats on Tx modes
> 
> Qi Zhang (7):
>       net/ice/base: fix return value
>       net/ice/base: fix memory leak on error path
>       net/ice/base: fix reference count on VSI list update
>       net/ice/base: fix initializing resource for field vector
>       net/ice/base: fix VSI ID mask to 10 bits
>       net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
>       net/ice/base: fix RSS interference
> 
> Rahul Gupta (1):
>       net/bnxt: fix performance for Arm
> 
> Rahul Lakkireddy (3):
>       net/cxgbe: fix CLIP leak in filter error path
>       net/cxgbe: fix double MPS alloc by flow validate and create
>       net/cxgbe: fix L2T leak in filter error and free path
> 
> Raslan Darawsheh (3):
>       net: fix pedantic build
>       net/mlx5: fix flow items size calculation
>       net/mlx5: fix VF MAC address set over BlueField
> 
> Ruifeng Wang (8):
>       net/i40e: enable NEON Rx/Tx in meson
>       eal/arm: add vcopyq intrinsic for aarch32
>       net/ixgbe: fix include of vector header file
>       test: allow no-huge mode for fast-tests
>       test/cycles: restore default delay callback
>       crypto/armv8: remove debug option
>       crypto/armv8: use dedicated log type
>       net/i40e: support aarch32
> 
> Sarosh Arif (3):
>       doc: fix typo in bbdev test guide
>       examples/packet_ordering: use proper exit method
>       doc: fix ethtool app path
> 
> Shougang Wang (2):
>       net/ice: fix error log in generic flow
>       net/i40e: fix filter pctype
> 
> Shy Shyman (3):
>       app/testpmd: fix error detection in MTU command
>       net/mlx5: fix flow META item validation
>       net/mlx5: fix HW counters path in switchdev mode
> 
> Stephen Hemminger (8):
>       net/netvsc: fix warning when VF is removed
>       net/netvsc: do not query VF link state
>       net/netvsc: do not spin forever waiting for reply
>       eal: fix lcore accessors for non-EAL threads
>       cfgfile: fix stack buffer underflow
>       rib: add C++ include guard
>       kni: fix reference to master/slave process
>       doc: fix reference to master process
> 
> Suanming Mou (3):
>       net/mlx5: fix secondary process resources release
>       net/mlx5: fix interrupt installation timing
>       net/mlx5: fix counter query
> 
> Tal Shnaiderman (2):
>       build: fix drivers library path on Windows
>       pci: fix address domain format size
> 
> Thomas Monjalon (1):
>       doc: update build instructions in the Linux guide
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix SPI transaction
>       raw/ifpga/base: fix NIOS SPI init
> 
> Timothy Redaelli (1):
>       test: fix rpath for drivers with meson
> 
> Viacheslav Ovsiienko (3):
>       net/mlx5: fix UAR lock sharing for multiport devices
>       common/mlx5: fix queue doorbell record size
>       net/mlx5: fix metadata storing for NEON Rx
> 
> Vladimir Medvedkin (1):
>       doc: add RIB and FIB into the API index
> 
> Wei Hu (Xavier) (12):
>       net/hns3: fix Tx less than 60 bytes
>       net/hns3: fix VLAN tags reported in Rx
>       app/testpmd: fix stats error message
>       net/hns3: fix flow director error message
>       net/hns3: fix unintended sign extension in fd operation
>       net/hns3: fix Rx buffer size
>       net/hns3: check multi-process action register result
>       ethdev: fix data room size verification in Rx queue setup
>       ethdev: fix VLAN offloads set if no relative capabilities
>       net/bonding: fix error code on device creation
>       net/bonding: fix MAC address when switching active port
>       net/bonding: fix MAC address when one port resets
> 
> Wei Zhao (4):
>       net/ice: fix switch action number check
>       net/ixgbe: report 10Mbps link speed for x553
>       net/ice: add input set byte number check
>       net/i40e: enable QinQ stripping
> 
> Weifeng Li (1):
>       net/bonding: change state machine to defaulted
> 
> Xiao Wang (1):
>       net/virtio-user: fix status management
> 
> Xiaolong Ye (6):
>       mbuf: remove unused next member in dynamic flag/field
>       test/mbuf: fix a dynamic flag log
>       mbuf: fix boundary check at dynamic field registration
>       mbuf: fix error code in dynamic field/flag registration
>       mbuf: fix free space update for dynamic field
>       mbuf: fix dynamic field dump log
> 
> Xiaoyun Wang (5):
>       net/hinic/base: check output of management sync channel
>       net/hinic/base: remove unused function parameters
>       net/hinic: fix setting promiscuous mode
>       net/hinic: optimize Rx performance for x86
>       net/hinic/base: avoid system time jump
> 
> Yicai Lu (1):
>       net/bonding: fix LACP negotiation
> 
> Yunjian Wang (12):
>       app/testpmd: fix memory leak on error path
>       vfio: remove unused variable
>       net/af_packet: fix check of file descriptors
>       net/af_packet: fix memory leak on init failure
>       net/af_packet: fix munmap on init failure
>       bus/fslmc: fix memory leak in secondary process
>       hash: fix out-of-memory handling in hash creation
>       event/dpaa: remove dead code
>       net/qede: remove dead code
>       net/hinic: check memory allocations in flow creation
>       net/ice: fix memory leak when releasing VSI
>       net/ice: add memory allocation check in RSS init
> 
> Zhiguang He (1):
>       net/bonding: fix dead loop on RSS RETA update
> 
> Zhihong Peng (2):
>       net/i40e: report VLAN filter capability
>       net/e1000: report VLAN extend capability
> 
> Zhike Wang (1):
>       mempool: fix allocation in memzone during retry
> 
> 

Re: [dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Tue, 2020-08-25 at 05:13 -0400, Pei Zhang wrote:
> Hello Luca,
> 
> Testing with dpdk 19.11.4-rc1 from Red Hat looks good.
> 
> We cover below 16 scenarios and and all get PASS on RHEL8 testing:
> 
> (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS
> (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS
> (3)Guest with device assignment(VF) throughput testing: PASS
> (4)PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
> (5)PVP vhost-user 2Q throughput testing: PASS
> (6)PVP vhost-user 1Q - cross numa node throughput testing: PASS
> (7)Guest with vhost-user 2 queues throughput testing: PASS
> (8)vhost-user reconnect with dpdk-client, qemu-server: qemu reconnect: PASS
> (9)PVP 1Q live migration testing: PASS
> (10)PVP 1Q cross numa node live migration testing: PASS
> (11)Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
> (12)Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
> (13)Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
> (14) Allocate memory from the NUMA node which Virtio device locates: PASS
> (15)Host PF + DPDK testing: PASS
> (16)Host VF + DPDK testing: PASS
> 
> Versions:
> 
> kernel 4.18
> qemu 5.1
> dpdk: git://dpdk.org/dpdk-stable remotes/origin/19.11
> # git log
> commit bb00cdf6cdcf690001ef4154a5aaad8c0dc5d9b9 (HEAD, tag: v19.11.4-rc1, origin/19.11)
> Author: Luca Boccassi <bluca@debian.org>
> Date:   Tue Aug 18 19:00:36 2020 +0100
> 
>     version: 19.11.4-rc1
>     
>     Signed-off-by: Luca Boccassi <bluca@debian.org>
> 
> 
> NICs: X540-AT2 NIC(ixgbe, 10G)
> 
> Best regards,
> 
> Pei

Thank you!

> 
> ----- Original Message -----
> > From: "Luca Boccassi" <bluca@debian.org>
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org, "Abhishek Marathe" <Abhishek.Marathe@microsoft.com>, "Akhil Goyal" <akhil.goyal@nxp.com>, "Ali
> > Alnubani" <alialnu@mellanox.com>, "benjamin walker" <benjamin.walker@intel.com>, "David Christensen"
> > <drc@linux.vnet.ibm.com>, "Hemant Agrawal" <hemant.agrawal@nxp.com>, "Ian Stokes" <ian.stokes@intel.com>, "Jerin
> > Jacob" <jerinj@marvell.com>, "John McNamara" <john.mcnamara@intel.com>, "Ju-Hyoung Lee" <juhlee@microsoft.com>,
> > "Kevin Traynor" <ktraynor@redhat.com>, "Pei Zhang" <pezhang@redhat.com>, "pingx yu" <pingx.yu@intel.com>, "qian q
> > xu" <qian.q.xu@intel.com>, "Raslan Darawsheh" <rasland@mellanox.com>, "Thomas Monjalon" <thomas@monjalon.net>, "yuan
> > peng" <yuan.peng@intel.com>, "zhaoyan chen" <zhaoyan.chen@intel.com>
> > Sent: Wednesday, August 19, 2020 2:12:22 AM
> > Subject: 19.11.4 patches review and test
> > 
> > Hi all,
> > 
> > Here is a list of patches targeted for stable release 19.11.4.
> > 
> > The planned date for the final release is August 31st.
> > 
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> > 
> > A release candidate tarball can be found at:
> > 
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > 
> > These patches are located at branch 19.11 of dpdk-stable repo:
> >     https://dpdk.org/browse/dpdk-stable/
> > 
> > Thanks.
> > 
> > Luca Boccassi
> > 
> > ---
> > Adam Dybkowski (7):
> >       test/crypto: fix asymmetric session mempool creation
> >       crypto/qat: fix AES-XTS capabilities
> >       crypto/qat: handle mixed hash-cipher requests on GEN3
> >       test/crypto: add mixed encypted-digest
> >       common/qat: get firmware version
> >       crypto/qat: handle mixed hash-cipher on GEN2
> >       common/qat: fix uninitialized variable
> > 
> > Akhil Goyal (4):
> >       crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
> >       crypto/dpaax_sec: fix inline query for descriptors
> >       crypto/dpaa2_sec: fix HFN override
> >       common/dpaax: fix 12-bit null auth case
> > 
> > Alan Dewar (1):
> >       sched: fix port time rounding
> > 
> > Alexander Kozyrev (3):
> >       net/mlx5: fix vectorized Rx burst termination
> >       net/mlx5: do not select legacy MPW implicitly
> >       net/mlx5: fix descriptors number adjustment
> > 
> > Ali Alnubani (2):
> >       net/mlx5: fix typos in meter error messages
> >       doc: fix a typo in mlx5 guide
> > 
> > Alvin Zhang (1):
> >       net/i40e: fix queue pairs configuration in VF
> > 
> > Andrew Rybchenko (1):
> >       net/sfc: do not enforce hash offload in RSS multi-queue
> > 
> > Ankur Dwivedi (2):
> >       common/cpt: fix encryption offset
> >       test/crypto: change cipher offset for ESN vector
> > 
> > Apeksha Gupta (2):
> >       app/eventdev: fix capability check in pipeline ATQ test
> >       event/dpaa2: add all-types queue capability flag
> > 
> > Archana Muniganti (2):
> >       examples/fips_validation: fix TDES interim callback
> >       examples/fips_validation: fix count overwrite for TDES
> > 
> > Archit Pandey (1):
> >       sched: fix 64-bit rate
> > 
> > Arek Kusztal (4):
> >       drivers/qat: improve multi process on qat
> >       drivers/qat: add multi process handling of driver id
> >       drivers/qat: add handling of capabilities in multi process
> >       crypto/qat: add minimum enq threshold
> > 
> > Ayuj Verma (1):
> >       examples/fips_validation: fix parsing of TDES vectors
> > 
> > Bruce Richardson (12):
> >       test: fix build with ring PMD but no bond PMD
> >       mem: fix 32-bit init config with meson
> >       rawdev: allow getting info for unknown device
> >       rawdev: fill NUMA socket ID in info
> >       rawdev: export dump function in map file
> >       doc: rebuild with meson whenever a file changes
> >       build: always link whole DPDK static libraries
> >       devtools: test static linkage with pkg-config
> >       build/pkg-config: move pkg-config file creation
> >       build/pkg-config: output drivers first for static build
> >       build/pkg-config: improve static linking flags
> >       build/pkg-config: prevent overlinking
> > 
> > Chas Williams (1):
> >       net/netvsc: fix crash during Tx
> > 
> > Chenbo Xia (1):
> >       net/virtio-user: check tap system call setting
> > 
> > Chengchang Tang (5):
> >       net/hns3: clear promiscuous on PF uninit
> >       net/hns3: remove unsupported VLAN capabilities
> >       net/hns3: fix VLAN strip configuration when setting PVID
> >       net/hns3: remove restriction on setting VF MTU
> >       net/hns3: fix adding multicast MAC address
> > 
> > Chenmin Sun (1):
> >       net/i40e: fix flow director Rx writeback packet
> > 
> > Ciara Loftus (1):
> >       net/af_xdp: remove mempool freeing on umem destruction
> > 
> > David Marchand (7):
> >       eal/windows: fix symbol export
> >       eal: remove redundant newline in alert message
> >       net/mlx5: remove redundant newline from logs
> >       net/mvpp2: fix non-EAL thread support
> >       devtools: fix path in forbidden token check
> >       lib: remind experimental status in headers
> >       net/bonding: fix socket ID check
> > 
> > Dekel Peled (2):
> >       net/mlx5: fix VLAN pop with decap action validation
> >       net/mlx5: fix VLAN push action on hairpin queue
> > 
> > Devendra Singh Rawat (1):
> >       net/qede: fix multicast drop in promiscuous mode
> > 
> > Dong Zhou (1):
> >       net/mlx5: fix LRO checksum
> > 
> > Dongyang Pan (1):
> >       net/bonding: delete redundant code
> > 
> > Fady Bader (1):
> >       meter: remove inline functions from export list
> > 
> > Feifei Wang (1):
> >       test/ring: fix statistics in bulk enq/dequeue
> > 
> > Ferruh Yigit (4):
> >       net/iavf: fix uninitialized variable
> >       net/ixgbe/base: remove dead code
> >       ethdev: fix log type for some error messages
> >       drivers/net: fix exposing internal headers
> > 
> > Fiona Trahe (3):
> >       common/qat: remove tail write coalescing
> >       common/qat: move max inflights param into qp
> >       common/qat: support dual threads for enqueue/dequeue
> > 
> > Gaurav Singh (1):
> >       net/i40e: remove duplicate tunnel type check
> > 
> > Georgiy Levashov (1):
> >       examples: add flush after stats printing
> > 
> > Gregory Etelson (1):
> >       net/mlx5: fix tunnel flow priority
> > 
> > Guinan Sun (5):
> >       net/ixgbe/base: fix host interface shadow RAM read
> >       net/ixgbe/base: fix x550em 10G NIC link status
> >       net/ixgbe/base: fix infinite recursion on PCIe link down
> >       net/ixgbe: fix MAC control frame forward
> >       net/ixgbe: fix flow control status
> > 
> > Haiyue Wang (6):
> >       bus/pci: fix VF memory access
> >       eal: fix uuid header dependencies
> >       net/ice: fix TCP checksum offload
> >       net/ice: calculate TCP header size for offload
> >       net/ice: fix Tx hang with TSO
> >       net/ice: revert fake TSO fixes
> > 
> > Hao Chen (1):
> >       net/hns3: optimize default RSS algorithm
> > 
> > Harman Kalra (4):
> >       eal/linux: fix epoll fd list rebuild for interrupts
> >       net/octeontx2: fix DMAC filtering
> >       common/octeontx2: fix crash on running procinfo
> >       eal: fix parentheses in alignment macros
> > 
> > Harry van Haaren (1):
> >       examples/eventdev: fix 32-bit coremask
> > 
> > Heinrich Kuhn (1):
> >       net/nfp: fix RSS hash configuration reporting
> > 
> > Hemant Agrawal (1):
> >       rawdev: remove remaining experimental tags
> > 
> > Hongbo Zheng (4):
> >       net/hns3: ignore function return on reset error path
> >       net/hns3: fix unintended sign extension in dump operation
> >       net/hns3: clear residual hardware configurations on init
> >       net/hns3: get link status change through mailbox
> > 
> > Hongzhi Guo (3):
> >       net: fix IPv4 checksum
> >       net: fix unneeded replacement of TCP checksum 0
> >       net: fix checksum on big endian CPUs
> > 
> > Honnappa Nagarahalli (5):
> >       eal/armv8: fix timer frequency calibration with PMU
> >       app/testpmd: use clock time in throughput calculation
> >       app/testpmd: fix burst percentage calculation
> >       doc: fix some typos in Linux guide
> >       test/hash: move lock-free tests to perf tests
> > 
> > Hrvoje Habjanic (1):
> >       sched: fix subport freeing
> > 
> > Ian Dolzhansky (1):
> >       net/failsafe: fix RSS RETA size info
> > 
> > Igor Romanov (1):
> >       service: fix lcore iteration
> > 
> > Jecky Pei (1):
> >       net/kni: set packet input port in Rx
> > 
> > Jeff Guo (1):
> >       net/e1000: fix crash on Tx done clean up
> > 
> > Junfeng Guo (2):
> >       net/ice/base: fix RSS removal for GTP-U
> >       net/ice/base: fix memory leak on GTPU RSS
> > 
> > Junyu Jiang (2):
> >       net/iavf: fix RSS RETA after restart
> >       net/ice: fix bytes statistics
> > 
> > Kalesh AP (5):
> >       net/bnxt: remove unused enum declaration
> >       net/bnxt: fix unnecessary HWRM command
> >       net/bnxt: fix flow error on filter creation
> >       net/bnxt: fix freeing filters on flow creation failure
> >       net/bnxt: fix logical AND in if condition
> > 
> > Kevin Traynor (1):
> >       vhost: remove zero-copy and client mode restriction
> > 
> > Konstantin Ananyev (2):
> >       test/bpf: fix few small issues
> >       bpf: fix add/sub min/max estimations
> > 
> > Levend Sayar (1):
> >       service: fix C++ linkage
> > 
> > Lijun Ou (5):
> >       net/hns3: add RSS hash offload to Rx configuration
> >       net/hns3: fix key length when configuring RSS
> >       net/hns3: fix RSS configuration on empty RSS type
> >       net/hns3: remove unnecessary branch
> >       app/testpmd: remove hardcoded descriptors limit
> > 
> > Long Li (3):
> >       bus/vmbus: fix ring buffer mapping
> >       net/netvsc: fix underflow when Rx external mbuf
> >       net/netvsc: fix chimney index
> > 
> > Lukasz Wojciechowski (1):
> >       service: fix core mapping reset
> > 
> > Mao Jiang (2):
> >       net/i40e: fix binding interrupt without MSI-X vector
> >       net/i40e: fix flow director MSI-X resource allocation
> > 
> > Matan Azrad (1):
> >       vhost: fix features definition location
> > 
> > Maxime Coquelin (3):
> >       bus/dpaa: fix iterating on a class type
> >       bus/fslmc: fix iterating on a class type
> >       vhost: fix virtio ready flag check
> > 
> > Michael Baum (11):
> >       net/mlx5: remove needless Tx queue initialization check
> >       net/mlx5: fix unreachable MPLS error path
> >       common/mlx5: fix code arrangement in tag allocation
> >       net/mlx5: fix iterator type in Rx queue management
> >       net/mlx5: fix initialization of steering registers
> >       net/mlx5: fix crash in NVGRE item translation
> >       net/mlx5: remove ineffective increment in hairpin split
> >       net/mlx4: optimize stack memory size in probe
> >       net/mlx5: fix unnecessary init in mark conversion
> >       net/mlx5: fix hairpin Tx queue creation error flow
> >       net/mlx5: fix hairpin Rx queue creation error flow
> > 
> > Muhammad Bilal (1):
> >       bus/vdev: fix a typo in doxygen comment
> > 
> > Nipun Gupta (2):
> >       bus/fslmc: fix getting FD error
> >       net/dpaa: fix FD offset data type
> > 
> > Pablo de Lara (1):
> >       drivers/crypto: add missing OOP feature flag
> > 
> > Parav Pandit (1):
> >       common/mlx5: fix void parameters in glue wrappers
> > 
> > Patrick Fu (1):
> >       vhost: fix double-free with zero-copy
> > 
> > Pavan Nikhilesh (2):
> >       event/octeontx2: fix device reconfigure
> >       event/octeontx2: fix sub event type
> > 
> > Pavel Ivashchenko (1):
> >       net/i40e: fix getting EEPROM information
> > 
> > Phil Yang (5):
> >       eventdev: fix race condition on timer list counter
> >       eventdev: use C11 atomics for lcore timer armed flag
> >       eventdev: remove redundant reset on timer cancel
> >       eventdev: relax SMP barriers with C11 atomics
> >       app/testpmd: fix CPU cycles per packet stats on Tx modes
> > 
> > Qi Zhang (7):
> >       net/ice/base: fix return value
> >       net/ice/base: fix memory leak on error path
> >       net/ice/base: fix reference count on VSI list update
> >       net/ice/base: fix initializing resource for field vector
> >       net/ice/base: fix VSI ID mask to 10 bits
> >       net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
> >       net/ice/base: fix RSS interference
> > 
> > Rahul Gupta (1):
> >       net/bnxt: fix performance for Arm
> > 
> > Rahul Lakkireddy (3):
> >       net/cxgbe: fix CLIP leak in filter error path
> >       net/cxgbe: fix double MPS alloc by flow validate and create
> >       net/cxgbe: fix L2T leak in filter error and free path
> > 
> > Raslan Darawsheh (3):
> >       net: fix pedantic build
> >       net/mlx5: fix flow items size calculation
> >       net/mlx5: fix VF MAC address set over BlueField
> > 
> > Ruifeng Wang (8):
> >       net/i40e: enable NEON Rx/Tx in meson
> >       eal/arm: add vcopyq intrinsic for aarch32
> >       net/ixgbe: fix include of vector header file
> >       test: allow no-huge mode for fast-tests
> >       test/cycles: restore default delay callback
> >       crypto/armv8: remove debug option
> >       crypto/armv8: use dedicated log type
> >       net/i40e: support aarch32
> > 
> > Sarosh Arif (3):
> >       doc: fix typo in bbdev test guide
> >       examples/packet_ordering: use proper exit method
> >       doc: fix ethtool app path
> > 
> > Shougang Wang (2):
> >       net/ice: fix error log in generic flow
> >       net/i40e: fix filter pctype
> > 
> > Shy Shyman (3):
> >       app/testpmd: fix error detection in MTU command
> >       net/mlx5: fix flow META item validation
> >       net/mlx5: fix HW counters path in switchdev mode
> > 
> > Stephen Hemminger (8):
> >       net/netvsc: fix warning when VF is removed
> >       net/netvsc: do not query VF link state
> >       net/netvsc: do not spin forever waiting for reply
> >       eal: fix lcore accessors for non-EAL threads
> >       cfgfile: fix stack buffer underflow
> >       rib: add C++ include guard
> >       kni: fix reference to master/slave process
> >       doc: fix reference to master process
> > 
> > Suanming Mou (3):
> >       net/mlx5: fix secondary process resources release
> >       net/mlx5: fix interrupt installation timing
> >       net/mlx5: fix counter query
> > 
> > Tal Shnaiderman (2):
> >       build: fix drivers library path on Windows
> >       pci: fix address domain format size
> > 
> > Thomas Monjalon (1):
> >       doc: update build instructions in the Linux guide
> > 
> > Tianfei Zhang (2):
> >       raw/ifpga/base: fix SPI transaction
> >       raw/ifpga/base: fix NIOS SPI init
> > 
> > Timothy Redaelli (1):
> >       test: fix rpath for drivers with meson
> > 
> > Viacheslav Ovsiienko (3):
> >       net/mlx5: fix UAR lock sharing for multiport devices
> >       common/mlx5: fix queue doorbell record size
> >       net/mlx5: fix metadata storing for NEON Rx
> > 
> > Vladimir Medvedkin (1):
> >       doc: add RIB and FIB into the API index
> > 
> > Wei Hu (Xavier) (12):
> >       net/hns3: fix Tx less than 60 bytes
> >       net/hns3: fix VLAN tags reported in Rx
> >       app/testpmd: fix stats error message
> >       net/hns3: fix flow director error message
> >       net/hns3: fix unintended sign extension in fd operation
> >       net/hns3: fix Rx buffer size
> >       net/hns3: check multi-process action register result
> >       ethdev: fix data room size verification in Rx queue setup
> >       ethdev: fix VLAN offloads set if no relative capabilities
> >       net/bonding: fix error code on device creation
> >       net/bonding: fix MAC address when switching active port
> >       net/bonding: fix MAC address when one port resets
> > 
> > Wei Zhao (4):
> >       net/ice: fix switch action number check
> >       net/ixgbe: report 10Mbps link speed for x553
> >       net/ice: add input set byte number check
> >       net/i40e: enable QinQ stripping
> > 
> > Weifeng Li (1):
> >       net/bonding: change state machine to defaulted
> > 
> > Xiao Wang (1):
> >       net/virtio-user: fix status management
> > 
> > Xiaolong Ye (6):
> >       mbuf: remove unused next member in dynamic flag/field
> >       test/mbuf: fix a dynamic flag log
> >       mbuf: fix boundary check at dynamic field registration
> >       mbuf: fix error code in dynamic field/flag registration
> >       mbuf: fix free space update for dynamic field
> >       mbuf: fix dynamic field dump log
> > 
> > Xiaoyun Wang (5):
> >       net/hinic/base: check output of management sync channel
> >       net/hinic/base: remove unused function parameters
> >       net/hinic: fix setting promiscuous mode
> >       net/hinic: optimize Rx performance for x86
> >       net/hinic/base: avoid system time jump
> > 
> > Yicai Lu (1):
> >       net/bonding: fix LACP negotiation
> > 
> > Yunjian Wang (12):
> >       app/testpmd: fix memory leak on error path
> >       vfio: remove unused variable
> >       net/af_packet: fix check of file descriptors
> >       net/af_packet: fix memory leak on init failure
> >       net/af_packet: fix munmap on init failure
> >       bus/fslmc: fix memory leak in secondary process
> >       hash: fix out-of-memory handling in hash creation
> >       event/dpaa: remove dead code
> >       net/qede: remove dead code
> >       net/hinic: check memory allocations in flow creation
> >       net/ice: fix memory leak when releasing VSI
> >       net/ice: add memory allocation check in RSS init
> > 
> > Zhiguang He (1):
> >       net/bonding: fix dead loop on RSS RETA update
> > 
> > Zhihong Peng (2):
> >       net/i40e: report VLAN filter capability
> >       net/e1000: report VLAN extend capability
> > 
> > Zhike Wang (1):
> >       mempool: fix allocation in memzone during retry
> > 
> > 

Re: [dpdk-dev] 19.11.4 patches review and test

[Chen, BoX C]

Hi Luca,
Update LTS 19.11.4 test result for Intel part. No new issue is found except known issues.  

* Intel(R) Testing

# Basic Intel(R) NIC testing
 * PF(i40e):Passed
    - Exception message when starting testpmd for testing external memory. It has been fixed on 20.05.patch link: http://patches.dpdk.org/patch/66041/
 * PF(ixgbe):Passed
 * PF(ice):Passed
    - The MD5 is not same between kernel ethtool and dpdk ethtool when testing userspace_ethtool/retrieve_eeprom. It has been fixed on 20.08.patch link: http://patches.dpdk.org/patch/72354/
    - With latest ice driver and firmware package exception found when port reset vf of testpmd. It is also found on latest dpdk version, dev is debugging.
 * VF(i40e):Passed
 * VF(ixgbe):Passed
 * VF(ice):Passed
 * Build or compile: Passed
 * Intel NIC single core/NIC performance: Passed
 
#Basic cryptodev and virtio testing
 * vhost/virtio basic loopback, PVP and performance test: Passed. 
    - udp-fragmentation-offload can't be setup on vm Ubuntu1910.it is kernel issue, tracked on: https://bugzilla.kernel.org/show_bug.cgi?id=207075
    - l3fwd-power can wake up lcore but can not sleep again. It is also found on 20.08, dev is debugging.
 * cryptodev Function: Passed. 
    - fips_cryptodev test failed for TDES. It is also found on 20.08, dev is debugging. https://bugs.dpdk.org/show_bug.cgi?id=512
 * cryptodev Performance: Passed. 
    - known unstable issue of test case 1c1t 3CPM. not effect LTS release.

Thanks.
Regards,
Chen Bo

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> Sent: August 19, 2020 2:12
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Pei Zhang
> <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q
> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>;
> Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan
> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: [dpdk-dev] 19.11.4 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 19.11.4.
> 
> The planned date for the final release is August 31st.
> 
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> 
> These patches are located at branch 19.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> Adam Dybkowski (7):
>       test/crypto: fix asymmetric session mempool creation
>       crypto/qat: fix AES-XTS capabilities
>       crypto/qat: handle mixed hash-cipher requests on GEN3
>       test/crypto: add mixed encypted-digest
>       common/qat: get firmware version
>       crypto/qat: handle mixed hash-cipher on GEN2
>       common/qat: fix uninitialized variable
> 
> Akhil Goyal (4):
>       crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
>       crypto/dpaax_sec: fix inline query for descriptors
>       crypto/dpaa2_sec: fix HFN override
>       common/dpaax: fix 12-bit null auth case
> 
> Alan Dewar (1):
>       sched: fix port time rounding
> 
> Alexander Kozyrev (3):
>       net/mlx5: fix vectorized Rx burst termination
>       net/mlx5: do not select legacy MPW implicitly
>       net/mlx5: fix descriptors number adjustment
> 
> Ali Alnubani (2):
>       net/mlx5: fix typos in meter error messages
>       doc: fix a typo in mlx5 guide
> 
> Alvin Zhang (1):
>       net/i40e: fix queue pairs configuration in VF
> 
> Andrew Rybchenko (1):
>       net/sfc: do not enforce hash offload in RSS multi-queue
> 
> Ankur Dwivedi (2):
>       common/cpt: fix encryption offset
>       test/crypto: change cipher offset for ESN vector
> 
> Apeksha Gupta (2):
>       app/eventdev: fix capability check in pipeline ATQ test
>       event/dpaa2: add all-types queue capability flag
> 
> Archana Muniganti (2):
>       examples/fips_validation: fix TDES interim callback
>       examples/fips_validation: fix count overwrite for TDES
> 
> Archit Pandey (1):
>       sched: fix 64-bit rate
> 
> Arek Kusztal (4):
>       drivers/qat: improve multi process on qat
>       drivers/qat: add multi process handling of driver id
>       drivers/qat: add handling of capabilities in multi process
>       crypto/qat: add minimum enq threshold
> 
> Ayuj Verma (1):
>       examples/fips_validation: fix parsing of TDES vectors
> 
> Bruce Richardson (12):
>       test: fix build with ring PMD but no bond PMD
>       mem: fix 32-bit init config with meson
>       rawdev: allow getting info for unknown device
>       rawdev: fill NUMA socket ID in info
>       rawdev: export dump function in map file
>       doc: rebuild with meson whenever a file changes
>       build: always link whole DPDK static libraries
>       devtools: test static linkage with pkg-config
>       build/pkg-config: move pkg-config file creation
>       build/pkg-config: output drivers first for static build
>       build/pkg-config: improve static linking flags
>       build/pkg-config: prevent overlinking
> 
> Chas Williams (1):
>       net/netvsc: fix crash during Tx
> 
> Chenbo Xia (1):
>       net/virtio-user: check tap system call setting
> 
> Chengchang Tang (5):
>       net/hns3: clear promiscuous on PF uninit
>       net/hns3: remove unsupported VLAN capabilities
>       net/hns3: fix VLAN strip configuration when setting PVID
>       net/hns3: remove restriction on setting VF MTU
>       net/hns3: fix adding multicast MAC address
> 
> Chenmin Sun (1):
>       net/i40e: fix flow director Rx writeback packet
> 
> Ciara Loftus (1):
>       net/af_xdp: remove mempool freeing on umem destruction
> 
> David Marchand (7):
>       eal/windows: fix symbol export
>       eal: remove redundant newline in alert message
>       net/mlx5: remove redundant newline from logs
>       net/mvpp2: fix non-EAL thread support
>       devtools: fix path in forbidden token check
>       lib: remind experimental status in headers
>       net/bonding: fix socket ID check
> 
> Dekel Peled (2):
>       net/mlx5: fix VLAN pop with decap action validation
>       net/mlx5: fix VLAN push action on hairpin queue
> 
> Devendra Singh Rawat (1):
>       net/qede: fix multicast drop in promiscuous mode
> 
> Dong Zhou (1):
>       net/mlx5: fix LRO checksum
> 
> Dongyang Pan (1):
>       net/bonding: delete redundant code
> 
> Fady Bader (1):
>       meter: remove inline functions from export list
> 
> Feifei Wang (1):
>       test/ring: fix statistics in bulk enq/dequeue
> 
> Ferruh Yigit (4):
>       net/iavf: fix uninitialized variable
>       net/ixgbe/base: remove dead code
>       ethdev: fix log type for some error messages
>       drivers/net: fix exposing internal headers
> 
> Fiona Trahe (3):
>       common/qat: remove tail write coalescing
>       common/qat: move max inflights param into qp
>       common/qat: support dual threads for enqueue/dequeue
> 
> Gaurav Singh (1):
>       net/i40e: remove duplicate tunnel type check
> 
> Georgiy Levashov (1):
>       examples: add flush after stats printing
> 
> Gregory Etelson (1):
>       net/mlx5: fix tunnel flow priority
> 
> Guinan Sun (5):
>       net/ixgbe/base: fix host interface shadow RAM read
>       net/ixgbe/base: fix x550em 10G NIC link status
>       net/ixgbe/base: fix infinite recursion on PCIe link down
>       net/ixgbe: fix MAC control frame forward
>       net/ixgbe: fix flow control status
> 
> Haiyue Wang (6):
>       bus/pci: fix VF memory access
>       eal: fix uuid header dependencies
>       net/ice: fix TCP checksum offload
>       net/ice: calculate TCP header size for offload
>       net/ice: fix Tx hang with TSO
>       net/ice: revert fake TSO fixes
> 
> Hao Chen (1):
>       net/hns3: optimize default RSS algorithm
> 
> Harman Kalra (4):
>       eal/linux: fix epoll fd list rebuild for interrupts
>       net/octeontx2: fix DMAC filtering
>       common/octeontx2: fix crash on running procinfo
>       eal: fix parentheses in alignment macros
> 
> Harry van Haaren (1):
>       examples/eventdev: fix 32-bit coremask
> 
> Heinrich Kuhn (1):
>       net/nfp: fix RSS hash configuration reporting
> 
> Hemant Agrawal (1):
>       rawdev: remove remaining experimental tags
> 
> Hongbo Zheng (4):
>       net/hns3: ignore function return on reset error path
>       net/hns3: fix unintended sign extension in dump operation
>       net/hns3: clear residual hardware configurations on init
>       net/hns3: get link status change through mailbox
> 
> Hongzhi Guo (3):
>       net: fix IPv4 checksum
>       net: fix unneeded replacement of TCP checksum 0
>       net: fix checksum on big endian CPUs
> 
> Honnappa Nagarahalli (5):
>       eal/armv8: fix timer frequency calibration with PMU
>       app/testpmd: use clock time in throughput calculation
>       app/testpmd: fix burst percentage calculation
>       doc: fix some typos in Linux guide
>       test/hash: move lock-free tests to perf tests
> 
> Hrvoje Habjanic (1):
>       sched: fix subport freeing
> 
> Ian Dolzhansky (1):
>       net/failsafe: fix RSS RETA size info
> 
> Igor Romanov (1):
>       service: fix lcore iteration
> 
> Jecky Pei (1):
>       net/kni: set packet input port in Rx
> 
> Jeff Guo (1):
>       net/e1000: fix crash on Tx done clean up
> 
> Junfeng Guo (2):
>       net/ice/base: fix RSS removal for GTP-U
>       net/ice/base: fix memory leak on GTPU RSS
> 
> Junyu Jiang (2):
>       net/iavf: fix RSS RETA after restart
>       net/ice: fix bytes statistics
> 
> Kalesh AP (5):
>       net/bnxt: remove unused enum declaration
>       net/bnxt: fix unnecessary HWRM command
>       net/bnxt: fix flow error on filter creation
>       net/bnxt: fix freeing filters on flow creation failure
>       net/bnxt: fix logical AND in if condition
> 
> Kevin Traynor (1):
>       vhost: remove zero-copy and client mode restriction
> 
> Konstantin Ananyev (2):
>       test/bpf: fix few small issues
>       bpf: fix add/sub min/max estimations
> 
> Levend Sayar (1):
>       service: fix C++ linkage
> 
> Lijun Ou (5):
>       net/hns3: add RSS hash offload to Rx configuration
>       net/hns3: fix key length when configuring RSS
>       net/hns3: fix RSS configuration on empty RSS type
>       net/hns3: remove unnecessary branch
>       app/testpmd: remove hardcoded descriptors limit
> 
> Long Li (3):
>       bus/vmbus: fix ring buffer mapping
>       net/netvsc: fix underflow when Rx external mbuf
>       net/netvsc: fix chimney index
> 
> Lukasz Wojciechowski (1):
>       service: fix core mapping reset
> 
> Mao Jiang (2):
>       net/i40e: fix binding interrupt without MSI-X vector
>       net/i40e: fix flow director MSI-X resource allocation
> 
> Matan Azrad (1):
>       vhost: fix features definition location
> 
> Maxime Coquelin (3):
>       bus/dpaa: fix iterating on a class type
>       bus/fslmc: fix iterating on a class type
>       vhost: fix virtio ready flag check
> 
> Michael Baum (11):
>       net/mlx5: remove needless Tx queue initialization check
>       net/mlx5: fix unreachable MPLS error path
>       common/mlx5: fix code arrangement in tag allocation
>       net/mlx5: fix iterator type in Rx queue management
>       net/mlx5: fix initialization of steering registers
>       net/mlx5: fix crash in NVGRE item translation
>       net/mlx5: remove ineffective increment in hairpin split
>       net/mlx4: optimize stack memory size in probe
>       net/mlx5: fix unnecessary init in mark conversion
>       net/mlx5: fix hairpin Tx queue creation error flow
>       net/mlx5: fix hairpin Rx queue creation error flow
> 
> Muhammad Bilal (1):
>       bus/vdev: fix a typo in doxygen comment
> 
> Nipun Gupta (2):
>       bus/fslmc: fix getting FD error
>       net/dpaa: fix FD offset data type
> 
> Pablo de Lara (1):
>       drivers/crypto: add missing OOP feature flag
> 
> Parav Pandit (1):
>       common/mlx5: fix void parameters in glue wrappers
> 
> Patrick Fu (1):
>       vhost: fix double-free with zero-copy
> 
> Pavan Nikhilesh (2):
>       event/octeontx2: fix device reconfigure
>       event/octeontx2: fix sub event type
> 
> Pavel Ivashchenko (1):
>       net/i40e: fix getting EEPROM information
> 
> Phil Yang (5):
>       eventdev: fix race condition on timer list counter
>       eventdev: use C11 atomics for lcore timer armed flag
>       eventdev: remove redundant reset on timer cancel
>       eventdev: relax SMP barriers with C11 atomics
>       app/testpmd: fix CPU cycles per packet stats on Tx modes
> 
> Qi Zhang (7):
>       net/ice/base: fix return value
>       net/ice/base: fix memory leak on error path
>       net/ice/base: fix reference count on VSI list update
>       net/ice/base: fix initializing resource for field vector
>       net/ice/base: fix VSI ID mask to 10 bits
>       net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
>       net/ice/base: fix RSS interference
> 
> Rahul Gupta (1):
>       net/bnxt: fix performance for Arm
> 
> Rahul Lakkireddy (3):
>       net/cxgbe: fix CLIP leak in filter error path
>       net/cxgbe: fix double MPS alloc by flow validate and create
>       net/cxgbe: fix L2T leak in filter error and free path
> 
> Raslan Darawsheh (3):
>       net: fix pedantic build
>       net/mlx5: fix flow items size calculation
>       net/mlx5: fix VF MAC address set over BlueField
> 
> Ruifeng Wang (8):
>       net/i40e: enable NEON Rx/Tx in meson
>       eal/arm: add vcopyq intrinsic for aarch32
>       net/ixgbe: fix include of vector header file
>       test: allow no-huge mode for fast-tests
>       test/cycles: restore default delay callback
>       crypto/armv8: remove debug option
>       crypto/armv8: use dedicated log type
>       net/i40e: support aarch32
> 
> Sarosh Arif (3):
>       doc: fix typo in bbdev test guide
>       examples/packet_ordering: use proper exit method
>       doc: fix ethtool app path
> 
> Shougang Wang (2):
>       net/ice: fix error log in generic flow
>       net/i40e: fix filter pctype
> 
> Shy Shyman (3):
>       app/testpmd: fix error detection in MTU command
>       net/mlx5: fix flow META item validation
>       net/mlx5: fix HW counters path in switchdev mode
> 
> Stephen Hemminger (8):
>       net/netvsc: fix warning when VF is removed
>       net/netvsc: do not query VF link state
>       net/netvsc: do not spin forever waiting for reply
>       eal: fix lcore accessors for non-EAL threads
>       cfgfile: fix stack buffer underflow
>       rib: add C++ include guard
>       kni: fix reference to master/slave process
>       doc: fix reference to master process
> 
> Suanming Mou (3):
>       net/mlx5: fix secondary process resources release
>       net/mlx5: fix interrupt installation timing
>       net/mlx5: fix counter query
> 
> Tal Shnaiderman (2):
>       build: fix drivers library path on Windows
>       pci: fix address domain format size
> 
> Thomas Monjalon (1):
>       doc: update build instructions in the Linux guide
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix SPI transaction
>       raw/ifpga/base: fix NIOS SPI init
> 
> Timothy Redaelli (1):
>       test: fix rpath for drivers with meson
> 
> Viacheslav Ovsiienko (3):
>       net/mlx5: fix UAR lock sharing for multiport devices
>       common/mlx5: fix queue doorbell record size
>       net/mlx5: fix metadata storing for NEON Rx
> 
> Vladimir Medvedkin (1):
>       doc: add RIB and FIB into the API index
> 
> Wei Hu (Xavier) (12):
>       net/hns3: fix Tx less than 60 bytes
>       net/hns3: fix VLAN tags reported in Rx
>       app/testpmd: fix stats error message
>       net/hns3: fix flow director error message
>       net/hns3: fix unintended sign extension in fd operation
>       net/hns3: fix Rx buffer size
>       net/hns3: check multi-process action register result
>       ethdev: fix data room size verification in Rx queue setup
>       ethdev: fix VLAN offloads set if no relative capabilities
>       net/bonding: fix error code on device creation
>       net/bonding: fix MAC address when switching active port
>       net/bonding: fix MAC address when one port resets
> 
> Wei Zhao (4):
>       net/ice: fix switch action number check
>       net/ixgbe: report 10Mbps link speed for x553
>       net/ice: add input set byte number check
>       net/i40e: enable QinQ stripping
> 
> Weifeng Li (1):
>       net/bonding: change state machine to defaulted
> 
> Xiao Wang (1):
>       net/virtio-user: fix status management
> 
> Xiaolong Ye (6):
>       mbuf: remove unused next member in dynamic flag/field
>       test/mbuf: fix a dynamic flag log
>       mbuf: fix boundary check at dynamic field registration
>       mbuf: fix error code in dynamic field/flag registration
>       mbuf: fix free space update for dynamic field
>       mbuf: fix dynamic field dump log
> 
> Xiaoyun Wang (5):
>       net/hinic/base: check output of management sync channel
>       net/hinic/base: remove unused function parameters
>       net/hinic: fix setting promiscuous mode
>       net/hinic: optimize Rx performance for x86
>       net/hinic/base: avoid system time jump
> 
> Yicai Lu (1):
>       net/bonding: fix LACP negotiation
> 
> Yunjian Wang (12):
>       app/testpmd: fix memory leak on error path
>       vfio: remove unused variable
>       net/af_packet: fix check of file descriptors
>       net/af_packet: fix memory leak on init failure
>       net/af_packet: fix munmap on init failure
>       bus/fslmc: fix memory leak in secondary process
>       hash: fix out-of-memory handling in hash creation
>       event/dpaa: remove dead code
>       net/qede: remove dead code
>       net/hinic: check memory allocations in flow creation
>       net/ice: fix memory leak when releasing VSI
>       net/ice: add memory allocation check in RSS init
> 
> Zhiguang He (1):
>       net/bonding: fix dead loop on RSS RETA update
> 
> Zhihong Peng (2):
>       net/i40e: report VLAN filter capability
>       net/e1000: report VLAN extend capability
> 
> Zhike Wang (1):
>       mempool: fix allocation in memzone during retry

Re: [dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Wed, 2020-08-26 at 02:30 +0000, Chen, BoX C wrote:
> Hi Luca,
> Update LTS 19.11.4 test result for Intel part. No new issue is found except known issues.  

Thank you!

> * Intel(R) Testing
> 
> # Basic Intel(R) NIC testing
>  * PF(i40e):Passed
>     - Exception message when starting testpmd for testing external memory. It has been fixed on 20.05.patch link: http://patches.dpdk.org/patch/66041/

Anatoly, is it safe to backport this patch to 19.11? It applies and
builds cleanly when cherry-picked:

d1c7c0cdf7ba ("vfio: map contiguous areas in one go")

>  * PF(ixgbe):Passed
>  * PF(ice):Passed
>     - The MD5 is not same between kernel ethtool and dpdk ethtool when testing userspace_ethtool/retrieve_eeprom. It has been fixed on 20.08.patch link: http://patches.dpdk.org/patch/72354/

Shougang and Qi, this patch applies when backported but build fails, as
some internal structures are different. Do you consider this issue a
blocking one for the release and want to do the work to backport the
fixes to 19.11?

01186263c2c7 ("net/ice: fix EEPROM data")

../drivers/net/ice/ice_ethdev.c: In function ‘ice_get_eeprom_length’:
../drivers/net/ice/ice_ethdev.c:3979:16: error: ‘struct ice_nvm_info’
has no member named ‘flash_size’
  return hw->nvm.flash_size;

>     - With latest ice driver and firmware package exception found when port reset vf of testpmd. It is also found on latest dpdk version, dev is debugging.
>  * VF(i40e):Passed
>  * VF(ixgbe):Passed
>  * VF(ice):Passed
>  * Build or compile: Passed
>  * Intel NIC single core/NIC performance: Passed
>  
> #Basic cryptodev and virtio testing
>  * vhost/virtio basic loopback, PVP and performance test: Passed. 
>     - udp-fragmentation-offload can't be setup on vm Ubuntu1910.it is kernel issue, tracked on: https://bugzilla.kernel.org/show_bug.cgi?id=207075
>     - l3fwd-power can wake up lcore but can not sleep again. It is also found on 20.08, dev is debugging.
>  * cryptodev Function: Passed. 
>     - fips_cryptodev test failed for TDES. It is also found on 20.08, dev is debugging. https://bugs.dpdk.org/show_bug.cgi?id=512
>  * cryptodev Performance: Passed. 
>     - known unstable issue of test case 1c1t 3CPM. not effect LTS release.
> 
> Thanks.
> Regards,
> Chen Bo
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> > Sent: August 19, 2020 2:12
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> > Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> > Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> > <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Pei Zhang
> > <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q
> > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>;
> > Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan
> > <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Subject: [dpdk-dev] 19.11.4 patches review and test
> > 
> > Hi all,
> > 
> > Here is a list of patches targeted for stable release 19.11.4.
> > 
> > The planned date for the final release is August 31st.
> > 
> > Please help with testing and validation of your use cases and report any
> > issues/results with reply-all to this mail. For the final release the fixes and
> > reported validations will be added to the release notes.
> > 
> > A release candidate tarball can be found at:
> > 
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > 
> > These patches are located at branch 19.11 of dpdk-stable repo:
> >     https://dpdk.org/browse/dpdk-stable/
> > 
> > Thanks.
> > 
> > Luca Boccassi
> > 
> > ---
> > Adam Dybkowski (7):
> >       test/crypto: fix asymmetric session mempool creation
> >       crypto/qat: fix AES-XTS capabilities
> >       crypto/qat: handle mixed hash-cipher requests on GEN3
> >       test/crypto: add mixed encypted-digest
> >       common/qat: get firmware version
> >       crypto/qat: handle mixed hash-cipher on GEN2
> >       common/qat: fix uninitialized variable
> > 
> > Akhil Goyal (4):
> >       crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
> >       crypto/dpaax_sec: fix inline query for descriptors
> >       crypto/dpaa2_sec: fix HFN override
> >       common/dpaax: fix 12-bit null auth case
> > 
> > Alan Dewar (1):
> >       sched: fix port time rounding
> > 
> > Alexander Kozyrev (3):
> >       net/mlx5: fix vectorized Rx burst termination
> >       net/mlx5: do not select legacy MPW implicitly
> >       net/mlx5: fix descriptors number adjustment
> > 
> > Ali Alnubani (2):
> >       net/mlx5: fix typos in meter error messages
> >       doc: fix a typo in mlx5 guide
> > 
> > Alvin Zhang (1):
> >       net/i40e: fix queue pairs configuration in VF
> > 
> > Andrew Rybchenko (1):
> >       net/sfc: do not enforce hash offload in RSS multi-queue
> > 
> > Ankur Dwivedi (2):
> >       common/cpt: fix encryption offset
> >       test/crypto: change cipher offset for ESN vector
> > 
> > Apeksha Gupta (2):
> >       app/eventdev: fix capability check in pipeline ATQ test
> >       event/dpaa2: add all-types queue capability flag
> > 
> > Archana Muniganti (2):
> >       examples/fips_validation: fix TDES interim callback
> >       examples/fips_validation: fix count overwrite for TDES
> > 
> > Archit Pandey (1):
> >       sched: fix 64-bit rate
> > 
> > Arek Kusztal (4):
> >       drivers/qat: improve multi process on qat
> >       drivers/qat: add multi process handling of driver id
> >       drivers/qat: add handling of capabilities in multi process
> >       crypto/qat: add minimum enq threshold
> > 
> > Ayuj Verma (1):
> >       examples/fips_validation: fix parsing of TDES vectors
> > 
> > Bruce Richardson (12):
> >       test: fix build with ring PMD but no bond PMD
> >       mem: fix 32-bit init config with meson
> >       rawdev: allow getting info for unknown device
> >       rawdev: fill NUMA socket ID in info
> >       rawdev: export dump function in map file
> >       doc: rebuild with meson whenever a file changes
> >       build: always link whole DPDK static libraries
> >       devtools: test static linkage with pkg-config
> >       build/pkg-config: move pkg-config file creation
> >       build/pkg-config: output drivers first for static build
> >       build/pkg-config: improve static linking flags
> >       build/pkg-config: prevent overlinking
> > 
> > Chas Williams (1):
> >       net/netvsc: fix crash during Tx
> > 
> > Chenbo Xia (1):
> >       net/virtio-user: check tap system call setting
> > 
> > Chengchang Tang (5):
> >       net/hns3: clear promiscuous on PF uninit
> >       net/hns3: remove unsupported VLAN capabilities
> >       net/hns3: fix VLAN strip configuration when setting PVID
> >       net/hns3: remove restriction on setting VF MTU
> >       net/hns3: fix adding multicast MAC address
> > 
> > Chenmin Sun (1):
> >       net/i40e: fix flow director Rx writeback packet
> > 
> > Ciara Loftus (1):
> >       net/af_xdp: remove mempool freeing on umem destruction
> > 
> > David Marchand (7):
> >       eal/windows: fix symbol export
> >       eal: remove redundant newline in alert message
> >       net/mlx5: remove redundant newline from logs
> >       net/mvpp2: fix non-EAL thread support
> >       devtools: fix path in forbidden token check
> >       lib: remind experimental status in headers
> >       net/bonding: fix socket ID check
> > 
> > Dekel Peled (2):
> >       net/mlx5: fix VLAN pop with decap action validation
> >       net/mlx5: fix VLAN push action on hairpin queue
> > 
> > Devendra Singh Rawat (1):
> >       net/qede: fix multicast drop in promiscuous mode
> > 
> > Dong Zhou (1):
> >       net/mlx5: fix LRO checksum
> > 
> > Dongyang Pan (1):
> >       net/bonding: delete redundant code
> > 
> > Fady Bader (1):
> >       meter: remove inline functions from export list
> > 
> > Feifei Wang (1):
> >       test/ring: fix statistics in bulk enq/dequeue
> > 
> > Ferruh Yigit (4):
> >       net/iavf: fix uninitialized variable
> >       net/ixgbe/base: remove dead code
> >       ethdev: fix log type for some error messages
> >       drivers/net: fix exposing internal headers
> > 
> > Fiona Trahe (3):
> >       common/qat: remove tail write coalescing
> >       common/qat: move max inflights param into qp
> >       common/qat: support dual threads for enqueue/dequeue
> > 
> > Gaurav Singh (1):
> >       net/i40e: remove duplicate tunnel type check
> > 
> > Georgiy Levashov (1):
> >       examples: add flush after stats printing
> > 
> > Gregory Etelson (1):
> >       net/mlx5: fix tunnel flow priority
> > 
> > Guinan Sun (5):
> >       net/ixgbe/base: fix host interface shadow RAM read
> >       net/ixgbe/base: fix x550em 10G NIC link status
> >       net/ixgbe/base: fix infinite recursion on PCIe link down
> >       net/ixgbe: fix MAC control frame forward
> >       net/ixgbe: fix flow control status
> > 
> > Haiyue Wang (6):
> >       bus/pci: fix VF memory access
> >       eal: fix uuid header dependencies
> >       net/ice: fix TCP checksum offload
> >       net/ice: calculate TCP header size for offload
> >       net/ice: fix Tx hang with TSO
> >       net/ice: revert fake TSO fixes
> > 
> > Hao Chen (1):
> >       net/hns3: optimize default RSS algorithm
> > 
> > Harman Kalra (4):
> >       eal/linux: fix epoll fd list rebuild for interrupts
> >       net/octeontx2: fix DMAC filtering
> >       common/octeontx2: fix crash on running procinfo
> >       eal: fix parentheses in alignment macros
> > 
> > Harry van Haaren (1):
> >       examples/eventdev: fix 32-bit coremask
> > 
> > Heinrich Kuhn (1):
> >       net/nfp: fix RSS hash configuration reporting
> > 
> > Hemant Agrawal (1):
> >       rawdev: remove remaining experimental tags
> > 
> > Hongbo Zheng (4):
> >       net/hns3: ignore function return on reset error path
> >       net/hns3: fix unintended sign extension in dump operation
> >       net/hns3: clear residual hardware configurations on init
> >       net/hns3: get link status change through mailbox
> > 
> > Hongzhi Guo (3):
> >       net: fix IPv4 checksum
> >       net: fix unneeded replacement of TCP checksum 0
> >       net: fix checksum on big endian CPUs
> > 
> > Honnappa Nagarahalli (5):
> >       eal/armv8: fix timer frequency calibration with PMU
> >       app/testpmd: use clock time in throughput calculation
> >       app/testpmd: fix burst percentage calculation
> >       doc: fix some typos in Linux guide
> >       test/hash: move lock-free tests to perf tests
> > 
> > Hrvoje Habjanic (1):
> >       sched: fix subport freeing
> > 
> > Ian Dolzhansky (1):
> >       net/failsafe: fix RSS RETA size info
> > 
> > Igor Romanov (1):
> >       service: fix lcore iteration
> > 
> > Jecky Pei (1):
> >       net/kni: set packet input port in Rx
> > 
> > Jeff Guo (1):
> >       net/e1000: fix crash on Tx done clean up
> > 
> > Junfeng Guo (2):
> >       net/ice/base: fix RSS removal for GTP-U
> >       net/ice/base: fix memory leak on GTPU RSS
> > 
> > Junyu Jiang (2):
> >       net/iavf: fix RSS RETA after restart
> >       net/ice: fix bytes statistics
> > 
> > Kalesh AP (5):
> >       net/bnxt: remove unused enum declaration
> >       net/bnxt: fix unnecessary HWRM command
> >       net/bnxt: fix flow error on filter creation
> >       net/bnxt: fix freeing filters on flow creation failure
> >       net/bnxt: fix logical AND in if condition
> > 
> > Kevin Traynor (1):
> >       vhost: remove zero-copy and client mode restriction
> > 
> > Konstantin Ananyev (2):
> >       test/bpf: fix few small issues
> >       bpf: fix add/sub min/max estimations
> > 
> > Levend Sayar (1):
> >       service: fix C++ linkage
> > 
> > Lijun Ou (5):
> >       net/hns3: add RSS hash offload to Rx configuration
> >       net/hns3: fix key length when configuring RSS
> >       net/hns3: fix RSS configuration on empty RSS type
> >       net/hns3: remove unnecessary branch
> >       app/testpmd: remove hardcoded descriptors limit
> > 
> > Long Li (3):
> >       bus/vmbus: fix ring buffer mapping
> >       net/netvsc: fix underflow when Rx external mbuf
> >       net/netvsc: fix chimney index
> > 
> > Lukasz Wojciechowski (1):
> >       service: fix core mapping reset
> > 
> > Mao Jiang (2):
> >       net/i40e: fix binding interrupt without MSI-X vector
> >       net/i40e: fix flow director MSI-X resource allocation
> > 
> > Matan Azrad (1):
> >       vhost: fix features definition location
> > 
> > Maxime Coquelin (3):
> >       bus/dpaa: fix iterating on a class type
> >       bus/fslmc: fix iterating on a class type
> >       vhost: fix virtio ready flag check
> > 
> > Michael Baum (11):
> >       net/mlx5: remove needless Tx queue initialization check
> >       net/mlx5: fix unreachable MPLS error path
> >       common/mlx5: fix code arrangement in tag allocation
> >       net/mlx5: fix iterator type in Rx queue management
> >       net/mlx5: fix initialization of steering registers
> >       net/mlx5: fix crash in NVGRE item translation
> >       net/mlx5: remove ineffective increment in hairpin split
> >       net/mlx4: optimize stack memory size in probe
> >       net/mlx5: fix unnecessary init in mark conversion
> >       net/mlx5: fix hairpin Tx queue creation error flow
> >       net/mlx5: fix hairpin Rx queue creation error flow
> > 
> > Muhammad Bilal (1):
> >       bus/vdev: fix a typo in doxygen comment
> > 
> > Nipun Gupta (2):
> >       bus/fslmc: fix getting FD error
> >       net/dpaa: fix FD offset data type
> > 
> > Pablo de Lara (1):
> >       drivers/crypto: add missing OOP feature flag
> > 
> > Parav Pandit (1):
> >       common/mlx5: fix void parameters in glue wrappers
> > 
> > Patrick Fu (1):
> >       vhost: fix double-free with zero-copy
> > 
> > Pavan Nikhilesh (2):
> >       event/octeontx2: fix device reconfigure
> >       event/octeontx2: fix sub event type
> > 
> > Pavel Ivashchenko (1):
> >       net/i40e: fix getting EEPROM information
> > 
> > Phil Yang (5):
> >       eventdev: fix race condition on timer list counter
> >       eventdev: use C11 atomics for lcore timer armed flag
> >       eventdev: remove redundant reset on timer cancel
> >       eventdev: relax SMP barriers with C11 atomics
> >       app/testpmd: fix CPU cycles per packet stats on Tx modes
> > 
> > Qi Zhang (7):
> >       net/ice/base: fix return value
> >       net/ice/base: fix memory leak on error path
> >       net/ice/base: fix reference count on VSI list update
> >       net/ice/base: fix initializing resource for field vector
> >       net/ice/base: fix VSI ID mask to 10 bits
> >       net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
> >       net/ice/base: fix RSS interference
> > 
> > Rahul Gupta (1):
> >       net/bnxt: fix performance for Arm
> > 
> > Rahul Lakkireddy (3):
> >       net/cxgbe: fix CLIP leak in filter error path
> >       net/cxgbe: fix double MPS alloc by flow validate and create
> >       net/cxgbe: fix L2T leak in filter error and free path
> > 
> > Raslan Darawsheh (3):
> >       net: fix pedantic build
> >       net/mlx5: fix flow items size calculation
> >       net/mlx5: fix VF MAC address set over BlueField
> > 
> > Ruifeng Wang (8):
> >       net/i40e: enable NEON Rx/Tx in meson
> >       eal/arm: add vcopyq intrinsic for aarch32
> >       net/ixgbe: fix include of vector header file
> >       test: allow no-huge mode for fast-tests
> >       test/cycles: restore default delay callback
> >       crypto/armv8: remove debug option
> >       crypto/armv8: use dedicated log type
> >       net/i40e: support aarch32
> > 
> > Sarosh Arif (3):
> >       doc: fix typo in bbdev test guide
> >       examples/packet_ordering: use proper exit method
> >       doc: fix ethtool app path
> > 
> > Shougang Wang (2):
> >       net/ice: fix error log in generic flow
> >       net/i40e: fix filter pctype
> > 
> > Shy Shyman (3):
> >       app/testpmd: fix error detection in MTU command
> >       net/mlx5: fix flow META item validation
> >       net/mlx5: fix HW counters path in switchdev mode
> > 
> > Stephen Hemminger (8):
> >       net/netvsc: fix warning when VF is removed
> >       net/netvsc: do not query VF link state
> >       net/netvsc: do not spin forever waiting for reply
> >       eal: fix lcore accessors for non-EAL threads
> >       cfgfile: fix stack buffer underflow
> >       rib: add C++ include guard
> >       kni: fix reference to master/slave process
> >       doc: fix reference to master process
> > 
> > Suanming Mou (3):
> >       net/mlx5: fix secondary process resources release
> >       net/mlx5: fix interrupt installation timing
> >       net/mlx5: fix counter query
> > 
> > Tal Shnaiderman (2):
> >       build: fix drivers library path on Windows
> >       pci: fix address domain format size
> > 
> > Thomas Monjalon (1):
> >       doc: update build instructions in the Linux guide
> > 
> > Tianfei Zhang (2):
> >       raw/ifpga/base: fix SPI transaction
> >       raw/ifpga/base: fix NIOS SPI init
> > 
> > Timothy Redaelli (1):
> >       test: fix rpath for drivers with meson
> > 
> > Viacheslav Ovsiienko (3):
> >       net/mlx5: fix UAR lock sharing for multiport devices
> >       common/mlx5: fix queue doorbell record size
> >       net/mlx5: fix metadata storing for NEON Rx
> > 
> > Vladimir Medvedkin (1):
> >       doc: add RIB and FIB into the API index
> > 
> > Wei Hu (Xavier) (12):
> >       net/hns3: fix Tx less than 60 bytes
> >       net/hns3: fix VLAN tags reported in Rx
> >       app/testpmd: fix stats error message
> >       net/hns3: fix flow director error message
> >       net/hns3: fix unintended sign extension in fd operation
> >       net/hns3: fix Rx buffer size
> >       net/hns3: check multi-process action register result
> >       ethdev: fix data room size verification in Rx queue setup
> >       ethdev: fix VLAN offloads set if no relative capabilities
> >       net/bonding: fix error code on device creation
> >       net/bonding: fix MAC address when switching active port
> >       net/bonding: fix MAC address when one port resets
> > 
> > Wei Zhao (4):
> >       net/ice: fix switch action number check
> >       net/ixgbe: report 10Mbps link speed for x553
> >       net/ice: add input set byte number check
> >       net/i40e: enable QinQ stripping
> > 
> > Weifeng Li (1):
> >       net/bonding: change state machine to defaulted
> > 
> > Xiao Wang (1):
> >       net/virtio-user: fix status management
> > 
> > Xiaolong Ye (6):
> >       mbuf: remove unused next member in dynamic flag/field
> >       test/mbuf: fix a dynamic flag log
> >       mbuf: fix boundary check at dynamic field registration
> >       mbuf: fix error code in dynamic field/flag registration
> >       mbuf: fix free space update for dynamic field
> >       mbuf: fix dynamic field dump log
> > 
> > Xiaoyun Wang (5):
> >       net/hinic/base: check output of management sync channel
> >       net/hinic/base: remove unused function parameters
> >       net/hinic: fix setting promiscuous mode
> >       net/hinic: optimize Rx performance for x86
> >       net/hinic/base: avoid system time jump
> > 
> > Yicai Lu (1):
> >       net/bonding: fix LACP negotiation
> > 
> > Yunjian Wang (12):
> >       app/testpmd: fix memory leak on error path
> >       vfio: remove unused variable
> >       net/af_packet: fix check of file descriptors
> >       net/af_packet: fix memory leak on init failure
> >       net/af_packet: fix munmap on init failure
> >       bus/fslmc: fix memory leak in secondary process
> >       hash: fix out-of-memory handling in hash creation
> >       event/dpaa: remove dead code
> >       net/qede: remove dead code
> >       net/hinic: check memory allocations in flow creation
> >       net/ice: fix memory leak when releasing VSI
> >       net/ice: add memory allocation check in RSS init
> > 
> > Zhiguang He (1):
> >       net/bonding: fix dead loop on RSS RETA update
> > 
> > Zhihong Peng (2):
> >       net/i40e: report VLAN filter capability
> >       net/e1000: report VLAN extend capability
> > 
> > Zhike Wang (1):
> >       mempool: fix allocation in memzone during retry

Re: [dpdk-dev] 19.11.4 patches review and test

[Burakov, Anatoly]

On 26-Aug-20 10:50 AM, Luca Boccassi wrote:
> On Wed, 2020-08-26 at 02:30 +0000, Chen, BoX C wrote:
>> Hi Luca,
>> Update LTS 19.11.4 test result for Intel part. No new issue is found except known issues.
> 
> Thank you!
> 
>> * Intel(R) Testing
>>
>> # Basic Intel(R) NIC testing
>>   * PF(i40e):Passed
>>      - Exception message when starting testpmd for testing external memory. It has been fixed on 20.05.patch link: http://patches.dpdk.org/patch/66041/
> 
> Anatoly, is it safe to backport this patch to 19.11? It applies and
> builds cleanly when cherry-picked:
> 
> d1c7c0cdf7ba ("vfio: map contiguous areas in one go")

Hi Luca,

Yes, it should be safe - at least i'm not aware of any breakages ever 
being reported so far. Thanks!

-- 
Thanks,
Anatoly

Re: [dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Thu, 2020-08-27 at 10:47 +0100, Burakov, Anatoly wrote:
> On 26-Aug-20 10:50 AM, Luca Boccassi wrote:
> > On Wed, 2020-08-26 at 02:30 +0000, Chen, BoX C wrote:
> > > Hi Luca,
> > > Update LTS 19.11.4 test result for Intel part. No new issue is found except known issues.
> > 
> > Thank you!
> > 
> > > * Intel(R) Testing
> > > 
> > > # Basic Intel(R) NIC testing
> > >   * PF(i40e):Passed
> > >      - Exception message when starting testpmd for testing external memory. It has been fixed on 20.05.patch link: http://patches.dpdk.org/patch/66041/
> > 
> > Anatoly, is it safe to backport this patch to 19.11? It applies and
> > builds cleanly when cherry-picked:
> > 
> > d1c7c0cdf7ba ("vfio: map contiguous areas in one go")
> 
> Hi Luca,
> 
> Yes, it should be safe - at least i'm not aware of any breakages ever 
> being reported so far. Thanks!

Could you please double-check that there's no other patch/change that
depends on it/that it depends on and is missing from 19.11.4-rc1? Given
we wouldn't redo the full regression run, we need to be careful

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] 19.11.4 patches review and test

[Burakov, Anatoly]

On 27-Aug-20 11:37 AM, Luca Boccassi wrote:
> On Thu, 2020-08-27 at 10:47 +0100, Burakov, Anatoly wrote:
>> On 26-Aug-20 10:50 AM, Luca Boccassi wrote:
>>> On Wed, 2020-08-26 at 02:30 +0000, Chen, BoX C wrote:
>>>> Hi Luca,
>>>> Update LTS 19.11.4 test result for Intel part. No new issue is found except known issues.
>>>
>>> Thank you!
>>>
>>>> * Intel(R) Testing
>>>>
>>>> # Basic Intel(R) NIC testing
>>>>    * PF(i40e):Passed
>>>>       - Exception message when starting testpmd for testing external memory. It has been fixed on 20.05.patch link: http://patches.dpdk.org/patch/66041/
>>>
>>> Anatoly, is it safe to backport this patch to 19.11? It applies and
>>> builds cleanly when cherry-picked:
>>>
>>> d1c7c0cdf7ba ("vfio: map contiguous areas in one go")
>>
>> Hi Luca,
>>
>> Yes, it should be safe - at least i'm not aware of any breakages ever
>> being reported so far. Thanks!
> 
> Could you please double-check that there's no other patch/change that
> depends on it/that it depends on and is missing from 19.11.4-rc1? Given
> we wouldn't redo the full regression run, we need to be careful
> 

I'm positive that it's self-contained. It's just a different way of 
iterating through an array :)

-- 
Thanks,
Anatoly

Re: [dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Thu, 2020-08-27 at 11:57 +0100, Burakov, Anatoly wrote:
> On 27-Aug-20 11:37 AM, Luca Boccassi wrote:
> > On Thu, 2020-08-27 at 10:47 +0100, Burakov, Anatoly wrote:
> > > On 26-Aug-20 10:50 AM, Luca Boccassi wrote:
> > > > On Wed, 2020-08-26 at 02:30 +0000, Chen, BoX C wrote:
> > > > > Hi Luca,
> > > > > Update LTS 19.11.4 test result for Intel part. No new issue is found except known issues.
> > > > 
> > > > Thank you!
> > > > 
> > > > > * Intel(R) Testing
> > > > > 
> > > > > # Basic Intel(R) NIC testing
> > > > >    * PF(i40e):Passed
> > > > >       - Exception message when starting testpmd for testing external memory. It has been fixed on 20.05.patch link: http://patches.dpdk.org/patch/66041/
> > > > 
> > > > Anatoly, is it safe to backport this patch to 19.11? It applies and
> > > > builds cleanly when cherry-picked:
> > > > 
> > > > d1c7c0cdf7ba ("vfio: map contiguous areas in one go")
> > > 
> > > Hi Luca,
> > > 
> > > Yes, it should be safe - at least i'm not aware of any breakages ever
> > > being reported so far. Thanks!
> > 
> > Could you please double-check that there's no other patch/change that
> > depends on it/that it depends on and is missing from 19.11.4-rc1? Given
> > we wouldn't redo the full regression run, we need to be careful
> > 
> 
> I'm positive that it's self-contained. It's just a different way of 
> iterating through an array :)

Thanks, applied and pushed.

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] 19.11.4 patches review and test

[Wang, ShougangX]

Hi, Luca and Bo

> >     - The MD5 is not same between kernel ethtool and dpdk ethtool when
> > testing userspace_ethtool/retrieve_eeprom. It has been fixed on
> > 20.08.patch link: http://patches.dpdk.org/patch/72354/
> 
> Shougang and Qi, this patch applies when backported but build fails, as some
> internal structures are different. Do you consider this issue a blocking one for
> the release and want to do the work to backport the fixes to 19.11?
> 

This patch can't be applied because the solution depends on updating ice shared code.
I'm not sure the workload and impact of updating shared code. It is a small bug and it is 
not a DPDK main feature. So I think it is not a block issue for release and I don't suggest 
to fix it in 19.11. How do you think of it? 

> 01186263c2c7 ("net/ice: fix EEPROM data")
> 
> ../drivers/net/ice/ice_ethdev.c: In function ‘ice_get_eeprom_length’:
> ../drivers/net/ice/ice_ethdev.c:3979:16: error: ‘struct ice_nvm_info’
> has no member named ‘flash_size’
>   return hw->nvm.flash_size;

Thanks.
Shougang

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Wednesday, August 26, 2020 5:50 PM
> To: Wang, ShougangX <shougangx.wang@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Chen, BoX C <box.c.chen@intel.com>
> Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> 
> On Wed, 2020-08-26 at 02:30 +0000, Chen, BoX C wrote:
> > Hi Luca,
> > Update LTS 19.11.4 test result for Intel part. No new issue is found except
> known issues.
> 
> Thank you!
> 
> > * Intel(R) Testing
> >
> > # Basic Intel(R) NIC testing
> >  * PF(i40e):Passed
> >     - Exception message when starting testpmd for testing external
> > memory. It has been fixed on 20.05.patch link:
> > http://patches.dpdk.org/patch/66041/
> 
> Anatoly, is it safe to backport this patch to 19.11? It applies and builds cleanly
> when cherry-picked:
> 
> d1c7c0cdf7ba ("vfio: map contiguous areas in one go")
> 
> >  * PF(ixgbe):Passed
> >  * PF(ice):Passed
> >     - The MD5 is not same between kernel ethtool and dpdk ethtool when
> > testing userspace_ethtool/retrieve_eeprom. It has been fixed on
> > 20.08.patch link: http://patches.dpdk.org/patch/72354/
> 
> Shougang and Qi, this patch applies when backported but build fails, as some
> internal structures are different. Do you consider this issue a blocking one for
> the release and want to do the work to backport the fixes to 19.11?
> 
> 01186263c2c7 ("net/ice: fix EEPROM data")
> 
> ../drivers/net/ice/ice_ethdev.c: In function ‘ice_get_eeprom_length’:
> ../drivers/net/ice/ice_ethdev.c:3979:16: error: ‘struct ice_nvm_info’
> has no member named ‘flash_size’
>   return hw->nvm.flash_size;
> 
> >     - With latest ice driver and firmware package exception found when port
> reset vf of testpmd. It is also found on latest dpdk version, dev is debugging.
> >  * VF(i40e):Passed
> >  * VF(ixgbe):Passed
> >  * VF(ice):Passed
> >  * Build or compile: Passed
> >  * Intel NIC single core/NIC performance: Passed
> >
> > #Basic cryptodev and virtio testing
> >  * vhost/virtio basic loopback, PVP and performance test: Passed.
> >     - udp-fragmentation-offload can't be setup on vm Ubuntu1910.it is
> kernel issue, tracked on: https://bugzilla.kernel.org/show_bug.cgi?id=207075
> >     - l3fwd-power can wake up lcore but can not sleep again. It is also found
> on 20.08, dev is debugging.
> >  * cryptodev Function: Passed.
> >     - fips_cryptodev test failed for TDES. It is also found on 20.08,
> > dev is debugging. https://bugs.dpdk.org/show_bug.cgi?id=512
> >  * cryptodev Performance: Passed.
> >     - known unstable issue of test case 1c1t 3CPM. not effect LTS release.
> >
> > Thanks.
> > Regards,
> > Chen Bo
> >
> > > -----Original Message-----
> > > From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> > > Sent: August 19, 2020 2:12
> > > To: stable@dpdk.org
> > > Cc: dev@dpdk.org; Abhishek Marathe
> <Abhishek.Marathe@microsoft.com>;
> > > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani
> > > <alialnu@mellanox.com>; Walker, Benjamin
> > > <benjamin.walker@intel.com>; David Christensen
> > > <drc@linux.vnet.ibm.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>;
> > > Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
> > > <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> > > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > > <ktraynor@redhat.com>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
> > > <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan
> > > Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> > > <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen,
> > > Zhaoyan <zhaoyan.chen@intel.com>
> > > Subject: [dpdk-dev] 19.11.4 patches review and test
> > >
> > > Hi all,
> > >
> > > Here is a list of patches targeted for stable release 19.11.4.
> > >
> > > The planned date for the final release is August 31st.
> > >
> > > Please help with testing and validation of your use cases and report
> > > any issues/results with reply-all to this mail. For the final
> > > release the fixes and reported validations will be added to the release
> notes.
> > >
> > > A release candidate tarball can be found at:
> > >
> > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > >
> > > These patches are located at branch 19.11 of dpdk-stable repo:
> > >     https://dpdk.org/browse/dpdk-stable/
> > >
> > > Thanks.
> > >
> > > Luca Boccassi
> > >
> > > ---
> > > Adam Dybkowski (7):
> > >       test/crypto: fix asymmetric session mempool creation
> > >       crypto/qat: fix AES-XTS capabilities
> > >       crypto/qat: handle mixed hash-cipher requests on GEN3
> > >       test/crypto: add mixed encypted-digest
> > >       common/qat: get firmware version
> > >       crypto/qat: handle mixed hash-cipher on GEN2
> > >       common/qat: fix uninitialized variable
> > >
> > > Akhil Goyal (4):
> > >       crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
> > >       crypto/dpaax_sec: fix inline query for descriptors
> > >       crypto/dpaa2_sec: fix HFN override
> > >       common/dpaax: fix 12-bit null auth case
> > >
> > > Alan Dewar (1):
> > >       sched: fix port time rounding
> > >
> > > Alexander Kozyrev (3):
> > >       net/mlx5: fix vectorized Rx burst termination
> > >       net/mlx5: do not select legacy MPW implicitly
> > >       net/mlx5: fix descriptors number adjustment
> > >
> > > Ali Alnubani (2):
> > >       net/mlx5: fix typos in meter error messages
> > >       doc: fix a typo in mlx5 guide
> > >
> > > Alvin Zhang (1):
> > >       net/i40e: fix queue pairs configuration in VF
> > >
> > > Andrew Rybchenko (1):
> > >       net/sfc: do not enforce hash offload in RSS multi-queue
> > >
> > > Ankur Dwivedi (2):
> > >       common/cpt: fix encryption offset
> > >       test/crypto: change cipher offset for ESN vector
> > >
> > > Apeksha Gupta (2):
> > >       app/eventdev: fix capability check in pipeline ATQ test
> > >       event/dpaa2: add all-types queue capability flag
> > >
> > > Archana Muniganti (2):
> > >       examples/fips_validation: fix TDES interim callback
> > >       examples/fips_validation: fix count overwrite for TDES
> > >
> > > Archit Pandey (1):
> > >       sched: fix 64-bit rate
> > >
> > > Arek Kusztal (4):
> > >       drivers/qat: improve multi process on qat
> > >       drivers/qat: add multi process handling of driver id
> > >       drivers/qat: add handling of capabilities in multi process
> > >       crypto/qat: add minimum enq threshold
> > >
> > > Ayuj Verma (1):
> > >       examples/fips_validation: fix parsing of TDES vectors
> > >
> > > Bruce Richardson (12):
> > >       test: fix build with ring PMD but no bond PMD
> > >       mem: fix 32-bit init config with meson
> > >       rawdev: allow getting info for unknown device
> > >       rawdev: fill NUMA socket ID in info
> > >       rawdev: export dump function in map file
> > >       doc: rebuild with meson whenever a file changes
> > >       build: always link whole DPDK static libraries
> > >       devtools: test static linkage with pkg-config
> > >       build/pkg-config: move pkg-config file creation
> > >       build/pkg-config: output drivers first for static build
> > >       build/pkg-config: improve static linking flags
> > >       build/pkg-config: prevent overlinking
> > >
> > > Chas Williams (1):
> > >       net/netvsc: fix crash during Tx
> > >
> > > Chenbo Xia (1):
> > >       net/virtio-user: check tap system call setting
> > >
> > > Chengchang Tang (5):
> > >       net/hns3: clear promiscuous on PF uninit
> > >       net/hns3: remove unsupported VLAN capabilities
> > >       net/hns3: fix VLAN strip configuration when setting PVID
> > >       net/hns3: remove restriction on setting VF MTU
> > >       net/hns3: fix adding multicast MAC address
> > >
> > > Chenmin Sun (1):
> > >       net/i40e: fix flow director Rx writeback packet
> > >
> > > Ciara Loftus (1):
> > >       net/af_xdp: remove mempool freeing on umem destruction
> > >
> > > David Marchand (7):
> > >       eal/windows: fix symbol export
> > >       eal: remove redundant newline in alert message
> > >       net/mlx5: remove redundant newline from logs
> > >       net/mvpp2: fix non-EAL thread support
> > >       devtools: fix path in forbidden token check
> > >       lib: remind experimental status in headers
> > >       net/bonding: fix socket ID check
> > >
> > > Dekel Peled (2):
> > >       net/mlx5: fix VLAN pop with decap action validation
> > >       net/mlx5: fix VLAN push action on hairpin queue
> > >
> > > Devendra Singh Rawat (1):
> > >       net/qede: fix multicast drop in promiscuous mode
> > >
> > > Dong Zhou (1):
> > >       net/mlx5: fix LRO checksum
> > >
> > > Dongyang Pan (1):
> > >       net/bonding: delete redundant code
> > >
> > > Fady Bader (1):
> > >       meter: remove inline functions from export list
> > >
> > > Feifei Wang (1):
> > >       test/ring: fix statistics in bulk enq/dequeue
> > >
> > > Ferruh Yigit (4):
> > >       net/iavf: fix uninitialized variable
> > >       net/ixgbe/base: remove dead code
> > >       ethdev: fix log type for some error messages
> > >       drivers/net: fix exposing internal headers
> > >
> > > Fiona Trahe (3):
> > >       common/qat: remove tail write coalescing
> > >       common/qat: move max inflights param into qp
> > >       common/qat: support dual threads for enqueue/dequeue
> > >
> > > Gaurav Singh (1):
> > >       net/i40e: remove duplicate tunnel type check
> > >
> > > Georgiy Levashov (1):
> > >       examples: add flush after stats printing
> > >
> > > Gregory Etelson (1):
> > >       net/mlx5: fix tunnel flow priority
> > >
> > > Guinan Sun (5):
> > >       net/ixgbe/base: fix host interface shadow RAM read
> > >       net/ixgbe/base: fix x550em 10G NIC link status
> > >       net/ixgbe/base: fix infinite recursion on PCIe link down
> > >       net/ixgbe: fix MAC control frame forward
> > >       net/ixgbe: fix flow control status
> > >
> > > Haiyue Wang (6):
> > >       bus/pci: fix VF memory access
> > >       eal: fix uuid header dependencies
> > >       net/ice: fix TCP checksum offload
> > >       net/ice: calculate TCP header size for offload
> > >       net/ice: fix Tx hang with TSO
> > >       net/ice: revert fake TSO fixes
> > >
> > > Hao Chen (1):
> > >       net/hns3: optimize default RSS algorithm
> > >
> > > Harman Kalra (4):
> > >       eal/linux: fix epoll fd list rebuild for interrupts
> > >       net/octeontx2: fix DMAC filtering
> > >       common/octeontx2: fix crash on running procinfo
> > >       eal: fix parentheses in alignment macros
> > >
> > > Harry van Haaren (1):
> > >       examples/eventdev: fix 32-bit coremask
> > >
> > > Heinrich Kuhn (1):
> > >       net/nfp: fix RSS hash configuration reporting
> > >
> > > Hemant Agrawal (1):
> > >       rawdev: remove remaining experimental tags
> > >
> > > Hongbo Zheng (4):
> > >       net/hns3: ignore function return on reset error path
> > >       net/hns3: fix unintended sign extension in dump operation
> > >       net/hns3: clear residual hardware configurations on init
> > >       net/hns3: get link status change through mailbox
> > >
> > > Hongzhi Guo (3):
> > >       net: fix IPv4 checksum
> > >       net: fix unneeded replacement of TCP checksum 0
> > >       net: fix checksum on big endian CPUs
> > >
> > > Honnappa Nagarahalli (5):
> > >       eal/armv8: fix timer frequency calibration with PMU
> > >       app/testpmd: use clock time in throughput calculation
> > >       app/testpmd: fix burst percentage calculation
> > >       doc: fix some typos in Linux guide
> > >       test/hash: move lock-free tests to perf tests
> > >
> > > Hrvoje Habjanic (1):
> > >       sched: fix subport freeing
> > >
> > > Ian Dolzhansky (1):
> > >       net/failsafe: fix RSS RETA size info
> > >
> > > Igor Romanov (1):
> > >       service: fix lcore iteration
> > >
> > > Jecky Pei (1):
> > >       net/kni: set packet input port in Rx
> > >
> > > Jeff Guo (1):
> > >       net/e1000: fix crash on Tx done clean up
> > >
> > > Junfeng Guo (2):
> > >       net/ice/base: fix RSS removal for GTP-U
> > >       net/ice/base: fix memory leak on GTPU RSS
> > >
> > > Junyu Jiang (2):
> > >       net/iavf: fix RSS RETA after restart
> > >       net/ice: fix bytes statistics
> > >
> > > Kalesh AP (5):
> > >       net/bnxt: remove unused enum declaration
> > >       net/bnxt: fix unnecessary HWRM command
> > >       net/bnxt: fix flow error on filter creation
> > >       net/bnxt: fix freeing filters on flow creation failure
> > >       net/bnxt: fix logical AND in if condition
> > >
> > > Kevin Traynor (1):
> > >       vhost: remove zero-copy and client mode restriction
> > >
> > > Konstantin Ananyev (2):
> > >       test/bpf: fix few small issues
> > >       bpf: fix add/sub min/max estimations
> > >
> > > Levend Sayar (1):
> > >       service: fix C++ linkage
> > >
> > > Lijun Ou (5):
> > >       net/hns3: add RSS hash offload to Rx configuration
> > >       net/hns3: fix key length when configuring RSS
> > >       net/hns3: fix RSS configuration on empty RSS type
> > >       net/hns3: remove unnecessary branch
> > >       app/testpmd: remove hardcoded descriptors limit
> > >
> > > Long Li (3):
> > >       bus/vmbus: fix ring buffer mapping
> > >       net/netvsc: fix underflow when Rx external mbuf
> > >       net/netvsc: fix chimney index
> > >
> > > Lukasz Wojciechowski (1):
> > >       service: fix core mapping reset
> > >
> > > Mao Jiang (2):
> > >       net/i40e: fix binding interrupt without MSI-X vector
> > >       net/i40e: fix flow director MSI-X resource allocation
> > >
> > > Matan Azrad (1):
> > >       vhost: fix features definition location
> > >
> > > Maxime Coquelin (3):
> > >       bus/dpaa: fix iterating on a class type
> > >       bus/fslmc: fix iterating on a class type
> > >       vhost: fix virtio ready flag check
> > >
> > > Michael Baum (11):
> > >       net/mlx5: remove needless Tx queue initialization check
> > >       net/mlx5: fix unreachable MPLS error path
> > >       common/mlx5: fix code arrangement in tag allocation
> > >       net/mlx5: fix iterator type in Rx queue management
> > >       net/mlx5: fix initialization of steering registers
> > >       net/mlx5: fix crash in NVGRE item translation
> > >       net/mlx5: remove ineffective increment in hairpin split
> > >       net/mlx4: optimize stack memory size in probe
> > >       net/mlx5: fix unnecessary init in mark conversion
> > >       net/mlx5: fix hairpin Tx queue creation error flow
> > >       net/mlx5: fix hairpin Rx queue creation error flow
> > >
> > > Muhammad Bilal (1):
> > >       bus/vdev: fix a typo in doxygen comment
> > >
> > > Nipun Gupta (2):
> > >       bus/fslmc: fix getting FD error
> > >       net/dpaa: fix FD offset data type
> > >
> > > Pablo de Lara (1):
> > >       drivers/crypto: add missing OOP feature flag
> > >
> > > Parav Pandit (1):
> > >       common/mlx5: fix void parameters in glue wrappers
> > >
> > > Patrick Fu (1):
> > >       vhost: fix double-free with zero-copy
> > >
> > > Pavan Nikhilesh (2):
> > >       event/octeontx2: fix device reconfigure
> > >       event/octeontx2: fix sub event type
> > >
> > > Pavel Ivashchenko (1):
> > >       net/i40e: fix getting EEPROM information
> > >
> > > Phil Yang (5):
> > >       eventdev: fix race condition on timer list counter
> > >       eventdev: use C11 atomics for lcore timer armed flag
> > >       eventdev: remove redundant reset on timer cancel
> > >       eventdev: relax SMP barriers with C11 atomics
> > >       app/testpmd: fix CPU cycles per packet stats on Tx modes
> > >
> > > Qi Zhang (7):
> > >       net/ice/base: fix return value
> > >       net/ice/base: fix memory leak on error path
> > >       net/ice/base: fix reference count on VSI list update
> > >       net/ice/base: fix initializing resource for field vector
> > >       net/ice/base: fix VSI ID mask to 10 bits
> > >       net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
> > >       net/ice/base: fix RSS interference
> > >
> > > Rahul Gupta (1):
> > >       net/bnxt: fix performance for Arm
> > >
> > > Rahul Lakkireddy (3):
> > >       net/cxgbe: fix CLIP leak in filter error path
> > >       net/cxgbe: fix double MPS alloc by flow validate and create
> > >       net/cxgbe: fix L2T leak in filter error and free path
> > >
> > > Raslan Darawsheh (3):
> > >       net: fix pedantic build
> > >       net/mlx5: fix flow items size calculation
> > >       net/mlx5: fix VF MAC address set over BlueField
> > >
> > > Ruifeng Wang (8):
> > >       net/i40e: enable NEON Rx/Tx in meson
> > >       eal/arm: add vcopyq intrinsic for aarch32
> > >       net/ixgbe: fix include of vector header file
> > >       test: allow no-huge mode for fast-tests
> > >       test/cycles: restore default delay callback
> > >       crypto/armv8: remove debug option
> > >       crypto/armv8: use dedicated log type
> > >       net/i40e: support aarch32
> > >
> > > Sarosh Arif (3):
> > >       doc: fix typo in bbdev test guide
> > >       examples/packet_ordering: use proper exit method
> > >       doc: fix ethtool app path
> > >
> > > Shougang Wang (2):
> > >       net/ice: fix error log in generic flow
> > >       net/i40e: fix filter pctype
> > >
> > > Shy Shyman (3):
> > >       app/testpmd: fix error detection in MTU command
> > >       net/mlx5: fix flow META item validation
> > >       net/mlx5: fix HW counters path in switchdev mode
> > >
> > > Stephen Hemminger (8):
> > >       net/netvsc: fix warning when VF is removed
> > >       net/netvsc: do not query VF link state
> > >       net/netvsc: do not spin forever waiting for reply
> > >       eal: fix lcore accessors for non-EAL threads
> > >       cfgfile: fix stack buffer underflow
> > >       rib: add C++ include guard
> > >       kni: fix reference to master/slave process
> > >       doc: fix reference to master process
> > >
> > > Suanming Mou (3):
> > >       net/mlx5: fix secondary process resources release
> > >       net/mlx5: fix interrupt installation timing
> > >       net/mlx5: fix counter query
> > >
> > > Tal Shnaiderman (2):
> > >       build: fix drivers library path on Windows
> > >       pci: fix address domain format size
> > >
> > > Thomas Monjalon (1):
> > >       doc: update build instructions in the Linux guide
> > >
> > > Tianfei Zhang (2):
> > >       raw/ifpga/base: fix SPI transaction
> > >       raw/ifpga/base: fix NIOS SPI init
> > >
> > > Timothy Redaelli (1):
> > >       test: fix rpath for drivers with meson
> > >
> > > Viacheslav Ovsiienko (3):
> > >       net/mlx5: fix UAR lock sharing for multiport devices
> > >       common/mlx5: fix queue doorbell record size
> > >       net/mlx5: fix metadata storing for NEON Rx
> > >
> > > Vladimir Medvedkin (1):
> > >       doc: add RIB and FIB into the API index
> > >
> > > Wei Hu (Xavier) (12):
> > >       net/hns3: fix Tx less than 60 bytes
> > >       net/hns3: fix VLAN tags reported in Rx
> > >       app/testpmd: fix stats error message
> > >       net/hns3: fix flow director error message
> > >       net/hns3: fix unintended sign extension in fd operation
> > >       net/hns3: fix Rx buffer size
> > >       net/hns3: check multi-process action register result
> > >       ethdev: fix data room size verification in Rx queue setup
> > >       ethdev: fix VLAN offloads set if no relative capabilities
> > >       net/bonding: fix error code on device creation
> > >       net/bonding: fix MAC address when switching active port
> > >       net/bonding: fix MAC address when one port resets
> > >
> > > Wei Zhao (4):
> > >       net/ice: fix switch action number check
> > >       net/ixgbe: report 10Mbps link speed for x553
> > >       net/ice: add input set byte number check
> > >       net/i40e: enable QinQ stripping
> > >
> > > Weifeng Li (1):
> > >       net/bonding: change state machine to defaulted
> > >
> > > Xiao Wang (1):
> > >       net/virtio-user: fix status management
> > >
> > > Xiaolong Ye (6):
> > >       mbuf: remove unused next member in dynamic flag/field
> > >       test/mbuf: fix a dynamic flag log
> > >       mbuf: fix boundary check at dynamic field registration
> > >       mbuf: fix error code in dynamic field/flag registration
> > >       mbuf: fix free space update for dynamic field
> > >       mbuf: fix dynamic field dump log
> > >
> > > Xiaoyun Wang (5):
> > >       net/hinic/base: check output of management sync channel
> > >       net/hinic/base: remove unused function parameters
> > >       net/hinic: fix setting promiscuous mode
> > >       net/hinic: optimize Rx performance for x86
> > >       net/hinic/base: avoid system time jump
> > >
> > > Yicai Lu (1):
> > >       net/bonding: fix LACP negotiation
> > >
> > > Yunjian Wang (12):
> > >       app/testpmd: fix memory leak on error path
> > >       vfio: remove unused variable
> > >       net/af_packet: fix check of file descriptors
> > >       net/af_packet: fix memory leak on init failure
> > >       net/af_packet: fix munmap on init failure
> > >       bus/fslmc: fix memory leak in secondary process
> > >       hash: fix out-of-memory handling in hash creation
> > >       event/dpaa: remove dead code
> > >       net/qede: remove dead code
> > >       net/hinic: check memory allocations in flow creation
> > >       net/ice: fix memory leak when releasing VSI
> > >       net/ice: add memory allocation check in RSS init
> > >
> > > Zhiguang He (1):
> > >       net/bonding: fix dead loop on RSS RETA update
> > >
> > > Zhihong Peng (2):
> > >       net/i40e: report VLAN filter capability
> > >       net/e1000: report VLAN extend capability
> > >
> > > Zhike Wang (1):
> > >       mempool: fix allocation in memzone during retry

Re: [dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Fri, 2020-08-28 at 04:03 +0000, Wang, ShougangX wrote:
> Hi, Luca and Bo
> 
> > >     - The MD5 is not same between kernel ethtool and dpdk ethtool when
> > > testing userspace_ethtool/retrieve_eeprom. It has been fixed on
> > > 20.08.patch link: http://patches.dpdk.org/patch/72354/
> > 
> > Shougang and Qi, this patch applies when backported but build fails, as some
> > internal structures are different. Do you consider this issue a blocking one for
> > the release and want to do the work to backport the fixes to 19.11?
> > 
> 
> This patch can't be applied because the solution depends on updating ice shared code.
> I'm not sure the workload and impact of updating shared code. It is a small bug and it is 
> not a DPDK main feature. So I think it is not a block issue for release and I don't suggest 
> to fix it in 19.11. How do you think of it? 

Sounds good to me, let's skip it. Thanks for checking!

> > 01186263c2c7 ("net/ice: fix EEPROM data")
> > 
> > ../drivers/net/ice/ice_ethdev.c: In function ‘ice_get_eeprom_length’:
> > ../drivers/net/ice/ice_ethdev.c:3979:16: error: ‘struct ice_nvm_info’
> > has no member named ‘flash_size’
> >   return hw->nvm.flash_size;
> 
> Thanks.
> Shougang
> 
> > -----Original Message-----
> > From: Luca Boccassi <bluca@debian.org>
> > Sent: Wednesday, August 26, 2020 5:50 PM
> > To: Wang, ShougangX <shougangx.wang@intel.com>; Burakov, Anatoly
> > <anatoly.burakov@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Chen, BoX C <box.c.chen@intel.com>
> > Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> > 
> > On Wed, 2020-08-26 at 02:30 +0000, Chen, BoX C wrote:
> > > Hi Luca,
> > > Update LTS 19.11.4 test result for Intel part. No new issue is found except
> > known issues.
> > 
> > Thank you!
> > 
> > > * Intel(R) Testing
> > > 
> > > # Basic Intel(R) NIC testing
> > >  * PF(i40e):Passed
> > >     - Exception message when starting testpmd for testing external
> > > memory. It has been fixed on 20.05.patch link:
> > > http://patches.dpdk.org/patch/66041/
> > 
> > Anatoly, is it safe to backport this patch to 19.11? It applies and builds cleanly
> > when cherry-picked:
> > 
> > d1c7c0cdf7ba ("vfio: map contiguous areas in one go")
> > 
> > >  * PF(ixgbe):Passed
> > >  * PF(ice):Passed
> > >     - The MD5 is not same between kernel ethtool and dpdk ethtool when
> > > testing userspace_ethtool/retrieve_eeprom. It has been fixed on
> > > 20.08.patch link: http://patches.dpdk.org/patch/72354/
> > 
> > Shougang and Qi, this patch applies when backported but build fails, as some
> > internal structures are different. Do you consider this issue a blocking one for
> > the release and want to do the work to backport the fixes to 19.11?
> > 
> > 01186263c2c7 ("net/ice: fix EEPROM data")
> > 
> > ../drivers/net/ice/ice_ethdev.c: In function ‘ice_get_eeprom_length’:
> > ../drivers/net/ice/ice_ethdev.c:3979:16: error: ‘struct ice_nvm_info’
> > has no member named ‘flash_size’
> >   return hw->nvm.flash_size;
> > 
> > >     - With latest ice driver and firmware package exception found when port
> > reset vf of testpmd. It is also found on latest dpdk version, dev is debugging.
> > >  * VF(i40e):Passed
> > >  * VF(ixgbe):Passed
> > >  * VF(ice):Passed
> > >  * Build or compile: Passed
> > >  * Intel NIC single core/NIC performance: Passed
> > > 
> > > #Basic cryptodev and virtio testing
> > >  * vhost/virtio basic loopback, PVP and performance test: Passed.
> > >     - udp-fragmentation-offload can't be setup on vm Ubuntu1910.it is
> > kernel issue, tracked on: https://bugzilla.kernel.org/show_bug.cgi?id=207075
> > >     - l3fwd-power can wake up lcore but can not sleep again. It is also found
> > on 20.08, dev is debugging.
> > >  * cryptodev Function: Passed.
> > >     - fips_cryptodev test failed for TDES. It is also found on 20.08,
> > > dev is debugging. https://bugs.dpdk.org/show_bug.cgi?id=512
> > >  * cryptodev Performance: Passed.
> > >     - known unstable issue of test case 1c1t 3CPM. not effect LTS release.
> > > 
> > > Thanks.
> > > Regards,
> > > Chen Bo
> > > 
> > > > -----Original Message-----
> > > > From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> > > > Sent: August 19, 2020 2:12
> > > > To: stable@dpdk.org
> > > > Cc: dev@dpdk.org; Abhishek Marathe
> > <Abhishek.Marathe@microsoft.com>;
> > > > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani
> > > > <alialnu@mellanox.com>; Walker, Benjamin
> > > > <benjamin.walker@intel.com>; David Christensen
> > > > <drc@linux.vnet.ibm.com>; Hemant Agrawal
> > <hemant.agrawal@nxp.com>;
> > > > Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob
> > > > <jerinj@marvell.com>; Mcnamara, John <john.mcnamara@intel.com>;
> > > > Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor
> > > > <ktraynor@redhat.com>; Pei Zhang <pezhang@redhat.com>; Yu, PingX
> > > > <pingx.yu@intel.com>; Xu, Qian Q <qian.q.xu@intel.com>; Raslan
> > > > Darawsheh <rasland@mellanox.com>; Thomas Monjalon
> > > > <thomas@monjalon.net>; Peng, Yuan <yuan.peng@intel.com>; Chen,
> > > > Zhaoyan <zhaoyan.chen@intel.com>
> > > > Subject: [dpdk-dev] 19.11.4 patches review and test
> > > > 
> > > > Hi all,
> > > > 
> > > > Here is a list of patches targeted for stable release 19.11.4.
> > > > 
> > > > The planned date for the final release is August 31st.
> > > > 
> > > > Please help with testing and validation of your use cases and report
> > > > any issues/results with reply-all to this mail. For the final
> > > > release the fixes and reported validations will be added to the release
> > notes.
> > > > A release candidate tarball can be found at:
> > > > 
> > > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > > > 
> > > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > >     https://dpdk.org/browse/dpdk-stable/
> > > > 
> > > > Thanks.
> > > > 
> > > > Luca Boccassi
> > > > 
> > > > ---
> > > > Adam Dybkowski (7):
> > > >       test/crypto: fix asymmetric session mempool creation
> > > >       crypto/qat: fix AES-XTS capabilities
> > > >       crypto/qat: handle mixed hash-cipher requests on GEN3
> > > >       test/crypto: add mixed encypted-digest
> > > >       common/qat: get firmware version
> > > >       crypto/qat: handle mixed hash-cipher on GEN2
> > > >       common/qat: fix uninitialized variable
> > > > 
> > > > Akhil Goyal (4):
> > > >       crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
> > > >       crypto/dpaax_sec: fix inline query for descriptors
> > > >       crypto/dpaa2_sec: fix HFN override
> > > >       common/dpaax: fix 12-bit null auth case
> > > > 
> > > > Alan Dewar (1):
> > > >       sched: fix port time rounding
> > > > 
> > > > Alexander Kozyrev (3):
> > > >       net/mlx5: fix vectorized Rx burst termination
> > > >       net/mlx5: do not select legacy MPW implicitly
> > > >       net/mlx5: fix descriptors number adjustment
> > > > 
> > > > Ali Alnubani (2):
> > > >       net/mlx5: fix typos in meter error messages
> > > >       doc: fix a typo in mlx5 guide
> > > > 
> > > > Alvin Zhang (1):
> > > >       net/i40e: fix queue pairs configuration in VF
> > > > 
> > > > Andrew Rybchenko (1):
> > > >       net/sfc: do not enforce hash offload in RSS multi-queue
> > > > 
> > > > Ankur Dwivedi (2):
> > > >       common/cpt: fix encryption offset
> > > >       test/crypto: change cipher offset for ESN vector
> > > > 
> > > > Apeksha Gupta (2):
> > > >       app/eventdev: fix capability check in pipeline ATQ test
> > > >       event/dpaa2: add all-types queue capability flag
> > > > 
> > > > Archana Muniganti (2):
> > > >       examples/fips_validation: fix TDES interim callback
> > > >       examples/fips_validation: fix count overwrite for TDES
> > > > 
> > > > Archit Pandey (1):
> > > >       sched: fix 64-bit rate
> > > > 
> > > > Arek Kusztal (4):
> > > >       drivers/qat: improve multi process on qat
> > > >       drivers/qat: add multi process handling of driver id
> > > >       drivers/qat: add handling of capabilities in multi process
> > > >       crypto/qat: add minimum enq threshold
> > > > 
> > > > Ayuj Verma (1):
> > > >       examples/fips_validation: fix parsing of TDES vectors
> > > > 
> > > > Bruce Richardson (12):
> > > >       test: fix build with ring PMD but no bond PMD
> > > >       mem: fix 32-bit init config with meson
> > > >       rawdev: allow getting info for unknown device
> > > >       rawdev: fill NUMA socket ID in info
> > > >       rawdev: export dump function in map file
> > > >       doc: rebuild with meson whenever a file changes
> > > >       build: always link whole DPDK static libraries
> > > >       devtools: test static linkage with pkg-config
> > > >       build/pkg-config: move pkg-config file creation
> > > >       build/pkg-config: output drivers first for static build
> > > >       build/pkg-config: improve static linking flags
> > > >       build/pkg-config: prevent overlinking
> > > > 
> > > > Chas Williams (1):
> > > >       net/netvsc: fix crash during Tx
> > > > 
> > > > Chenbo Xia (1):
> > > >       net/virtio-user: check tap system call setting
> > > > 
> > > > Chengchang Tang (5):
> > > >       net/hns3: clear promiscuous on PF uninit
> > > >       net/hns3: remove unsupported VLAN capabilities
> > > >       net/hns3: fix VLAN strip configuration when setting PVID
> > > >       net/hns3: remove restriction on setting VF MTU
> > > >       net/hns3: fix adding multicast MAC address
> > > > 
> > > > Chenmin Sun (1):
> > > >       net/i40e: fix flow director Rx writeback packet
> > > > 
> > > > Ciara Loftus (1):
> > > >       net/af_xdp: remove mempool freeing on umem destruction
> > > > 
> > > > David Marchand (7):
> > > >       eal/windows: fix symbol export
> > > >       eal: remove redundant newline in alert message
> > > >       net/mlx5: remove redundant newline from logs
> > > >       net/mvpp2: fix non-EAL thread support
> > > >       devtools: fix path in forbidden token check
> > > >       lib: remind experimental status in headers
> > > >       net/bonding: fix socket ID check
> > > > 
> > > > Dekel Peled (2):
> > > >       net/mlx5: fix VLAN pop with decap action validation
> > > >       net/mlx5: fix VLAN push action on hairpin queue
> > > > 
> > > > Devendra Singh Rawat (1):
> > > >       net/qede: fix multicast drop in promiscuous mode
> > > > 
> > > > Dong Zhou (1):
> > > >       net/mlx5: fix LRO checksum
> > > > 
> > > > Dongyang Pan (1):
> > > >       net/bonding: delete redundant code
> > > > 
> > > > Fady Bader (1):
> > > >       meter: remove inline functions from export list
> > > > 
> > > > Feifei Wang (1):
> > > >       test/ring: fix statistics in bulk enq/dequeue
> > > > 
> > > > Ferruh Yigit (4):
> > > >       net/iavf: fix uninitialized variable
> > > >       net/ixgbe/base: remove dead code
> > > >       ethdev: fix log type for some error messages
> > > >       drivers/net: fix exposing internal headers
> > > > 
> > > > Fiona Trahe (3):
> > > >       common/qat: remove tail write coalescing
> > > >       common/qat: move max inflights param into qp
> > > >       common/qat: support dual threads for enqueue/dequeue
> > > > 
> > > > Gaurav Singh (1):
> > > >       net/i40e: remove duplicate tunnel type check
> > > > 
> > > > Georgiy Levashov (1):
> > > >       examples: add flush after stats printing
> > > > 
> > > > Gregory Etelson (1):
> > > >       net/mlx5: fix tunnel flow priority
> > > > 
> > > > Guinan Sun (5):
> > > >       net/ixgbe/base: fix host interface shadow RAM read
> > > >       net/ixgbe/base: fix x550em 10G NIC link status
> > > >       net/ixgbe/base: fix infinite recursion on PCIe link down
> > > >       net/ixgbe: fix MAC control frame forward
> > > >       net/ixgbe: fix flow control status
> > > > 
> > > > Haiyue Wang (6):
> > > >       bus/pci: fix VF memory access
> > > >       eal: fix uuid header dependencies
> > > >       net/ice: fix TCP checksum offload
> > > >       net/ice: calculate TCP header size for offload
> > > >       net/ice: fix Tx hang with TSO
> > > >       net/ice: revert fake TSO fixes
> > > > 
> > > > Hao Chen (1):
> > > >       net/hns3: optimize default RSS algorithm
> > > > 
> > > > Harman Kalra (4):
> > > >       eal/linux: fix epoll fd list rebuild for interrupts
> > > >       net/octeontx2: fix DMAC filtering
> > > >       common/octeontx2: fix crash on running procinfo
> > > >       eal: fix parentheses in alignment macros
> > > > 
> > > > Harry van Haaren (1):
> > > >       examples/eventdev: fix 32-bit coremask
> > > > 
> > > > Heinrich Kuhn (1):
> > > >       net/nfp: fix RSS hash configuration reporting
> > > > 
> > > > Hemant Agrawal (1):
> > > >       rawdev: remove remaining experimental tags
> > > > 
> > > > Hongbo Zheng (4):
> > > >       net/hns3: ignore function return on reset error path
> > > >       net/hns3: fix unintended sign extension in dump operation
> > > >       net/hns3: clear residual hardware configurations on init
> > > >       net/hns3: get link status change through mailbox
> > > > 
> > > > Hongzhi Guo (3):
> > > >       net: fix IPv4 checksum
> > > >       net: fix unneeded replacement of TCP checksum 0
> > > >       net: fix checksum on big endian CPUs
> > > > 
> > > > Honnappa Nagarahalli (5):
> > > >       eal/armv8: fix timer frequency calibration with PMU
> > > >       app/testpmd: use clock time in throughput calculation
> > > >       app/testpmd: fix burst percentage calculation
> > > >       doc: fix some typos in Linux guide
> > > >       test/hash: move lock-free tests to perf tests
> > > > 
> > > > Hrvoje Habjanic (1):
> > > >       sched: fix subport freeing
> > > > 
> > > > Ian Dolzhansky (1):
> > > >       net/failsafe: fix RSS RETA size info
> > > > 
> > > > Igor Romanov (1):
> > > >       service: fix lcore iteration
> > > > 
> > > > Jecky Pei (1):
> > > >       net/kni: set packet input port in Rx
> > > > 
> > > > Jeff Guo (1):
> > > >       net/e1000: fix crash on Tx done clean up
> > > > 
> > > > Junfeng Guo (2):
> > > >       net/ice/base: fix RSS removal for GTP-U
> > > >       net/ice/base: fix memory leak on GTPU RSS
> > > > 
> > > > Junyu Jiang (2):
> > > >       net/iavf: fix RSS RETA after restart
> > > >       net/ice: fix bytes statistics
> > > > 
> > > > Kalesh AP (5):
> > > >       net/bnxt: remove unused enum declaration
> > > >       net/bnxt: fix unnecessary HWRM command
> > > >       net/bnxt: fix flow error on filter creation
> > > >       net/bnxt: fix freeing filters on flow creation failure
> > > >       net/bnxt: fix logical AND in if condition
> > > > 
> > > > Kevin Traynor (1):
> > > >       vhost: remove zero-copy and client mode restriction
> > > > 
> > > > Konstantin Ananyev (2):
> > > >       test/bpf: fix few small issues
> > > >       bpf: fix add/sub min/max estimations
> > > > 
> > > > Levend Sayar (1):
> > > >       service: fix C++ linkage
> > > > 
> > > > Lijun Ou (5):
> > > >       net/hns3: add RSS hash offload to Rx configuration
> > > >       net/hns3: fix key length when configuring RSS
> > > >       net/hns3: fix RSS configuration on empty RSS type
> > > >       net/hns3: remove unnecessary branch
> > > >       app/testpmd: remove hardcoded descriptors limit
> > > > 
> > > > Long Li (3):
> > > >       bus/vmbus: fix ring buffer mapping
> > > >       net/netvsc: fix underflow when Rx external mbuf
> > > >       net/netvsc: fix chimney index
> > > > 
> > > > Lukasz Wojciechowski (1):
> > > >       service: fix core mapping reset
> > > > 
> > > > Mao Jiang (2):
> > > >       net/i40e: fix binding interrupt without MSI-X vector
> > > >       net/i40e: fix flow director MSI-X resource allocation
> > > > 
> > > > Matan Azrad (1):
> > > >       vhost: fix features definition location
> > > > 
> > > > Maxime Coquelin (3):
> > > >       bus/dpaa: fix iterating on a class type
> > > >       bus/fslmc: fix iterating on a class type
> > > >       vhost: fix virtio ready flag check
> > > > 
> > > > Michael Baum (11):
> > > >       net/mlx5: remove needless Tx queue initialization check
> > > >       net/mlx5: fix unreachable MPLS error path
> > > >       common/mlx5: fix code arrangement in tag allocation
> > > >       net/mlx5: fix iterator type in Rx queue management
> > > >       net/mlx5: fix initialization of steering registers
> > > >       net/mlx5: fix crash in NVGRE item translation
> > > >       net/mlx5: remove ineffective increment in hairpin split
> > > >       net/mlx4: optimize stack memory size in probe
> > > >       net/mlx5: fix unnecessary init in mark conversion
> > > >       net/mlx5: fix hairpin Tx queue creation error flow
> > > >       net/mlx5: fix hairpin Rx queue creation error flow
> > > > 
> > > > Muhammad Bilal (1):
> > > >       bus/vdev: fix a typo in doxygen comment
> > > > 
> > > > Nipun Gupta (2):
> > > >       bus/fslmc: fix getting FD error
> > > >       net/dpaa: fix FD offset data type
> > > > 
> > > > Pablo de Lara (1):
> > > >       drivers/crypto: add missing OOP feature flag
> > > > 
> > > > Parav Pandit (1):
> > > >       common/mlx5: fix void parameters in glue wrappers
> > > > 
> > > > Patrick Fu (1):
> > > >       vhost: fix double-free with zero-copy
> > > > 
> > > > Pavan Nikhilesh (2):
> > > >       event/octeontx2: fix device reconfigure
> > > >       event/octeontx2: fix sub event type
> > > > 
> > > > Pavel Ivashchenko (1):
> > > >       net/i40e: fix getting EEPROM information
> > > > 
> > > > Phil Yang (5):
> > > >       eventdev: fix race condition on timer list counter
> > > >       eventdev: use C11 atomics for lcore timer armed flag
> > > >       eventdev: remove redundant reset on timer cancel
> > > >       eventdev: relax SMP barriers with C11 atomics
> > > >       app/testpmd: fix CPU cycles per packet stats on Tx modes
> > > > 
> > > > Qi Zhang (7):
> > > >       net/ice/base: fix return value
> > > >       net/ice/base: fix memory leak on error path
> > > >       net/ice/base: fix reference count on VSI list update
> > > >       net/ice/base: fix initializing resource for field vector
> > > >       net/ice/base: fix VSI ID mask to 10 bits
> > > >       net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
> > > >       net/ice/base: fix RSS interference
> > > > 
> > > > Rahul Gupta (1):
> > > >       net/bnxt: fix performance for Arm
> > > > 
> > > > Rahul Lakkireddy (3):
> > > >       net/cxgbe: fix CLIP leak in filter error path
> > > >       net/cxgbe: fix double MPS alloc by flow validate and create
> > > >       net/cxgbe: fix L2T leak in filter error and free path
> > > > 
> > > > Raslan Darawsheh (3):
> > > >       net: fix pedantic build
> > > >       net/mlx5: fix flow items size calculation
> > > >       net/mlx5: fix VF MAC address set over BlueField
> > > > 
> > > > Ruifeng Wang (8):
> > > >       net/i40e: enable NEON Rx/Tx in meson
> > > >       eal/arm: add vcopyq intrinsic for aarch32
> > > >       net/ixgbe: fix include of vector header file
> > > >       test: allow no-huge mode for fast-tests
> > > >       test/cycles: restore default delay callback
> > > >       crypto/armv8: remove debug option
> > > >       crypto/armv8: use dedicated log type
> > > >       net/i40e: support aarch32
> > > > 
> > > > Sarosh Arif (3):
> > > >       doc: fix typo in bbdev test guide
> > > >       examples/packet_ordering: use proper exit method
> > > >       doc: fix ethtool app path
> > > > 
> > > > Shougang Wang (2):
> > > >       net/ice: fix error log in generic flow
> > > >       net/i40e: fix filter pctype
> > > > 
> > > > Shy Shyman (3):
> > > >       app/testpmd: fix error detection in MTU command
> > > >       net/mlx5: fix flow META item validation
> > > >       net/mlx5: fix HW counters path in switchdev mode
> > > > 
> > > > Stephen Hemminger (8):
> > > >       net/netvsc: fix warning when VF is removed
> > > >       net/netvsc: do not query VF link state
> > > >       net/netvsc: do not spin forever waiting for reply
> > > >       eal: fix lcore accessors for non-EAL threads
> > > >       cfgfile: fix stack buffer underflow
> > > >       rib: add C++ include guard
> > > >       kni: fix reference to master/slave process
> > > >       doc: fix reference to master process
> > > > 
> > > > Suanming Mou (3):
> > > >       net/mlx5: fix secondary process resources release
> > > >       net/mlx5: fix interrupt installation timing
> > > >       net/mlx5: fix counter query
> > > > 
> > > > Tal Shnaiderman (2):
> > > >       build: fix drivers library path on Windows
> > > >       pci: fix address domain format size
> > > > 
> > > > Thomas Monjalon (1):
> > > >       doc: update build instructions in the Linux guide
> > > > 
> > > > Tianfei Zhang (2):
> > > >       raw/ifpga/base: fix SPI transaction
> > > >       raw/ifpga/base: fix NIOS SPI init
> > > > 
> > > > Timothy Redaelli (1):
> > > >       test: fix rpath for drivers with meson
> > > > 
> > > > Viacheslav Ovsiienko (3):
> > > >       net/mlx5: fix UAR lock sharing for multiport devices
> > > >       common/mlx5: fix queue doorbell record size
> > > >       net/mlx5: fix metadata storing for NEON Rx
> > > > 
> > > > Vladimir Medvedkin (1):
> > > >       doc: add RIB and FIB into the API index
> > > > 
> > > > Wei Hu (Xavier) (12):
> > > >       net/hns3: fix Tx less than 60 bytes
> > > >       net/hns3: fix VLAN tags reported in Rx
> > > >       app/testpmd: fix stats error message
> > > >       net/hns3: fix flow director error message
> > > >       net/hns3: fix unintended sign extension in fd operation
> > > >       net/hns3: fix Rx buffer size
> > > >       net/hns3: check multi-process action register result
> > > >       ethdev: fix data room size verification in Rx queue setup
> > > >       ethdev: fix VLAN offloads set if no relative capabilities
> > > >       net/bonding: fix error code on device creation
> > > >       net/bonding: fix MAC address when switching active port
> > > >       net/bonding: fix MAC address when one port resets
> > > > 
> > > > Wei Zhao (4):
> > > >       net/ice: fix switch action number check
> > > >       net/ixgbe: report 10Mbps link speed for x553
> > > >       net/ice: add input set byte number check
> > > >       net/i40e: enable QinQ stripping
> > > > 
> > > > Weifeng Li (1):
> > > >       net/bonding: change state machine to defaulted
> > > > 
> > > > Xiao Wang (1):
> > > >       net/virtio-user: fix status management
> > > > 
> > > > Xiaolong Ye (6):
> > > >       mbuf: remove unused next member in dynamic flag/field
> > > >       test/mbuf: fix a dynamic flag log
> > > >       mbuf: fix boundary check at dynamic field registration
> > > >       mbuf: fix error code in dynamic field/flag registration
> > > >       mbuf: fix free space update for dynamic field
> > > >       mbuf: fix dynamic field dump log
> > > > 
> > > > Xiaoyun Wang (5):
> > > >       net/hinic/base: check output of management sync channel
> > > >       net/hinic/base: remove unused function parameters
> > > >       net/hinic: fix setting promiscuous mode
> > > >       net/hinic: optimize Rx performance for x86
> > > >       net/hinic/base: avoid system time jump
> > > > 
> > > > Yicai Lu (1):
> > > >       net/bonding: fix LACP negotiation
> > > > 
> > > > Yunjian Wang (12):
> > > >       app/testpmd: fix memory leak on error path
> > > >       vfio: remove unused variable
> > > >       net/af_packet: fix check of file descriptors
> > > >       net/af_packet: fix memory leak on init failure
> > > >       net/af_packet: fix munmap on init failure
> > > >       bus/fslmc: fix memory leak in secondary process
> > > >       hash: fix out-of-memory handling in hash creation
> > > >       event/dpaa: remove dead code
> > > >       net/qede: remove dead code
> > > >       net/hinic: check memory allocations in flow creation
> > > >       net/ice: fix memory leak when releasing VSI
> > > >       net/ice: add memory allocation check in RSS init
> > > > 
> > > > Zhiguang He (1):
> > > >       net/bonding: fix dead loop on RSS RETA update
> > > > 
> > > > Zhihong Peng (2):
> > > >       net/i40e: report VLAN filter capability
> > > >       net/e1000: report VLAN extend capability
> > > > 
> > > > Zhike Wang (1):
> > > >       mempool: fix allocation in memzone during retry

Re: [dpdk-dev] 19.11.4 patches review and test

[Govindharajan, Hariprasad]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> Sent: Tuesday, August 18, 2020 7:12 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Pei Zhang
> <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q
> <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>;
> Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan
> <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> Subject: [dpdk-dev] 19.11.4 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 19.11.4.
> 
> The planned date for the final release is August 31st.
> 
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> 
> These patches are located at branch 19.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Luca Boccassi

[Govindharajan, Hariprasad]  hi Luca,
The DPDK-19.11.4-RC1 release was tested with OvS 2.13 and master versions for the following devices:
ICE
i40e
ixgbe 
vHost user client
with the following tests:
1)	Performance tests
2)	vHost zero-copy
3)	Flow control
4)	RSS
5)	Partial HW offloading

From the validation side, no issues were seen.

Regards,
G Hariprasad

> ---
> Adam Dybkowski (7):
>       test/crypto: fix asymmetric session mempool creation
>       crypto/qat: fix AES-XTS capabilities
>       crypto/qat: handle mixed hash-cipher requests on GEN3
>       test/crypto: add mixed encypted-digest
>       common/qat: get firmware version
>       crypto/qat: handle mixed hash-cipher on GEN2
>       common/qat: fix uninitialized variable
> 
> Akhil Goyal (4):
>       crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
>       crypto/dpaax_sec: fix inline query for descriptors
>       crypto/dpaa2_sec: fix HFN override
>       common/dpaax: fix 12-bit null auth case
> 
> Alan Dewar (1):
>       sched: fix port time rounding
> 
> Alexander Kozyrev (3):
>       net/mlx5: fix vectorized Rx burst termination
>       net/mlx5: do not select legacy MPW implicitly
>       net/mlx5: fix descriptors number adjustment
> 
> Ali Alnubani (2):
>       net/mlx5: fix typos in meter error messages
>       doc: fix a typo in mlx5 guide
> 
> Alvin Zhang (1):
>       net/i40e: fix queue pairs configuration in VF
> 
> Andrew Rybchenko (1):
>       net/sfc: do not enforce hash offload in RSS multi-queue
> 
> Ankur Dwivedi (2):
>       common/cpt: fix encryption offset
>       test/crypto: change cipher offset for ESN vector
> 
> Apeksha Gupta (2):
>       app/eventdev: fix capability check in pipeline ATQ test
>       event/dpaa2: add all-types queue capability flag
> 
> Archana Muniganti (2):
>       examples/fips_validation: fix TDES interim callback
>       examples/fips_validation: fix count overwrite for TDES
> 
> Archit Pandey (1):
>       sched: fix 64-bit rate
> 
> Arek Kusztal (4):
>       drivers/qat: improve multi process on qat
>       drivers/qat: add multi process handling of driver id
>       drivers/qat: add handling of capabilities in multi process
>       crypto/qat: add minimum enq threshold
> 
> Ayuj Verma (1):
>       examples/fips_validation: fix parsing of TDES vectors
> 
> Bruce Richardson (12):
>       test: fix build with ring PMD but no bond PMD
>       mem: fix 32-bit init config with meson
>       rawdev: allow getting info for unknown device
>       rawdev: fill NUMA socket ID in info
>       rawdev: export dump function in map file
>       doc: rebuild with meson whenever a file changes
>       build: always link whole DPDK static libraries
>       devtools: test static linkage with pkg-config
>       build/pkg-config: move pkg-config file creation
>       build/pkg-config: output drivers first for static build
>       build/pkg-config: improve static linking flags
>       build/pkg-config: prevent overlinking
> 
> Chas Williams (1):
>       net/netvsc: fix crash during Tx
> 
> Chenbo Xia (1):
>       net/virtio-user: check tap system call setting
> 
> Chengchang Tang (5):
>       net/hns3: clear promiscuous on PF uninit
>       net/hns3: remove unsupported VLAN capabilities
>       net/hns3: fix VLAN strip configuration when setting PVID
>       net/hns3: remove restriction on setting VF MTU
>       net/hns3: fix adding multicast MAC address
> 
> Chenmin Sun (1):
>       net/i40e: fix flow director Rx writeback packet
> 
> Ciara Loftus (1):
>       net/af_xdp: remove mempool freeing on umem destruction
> 
> David Marchand (7):
>       eal/windows: fix symbol export
>       eal: remove redundant newline in alert message
>       net/mlx5: remove redundant newline from logs
>       net/mvpp2: fix non-EAL thread support
>       devtools: fix path in forbidden token check
>       lib: remind experimental status in headers
>       net/bonding: fix socket ID check
> 
> Dekel Peled (2):
>       net/mlx5: fix VLAN pop with decap action validation
>       net/mlx5: fix VLAN push action on hairpin queue
> 
> Devendra Singh Rawat (1):
>       net/qede: fix multicast drop in promiscuous mode
> 
> Dong Zhou (1):
>       net/mlx5: fix LRO checksum
> 
> Dongyang Pan (1):
>       net/bonding: delete redundant code
> 
> Fady Bader (1):
>       meter: remove inline functions from export list
> 
> Feifei Wang (1):
>       test/ring: fix statistics in bulk enq/dequeue
> 
> Ferruh Yigit (4):
>       net/iavf: fix uninitialized variable
>       net/ixgbe/base: remove dead code
>       ethdev: fix log type for some error messages
>       drivers/net: fix exposing internal headers
> 
> Fiona Trahe (3):
>       common/qat: remove tail write coalescing
>       common/qat: move max inflights param into qp
>       common/qat: support dual threads for enqueue/dequeue
> 
> Gaurav Singh (1):
>       net/i40e: remove duplicate tunnel type check
> 
> Georgiy Levashov (1):
>       examples: add flush after stats printing
> 
> Gregory Etelson (1):
>       net/mlx5: fix tunnel flow priority
> 
> Guinan Sun (5):
>       net/ixgbe/base: fix host interface shadow RAM read
>       net/ixgbe/base: fix x550em 10G NIC link status
>       net/ixgbe/base: fix infinite recursion on PCIe link down
>       net/ixgbe: fix MAC control frame forward
>       net/ixgbe: fix flow control status
> 
> Haiyue Wang (6):
>       bus/pci: fix VF memory access
>       eal: fix uuid header dependencies
>       net/ice: fix TCP checksum offload
>       net/ice: calculate TCP header size for offload
>       net/ice: fix Tx hang with TSO
>       net/ice: revert fake TSO fixes
> 
> Hao Chen (1):
>       net/hns3: optimize default RSS algorithm
> 
> Harman Kalra (4):
>       eal/linux: fix epoll fd list rebuild for interrupts
>       net/octeontx2: fix DMAC filtering
>       common/octeontx2: fix crash on running procinfo
>       eal: fix parentheses in alignment macros
> 
> Harry van Haaren (1):
>       examples/eventdev: fix 32-bit coremask
> 
> Heinrich Kuhn (1):
>       net/nfp: fix RSS hash configuration reporting
> 
> Hemant Agrawal (1):
>       rawdev: remove remaining experimental tags
> 
> Hongbo Zheng (4):
>       net/hns3: ignore function return on reset error path
>       net/hns3: fix unintended sign extension in dump operation
>       net/hns3: clear residual hardware configurations on init
>       net/hns3: get link status change through mailbox
> 
> Hongzhi Guo (3):
>       net: fix IPv4 checksum
>       net: fix unneeded replacement of TCP checksum 0
>       net: fix checksum on big endian CPUs
> 
> Honnappa Nagarahalli (5):
>       eal/armv8: fix timer frequency calibration with PMU
>       app/testpmd: use clock time in throughput calculation
>       app/testpmd: fix burst percentage calculation
>       doc: fix some typos in Linux guide
>       test/hash: move lock-free tests to perf tests
> 
> Hrvoje Habjanic (1):
>       sched: fix subport freeing
> 
> Ian Dolzhansky (1):
>       net/failsafe: fix RSS RETA size info
> 
> Igor Romanov (1):
>       service: fix lcore iteration
> 
> Jecky Pei (1):
>       net/kni: set packet input port in Rx
> 
> Jeff Guo (1):
>       net/e1000: fix crash on Tx done clean up
> 
> Junfeng Guo (2):
>       net/ice/base: fix RSS removal for GTP-U
>       net/ice/base: fix memory leak on GTPU RSS
> 
> Junyu Jiang (2):
>       net/iavf: fix RSS RETA after restart
>       net/ice: fix bytes statistics
> 
> Kalesh AP (5):
>       net/bnxt: remove unused enum declaration
>       net/bnxt: fix unnecessary HWRM command
>       net/bnxt: fix flow error on filter creation
>       net/bnxt: fix freeing filters on flow creation failure
>       net/bnxt: fix logical AND in if condition
> 
> Kevin Traynor (1):
>       vhost: remove zero-copy and client mode restriction
> 
> Konstantin Ananyev (2):
>       test/bpf: fix few small issues
>       bpf: fix add/sub min/max estimations
> 
> Levend Sayar (1):
>       service: fix C++ linkage
> 
> Lijun Ou (5):
>       net/hns3: add RSS hash offload to Rx configuration
>       net/hns3: fix key length when configuring RSS
>       net/hns3: fix RSS configuration on empty RSS type
>       net/hns3: remove unnecessary branch
>       app/testpmd: remove hardcoded descriptors limit
> 
> Long Li (3):
>       bus/vmbus: fix ring buffer mapping
>       net/netvsc: fix underflow when Rx external mbuf
>       net/netvsc: fix chimney index
> 
> Lukasz Wojciechowski (1):
>       service: fix core mapping reset
> 
> Mao Jiang (2):
>       net/i40e: fix binding interrupt without MSI-X vector
>       net/i40e: fix flow director MSI-X resource allocation
> 
> Matan Azrad (1):
>       vhost: fix features definition location
> 
> Maxime Coquelin (3):
>       bus/dpaa: fix iterating on a class type
>       bus/fslmc: fix iterating on a class type
>       vhost: fix virtio ready flag check
> 
> Michael Baum (11):
>       net/mlx5: remove needless Tx queue initialization check
>       net/mlx5: fix unreachable MPLS error path
>       common/mlx5: fix code arrangement in tag allocation
>       net/mlx5: fix iterator type in Rx queue management
>       net/mlx5: fix initialization of steering registers
>       net/mlx5: fix crash in NVGRE item translation
>       net/mlx5: remove ineffective increment in hairpin split
>       net/mlx4: optimize stack memory size in probe
>       net/mlx5: fix unnecessary init in mark conversion
>       net/mlx5: fix hairpin Tx queue creation error flow
>       net/mlx5: fix hairpin Rx queue creation error flow
> 
> Muhammad Bilal (1):
>       bus/vdev: fix a typo in doxygen comment
> 
> Nipun Gupta (2):
>       bus/fslmc: fix getting FD error
>       net/dpaa: fix FD offset data type
> 
> Pablo de Lara (1):
>       drivers/crypto: add missing OOP feature flag
> 
> Parav Pandit (1):
>       common/mlx5: fix void parameters in glue wrappers
> 
> Patrick Fu (1):
>       vhost: fix double-free with zero-copy
> 
> Pavan Nikhilesh (2):
>       event/octeontx2: fix device reconfigure
>       event/octeontx2: fix sub event type
> 
> Pavel Ivashchenko (1):
>       net/i40e: fix getting EEPROM information
> 
> Phil Yang (5):
>       eventdev: fix race condition on timer list counter
>       eventdev: use C11 atomics for lcore timer armed flag
>       eventdev: remove redundant reset on timer cancel
>       eventdev: relax SMP barriers with C11 atomics
>       app/testpmd: fix CPU cycles per packet stats on Tx modes
> 
> Qi Zhang (7):
>       net/ice/base: fix return value
>       net/ice/base: fix memory leak on error path
>       net/ice/base: fix reference count on VSI list update
>       net/ice/base: fix initializing resource for field vector
>       net/ice/base: fix VSI ID mask to 10 bits
>       net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
>       net/ice/base: fix RSS interference
> 
> Rahul Gupta (1):
>       net/bnxt: fix performance for Arm
> 
> Rahul Lakkireddy (3):
>       net/cxgbe: fix CLIP leak in filter error path
>       net/cxgbe: fix double MPS alloc by flow validate and create
>       net/cxgbe: fix L2T leak in filter error and free path
> 
> Raslan Darawsheh (3):
>       net: fix pedantic build
>       net/mlx5: fix flow items size calculation
>       net/mlx5: fix VF MAC address set over BlueField
> 
> Ruifeng Wang (8):
>       net/i40e: enable NEON Rx/Tx in meson
>       eal/arm: add vcopyq intrinsic for aarch32
>       net/ixgbe: fix include of vector header file
>       test: allow no-huge mode for fast-tests
>       test/cycles: restore default delay callback
>       crypto/armv8: remove debug option
>       crypto/armv8: use dedicated log type
>       net/i40e: support aarch32
> 
> Sarosh Arif (3):
>       doc: fix typo in bbdev test guide
>       examples/packet_ordering: use proper exit method
>       doc: fix ethtool app path
> 
> Shougang Wang (2):
>       net/ice: fix error log in generic flow
>       net/i40e: fix filter pctype
> 
> Shy Shyman (3):
>       app/testpmd: fix error detection in MTU command
>       net/mlx5: fix flow META item validation
>       net/mlx5: fix HW counters path in switchdev mode
> 
> Stephen Hemminger (8):
>       net/netvsc: fix warning when VF is removed
>       net/netvsc: do not query VF link state
>       net/netvsc: do not spin forever waiting for reply
>       eal: fix lcore accessors for non-EAL threads
>       cfgfile: fix stack buffer underflow
>       rib: add C++ include guard
>       kni: fix reference to master/slave process
>       doc: fix reference to master process
> 
> Suanming Mou (3):
>       net/mlx5: fix secondary process resources release
>       net/mlx5: fix interrupt installation timing
>       net/mlx5: fix counter query
> 
> Tal Shnaiderman (2):
>       build: fix drivers library path on Windows
>       pci: fix address domain format size
> 
> Thomas Monjalon (1):
>       doc: update build instructions in the Linux guide
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix SPI transaction
>       raw/ifpga/base: fix NIOS SPI init
> 
> Timothy Redaelli (1):
>       test: fix rpath for drivers with meson
> 
> Viacheslav Ovsiienko (3):
>       net/mlx5: fix UAR lock sharing for multiport devices
>       common/mlx5: fix queue doorbell record size
>       net/mlx5: fix metadata storing for NEON Rx
> 
> Vladimir Medvedkin (1):
>       doc: add RIB and FIB into the API index
> 
> Wei Hu (Xavier) (12):
>       net/hns3: fix Tx less than 60 bytes
>       net/hns3: fix VLAN tags reported in Rx
>       app/testpmd: fix stats error message
>       net/hns3: fix flow director error message
>       net/hns3: fix unintended sign extension in fd operation
>       net/hns3: fix Rx buffer size
>       net/hns3: check multi-process action register result
>       ethdev: fix data room size verification in Rx queue setup
>       ethdev: fix VLAN offloads set if no relative capabilities
>       net/bonding: fix error code on device creation
>       net/bonding: fix MAC address when switching active port
>       net/bonding: fix MAC address when one port resets
> 
> Wei Zhao (4):
>       net/ice: fix switch action number check
>       net/ixgbe: report 10Mbps link speed for x553
>       net/ice: add input set byte number check
>       net/i40e: enable QinQ stripping
> 
> Weifeng Li (1):
>       net/bonding: change state machine to defaulted
> 
> Xiao Wang (1):
>       net/virtio-user: fix status management
> 
> Xiaolong Ye (6):
>       mbuf: remove unused next member in dynamic flag/field
>       test/mbuf: fix a dynamic flag log
>       mbuf: fix boundary check at dynamic field registration
>       mbuf: fix error code in dynamic field/flag registration
>       mbuf: fix free space update for dynamic field
>       mbuf: fix dynamic field dump log
> 
> Xiaoyun Wang (5):
>       net/hinic/base: check output of management sync channel
>       net/hinic/base: remove unused function parameters
>       net/hinic: fix setting promiscuous mode
>       net/hinic: optimize Rx performance for x86
>       net/hinic/base: avoid system time jump
> 
> Yicai Lu (1):
>       net/bonding: fix LACP negotiation
> 
> Yunjian Wang (12):
>       app/testpmd: fix memory leak on error path
>       vfio: remove unused variable
>       net/af_packet: fix check of file descriptors
>       net/af_packet: fix memory leak on init failure
>       net/af_packet: fix munmap on init failure
>       bus/fslmc: fix memory leak in secondary process
>       hash: fix out-of-memory handling in hash creation
>       event/dpaa: remove dead code
>       net/qede: remove dead code
>       net/hinic: check memory allocations in flow creation
>       net/ice: fix memory leak when releasing VSI
>       net/ice: add memory allocation check in RSS init
> 
> Zhiguang He (1):
>       net/bonding: fix dead loop on RSS RETA update
> 
> Zhihong Peng (2):
>       net/i40e: report VLAN filter capability
>       net/e1000: report VLAN extend capability
> 
> Zhike Wang (1):
>       mempool: fix allocation in memzone during retry

Re: [dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Fri, 2020-08-28 at 14:34 +0000, Govindharajan, Hariprasad wrote:
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> > Sent: Tuesday, August 18, 2020 7:12 PM
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> > Walker, Benjamin <benjamin.walker@intel.com>; David Christensen
> > <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> > Stokes, Ian <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>;
> > Mcnamara, John <john.mcnamara@intel.com>; Ju-Hyoung Lee
> > <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Pei Zhang
> > <pezhang@redhat.com>; Yu, PingX <pingx.yu@intel.com>; Xu, Qian Q
> > <qian.q.xu@intel.com>; Raslan Darawsheh <rasland@mellanox.com>;
> > Thomas Monjalon <thomas@monjalon.net>; Peng, Yuan
> > <yuan.peng@intel.com>; Chen, Zhaoyan <zhaoyan.chen@intel.com>
> > Subject: [dpdk-dev] 19.11.4 patches review and test
> > 
> > Hi all,
> > 
> > Here is a list of patches targeted for stable release 19.11.4.
> > 
> > The planned date for the final release is August 31st.
> > 
> > Please help with testing and validation of your use cases and report any
> > issues/results with reply-all to this mail. For the final release the fixes and
> > reported validations will be added to the release notes.
> > 
> > A release candidate tarball can be found at:
> > 
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > 
> > These patches are located at branch 19.11 of dpdk-stable repo:
> >     https://dpdk.org/browse/dpdk-stable/
> > 
> > Thanks.
> > 
> > Luca Boccassi
> 
> [Govindharajan, Hariprasad]  hi Luca,
> The DPDK-19.11.4-RC1 release was tested with OvS 2.13 and master versions for the following devices:
> ICE
> i40e
> ixgbe 
> vHost user client
> with the following tests:
> 1)	Performance tests
> 2)	vHost zero-copy
> 3)	Flow control
> 4)	RSS
> 5)	Partial HW offloading
> 
> From the validation side, no issues were seen.
> 
> Regards,
> G Hariprasad

Thank you!

> > ---
> > Adam Dybkowski (7):
> >       test/crypto: fix asymmetric session mempool creation
> >       crypto/qat: fix AES-XTS capabilities
> >       crypto/qat: handle mixed hash-cipher requests on GEN3
> >       test/crypto: add mixed encypted-digest
> >       common/qat: get firmware version
> >       crypto/qat: handle mixed hash-cipher on GEN2
> >       common/qat: fix uninitialized variable
> > 
> > Akhil Goyal (4):
> >       crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
> >       crypto/dpaax_sec: fix inline query for descriptors
> >       crypto/dpaa2_sec: fix HFN override
> >       common/dpaax: fix 12-bit null auth case
> > 
> > Alan Dewar (1):
> >       sched: fix port time rounding
> > 
> > Alexander Kozyrev (3):
> >       net/mlx5: fix vectorized Rx burst termination
> >       net/mlx5: do not select legacy MPW implicitly
> >       net/mlx5: fix descriptors number adjustment
> > 
> > Ali Alnubani (2):
> >       net/mlx5: fix typos in meter error messages
> >       doc: fix a typo in mlx5 guide
> > 
> > Alvin Zhang (1):
> >       net/i40e: fix queue pairs configuration in VF
> > 
> > Andrew Rybchenko (1):
> >       net/sfc: do not enforce hash offload in RSS multi-queue
> > 
> > Ankur Dwivedi (2):
> >       common/cpt: fix encryption offset
> >       test/crypto: change cipher offset for ESN vector
> > 
> > Apeksha Gupta (2):
> >       app/eventdev: fix capability check in pipeline ATQ test
> >       event/dpaa2: add all-types queue capability flag
> > 
> > Archana Muniganti (2):
> >       examples/fips_validation: fix TDES interim callback
> >       examples/fips_validation: fix count overwrite for TDES
> > 
> > Archit Pandey (1):
> >       sched: fix 64-bit rate
> > 
> > Arek Kusztal (4):
> >       drivers/qat: improve multi process on qat
> >       drivers/qat: add multi process handling of driver id
> >       drivers/qat: add handling of capabilities in multi process
> >       crypto/qat: add minimum enq threshold
> > 
> > Ayuj Verma (1):
> >       examples/fips_validation: fix parsing of TDES vectors
> > 
> > Bruce Richardson (12):
> >       test: fix build with ring PMD but no bond PMD
> >       mem: fix 32-bit init config with meson
> >       rawdev: allow getting info for unknown device
> >       rawdev: fill NUMA socket ID in info
> >       rawdev: export dump function in map file
> >       doc: rebuild with meson whenever a file changes
> >       build: always link whole DPDK static libraries
> >       devtools: test static linkage with pkg-config
> >       build/pkg-config: move pkg-config file creation
> >       build/pkg-config: output drivers first for static build
> >       build/pkg-config: improve static linking flags
> >       build/pkg-config: prevent overlinking
> > 
> > Chas Williams (1):
> >       net/netvsc: fix crash during Tx
> > 
> > Chenbo Xia (1):
> >       net/virtio-user: check tap system call setting
> > 
> > Chengchang Tang (5):
> >       net/hns3: clear promiscuous on PF uninit
> >       net/hns3: remove unsupported VLAN capabilities
> >       net/hns3: fix VLAN strip configuration when setting PVID
> >       net/hns3: remove restriction on setting VF MTU
> >       net/hns3: fix adding multicast MAC address
> > 
> > Chenmin Sun (1):
> >       net/i40e: fix flow director Rx writeback packet
> > 
> > Ciara Loftus (1):
> >       net/af_xdp: remove mempool freeing on umem destruction
> > 
> > David Marchand (7):
> >       eal/windows: fix symbol export
> >       eal: remove redundant newline in alert message
> >       net/mlx5: remove redundant newline from logs
> >       net/mvpp2: fix non-EAL thread support
> >       devtools: fix path in forbidden token check
> >       lib: remind experimental status in headers
> >       net/bonding: fix socket ID check
> > 
> > Dekel Peled (2):
> >       net/mlx5: fix VLAN pop with decap action validation
> >       net/mlx5: fix VLAN push action on hairpin queue
> > 
> > Devendra Singh Rawat (1):
> >       net/qede: fix multicast drop in promiscuous mode
> > 
> > Dong Zhou (1):
> >       net/mlx5: fix LRO checksum
> > 
> > Dongyang Pan (1):
> >       net/bonding: delete redundant code
> > 
> > Fady Bader (1):
> >       meter: remove inline functions from export list
> > 
> > Feifei Wang (1):
> >       test/ring: fix statistics in bulk enq/dequeue
> > 
> > Ferruh Yigit (4):
> >       net/iavf: fix uninitialized variable
> >       net/ixgbe/base: remove dead code
> >       ethdev: fix log type for some error messages
> >       drivers/net: fix exposing internal headers
> > 
> > Fiona Trahe (3):
> >       common/qat: remove tail write coalescing
> >       common/qat: move max inflights param into qp
> >       common/qat: support dual threads for enqueue/dequeue
> > 
> > Gaurav Singh (1):
> >       net/i40e: remove duplicate tunnel type check
> > 
> > Georgiy Levashov (1):
> >       examples: add flush after stats printing
> > 
> > Gregory Etelson (1):
> >       net/mlx5: fix tunnel flow priority
> > 
> > Guinan Sun (5):
> >       net/ixgbe/base: fix host interface shadow RAM read
> >       net/ixgbe/base: fix x550em 10G NIC link status
> >       net/ixgbe/base: fix infinite recursion on PCIe link down
> >       net/ixgbe: fix MAC control frame forward
> >       net/ixgbe: fix flow control status
> > 
> > Haiyue Wang (6):
> >       bus/pci: fix VF memory access
> >       eal: fix uuid header dependencies
> >       net/ice: fix TCP checksum offload
> >       net/ice: calculate TCP header size for offload
> >       net/ice: fix Tx hang with TSO
> >       net/ice: revert fake TSO fixes
> > 
> > Hao Chen (1):
> >       net/hns3: optimize default RSS algorithm
> > 
> > Harman Kalra (4):
> >       eal/linux: fix epoll fd list rebuild for interrupts
> >       net/octeontx2: fix DMAC filtering
> >       common/octeontx2: fix crash on running procinfo
> >       eal: fix parentheses in alignment macros
> > 
> > Harry van Haaren (1):
> >       examples/eventdev: fix 32-bit coremask
> > 
> > Heinrich Kuhn (1):
> >       net/nfp: fix RSS hash configuration reporting
> > 
> > Hemant Agrawal (1):
> >       rawdev: remove remaining experimental tags
> > 
> > Hongbo Zheng (4):
> >       net/hns3: ignore function return on reset error path
> >       net/hns3: fix unintended sign extension in dump operation
> >       net/hns3: clear residual hardware configurations on init
> >       net/hns3: get link status change through mailbox
> > 
> > Hongzhi Guo (3):
> >       net: fix IPv4 checksum
> >       net: fix unneeded replacement of TCP checksum 0
> >       net: fix checksum on big endian CPUs
> > 
> > Honnappa Nagarahalli (5):
> >       eal/armv8: fix timer frequency calibration with PMU
> >       app/testpmd: use clock time in throughput calculation
> >       app/testpmd: fix burst percentage calculation
> >       doc: fix some typos in Linux guide
> >       test/hash: move lock-free tests to perf tests
> > 
> > Hrvoje Habjanic (1):
> >       sched: fix subport freeing
> > 
> > Ian Dolzhansky (1):
> >       net/failsafe: fix RSS RETA size info
> > 
> > Igor Romanov (1):
> >       service: fix lcore iteration
> > 
> > Jecky Pei (1):
> >       net/kni: set packet input port in Rx
> > 
> > Jeff Guo (1):
> >       net/e1000: fix crash on Tx done clean up
> > 
> > Junfeng Guo (2):
> >       net/ice/base: fix RSS removal for GTP-U
> >       net/ice/base: fix memory leak on GTPU RSS
> > 
> > Junyu Jiang (2):
> >       net/iavf: fix RSS RETA after restart
> >       net/ice: fix bytes statistics
> > 
> > Kalesh AP (5):
> >       net/bnxt: remove unused enum declaration
> >       net/bnxt: fix unnecessary HWRM command
> >       net/bnxt: fix flow error on filter creation
> >       net/bnxt: fix freeing filters on flow creation failure
> >       net/bnxt: fix logical AND in if condition
> > 
> > Kevin Traynor (1):
> >       vhost: remove zero-copy and client mode restriction
> > 
> > Konstantin Ananyev (2):
> >       test/bpf: fix few small issues
> >       bpf: fix add/sub min/max estimations
> > 
> > Levend Sayar (1):
> >       service: fix C++ linkage
> > 
> > Lijun Ou (5):
> >       net/hns3: add RSS hash offload to Rx configuration
> >       net/hns3: fix key length when configuring RSS
> >       net/hns3: fix RSS configuration on empty RSS type
> >       net/hns3: remove unnecessary branch
> >       app/testpmd: remove hardcoded descriptors limit
> > 
> > Long Li (3):
> >       bus/vmbus: fix ring buffer mapping
> >       net/netvsc: fix underflow when Rx external mbuf
> >       net/netvsc: fix chimney index
> > 
> > Lukasz Wojciechowski (1):
> >       service: fix core mapping reset
> > 
> > Mao Jiang (2):
> >       net/i40e: fix binding interrupt without MSI-X vector
> >       net/i40e: fix flow director MSI-X resource allocation
> > 
> > Matan Azrad (1):
> >       vhost: fix features definition location
> > 
> > Maxime Coquelin (3):
> >       bus/dpaa: fix iterating on a class type
> >       bus/fslmc: fix iterating on a class type
> >       vhost: fix virtio ready flag check
> > 
> > Michael Baum (11):
> >       net/mlx5: remove needless Tx queue initialization check
> >       net/mlx5: fix unreachable MPLS error path
> >       common/mlx5: fix code arrangement in tag allocation
> >       net/mlx5: fix iterator type in Rx queue management
> >       net/mlx5: fix initialization of steering registers
> >       net/mlx5: fix crash in NVGRE item translation
> >       net/mlx5: remove ineffective increment in hairpin split
> >       net/mlx4: optimize stack memory size in probe
> >       net/mlx5: fix unnecessary init in mark conversion
> >       net/mlx5: fix hairpin Tx queue creation error flow
> >       net/mlx5: fix hairpin Rx queue creation error flow
> > 
> > Muhammad Bilal (1):
> >       bus/vdev: fix a typo in doxygen comment
> > 
> > Nipun Gupta (2):
> >       bus/fslmc: fix getting FD error
> >       net/dpaa: fix FD offset data type
> > 
> > Pablo de Lara (1):
> >       drivers/crypto: add missing OOP feature flag
> > 
> > Parav Pandit (1):
> >       common/mlx5: fix void parameters in glue wrappers
> > 
> > Patrick Fu (1):
> >       vhost: fix double-free with zero-copy
> > 
> > Pavan Nikhilesh (2):
> >       event/octeontx2: fix device reconfigure
> >       event/octeontx2: fix sub event type
> > 
> > Pavel Ivashchenko (1):
> >       net/i40e: fix getting EEPROM information
> > 
> > Phil Yang (5):
> >       eventdev: fix race condition on timer list counter
> >       eventdev: use C11 atomics for lcore timer armed flag
> >       eventdev: remove redundant reset on timer cancel
> >       eventdev: relax SMP barriers with C11 atomics
> >       app/testpmd: fix CPU cycles per packet stats on Tx modes
> > 
> > Qi Zhang (7):
> >       net/ice/base: fix return value
> >       net/ice/base: fix memory leak on error path
> >       net/ice/base: fix reference count on VSI list update
> >       net/ice/base: fix initializing resource for field vector
> >       net/ice/base: fix VSI ID mask to 10 bits
> >       net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
> >       net/ice/base: fix RSS interference
> > 
> > Rahul Gupta (1):
> >       net/bnxt: fix performance for Arm
> > 
> > Rahul Lakkireddy (3):
> >       net/cxgbe: fix CLIP leak in filter error path
> >       net/cxgbe: fix double MPS alloc by flow validate and create
> >       net/cxgbe: fix L2T leak in filter error and free path
> > 
> > Raslan Darawsheh (3):
> >       net: fix pedantic build
> >       net/mlx5: fix flow items size calculation
> >       net/mlx5: fix VF MAC address set over BlueField
> > 
> > Ruifeng Wang (8):
> >       net/i40e: enable NEON Rx/Tx in meson
> >       eal/arm: add vcopyq intrinsic for aarch32
> >       net/ixgbe: fix include of vector header file
> >       test: allow no-huge mode for fast-tests
> >       test/cycles: restore default delay callback
> >       crypto/armv8: remove debug option
> >       crypto/armv8: use dedicated log type
> >       net/i40e: support aarch32
> > 
> > Sarosh Arif (3):
> >       doc: fix typo in bbdev test guide
> >       examples/packet_ordering: use proper exit method
> >       doc: fix ethtool app path
> > 
> > Shougang Wang (2):
> >       net/ice: fix error log in generic flow
> >       net/i40e: fix filter pctype
> > 
> > Shy Shyman (3):
> >       app/testpmd: fix error detection in MTU command
> >       net/mlx5: fix flow META item validation
> >       net/mlx5: fix HW counters path in switchdev mode
> > 
> > Stephen Hemminger (8):
> >       net/netvsc: fix warning when VF is removed
> >       net/netvsc: do not query VF link state
> >       net/netvsc: do not spin forever waiting for reply
> >       eal: fix lcore accessors for non-EAL threads
> >       cfgfile: fix stack buffer underflow
> >       rib: add C++ include guard
> >       kni: fix reference to master/slave process
> >       doc: fix reference to master process
> > 
> > Suanming Mou (3):
> >       net/mlx5: fix secondary process resources release
> >       net/mlx5: fix interrupt installation timing
> >       net/mlx5: fix counter query
> > 
> > Tal Shnaiderman (2):
> >       build: fix drivers library path on Windows
> >       pci: fix address domain format size
> > 
> > Thomas Monjalon (1):
> >       doc: update build instructions in the Linux guide
> > 
> > Tianfei Zhang (2):
> >       raw/ifpga/base: fix SPI transaction
> >       raw/ifpga/base: fix NIOS SPI init
> > 
> > Timothy Redaelli (1):
> >       test: fix rpath for drivers with meson
> > 
> > Viacheslav Ovsiienko (3):
> >       net/mlx5: fix UAR lock sharing for multiport devices
> >       common/mlx5: fix queue doorbell record size
> >       net/mlx5: fix metadata storing for NEON Rx
> > 
> > Vladimir Medvedkin (1):
> >       doc: add RIB and FIB into the API index
> > 
> > Wei Hu (Xavier) (12):
> >       net/hns3: fix Tx less than 60 bytes
> >       net/hns3: fix VLAN tags reported in Rx
> >       app/testpmd: fix stats error message
> >       net/hns3: fix flow director error message
> >       net/hns3: fix unintended sign extension in fd operation
> >       net/hns3: fix Rx buffer size
> >       net/hns3: check multi-process action register result
> >       ethdev: fix data room size verification in Rx queue setup
> >       ethdev: fix VLAN offloads set if no relative capabilities
> >       net/bonding: fix error code on device creation
> >       net/bonding: fix MAC address when switching active port
> >       net/bonding: fix MAC address when one port resets
> > 
> > Wei Zhao (4):
> >       net/ice: fix switch action number check
> >       net/ixgbe: report 10Mbps link speed for x553
> >       net/ice: add input set byte number check
> >       net/i40e: enable QinQ stripping
> > 
> > Weifeng Li (1):
> >       net/bonding: change state machine to defaulted
> > 
> > Xiao Wang (1):
> >       net/virtio-user: fix status management
> > 
> > Xiaolong Ye (6):
> >       mbuf: remove unused next member in dynamic flag/field
> >       test/mbuf: fix a dynamic flag log
> >       mbuf: fix boundary check at dynamic field registration
> >       mbuf: fix error code in dynamic field/flag registration
> >       mbuf: fix free space update for dynamic field
> >       mbuf: fix dynamic field dump log
> > 
> > Xiaoyun Wang (5):
> >       net/hinic/base: check output of management sync channel
> >       net/hinic/base: remove unused function parameters
> >       net/hinic: fix setting promiscuous mode
> >       net/hinic: optimize Rx performance for x86
> >       net/hinic/base: avoid system time jump
> > 
> > Yicai Lu (1):
> >       net/bonding: fix LACP negotiation
> > 
> > Yunjian Wang (12):
> >       app/testpmd: fix memory leak on error path
> >       vfio: remove unused variable
> >       net/af_packet: fix check of file descriptors
> >       net/af_packet: fix memory leak on init failure
> >       net/af_packet: fix munmap on init failure
> >       bus/fslmc: fix memory leak in secondary process
> >       hash: fix out-of-memory handling in hash creation
> >       event/dpaa: remove dead code
> >       net/qede: remove dead code
> >       net/hinic: check memory allocations in flow creation
> >       net/ice: fix memory leak when releasing VSI
> >       net/ice: add memory allocation check in RSS init
> > 
> > Zhiguang He (1):
> >       net/bonding: fix dead loop on RSS RETA update
> > 
> > Zhihong Peng (2):
> >       net/i40e: report VLAN filter capability
> >       net/e1000: report VLAN extend capability
> > 
> > Zhike Wang (1):
> >       mempool: fix allocation in memzone during retry

Re: [dpdk-dev] 19.11.4 patches review and test

[Ali Alnubani]

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> Sent: Tuesday, August 18, 2020 9:12 PM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
> <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
> <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
> Kevin Traynor <ktraynor@redhat.com>; Pei Zhang <pezhang@redhat.com>;
> pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh
> <rasland@mellanox.com>; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: [dpdk-dev] 19.11.4 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 19.11.4.
> 
> The planned date for the final release is August 31st.
> 
> Please help with testing and validation of your use cases and report any
> issues/results with reply-all to this mail. For the final release the fixes and
> reported validations will be added to the release notes.
> 

The following covers the functional tests that we ran on Mellanox hardware for this release:
- Basic functionality:
  Send and receive multiple types of traffic.
- testpmd xstats counter test.
- testpmd timestamp test.
- Changing/checking link status through testpmd.
- RTE flow and flow_director tests.
  Items: eth / vlan / ipv4 / ipv6 / tcp / udp / icmp / gre / nvgre / vxlan / geneve / ip in ip / mplsoudp / mplsogre
  Actions: drop / queue / rss / mark / flag / jump / count / port_id / raw_encap / raw_decap / vxlan_encap / vxlan_decap / NAT / dec_ttl
- Some RSS tests.
- VLAN stripping and insertion tests.
- Checksum and TSO tests.
- ptype tests.
- l3fwd-power example application tests.
- Multi-process example applications tests.

Testing matrix:
- NIC: ConnectX-4 Lx / OS: RHEL7.4 / Driver: MLNX_OFED_LINUX-5.1-0.6.6.0 / Firmware: 14.28.1002
- NIC: ConnectX-5 / OS: RHEL7.4 / Driver: MLNX_OFED_LINUX-5.1-0.6.6.0 / Firmware: 16.28.1002

Compilation tests in the following OS/driver combinations are also passing:
- Ubuntu 20.04 with MLNX_OFED_LINUX-5.1-0.6.6.0.
- Ubuntu 20.04 with rdma-core v31.0.
- Ubuntu 20.04 with rdma-core v28.0.
- Ubuntu 18.04 with rdma-core v17.1.
- Ubuntu 18.04 with rdma-core v31.0 (i386).
- Ubuntu 16.04 with rdma-core v22.6.
- Fedora 32 with rdma-core v30.0.
- CentOS 7 7.8.2003 with rdma-core v31.0.
- CentOS 8 8.2.2004 with rdma-core v31.0.
- RHEL 7.5 with rdma-core v15.
- openSUSE Leap 15.2 with rdma-core v27.1.

We don't see any critical issues blocking the release.

Regards,
Ali

Re: [dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Sun, 2020-08-30 at 14:36 +0000, Ali Alnubani wrote:
> Hi,
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Luca Boccassi
> > Sent: Tuesday, August 18, 2020 9:12 PM
> > To: stable@dpdk.org
> > Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>;
> > Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>;
> > benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>;
> > Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes
> > <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara
> > <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>;
> > Kevin Traynor <ktraynor@redhat.com>; Pei Zhang <pezhang@redhat.com>;
> > pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh
> > <rasland@mellanox.com>; NBU-Contact-Thomas Monjalon
> > <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> > Subject: [dpdk-dev] 19.11.4 patches review and test
> > 
> > Hi all,
> > 
> > Here is a list of patches targeted for stable release 19.11.4.
> > 
> > The planned date for the final release is August 31st.
> > 
> > Please help with testing and validation of your use cases and report any
> > issues/results with reply-all to this mail. For the final release the fixes and
> > reported validations will be added to the release notes.
> > 
> 
> The following covers the functional tests that we ran on Mellanox hardware for this release:
> - Basic functionality:
>   Send and receive multiple types of traffic.
> - testpmd xstats counter test.
> - testpmd timestamp test.
> - Changing/checking link status through testpmd.
> - RTE flow and flow_director tests.
>   Items: eth / vlan / ipv4 / ipv6 / tcp / udp / icmp / gre / nvgre / vxlan / geneve / ip in ip / mplsoudp / mplsogre
>   Actions: drop / queue / rss / mark / flag / jump / count / port_id / raw_encap / raw_decap / vxlan_encap / vxlan_decap / NAT / dec_ttl
> - Some RSS tests.
> - VLAN stripping and insertion tests.
> - Checksum and TSO tests.
> - ptype tests.
> - l3fwd-power example application tests.
> - Multi-process example applications tests.
> 
> Testing matrix:
> - NIC: ConnectX-4 Lx / OS: RHEL7.4 / Driver: MLNX_OFED_LINUX-5.1-0.6.6.0 / Firmware: 14.28.1002
> - NIC: ConnectX-5 / OS: RHEL7.4 / Driver: MLNX_OFED_LINUX-5.1-0.6.6.0 / Firmware: 16.28.1002
> 
> Compilation tests in the following OS/driver combinations are also passing:
> - Ubuntu 20.04 with MLNX_OFED_LINUX-5.1-0.6.6.0.
> - Ubuntu 20.04 with rdma-core v31.0.
> - Ubuntu 20.04 with rdma-core v28.0.
> - Ubuntu 18.04 with rdma-core v17.1.
> - Ubuntu 18.04 with rdma-core v31.0 (i386).
> - Ubuntu 16.04 with rdma-core v22.6.
> - Fedora 32 with rdma-core v30.0.
> - CentOS 7 7.8.2003 with rdma-core v31.0.
> - CentOS 8 8.2.2004 with rdma-core v31.0.
> - RHEL 7.5 with rdma-core v15.
> - openSUSE Leap 15.2 with rdma-core v27.1.
> 
> We don't see any critical issues blocking the release.
> 
> Regards,
> Ali

Thank you!

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> Hi all,
> 
> Here is a list of patches targeted for stable release 19.11.4.
> 
> The planned date for the final release is August 31st.
> 
> Please help with testing and validation of your use cases and report
> any issues/results with reply-all to this mail. For the final release
> the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> 
> These patches are located at branch 19.11 of dpdk-stable repo:
>     https://dpdk.org/browse/dpdk-stable/
> 
> Thanks.
> 
> Luca Boccassi

Microsoft's regression tests are still running, delaying until Thursday
the 3rd. Apologies for any inconvenience.

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] 19.11.4 patches review and test

[Christian Ehrhardt]

On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi <bluca@debian.org> wrote:
>
> On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.4.
> >
> > The planned date for the final release is August 31st.
> >
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> >
> > These patches are located at branch 19.11 of dpdk-stable repo:
> >     https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
> >
> > Luca Boccassi
>
> Microsoft's regression tests are still running, delaying until Thursday
> the 3rd. Apologies for any inconvenience.

Due to report on OVS failing to build I happened to find that 19.11.4
has massively changed linking.
=> https://paste.ubuntu.com/p/znCRR4gpjP/

This was meant to be helpful for sure and I assume is around:
48f7fd27f6 build/pkg-config: prevent overlinking
2d1535d592 build/pkg-config: improve static linking flags
9fb13a12c1 build/pkg-config: output drivers first for static build
59b108d824 build/pkg-config: move pkg-config file creation
aea915e944 devtools: test static linkage with pkg-config

But overlinking has effectively become underlinking now
https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz

/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
in function `rte_eth_from_rings':
(.text+0x91c): undefined reference to `rte_vdev_init'
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
in function `vdrvinitfn_pmd_ring_drv':
(.text.startup+0x28): undefined reference to `rte_vdev_register'
collect2: error: ld returned 1 exit status

Also as you can see in the pastebin above, CFlags and Libs massively
shrunk and likely too much so.

Given that this should be a stable release I'd ask to back out those
changes so that a test build creates the same .pc file as before -
would that make sense?


> --
> Kind regards,
> Luca Boccassi



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [dpdk-dev] 19.11.4 patches review and test

[Bruce Richardson]

On Tue, Sep 01, 2020 at 02:32:26PM +0200, Christian Ehrhardt wrote:
> On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi <bluca@debian.org> wrote:
> >
> > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> > > Hi all,
> > >
> > > Here is a list of patches targeted for stable release 19.11.4.
> > >
> > > The planned date for the final release is August 31st.
> > >
> > > Please help with testing and validation of your use cases and report
> > > any issues/results with reply-all to this mail. For the final release
> > > the fixes and reported validations will be added to the release notes.
> > >
> > > A release candidate tarball can be found at:
> > >
> > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > >
> > > These patches are located at branch 19.11 of dpdk-stable repo:
> > >     https://dpdk.org/browse/dpdk-stable/
> > >
> > > Thanks.
> > >
> > > Luca Boccassi
> >
> > Microsoft's regression tests are still running, delaying until Thursday
> > the 3rd. Apologies for any inconvenience.
> 
> Due to report on OVS failing to build I happened to find that 19.11.4
> has massively changed linking.
> => https://paste.ubuntu.com/p/znCRR4gpjP/
> 
> This was meant to be helpful for sure and I assume is around:
> 48f7fd27f6 build/pkg-config: prevent overlinking
> 2d1535d592 build/pkg-config: improve static linking flags
> 9fb13a12c1 build/pkg-config: output drivers first for static build
> 59b108d824 build/pkg-config: move pkg-config file creation
> aea915e944 devtools: test static linkage with pkg-config
> 
> But overlinking has effectively become underlinking now
> https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz
> 
> /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> in function `rte_eth_from_rings':
> (.text+0x91c): undefined reference to `rte_vdev_init'
> /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> in function `vdrvinitfn_pmd_ring_drv':
> (.text.startup+0x28): undefined reference to `rte_vdev_register'
> collect2: error: ld returned 1 exit status
> 
> Also as you can see in the pastebin above, CFlags and Libs massively
> shrunk and likely too much so.
> 
> Given that this should be a stable release I'd ask to back out those
> changes so that a test build creates the same .pc file as before -
> would that make sense?
> 
> 
Adding some OVS folks on CC.

The request for backporting these actually came from the OVS side, since
they were deemed necessary to enable OVS to switch to use DPDK pkg-config
rather than the older approach using a makefile-based build. However, it
appears you guys were already building OVS using the pkg-config file, and
since this causes issues where there were none, backing it out seems a
prudent choice.

Ian, Sunil, any comments here.

Regards
/Bruce

Re: [dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Tue, 2020-09-01 at 14:32 +0200, Christian Ehrhardt wrote:
> On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi <bluca@debian.org> wrote:
> > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> > > Hi all,
> > > 
> > > Here is a list of patches targeted for stable release 19.11.4.
> > > 
> > > The planned date for the final release is August 31st.
> > > 
> > > Please help with testing and validation of your use cases and report
> > > any issues/results with reply-all to this mail. For the final release
> > > the fixes and reported validations will be added to the release notes.
> > > 
> > > A release candidate tarball can be found at:
> > > 
> > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > > 
> > > These patches are located at branch 19.11 of dpdk-stable repo:
> > >     https://dpdk.org/browse/dpdk-stable/
> > > 
> > > Thanks.
> > > 
> > > Luca Boccassi
> > 
> > Microsoft's regression tests are still running, delaying until Thursday
> > the 3rd. Apologies for any inconvenience.
> 
> Due to report on OVS failing to build I happened to find that 19.11.4
> has massively changed linking.
> => https://paste.ubuntu.com/p/znCRR4gpjP/
> 
> This was meant to be helpful for sure and I assume is around:
> 48f7fd27f6 build/pkg-config: prevent overlinking
> 2d1535d592 build/pkg-config: improve static linking flags
> 9fb13a12c1 build/pkg-config: output drivers first for static build
> 59b108d824 build/pkg-config: move pkg-config file creation
> aea915e944 devtools: test static linkage with pkg-config
> 
> But overlinking has effectively become underlinking now
> https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz
> 
> /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> in function `rte_eth_from_rings':
> (.text+0x91c): undefined reference to `rte_vdev_init'
> /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> in function `vdrvinitfn_pmd_ring_drv':
> (.text.startup+0x28): undefined reference to `rte_vdev_register'
> collect2: error: ld returned 1 exit status
> 
> Also as you can see in the pastebin above, CFlags and Libs massively
> shrunk and likely too much so.
> 
> Given that this should be a stable release I'd ask to back out those
> changes so that a test build creates the same .pc file as before -
> would that make sense?

Paging Bruce and Ian - IIRC OVS explicitly asked for that series to be
backported and took a dependency on it, so removing it might cause
breakages for them? Ian?

Bruce, have you see the error reported by Christian before?

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] 19.11.4 patches review and test

[Bruce Richardson]

On Tue, Sep 01, 2020 at 01:49:07PM +0100, Luca Boccassi wrote:
> On Tue, 2020-09-01 at 14:32 +0200, Christian Ehrhardt wrote:
> > On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi <bluca@debian.org> wrote:
> > > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> > > > Hi all,
> > > > 
> > > > Here is a list of patches targeted for stable release 19.11.4.
> > > > 
> > > > The planned date for the final release is August 31st.
> > > > 
> > > > Please help with testing and validation of your use cases and report
> > > > any issues/results with reply-all to this mail. For the final release
> > > > the fixes and reported validations will be added to the release notes.
> > > > 
> > > > A release candidate tarball can be found at:
> > > > 
> > > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > > > 
> > > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > >     https://dpdk.org/browse/dpdk-stable/
> > > > 
> > > > Thanks.
> > > > 
> > > > Luca Boccassi
> > > 
> > > Microsoft's regression tests are still running, delaying until Thursday
> > > the 3rd. Apologies for any inconvenience.
> > 
> > Due to report on OVS failing to build I happened to find that 19.11.4
> > has massively changed linking.
> > => https://paste.ubuntu.com/p/znCRR4gpjP/
> > 
> > This was meant to be helpful for sure and I assume is around:
> > 48f7fd27f6 build/pkg-config: prevent overlinking
> > 2d1535d592 build/pkg-config: improve static linking flags
> > 9fb13a12c1 build/pkg-config: output drivers first for static build
> > 59b108d824 build/pkg-config: move pkg-config file creation
> > aea915e944 devtools: test static linkage with pkg-config
> > 
> > But overlinking has effectively become underlinking now
> > https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz
> > 
> > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > in function `rte_eth_from_rings':
> > (.text+0x91c): undefined reference to `rte_vdev_init'
> > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > in function `vdrvinitfn_pmd_ring_drv':
> > (.text.startup+0x28): undefined reference to `rte_vdev_register'
> > collect2: error: ld returned 1 exit status
> > 
> > Also as you can see in the pastebin above, CFlags and Libs massively
> > shrunk and likely too much so.
> > 
> > Given that this should be a stable release I'd ask to back out those
> > changes so that a test build creates the same .pc file as before -
> > would that make sense?
> 
> Paging Bruce and Ian - IIRC OVS explicitly asked for that series to be
> backported and took a dependency on it, so removing it might cause
> breakages for them? Ian?
> 
> Bruce, have you see the error reported by Christian before?
> 
Nope, but I'll look into it...

Re: [dpdk-dev] 19.11.4 patches review and test

[Pai G, Sunil]

Hi,

Yes , OVS was using pkg-config even before these patches were rolled out.
But it always used to pick the DPDK shared libs by default for OVS even on using the -Bstatic/-Bshared flags.
These patches from Bruce simplify the process from DPDK side without having the user to specify them.
Moreover, with these patches , the problem of shared DPDK libs always being picked instead of static was not seen any more with a bit of changes from the OVS side as well.
http://patchwork.ozlabs.org/project/openvswitch/patch/20200707141126.71414-1-sunil.pai.g@intel.com/ .
The patches for ovs-master are ready as well and will them out soon.

Thanks and Regards,
Pai G, Sunil
Sunil

> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Tuesday, September 1, 2020 6:18 PM
> To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Cc: Luca Boccassi <bluca@debian.org>; stable@dpdk.org; dev <dev@dpdk.org>;
> Pai G, Sunil <sunil.pai.g@intel.com>; Stokes, Ian <ian.stokes@intel.com>
> Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> 
> On Tue, Sep 01, 2020 at 02:32:26PM +0200, Christian Ehrhardt wrote:
> > On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi <bluca@debian.org> wrote:
> > >
> > > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> > > > Hi all,
> > > >
> > > > Here is a list of patches targeted for stable release 19.11.4.
> > > >
> > > > The planned date for the final release is August 31st.
> > > >
> > > > Please help with testing and validation of your use cases and
> > > > report any issues/results with reply-all to this mail. For the
> > > > final release the fixes and reported validations will be added to the release
> notes.
> > > >
> > > > A release candidate tarball can be found at:
> > > >
> > > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > > >
> > > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > >     https://dpdk.org/browse/dpdk-stable/
> > > >
> > > > Thanks.
> > > >
> > > > Luca Boccassi
> > >
> > > Microsoft's regression tests are still running, delaying until
> > > Thursday the 3rd. Apologies for any inconvenience.
> >
> > Due to report on OVS failing to build I happened to find that 19.11.4
> > has massively changed linking.
> > => https://paste.ubuntu.com/p/znCRR4gpjP/
> >
> > This was meant to be helpful for sure and I assume is around:
> > 48f7fd27f6 build/pkg-config: prevent overlinking
> > 2d1535d592 build/pkg-config: improve static linking flags
> > 9fb13a12c1 build/pkg-config: output drivers first for static build
> > 59b108d824 build/pkg-config: move pkg-config file creation
> > aea915e944 devtools: test static linkage with pkg-config
> >
> > But overlinking has effectively become underlinking now
> > https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.
> > openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz
> >
> > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-
> gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > in function `rte_eth_from_rings':
> > (.text+0x91c): undefined reference to `rte_vdev_init'
> > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-
> gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > in function `vdrvinitfn_pmd_ring_drv':
> > (.text.startup+0x28): undefined reference to `rte_vdev_register'
> > collect2: error: ld returned 1 exit status
> >
> > Also as you can see in the pastebin above, CFlags and Libs massively
> > shrunk and likely too much so.
> >
> > Given that this should be a stable release I'd ask to back out those
> > changes so that a test build creates the same .pc file as before -
> > would that make sense?
> >
> >
> Adding some OVS folks on CC.
> 
> The request for backporting these actually came from the OVS side, since they
> were deemed necessary to enable OVS to switch to use DPDK pkg-config rather
> than the older approach using a makefile-based build. However, it appears you
> guys were already building OVS using the pkg-config file, and since this causes
> issues where there were none, backing it out seems a prudent choice.
> 
> Ian, Sunil, any comments here.
> 
> Regards
> /Bruce

Re: [dpdk-dev] 19.11.4 patches review and test

[Bruce Richardson]

On Tue, Sep 01, 2020 at 02:01:28PM +0100, Bruce Richardson wrote:
> On Tue, Sep 01, 2020 at 01:49:07PM +0100, Luca Boccassi wrote:
> > On Tue, 2020-09-01 at 14:32 +0200, Christian Ehrhardt wrote:
> > > On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi <bluca@debian.org> wrote:
> > > > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> > > > > Hi all,
> > > > > 
> > > > > Here is a list of patches targeted for stable release 19.11.4.
> > > > > 
> > > > > The planned date for the final release is August 31st.
> > > > > 
> > > > > Please help with testing and validation of your use cases and report
> > > > > any issues/results with reply-all to this mail. For the final release
> > > > > the fixes and reported validations will be added to the release notes.
> > > > > 
> > > > > A release candidate tarball can be found at:
> > > > > 
> > > > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > > > > 
> > > > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > > >     https://dpdk.org/browse/dpdk-stable/
> > > > > 
> > > > > Thanks.
> > > > > 
> > > > > Luca Boccassi
> > > > 
> > > > Microsoft's regression tests are still running, delaying until Thursday
> > > > the 3rd. Apologies for any inconvenience.
> > > 
> > > Due to report on OVS failing to build I happened to find that 19.11.4
> > > has massively changed linking.
> > > => https://paste.ubuntu.com/p/znCRR4gpjP/
> > > 
> > > This was meant to be helpful for sure and I assume is around:
> > > 48f7fd27f6 build/pkg-config: prevent overlinking
> > > 2d1535d592 build/pkg-config: improve static linking flags
> > > 9fb13a12c1 build/pkg-config: output drivers first for static build
> > > 59b108d824 build/pkg-config: move pkg-config file creation
> > > aea915e944 devtools: test static linkage with pkg-config
> > > 
> > > But overlinking has effectively become underlinking now
> > > https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz
> > > 
> > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > > in function `rte_eth_from_rings':
> > > (.text+0x91c): undefined reference to `rte_vdev_init'
> > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > > in function `vdrvinitfn_pmd_ring_drv':
> > > (.text.startup+0x28): undefined reference to `rte_vdev_register'
> > > collect2: error: ld returned 1 exit status
> > > 
> > > Also as you can see in the pastebin above, CFlags and Libs massively
> > > shrunk and likely too much so.
> > > 
> > > Given that this should be a stable release I'd ask to back out those
> > > changes so that a test build creates the same .pc file as before -
> > > would that make sense?
> > 
> > Paging Bruce and Ian - IIRC OVS explicitly asked for that series to be
> > backported and took a dependency on it, so removing it might cause
> > breakages for them? Ian?
> > 
> > Bruce, have you see the error reported by Christian before?
> > 
> Nope, but I'll look into it...

I suspect the error is caused by the presence of "-Wl,--no-whole-archive"
immediately after "-Wl,--whole-archive". Now, while the --whole-archive
flag comes from the libdpdk.pc file, I don't know where the
--no-whole-archive comes from to cancel it out. Perhaps someone familiar
with the OVS package build here could suggest a source.

Regards,
/Bruce

Re: [dpdk-dev] 19.11.4 patches review and test

[Stokes, Ian]

> Hi,
> 
> Yes , OVS was using pkg-config even before these patches were rolled out.
> But it always used to pick the DPDK shared libs by default for OVS even on using
> the -Bstatic/-Bshared flags.
> These patches from Bruce simplify the process from DPDK side without having
> the user to specify them.
> Moreover, with these patches , the problem of shared DPDK libs always being
> picked instead of static was not seen any more with a bit of changes from the
> OVS side as well.
> http://patchwork.ozlabs.org/project/openvswitch/patch/20200707141126.7141
> 4-1-sunil.pai.g@intel.com/ .
> The patches for ovs-master are ready as well and will them out soon.
> 
> Thanks and Regards,
> Pai G, Sunil
> Sunil

Hi Folks,

From the OVS side there was a question WRT why we couldn't use meson in our Travis tests to build DPDK for OVS supporting 19.11.x, in this case it was related to the changes described by Sunil above and hence why the backport was requested. 

It doesn't have a huge impact on OVS, we can still use 19.11.4 if the patches are removed, however I suspect these changes are also on DPDK main branch at this point and will be part of 20.11? So eventually when we move to 20.11 the same issues may be encountered, maybe that preferable if we are change LTS versions.

From the OVS side we can look to upstream meson support in the dpdk-latest branch and then integrate it when 20.11 is released, but it would be nice to support it before then if possible.

Regards
Ian
> 
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > Sent: Tuesday, September 1, 2020 6:18 PM
> > To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > Cc: Luca Boccassi <bluca@debian.org>; stable@dpdk.org; dev
> > <dev@dpdk.org>; Pai G, Sunil <sunil.pai.g@intel.com>; Stokes, Ian
> > <ian.stokes@intel.com>
> > Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> >
> > On Tue, Sep 01, 2020 at 02:32:26PM +0200, Christian Ehrhardt wrote:
> > > On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi <bluca@debian.org> wrote:
> > > >
> > > > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> > > > > Hi all,
> > > > >
> > > > > Here is a list of patches targeted for stable release 19.11.4.
> > > > >
> > > > > The planned date for the final release is August 31st.
> > > > >
> > > > > Please help with testing and validation of your use cases and
> > > > > report any issues/results with reply-all to this mail. For the
> > > > > final release the fixes and reported validations will be added
> > > > > to the release
> > notes.
> > > > >
> > > > > A release candidate tarball can be found at:
> > > > >
> > > > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > > > >
> > > > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > > >     https://dpdk.org/browse/dpdk-stable/
> > > > >
> > > > > Thanks.
> > > > >
> > > > > Luca Boccassi
> > > >
> > > > Microsoft's regression tests are still running, delaying until
> > > > Thursday the 3rd. Apologies for any inconvenience.
> > >
> > > Due to report on OVS failing to build I happened to find that
> > > 19.11.4 has massively changed linking.
> > > => https://paste.ubuntu.com/p/znCRR4gpjP/
> > >
> > > This was meant to be helpful for sure and I assume is around:
> > > 48f7fd27f6 build/pkg-config: prevent overlinking
> > > 2d1535d592 build/pkg-config: improve static linking flags
> > > 9fb13a12c1 build/pkg-config: output drivers first for static build
> > > 59b108d824 build/pkg-config: move pkg-config file creation
> > > aea915e944 devtools: test static linkage with pkg-config
> > >
> > > But overlinking has effectively become underlinking now
> > > https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.
> > > openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz
> > >
> > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-
> > gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > > in function `rte_eth_from_rings':
> > > (.text+0x91c): undefined reference to `rte_vdev_init'
> > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-
> > gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > > in function `vdrvinitfn_pmd_ring_drv':
> > > (.text.startup+0x28): undefined reference to `rte_vdev_register'
> > > collect2: error: ld returned 1 exit status
> > >
> > > Also as you can see in the pastebin above, CFlags and Libs massively
> > > shrunk and likely too much so.
> > >
> > > Given that this should be a stable release I'd ask to back out those
> > > changes so that a test build creates the same .pc file as before -
> > > would that make sense?
> > >
> > >
> > Adding some OVS folks on CC.
> >
> > The request for backporting these actually came from the OVS side,
> > since they were deemed necessary to enable OVS to switch to use DPDK
> > pkg-config rather than the older approach using a makefile-based
> > build. However, it appears you guys were already building OVS using
> > the pkg-config file, and since this causes issues where there were none,
> backing it out seems a prudent choice.
> >
> > Ian, Sunil, any comments here.
> >
> > Regards
> > /Bruce

Re: [dpdk-dev] [EXTERNAL] 19.11.4 patches review and test

[Abhishek Marathe]

Hi Luca,

We have tested 19.11.4 and no issues found except known issues.
1. Issue with CX-3/MLX-4 driver with ibquery_pkey() failed.
2. Issue with hot-removal of VF driver.
we are tracking both the issues.

Report:

DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-19.11.4-rc1.tar.gz&data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C13a3a60691b8456980f908d84d456776%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637344307771913541&sdata=8oLAs5j%2BrEF%2BPHMBM036ZgPf2nlooe25daKwXT2YVvs%3D&reserved=0 was validated on Azure for RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, Ubuntu 18.04, Ubuntu 16.04.
Tested with Mellanox and netvsc poll-mode drivers.
The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C13a3a60691b8456980f908d84d456776%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637344307771913541&sdata=GNF1xf97D2LxyLYJYmDa%2BRoWNqGfItD3D3OjVhp6HRA%3D&reserved=0).

Test case description:

* VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
* VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
* VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios

* PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
* PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
* PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2

* DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C13a3a60691b8456980f908d84d456776%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637344307771913541&sdata=znhtFXLZiKaadAJKKLghm9NWvdRUvYZx2xLtIf0r15A%3D&reserved=0
* VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20

* VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
* VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
* VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.

Ubuntu 16.04: Pass
Ubuntu 18.04: Pass
RHEL 7.5: Pass
CentOS 7.5: Pass

Regards,
Abhishek
-----Original Message-----
From: Luca Boccassi <bluca@debian.org> 
Sent: Tuesday, August 18, 2020 11:12 AM
To: stable@dpdk.org
Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
Subject: [EXTERNAL] 19.11.4 patches review and test

Hi all,

Here is a list of patches targeted for stable release 19.11.4.

The planned date for the final release is August 31st.

Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.

A release candidate tarball can be found at:

    https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv19.11.4-rc1&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C5f6c5d506f3d439b1d1a08d843a24469%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637333711526043405&amp;sdata=LkqDTW1b6u1Q0S4ZJvRGzhG4XL2PG%2FSmikz7jR6iurI%3D&amp;reserved=0

These patches are located at branch 19.11 of dpdk-stable repo:
    https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C5f6c5d506f3d439b1d1a08d843a24469%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637333711526053410&amp;sdata=nLx7HUHx412XMexrqfAaIxUzK7ko%2BAq8OKakVglimEQ%3D&amp;reserved=0

Thanks.

Luca Boccassi

---
Adam Dybkowski (7):
      test/crypto: fix asymmetric session mempool creation
      crypto/qat: fix AES-XTS capabilities
      crypto/qat: handle mixed hash-cipher requests on GEN3
      test/crypto: add mixed encypted-digest
      common/qat: get firmware version
      crypto/qat: handle mixed hash-cipher on GEN2
      common/qat: fix uninitialized variable

Akhil Goyal (4):
      crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
      crypto/dpaax_sec: fix inline query for descriptors
      crypto/dpaa2_sec: fix HFN override
      common/dpaax: fix 12-bit null auth case

Alan Dewar (1):
      sched: fix port time rounding

Alexander Kozyrev (3):
      net/mlx5: fix vectorized Rx burst termination
      net/mlx5: do not select legacy MPW implicitly
      net/mlx5: fix descriptors number adjustment

Ali Alnubani (2):
      net/mlx5: fix typos in meter error messages
      doc: fix a typo in mlx5 guide

Alvin Zhang (1):
      net/i40e: fix queue pairs configuration in VF

Andrew Rybchenko (1):
      net/sfc: do not enforce hash offload in RSS multi-queue

Ankur Dwivedi (2):
      common/cpt: fix encryption offset
      test/crypto: change cipher offset for ESN vector

Apeksha Gupta (2):
      app/eventdev: fix capability check in pipeline ATQ test
      event/dpaa2: add all-types queue capability flag

Archana Muniganti (2):
      examples/fips_validation: fix TDES interim callback
      examples/fips_validation: fix count overwrite for TDES

Archit Pandey (1):
      sched: fix 64-bit rate

Arek Kusztal (4):
      drivers/qat: improve multi process on qat
      drivers/qat: add multi process handling of driver id
      drivers/qat: add handling of capabilities in multi process
      crypto/qat: add minimum enq threshold

Ayuj Verma (1):
      examples/fips_validation: fix parsing of TDES vectors

Bruce Richardson (12):
      test: fix build with ring PMD but no bond PMD
      mem: fix 32-bit init config with meson
      rawdev: allow getting info for unknown device
      rawdev: fill NUMA socket ID in info
      rawdev: export dump function in map file
      doc: rebuild with meson whenever a file changes
      build: always link whole DPDK static libraries
      devtools: test static linkage with pkg-config
      build/pkg-config: move pkg-config file creation
      build/pkg-config: output drivers first for static build
      build/pkg-config: improve static linking flags
      build/pkg-config: prevent overlinking

Chas Williams (1):
      net/netvsc: fix crash during Tx

Chenbo Xia (1):
      net/virtio-user: check tap system call setting

Chengchang Tang (5):
      net/hns3: clear promiscuous on PF uninit
      net/hns3: remove unsupported VLAN capabilities
      net/hns3: fix VLAN strip configuration when setting PVID
      net/hns3: remove restriction on setting VF MTU
      net/hns3: fix adding multicast MAC address

Chenmin Sun (1):
      net/i40e: fix flow director Rx writeback packet

Ciara Loftus (1):
      net/af_xdp: remove mempool freeing on umem destruction

David Marchand (7):
      eal/windows: fix symbol export
      eal: remove redundant newline in alert message
      net/mlx5: remove redundant newline from logs
      net/mvpp2: fix non-EAL thread support
      devtools: fix path in forbidden token check
      lib: remind experimental status in headers
      net/bonding: fix socket ID check

Dekel Peled (2):
      net/mlx5: fix VLAN pop with decap action validation
      net/mlx5: fix VLAN push action on hairpin queue

Devendra Singh Rawat (1):
      net/qede: fix multicast drop in promiscuous mode

Dong Zhou (1):
      net/mlx5: fix LRO checksum

Dongyang Pan (1):
      net/bonding: delete redundant code

Fady Bader (1):
      meter: remove inline functions from export list

Feifei Wang (1):
      test/ring: fix statistics in bulk enq/dequeue

Ferruh Yigit (4):
      net/iavf: fix uninitialized variable
      net/ixgbe/base: remove dead code
      ethdev: fix log type for some error messages
      drivers/net: fix exposing internal headers

Fiona Trahe (3):
      common/qat: remove tail write coalescing
      common/qat: move max inflights param into qp
      common/qat: support dual threads for enqueue/dequeue

Gaurav Singh (1):
      net/i40e: remove duplicate tunnel type check

Georgiy Levashov (1):
      examples: add flush after stats printing

Gregory Etelson (1):
      net/mlx5: fix tunnel flow priority

Guinan Sun (5):
      net/ixgbe/base: fix host interface shadow RAM read
      net/ixgbe/base: fix x550em 10G NIC link status
      net/ixgbe/base: fix infinite recursion on PCIe link down
      net/ixgbe: fix MAC control frame forward
      net/ixgbe: fix flow control status

Haiyue Wang (6):
      bus/pci: fix VF memory access
      eal: fix uuid header dependencies
      net/ice: fix TCP checksum offload
      net/ice: calculate TCP header size for offload
      net/ice: fix Tx hang with TSO
      net/ice: revert fake TSO fixes

Hao Chen (1):
      net/hns3: optimize default RSS algorithm

Harman Kalra (4):
      eal/linux: fix epoll fd list rebuild for interrupts
      net/octeontx2: fix DMAC filtering
      common/octeontx2: fix crash on running procinfo
      eal: fix parentheses in alignment macros

Harry van Haaren (1):
      examples/eventdev: fix 32-bit coremask

Heinrich Kuhn (1):
      net/nfp: fix RSS hash configuration reporting

Hemant Agrawal (1):
      rawdev: remove remaining experimental tags

Hongbo Zheng (4):
      net/hns3: ignore function return on reset error path
      net/hns3: fix unintended sign extension in dump operation
      net/hns3: clear residual hardware configurations on init
      net/hns3: get link status change through mailbox

Hongzhi Guo (3):
      net: fix IPv4 checksum
      net: fix unneeded replacement of TCP checksum 0
      net: fix checksum on big endian CPUs

Honnappa Nagarahalli (5):
      eal/armv8: fix timer frequency calibration with PMU
      app/testpmd: use clock time in throughput calculation
      app/testpmd: fix burst percentage calculation
      doc: fix some typos in Linux guide
      test/hash: move lock-free tests to perf tests

Hrvoje Habjanic (1):
      sched: fix subport freeing

Ian Dolzhansky (1):
      net/failsafe: fix RSS RETA size info

Igor Romanov (1):
      service: fix lcore iteration

Jecky Pei (1):
      net/kni: set packet input port in Rx

Jeff Guo (1):
      net/e1000: fix crash on Tx done clean up

Junfeng Guo (2):
      net/ice/base: fix RSS removal for GTP-U
      net/ice/base: fix memory leak on GTPU RSS

Junyu Jiang (2):
      net/iavf: fix RSS RETA after restart
      net/ice: fix bytes statistics

Kalesh AP (5):
      net/bnxt: remove unused enum declaration
      net/bnxt: fix unnecessary HWRM command
      net/bnxt: fix flow error on filter creation
      net/bnxt: fix freeing filters on flow creation failure
      net/bnxt: fix logical AND in if condition

Kevin Traynor (1):
      vhost: remove zero-copy and client mode restriction

Konstantin Ananyev (2):
      test/bpf: fix few small issues
      bpf: fix add/sub min/max estimations

Levend Sayar (1):
      service: fix C++ linkage

Lijun Ou (5):
      net/hns3: add RSS hash offload to Rx configuration
      net/hns3: fix key length when configuring RSS
      net/hns3: fix RSS configuration on empty RSS type
      net/hns3: remove unnecessary branch
      app/testpmd: remove hardcoded descriptors limit

Long Li (3):
      bus/vmbus: fix ring buffer mapping
      net/netvsc: fix underflow when Rx external mbuf
      net/netvsc: fix chimney index

Lukasz Wojciechowski (1):
      service: fix core mapping reset

Mao Jiang (2):
      net/i40e: fix binding interrupt without MSI-X vector
      net/i40e: fix flow director MSI-X resource allocation

Matan Azrad (1):
      vhost: fix features definition location

Maxime Coquelin (3):
      bus/dpaa: fix iterating on a class type
      bus/fslmc: fix iterating on a class type
      vhost: fix virtio ready flag check

Michael Baum (11):
      net/mlx5: remove needless Tx queue initialization check
      net/mlx5: fix unreachable MPLS error path
      common/mlx5: fix code arrangement in tag allocation
      net/mlx5: fix iterator type in Rx queue management
      net/mlx5: fix initialization of steering registers
      net/mlx5: fix crash in NVGRE item translation
      net/mlx5: remove ineffective increment in hairpin split
      net/mlx4: optimize stack memory size in probe
      net/mlx5: fix unnecessary init in mark conversion
      net/mlx5: fix hairpin Tx queue creation error flow
      net/mlx5: fix hairpin Rx queue creation error flow

Muhammad Bilal (1):
      bus/vdev: fix a typo in doxygen comment

Nipun Gupta (2):
      bus/fslmc: fix getting FD error
      net/dpaa: fix FD offset data type

Pablo de Lara (1):
      drivers/crypto: add missing OOP feature flag

Parav Pandit (1):
      common/mlx5: fix void parameters in glue wrappers

Patrick Fu (1):
      vhost: fix double-free with zero-copy

Pavan Nikhilesh (2):
      event/octeontx2: fix device reconfigure
      event/octeontx2: fix sub event type

Pavel Ivashchenko (1):
      net/i40e: fix getting EEPROM information

Phil Yang (5):
      eventdev: fix race condition on timer list counter
      eventdev: use C11 atomics for lcore timer armed flag
      eventdev: remove redundant reset on timer cancel
      eventdev: relax SMP barriers with C11 atomics
      app/testpmd: fix CPU cycles per packet stats on Tx modes

Qi Zhang (7):
      net/ice/base: fix return value
      net/ice/base: fix memory leak on error path
      net/ice/base: fix reference count on VSI list update
      net/ice/base: fix initializing resource for field vector
      net/ice/base: fix VSI ID mask to 10 bits
      net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
      net/ice/base: fix RSS interference

Rahul Gupta (1):
      net/bnxt: fix performance for Arm

Rahul Lakkireddy (3):
      net/cxgbe: fix CLIP leak in filter error path
      net/cxgbe: fix double MPS alloc by flow validate and create
      net/cxgbe: fix L2T leak in filter error and free path

Raslan Darawsheh (3):
      net: fix pedantic build
      net/mlx5: fix flow items size calculation
      net/mlx5: fix VF MAC address set over BlueField

Ruifeng Wang (8):
      net/i40e: enable NEON Rx/Tx in meson
      eal/arm: add vcopyq intrinsic for aarch32
      net/ixgbe: fix include of vector header file
      test: allow no-huge mode for fast-tests
      test/cycles: restore default delay callback
      crypto/armv8: remove debug option
      crypto/armv8: use dedicated log type
      net/i40e: support aarch32

Sarosh Arif (3):
      doc: fix typo in bbdev test guide
      examples/packet_ordering: use proper exit method
      doc: fix ethtool app path

Shougang Wang (2):
      net/ice: fix error log in generic flow
      net/i40e: fix filter pctype

Shy Shyman (3):
      app/testpmd: fix error detection in MTU command
      net/mlx5: fix flow META item validation
      net/mlx5: fix HW counters path in switchdev mode

Stephen Hemminger (8):
      net/netvsc: fix warning when VF is removed
      net/netvsc: do not query VF link state
      net/netvsc: do not spin forever waiting for reply
      eal: fix lcore accessors for non-EAL threads
      cfgfile: fix stack buffer underflow
      rib: add C++ include guard
      kni: fix reference to master/slave process
      doc: fix reference to master process

Suanming Mou (3):
      net/mlx5: fix secondary process resources release
      net/mlx5: fix interrupt installation timing
      net/mlx5: fix counter query

Tal Shnaiderman (2):
      build: fix drivers library path on Windows
      pci: fix address domain format size

Thomas Monjalon (1):
      doc: update build instructions in the Linux guide

Tianfei Zhang (2):
      raw/ifpga/base: fix SPI transaction
      raw/ifpga/base: fix NIOS SPI init

Timothy Redaelli (1):
      test: fix rpath for drivers with meson

Viacheslav Ovsiienko (3):
      net/mlx5: fix UAR lock sharing for multiport devices
      common/mlx5: fix queue doorbell record size
      net/mlx5: fix metadata storing for NEON Rx

Vladimir Medvedkin (1):
      doc: add RIB and FIB into the API index

Wei Hu (Xavier) (12):
      net/hns3: fix Tx less than 60 bytes
      net/hns3: fix VLAN tags reported in Rx
      app/testpmd: fix stats error message
      net/hns3: fix flow director error message
      net/hns3: fix unintended sign extension in fd operation
      net/hns3: fix Rx buffer size
      net/hns3: check multi-process action register result
      ethdev: fix data room size verification in Rx queue setup
      ethdev: fix VLAN offloads set if no relative capabilities
      net/bonding: fix error code on device creation
      net/bonding: fix MAC address when switching active port
      net/bonding: fix MAC address when one port resets

Wei Zhao (4):
      net/ice: fix switch action number check
      net/ixgbe: report 10Mbps link speed for x553
      net/ice: add input set byte number check
      net/i40e: enable QinQ stripping

Weifeng Li (1):
      net/bonding: change state machine to defaulted

Xiao Wang (1):
      net/virtio-user: fix status management

Xiaolong Ye (6):
      mbuf: remove unused next member in dynamic flag/field
      test/mbuf: fix a dynamic flag log
      mbuf: fix boundary check at dynamic field registration
      mbuf: fix error code in dynamic field/flag registration
      mbuf: fix free space update for dynamic field
      mbuf: fix dynamic field dump log

Xiaoyun Wang (5):
      net/hinic/base: check output of management sync channel
      net/hinic/base: remove unused function parameters
      net/hinic: fix setting promiscuous mode
      net/hinic: optimize Rx performance for x86
      net/hinic/base: avoid system time jump

Yicai Lu (1):
      net/bonding: fix LACP negotiation

Yunjian Wang (12):
      app/testpmd: fix memory leak on error path
      vfio: remove unused variable
      net/af_packet: fix check of file descriptors
      net/af_packet: fix memory leak on init failure
      net/af_packet: fix munmap on init failure
      bus/fslmc: fix memory leak in secondary process
      hash: fix out-of-memory handling in hash creation
      event/dpaa: remove dead code
      net/qede: remove dead code
      net/hinic: check memory allocations in flow creation
      net/ice: fix memory leak when releasing VSI
      net/ice: add memory allocation check in RSS init

Zhiguang He (1):
      net/bonding: fix dead loop on RSS RETA update

Zhihong Peng (2):
      net/i40e: report VLAN filter capability
      net/e1000: report VLAN extend capability

Zhike Wang (1):
      mempool: fix allocation in memzone during retry

Re: [dpdk-dev] [EXTERNAL] 19.11.4 patches review and test

[Luca Boccassi]

On Tue, 2020-09-01 at 18:04 +0000, Abhishek Marathe wrote:
> Hi Luca,
> 
> We have tested 19.11.4 and no issues found except known issues.
> 1. Issue with CX-3/MLX-4 driver with ibquery_pkey() failed.
> 2. Issue with hot-removal of VF driver.
> we are tracking both the issues.

Thank you!

Are these two issues new regressions since 19.11.3, or are they pre-
existing?
Should the release be held back until an initial assessment is done?

> Report:
> 
> DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-19.11.4-rc1.tar.gz&data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C13a3a60691b8456980f908d84d456776%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637344307771913541&sdata=8oLAs5j%2BrEF%2BPHMBM036ZgPf2nlooe25daKwXT2YVvs%3D&reserved=0 was validated on Azure for RedHat RHEL 7.5 latest, Openlogic CentOS 7.5 latest, Ubuntu 18.04, Ubuntu 16.04.
> Tested with Mellanox and netvsc poll-mode drivers.
> The tests were executed using LISAv2 framework (https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLIS%2FLISAv2&data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C13a3a60691b8456980f908d84d456776%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637344307771913541&sdata=GNF1xf97D2LxyLYJYmDa%2BRoWNqGfItD3D3OjVhp6HRA%3D&reserved=0).
> 
> Test case description:
> 
> * VERIFY-DPDK-COMPLIANCE - verifies kernel is supported and that the build is successful
> * VERIFY-DPDK-BUILD-AND-TESTPMD-TEST - verifies using testpmd that packets can be sent from a VM to another VM
> * VERIFY-SRIOV-FAILSAFE-FOR-DPDK - disables/enables Accelerated Networking for the NICs under test and makes sure DPDK works in both scenarios
> 
> * PERF-DPDK-FWD-PPS-DS15 - verifies DPDK forwarding performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> * PERF-DPDK-SINGLE-CORE-PPS-DS4 - verifies DPDK performance using testpmd on 1 core, rx and io mode on size Standard_DS4_v2
> * PERF-DPDK-MULTICORE-PPS-DS15 - verifies DPDK performance using testpmd on 2, 4, 8 cores, rx and io mode on size Standard_DS15_v2
> 
> * DPDK-RING-LATENCY - verifies DPDK CPU latency using https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fshemminger%2Fdpdk-ring-ping.git&data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C13a3a60691b8456980f908d84d456776%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637344307771913541&sdata=znhtFXLZiKaadAJKKLghm9NWvdRUvYZx2xLtIf0r15A%3D&reserved=0
> * VERIFY-DPDK-PRIMARY-SECONDARY-PROCESSES - verifies primary / secondary processes support for DPDK. Runs only on RHEL and Ubuntu distros with Linux kernel >= 4.20
> 
> * VERIFY-DPDK-OVS - builds OVS with DPDK support and tests if the OVS DPDK ports can be created. Runs only on Ubuntu distro.
> * VERIFY-DPDK-VPP - builds VPP with DPDK support and tests if the VPP ports are present. Runs only on RHEL and Ubuntu distros.
> * VERIFY-DPDK-NFF-GO - builds NFF-GO with DPDK support and runs the functional tests from the NFF-GO repository. Runs only on Ubuntu distro.
> 
> Ubuntu 16.04: Pass
> Ubuntu 18.04: Pass
> RHEL 7.5: Pass
> CentOS 7.5: Pass
> 
> Regards,
> Abhishek
> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org> 
> Sent: Tuesday, August 18, 2020 11:12 AM
> To: stable@dpdk.org
> Cc: dev@dpdk.org; Abhishek Marathe <Abhishek.Marathe@microsoft.com>; Akhil Goyal <akhil.goyal@nxp.com>; Ali Alnubani <alialnu@mellanox.com>; benjamin.walker@intel.com; David Christensen <drc@linux.vnet.ibm.com>; Hemant Agrawal <hemant.agrawal@nxp.com>; Ian Stokes <ian.stokes@intel.com>; Jerin Jacob <jerinj@marvell.com>; John McNamara <john.mcnamara@intel.com>; Ju-Hyoung Lee <juhlee@microsoft.com>; Kevin Traynor <ktraynor@redhat.com>; Pei Zhang <pezhang@redhat.com>; pingx.yu@intel.com; qian.q.xu@intel.com; Raslan Darawsheh <rasland@mellanox.com>; Thomas Monjalon <thomas@monjalon.net>; yuan.peng@intel.com; zhaoyan.chen@intel.com
> Subject: [EXTERNAL] 19.11.4 patches review and test
> 
> Hi all,
> 
> Here is a list of patches targeted for stable release 19.11.4.
> 
> The planned date for the final release is August 31st.
> 
> Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
> 
> A release candidate tarball can be found at:
> 
>     https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2Ftag%2F%3Fid%3Dv19.11.4-rc1&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C5f6c5d506f3d439b1d1a08d843a24469%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637333711526043405&amp;sdata=LkqDTW1b6u1Q0S4ZJvRGzhG4XL2PG%2FSmikz7jR6iurI%3D&amp;reserved=0
> 
> These patches are located at branch 19.11 of dpdk-stable repo:
>     https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdpdk.org%2Fbrowse%2Fdpdk-stable%2F&amp;data=02%7C01%7CAbhishek.Marathe%40microsoft.com%7C5f6c5d506f3d439b1d1a08d843a24469%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637333711526053410&amp;sdata=nLx7HUHx412XMexrqfAaIxUzK7ko%2BAq8OKakVglimEQ%3D&amp;reserved=0
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> Adam Dybkowski (7):
>       test/crypto: fix asymmetric session mempool creation
>       crypto/qat: fix AES-XTS capabilities
>       crypto/qat: handle mixed hash-cipher requests on GEN3
>       test/crypto: add mixed encypted-digest
>       common/qat: get firmware version
>       crypto/qat: handle mixed hash-cipher on GEN2
>       common/qat: fix uninitialized variable
> 
> Akhil Goyal (4):
>       crypto/dpaax_sec: fix 18-bit PDCP cases with HFN override
>       crypto/dpaax_sec: fix inline query for descriptors
>       crypto/dpaa2_sec: fix HFN override
>       common/dpaax: fix 12-bit null auth case
> 
> Alan Dewar (1):
>       sched: fix port time rounding
> 
> Alexander Kozyrev (3):
>       net/mlx5: fix vectorized Rx burst termination
>       net/mlx5: do not select legacy MPW implicitly
>       net/mlx5: fix descriptors number adjustment
> 
> Ali Alnubani (2):
>       net/mlx5: fix typos in meter error messages
>       doc: fix a typo in mlx5 guide
> 
> Alvin Zhang (1):
>       net/i40e: fix queue pairs configuration in VF
> 
> Andrew Rybchenko (1):
>       net/sfc: do not enforce hash offload in RSS multi-queue
> 
> Ankur Dwivedi (2):
>       common/cpt: fix encryption offset
>       test/crypto: change cipher offset for ESN vector
> 
> Apeksha Gupta (2):
>       app/eventdev: fix capability check in pipeline ATQ test
>       event/dpaa2: add all-types queue capability flag
> 
> Archana Muniganti (2):
>       examples/fips_validation: fix TDES interim callback
>       examples/fips_validation: fix count overwrite for TDES
> 
> Archit Pandey (1):
>       sched: fix 64-bit rate
> 
> Arek Kusztal (4):
>       drivers/qat: improve multi process on qat
>       drivers/qat: add multi process handling of driver id
>       drivers/qat: add handling of capabilities in multi process
>       crypto/qat: add minimum enq threshold
> 
> Ayuj Verma (1):
>       examples/fips_validation: fix parsing of TDES vectors
> 
> Bruce Richardson (12):
>       test: fix build with ring PMD but no bond PMD
>       mem: fix 32-bit init config with meson
>       rawdev: allow getting info for unknown device
>       rawdev: fill NUMA socket ID in info
>       rawdev: export dump function in map file
>       doc: rebuild with meson whenever a file changes
>       build: always link whole DPDK static libraries
>       devtools: test static linkage with pkg-config
>       build/pkg-config: move pkg-config file creation
>       build/pkg-config: output drivers first for static build
>       build/pkg-config: improve static linking flags
>       build/pkg-config: prevent overlinking
> 
> Chas Williams (1):
>       net/netvsc: fix crash during Tx
> 
> Chenbo Xia (1):
>       net/virtio-user: check tap system call setting
> 
> Chengchang Tang (5):
>       net/hns3: clear promiscuous on PF uninit
>       net/hns3: remove unsupported VLAN capabilities
>       net/hns3: fix VLAN strip configuration when setting PVID
>       net/hns3: remove restriction on setting VF MTU
>       net/hns3: fix adding multicast MAC address
> 
> Chenmin Sun (1):
>       net/i40e: fix flow director Rx writeback packet
> 
> Ciara Loftus (1):
>       net/af_xdp: remove mempool freeing on umem destruction
> 
> David Marchand (7):
>       eal/windows: fix symbol export
>       eal: remove redundant newline in alert message
>       net/mlx5: remove redundant newline from logs
>       net/mvpp2: fix non-EAL thread support
>       devtools: fix path in forbidden token check
>       lib: remind experimental status in headers
>       net/bonding: fix socket ID check
> 
> Dekel Peled (2):
>       net/mlx5: fix VLAN pop with decap action validation
>       net/mlx5: fix VLAN push action on hairpin queue
> 
> Devendra Singh Rawat (1):
>       net/qede: fix multicast drop in promiscuous mode
> 
> Dong Zhou (1):
>       net/mlx5: fix LRO checksum
> 
> Dongyang Pan (1):
>       net/bonding: delete redundant code
> 
> Fady Bader (1):
>       meter: remove inline functions from export list
> 
> Feifei Wang (1):
>       test/ring: fix statistics in bulk enq/dequeue
> 
> Ferruh Yigit (4):
>       net/iavf: fix uninitialized variable
>       net/ixgbe/base: remove dead code
>       ethdev: fix log type for some error messages
>       drivers/net: fix exposing internal headers
> 
> Fiona Trahe (3):
>       common/qat: remove tail write coalescing
>       common/qat: move max inflights param into qp
>       common/qat: support dual threads for enqueue/dequeue
> 
> Gaurav Singh (1):
>       net/i40e: remove duplicate tunnel type check
> 
> Georgiy Levashov (1):
>       examples: add flush after stats printing
> 
> Gregory Etelson (1):
>       net/mlx5: fix tunnel flow priority
> 
> Guinan Sun (5):
>       net/ixgbe/base: fix host interface shadow RAM read
>       net/ixgbe/base: fix x550em 10G NIC link status
>       net/ixgbe/base: fix infinite recursion on PCIe link down
>       net/ixgbe: fix MAC control frame forward
>       net/ixgbe: fix flow control status
> 
> Haiyue Wang (6):
>       bus/pci: fix VF memory access
>       eal: fix uuid header dependencies
>       net/ice: fix TCP checksum offload
>       net/ice: calculate TCP header size for offload
>       net/ice: fix Tx hang with TSO
>       net/ice: revert fake TSO fixes
> 
> Hao Chen (1):
>       net/hns3: optimize default RSS algorithm
> 
> Harman Kalra (4):
>       eal/linux: fix epoll fd list rebuild for interrupts
>       net/octeontx2: fix DMAC filtering
>       common/octeontx2: fix crash on running procinfo
>       eal: fix parentheses in alignment macros
> 
> Harry van Haaren (1):
>       examples/eventdev: fix 32-bit coremask
> 
> Heinrich Kuhn (1):
>       net/nfp: fix RSS hash configuration reporting
> 
> Hemant Agrawal (1):
>       rawdev: remove remaining experimental tags
> 
> Hongbo Zheng (4):
>       net/hns3: ignore function return on reset error path
>       net/hns3: fix unintended sign extension in dump operation
>       net/hns3: clear residual hardware configurations on init
>       net/hns3: get link status change through mailbox
> 
> Hongzhi Guo (3):
>       net: fix IPv4 checksum
>       net: fix unneeded replacement of TCP checksum 0
>       net: fix checksum on big endian CPUs
> 
> Honnappa Nagarahalli (5):
>       eal/armv8: fix timer frequency calibration with PMU
>       app/testpmd: use clock time in throughput calculation
>       app/testpmd: fix burst percentage calculation
>       doc: fix some typos in Linux guide
>       test/hash: move lock-free tests to perf tests
> 
> Hrvoje Habjanic (1):
>       sched: fix subport freeing
> 
> Ian Dolzhansky (1):
>       net/failsafe: fix RSS RETA size info
> 
> Igor Romanov (1):
>       service: fix lcore iteration
> 
> Jecky Pei (1):
>       net/kni: set packet input port in Rx
> 
> Jeff Guo (1):
>       net/e1000: fix crash on Tx done clean up
> 
> Junfeng Guo (2):
>       net/ice/base: fix RSS removal for GTP-U
>       net/ice/base: fix memory leak on GTPU RSS
> 
> Junyu Jiang (2):
>       net/iavf: fix RSS RETA after restart
>       net/ice: fix bytes statistics
> 
> Kalesh AP (5):
>       net/bnxt: remove unused enum declaration
>       net/bnxt: fix unnecessary HWRM command
>       net/bnxt: fix flow error on filter creation
>       net/bnxt: fix freeing filters on flow creation failure
>       net/bnxt: fix logical AND in if condition
> 
> Kevin Traynor (1):
>       vhost: remove zero-copy and client mode restriction
> 
> Konstantin Ananyev (2):
>       test/bpf: fix few small issues
>       bpf: fix add/sub min/max estimations
> 
> Levend Sayar (1):
>       service: fix C++ linkage
> 
> Lijun Ou (5):
>       net/hns3: add RSS hash offload to Rx configuration
>       net/hns3: fix key length when configuring RSS
>       net/hns3: fix RSS configuration on empty RSS type
>       net/hns3: remove unnecessary branch
>       app/testpmd: remove hardcoded descriptors limit
> 
> Long Li (3):
>       bus/vmbus: fix ring buffer mapping
>       net/netvsc: fix underflow when Rx external mbuf
>       net/netvsc: fix chimney index
> 
> Lukasz Wojciechowski (1):
>       service: fix core mapping reset
> 
> Mao Jiang (2):
>       net/i40e: fix binding interrupt without MSI-X vector
>       net/i40e: fix flow director MSI-X resource allocation
> 
> Matan Azrad (1):
>       vhost: fix features definition location
> 
> Maxime Coquelin (3):
>       bus/dpaa: fix iterating on a class type
>       bus/fslmc: fix iterating on a class type
>       vhost: fix virtio ready flag check
> 
> Michael Baum (11):
>       net/mlx5: remove needless Tx queue initialization check
>       net/mlx5: fix unreachable MPLS error path
>       common/mlx5: fix code arrangement in tag allocation
>       net/mlx5: fix iterator type in Rx queue management
>       net/mlx5: fix initialization of steering registers
>       net/mlx5: fix crash in NVGRE item translation
>       net/mlx5: remove ineffective increment in hairpin split
>       net/mlx4: optimize stack memory size in probe
>       net/mlx5: fix unnecessary init in mark conversion
>       net/mlx5: fix hairpin Tx queue creation error flow
>       net/mlx5: fix hairpin Rx queue creation error flow
> 
> Muhammad Bilal (1):
>       bus/vdev: fix a typo in doxygen comment
> 
> Nipun Gupta (2):
>       bus/fslmc: fix getting FD error
>       net/dpaa: fix FD offset data type
> 
> Pablo de Lara (1):
>       drivers/crypto: add missing OOP feature flag
> 
> Parav Pandit (1):
>       common/mlx5: fix void parameters in glue wrappers
> 
> Patrick Fu (1):
>       vhost: fix double-free with zero-copy
> 
> Pavan Nikhilesh (2):
>       event/octeontx2: fix device reconfigure
>       event/octeontx2: fix sub event type
> 
> Pavel Ivashchenko (1):
>       net/i40e: fix getting EEPROM information
> 
> Phil Yang (5):
>       eventdev: fix race condition on timer list counter
>       eventdev: use C11 atomics for lcore timer armed flag
>       eventdev: remove redundant reset on timer cancel
>       eventdev: relax SMP barriers with C11 atomics
>       app/testpmd: fix CPU cycles per packet stats on Tx modes
> 
> Qi Zhang (7):
>       net/ice/base: fix return value
>       net/ice/base: fix memory leak on error path
>       net/ice/base: fix reference count on VSI list update
>       net/ice/base: fix initializing resource for field vector
>       net/ice/base: fix VSI ID mask to 10 bits
>       net/ice/base: fix GTP-U inner RSS IPv4 IPv6 co-exist
>       net/ice/base: fix RSS interference
> 
> Rahul Gupta (1):
>       net/bnxt: fix performance for Arm
> 
> Rahul Lakkireddy (3):
>       net/cxgbe: fix CLIP leak in filter error path
>       net/cxgbe: fix double MPS alloc by flow validate and create
>       net/cxgbe: fix L2T leak in filter error and free path
> 
> Raslan Darawsheh (3):
>       net: fix pedantic build
>       net/mlx5: fix flow items size calculation
>       net/mlx5: fix VF MAC address set over BlueField
> 
> Ruifeng Wang (8):
>       net/i40e: enable NEON Rx/Tx in meson
>       eal/arm: add vcopyq intrinsic for aarch32
>       net/ixgbe: fix include of vector header file
>       test: allow no-huge mode for fast-tests
>       test/cycles: restore default delay callback
>       crypto/armv8: remove debug option
>       crypto/armv8: use dedicated log type
>       net/i40e: support aarch32
> 
> Sarosh Arif (3):
>       doc: fix typo in bbdev test guide
>       examples/packet_ordering: use proper exit method
>       doc: fix ethtool app path
> 
> Shougang Wang (2):
>       net/ice: fix error log in generic flow
>       net/i40e: fix filter pctype
> 
> Shy Shyman (3):
>       app/testpmd: fix error detection in MTU command
>       net/mlx5: fix flow META item validation
>       net/mlx5: fix HW counters path in switchdev mode
> 
> Stephen Hemminger (8):
>       net/netvsc: fix warning when VF is removed
>       net/netvsc: do not query VF link state
>       net/netvsc: do not spin forever waiting for reply
>       eal: fix lcore accessors for non-EAL threads
>       cfgfile: fix stack buffer underflow
>       rib: add C++ include guard
>       kni: fix reference to master/slave process
>       doc: fix reference to master process
> 
> Suanming Mou (3):
>       net/mlx5: fix secondary process resources release
>       net/mlx5: fix interrupt installation timing
>       net/mlx5: fix counter query
> 
> Tal Shnaiderman (2):
>       build: fix drivers library path on Windows
>       pci: fix address domain format size
> 
> Thomas Monjalon (1):
>       doc: update build instructions in the Linux guide
> 
> Tianfei Zhang (2):
>       raw/ifpga/base: fix SPI transaction
>       raw/ifpga/base: fix NIOS SPI init
> 
> Timothy Redaelli (1):
>       test: fix rpath for drivers with meson
> 
> Viacheslav Ovsiienko (3):
>       net/mlx5: fix UAR lock sharing for multiport devices
>       common/mlx5: fix queue doorbell record size
>       net/mlx5: fix metadata storing for NEON Rx
> 
> Vladimir Medvedkin (1):
>       doc: add RIB and FIB into the API index
> 
> Wei Hu (Xavier) (12):
>       net/hns3: fix Tx less than 60 bytes
>       net/hns3: fix VLAN tags reported in Rx
>       app/testpmd: fix stats error message
>       net/hns3: fix flow director error message
>       net/hns3: fix unintended sign extension in fd operation
>       net/hns3: fix Rx buffer size
>       net/hns3: check multi-process action register result
>       ethdev: fix data room size verification in Rx queue setup
>       ethdev: fix VLAN offloads set if no relative capabilities
>       net/bonding: fix error code on device creation
>       net/bonding: fix MAC address when switching active port
>       net/bonding: fix MAC address when one port resets
> 
> Wei Zhao (4):
>       net/ice: fix switch action number check
>       net/ixgbe: report 10Mbps link speed for x553
>       net/ice: add input set byte number check
>       net/i40e: enable QinQ stripping
> 
> Weifeng Li (1):
>       net/bonding: change state machine to defaulted
> 
> Xiao Wang (1):
>       net/virtio-user: fix status management
> 
> Xiaolong Ye (6):
>       mbuf: remove unused next member in dynamic flag/field
>       test/mbuf: fix a dynamic flag log
>       mbuf: fix boundary check at dynamic field registration
>       mbuf: fix error code in dynamic field/flag registration
>       mbuf: fix free space update for dynamic field
>       mbuf: fix dynamic field dump log
> 
> Xiaoyun Wang (5):
>       net/hinic/base: check output of management sync channel
>       net/hinic/base: remove unused function parameters
>       net/hinic: fix setting promiscuous mode
>       net/hinic: optimize Rx performance for x86
>       net/hinic/base: avoid system time jump
> 
> Yicai Lu (1):
>       net/bonding: fix LACP negotiation
> 
> Yunjian Wang (12):
>       app/testpmd: fix memory leak on error path
>       vfio: remove unused variable
>       net/af_packet: fix check of file descriptors
>       net/af_packet: fix memory leak on init failure
>       net/af_packet: fix munmap on init failure
>       bus/fslmc: fix memory leak in secondary process
>       hash: fix out-of-memory handling in hash creation
>       event/dpaa: remove dead code
>       net/qede: remove dead code
>       net/hinic: check memory allocations in flow creation
>       net/ice: fix memory leak when releasing VSI
>       net/ice: add memory allocation check in RSS init
> 
> Zhiguang He (1):
>       net/bonding: fix dead loop on RSS RETA update
> 
> Zhihong Peng (2):
>       net/i40e: report VLAN filter capability
>       net/e1000: report VLAN extend capability
> 
> Zhike Wang (1):
>       mempool: fix allocation in memzone during retry

Re: [dpdk-dev] [dpdk-stable] 19.11.4 patches review and test

[Luca Boccassi]

On Tue, 2020-09-01 at 15:10 +0000, Stokes, Ian wrote:
> > Hi,
> > 
> > Yes , OVS was using pkg-config even before these patches were rolled out.
> > But it always used to pick the DPDK shared libs by default for OVS even on using
> > the -Bstatic/-Bshared flags.
> > These patches from Bruce simplify the process from DPDK side without having
> > the user to specify them.
> > Moreover, with these patches , the problem of shared DPDK libs always being
> > picked instead of static was not seen any more with a bit of changes from the
> > OVS side as well.
> > http://patchwork.ozlabs.org/project/openvswitch/patch/20200707141126.7141
> > 4-1-sunil.pai.g@intel.com/ .
> > The patches for ovs-master are ready as well and will them out soon.
> > 
> > Thanks and Regards,
> > Pai G, Sunil
> > Sunil
> 
> Hi Folks,
> 
> From the OVS side there was a question WRT why we couldn't use meson in our Travis tests to build DPDK for OVS supporting 19.11.x, in this case it was related to the changes described by Sunil above and hence why the backport was requested. 
> 
> It doesn't have a huge impact on OVS, we can still use 19.11.4 if the patches are removed, however I suspect these changes are also on DPDK main branch at this point and will be part of 20.11? So eventually when we move to 20.11 the same issues may be encountered, maybe that preferable if we are change LTS versions.
> 
> From the OVS side we can look to upstream meson support in the dpdk-latest branch and then integrate it when 20.11 is released, but it would be nice to support it before then if possible.
> 
> Regards
> Ian

I'll proceed with a revert of those 5 patches for now, given 19.11.4 is
already a week late - Christian confirms the build issue is fixed after
doing so.

We can then figure out what the underlinking issue is without urgency
in time for 20.11, and then I'll add the patches again.

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] 19.11.4 patches review and test

[Christian Ehrhardt]

On Tue, Sep 1, 2020 at 3:23 PM Pai G, Sunil <sunil.pai.g@intel.com> wrote:
>
> Hi,
>
> Yes , OVS was using pkg-config even before these patches were rolled out.
> But it always used to pick the DPDK shared libs by default for OVS even on using the -Bstatic/-Bshared flags.
> These patches from Bruce simplify the process from DPDK side without having the user to specify them.
> Moreover, with these patches , the problem of shared DPDK libs always being picked instead of static was not seen any more with a bit of changes from the OVS side as well.
> http://patchwork.ozlabs.org/project/openvswitch/patch/20200707141126.71414-1-sunil.pai.g@intel.com/ .
> The patches for ovs-master are ready as well and will them out soon.

Hi Sunil, Ian, everyone ..

back  in 19.11.4 these DPDK changes were not picked up as they have
broken builds as discussed here.
Later on the communication was that all this works fine now and
thereby Luca has "reverted the reverts" in 19.11.6 [1].

But today we were made aware that still no OVS 2.13 builds against a
DPDK that has those changes.
Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
backported) the recent 2.13.3 does build.
They still fail with the very same issue I reported [2] back then.

Unfortunately I have just released 19.11.7 so I can't revert them
there - but OTOH reverting and counter reverting every other release
seems wrong anyway.

I wanted to ask if there is a set of patches that OVS would need to
backport to 2.13.x to make this work?
If they could be identified and prepared Distros could use them on
2.13.3 asap and 2.13.4 could officially release them for OVS later on.

But for that we'd need a hint which OVS changes that would need to be.
All I know atm is from the testing reports on DPDK it seems that OVS
2.14.3 and 2.15 are happy with the new DPDK code.
Do you have pointers on what 2.13.3 would need to get backported to
work again in regard to this build issue.


[1]: http://git.dpdk.org/dpdk-stable/log/?h=19.11&ofs=550
[2]: http://mails.dpdk.org/archives/stable/2020-September/024796.html

> Thanks and Regards,
> Pai G, Sunil
> Sunil
>
> > -----Original Message-----
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > Sent: Tuesday, September 1, 2020 6:18 PM
> > To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > Cc: Luca Boccassi <bluca@debian.org>; stable@dpdk.org; dev <dev@dpdk.org>;
> > Pai G, Sunil <sunil.pai.g@intel.com>; Stokes, Ian <ian.stokes@intel.com>
> > Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> >
> > On Tue, Sep 01, 2020 at 02:32:26PM +0200, Christian Ehrhardt wrote:
> > > On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi <bluca@debian.org> wrote:
> > > >
> > > > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> > > > > Hi all,
> > > > >
> > > > > Here is a list of patches targeted for stable release 19.11.4.
> > > > >
> > > > > The planned date for the final release is August 31st.
> > > > >
> > > > > Please help with testing and validation of your use cases and
> > > > > report any issues/results with reply-all to this mail. For the
> > > > > final release the fixes and reported validations will be added to the release
> > notes.
> > > > >
> > > > > A release candidate tarball can be found at:
> > > > >
> > > > >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > > > >
> > > > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > > >     https://dpdk.org/browse/dpdk-stable/
> > > > >
> > > > > Thanks.
> > > > >
> > > > > Luca Boccassi
> > > >
> > > > Microsoft's regression tests are still running, delaying until
> > > > Thursday the 3rd. Apologies for any inconvenience.
> > >
> > > Due to report on OVS failing to build I happened to find that 19.11.4
> > > has massively changed linking.
> > > => https://paste.ubuntu.com/p/znCRR4gpjP/
> > >
> > > This was meant to be helpful for sure and I assume is around:
> > > 48f7fd27f6 build/pkg-config: prevent overlinking
> > > 2d1535d592 build/pkg-config: improve static linking flags
> > > 9fb13a12c1 build/pkg-config: output drivers first for static build
> > > 59b108d824 build/pkg-config: move pkg-config file creation
> > > aea915e944 devtools: test static linkage with pkg-config
> > >
> > > But overlinking has effectively become underlinking now
> > > https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.
> > > openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz
> > >
> > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-
> > gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > > in function `rte_eth_from_rings':
> > > (.text+0x91c): undefined reference to `rte_vdev_init'
> > > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-
> > gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > > in function `vdrvinitfn_pmd_ring_drv':
> > > (.text.startup+0x28): undefined reference to `rte_vdev_register'
> > > collect2: error: ld returned 1 exit status
> > >
> > > Also as you can see in the pastebin above, CFlags and Libs massively
> > > shrunk and likely too much so.
> > >
> > > Given that this should be a stable release I'd ask to back out those
> > > changes so that a test build creates the same .pc file as before -
> > > would that make sense?
> > >
> > >
> > Adding some OVS folks on CC.
> >
> > The request for backporting these actually came from the OVS side, since they
> > were deemed necessary to enable OVS to switch to use DPDK pkg-config rather
> > than the older approach using a makefile-based build. However, it appears you
> > guys were already building OVS using the pkg-config file, and since this causes
> > issues where there were none, backing it out seems a prudent choice.
> >
> > Ian, Sunil, any comments here.
> >
> > Regards
> > /Bruce



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [dpdk-dev] 19.11.4 patches review and test

[Pai G, Sunil]

Hey Christian,

<snipped>

> back  in 19.11.4 these DPDK changes were not picked up as they have broken
> builds as discussed here.
> Later on the communication was that all this works fine now and thereby
> Luca has "reverted the reverts" in 19.11.6 [1].
> 
> But today we were made aware that still no OVS 2.13 builds against a DPDK
> that has those changes.
> Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
> backported) the recent 2.13.3 does build.
> They still fail with the very same issue I reported [2] back then.
> 
> Unfortunately I have just released 19.11.7 so I can't revert them there - but
> OTOH reverting and counter reverting every other release seems wrong
> anyway.
> 
> I wanted to ask if there is a set of patches that OVS would need to backport
> to 2.13.x to make this work?
> If they could be identified and prepared Distros could use them on
> 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
> 
> But for that we'd need a hint which OVS changes that would need to be.
> All I know atm is from the testing reports on DPDK it seems that OVS
> 2.14.3 and 2.15 are happy with the new DPDK code.

> Do you have pointers on what 2.13.3 would need to get backported to work
> again in regard to this build issue.

You would need to use partial contents from patch :
http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-26215-1-git-send-email-ian.stokes@intel.com/

If you'd like me to send patches which would work with 2.13, 2.14, I'm ok with that too.[keeping only those parts from patch which fixes the issue you see.]
But we must ensure it doesn’t cause problems for OVS too.
Your thoughts Ilya ?


> 
> [1]: http://git.dpdk.org/dpdk-stable/log/?h=19.11&ofs=550
> [2]: http://mails.dpdk.org/archives/stable/2020-September/024796.html
<snipped>

Thanks and regards,
Sunil

Re: [dpdk-dev] 19.11.4 patches review and test

[Ilya Maximets]

On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> Hey Christian,
> 
> <snipped>
> 
>> back  in 19.11.4 these DPDK changes were not picked up as they have broken
>> builds as discussed here.
>> Later on the communication was that all this works fine now and thereby
>> Luca has "reverted the reverts" in 19.11.6 [1].
>>
>> But today we were made aware that still no OVS 2.13 builds against a DPDK
>> that has those changes.
>> Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
>> backported) the recent 2.13.3 does build.
>> They still fail with the very same issue I reported [2] back then.
>>
>> Unfortunately I have just released 19.11.7 so I can't revert them there - but
>> OTOH reverting and counter reverting every other release seems wrong
>> anyway.

It is wrong indeed, but the main question here is why these patches was
backported to stable release in a first place?

Looking at these patches, they are not actual bug fixes but more like
"nice to have" features that additionally breaks the way application
links with DPDK.  Stuff like that should not be acceptable to the stable
release without a strong justification or, at least, testing with actual
applications.

Since we already have a revert of revert, revert of revert of revert
doesn't seem so bad.

>>
>> I wanted to ask if there is a set of patches that OVS would need to backport
>> to 2.13.x to make this work?
>> If they could be identified and prepared Distros could use them on
>> 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
>>
>> But for that we'd need a hint which OVS changes that would need to be.
>> All I know atm is from the testing reports on DPDK it seems that OVS
>> 2.14.3 and 2.15 are happy with the new DPDK code.
> 
>> Do you have pointers on what 2.13.3 would need to get backported to work
>> again in regard to this build issue.
> 
> You would need to use partial contents from patch :
> http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-26215-1-git-send-email-ian.stokes@intel.com/
> 
> If you'd like me to send patches which would work with 2.13, 2.14, I'm ok with that too.[keeping only those parts from patch which fixes the issue you see.]
> But we must ensure it doesn’t cause problems for OVS too.
> Your thoughts Ilya ?

We had more fixes on top of this particular patch and I'd like to not
cherry-pick and re-check all of this again.  For users stable releases
should be transparent, i.e. should not have disruptive changes that will
break their ability to build with version of a library that they would
like to use.

What are exact changes we're talking about?  Will it still be possible
to build OVS with older versions of a stable 19.11 if these changes applied?

> 
> 
>>
>> [1]: http://git.dpdk.org/dpdk-stable/log/?h=19.11&ofs=550
>> [2]: http://mails.dpdk.org/archives/stable/2020-September/024796.html
> <snipped>
> 
> Thanks and regards,
> Sunil
>

Re: [dpdk-dev] 19.11.4 patches review and test

[Pai G, Sunil]

Hi Christian, Ilya

> -----Original Message-----
> From: Ilya Maximets <i.maximets@ovn.org>
> Sent: Thursday, March 18, 2021 8:18 PM
> To: Pai G, Sunil <sunil.pai.g@intel.com>; Christian Ehrhardt
> <christian.ehrhardt@canonical.com>; Stokes, Ian <ian.stokes@intel.com>;
> Ilya Maximets <i.maximets@ovn.org>; Govindharajan, Hariprasad
> <hariprasad.govindharajan@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Luca Boccassi
> <bluca@debian.org>; stable@dpdk.org; dev <dev@dpdk.org>; James Page
> <james.page@canonical.com>
> Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> 
> On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> > Hey Christian,
> >
> > <snipped>
> >
> >> back  in 19.11.4 these DPDK changes were not picked up as they have
> >> broken builds as discussed here.
> >> Later on the communication was that all this works fine now and
> >> thereby Luca has "reverted the reverts" in 19.11.6 [1].
> >>
> >> But today we were made aware that still no OVS 2.13 builds against a
> >> DPDK that has those changes.
> >> Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
> >> backported) the recent 2.13.3 does build.
> >> They still fail with the very same issue I reported [2] back then.
> >>
> >> Unfortunately I have just released 19.11.7 so I can't revert them
> >> there - but OTOH reverting and counter reverting every other release
> >> seems wrong anyway.
> 
> It is wrong indeed, but the main question here is why these patches was
> backported to stable release in a first place?
> 
> Looking at these patches, they are not actual bug fixes but more like "nice to
> have" features that additionally breaks the way application links with DPDK.
> Stuff like that should not be acceptable to the stable release without a strong
> justification or, at least, testing with actual applications.
> 
> Since we already have a revert of revert, revert of revert of revert doesn't
> seem so bad.
> 
> >>
> >> I wanted to ask if there is a set of patches that OVS would need to
> >> backport to 2.13.x to make this work?
> >> If they could be identified and prepared Distros could use them on
> >> 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
> >>
> >> But for that we'd need a hint which OVS changes that would need to be.
> >> All I know atm is from the testing reports on DPDK it seems that OVS
> >> 2.14.3 and 2.15 are happy with the new DPDK code.
> >
> >> Do you have pointers on what 2.13.3 would need to get backported to
> >> work again in regard to this build issue.
> >
> > You would need to use partial contents from patch :
> > http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-
> 26215
> > -1-git-send-email-ian.stokes@intel.com/
> >
> > If you'd like me to send patches which would work with 2.13, 2.14, I'm
> > ok with that too.[keeping only those parts from patch which fixes the issue
> you see.] But we must ensure it doesn’t cause problems for OVS too.
> > Your thoughts Ilya ?
> 
> We had more fixes on top of this particular patch and I'd like to not cherry-
> pick and re-check all of this again. 

I agree, we had more fixes on top of this. It would be risky to cherry-pick.
So it might be a better option to revert.


> For users stable releases should be
> transparent, i.e. should not have disruptive changes that will break their
> ability to build with version of a library that they would like to use.
> 
> What are exact changes we're talking about?  Will it still be possible to build
> OVS with older versions of a stable 19.11 if these changes applied?
> 
> >
> >
> >>
> >> [1]: http://git.dpdk.org/dpdk-stable/log/?h=19.11&ofs=550
> >> [2]: http://mails.dpdk.org/archives/stable/2020-September/024796.html
> > <snipped>
> >
> > Thanks and regards,
> > Sunil
> >

Re: [dpdk-dev] 19.11.4 patches review and test

[Christian Ehrhardt]

On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil <sunil.pai.g@intel.com> wrote:
>
> Hi Christian, Ilya
>
> > -----Original Message-----
> > From: Ilya Maximets <i.maximets@ovn.org>
> > Sent: Thursday, March 18, 2021 8:18 PM
> > To: Pai G, Sunil <sunil.pai.g@intel.com>; Christian Ehrhardt
> > <christian.ehrhardt@canonical.com>; Stokes, Ian <ian.stokes@intel.com>;
> > Ilya Maximets <i.maximets@ovn.org>; Govindharajan, Hariprasad
> > <hariprasad.govindharajan@intel.com>
> > Cc: Richardson, Bruce <bruce.richardson@intel.com>; Luca Boccassi
> > <bluca@debian.org>; stable@dpdk.org; dev <dev@dpdk.org>; James Page
> > <james.page@canonical.com>
> > Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> >
> > On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> > > Hey Christian,
> > >
> > > <snipped>
> > >
> > >> back  in 19.11.4 these DPDK changes were not picked up as they have
> > >> broken builds as discussed here.
> > >> Later on the communication was that all this works fine now and
> > >> thereby Luca has "reverted the reverts" in 19.11.6 [1].
> > >>
> > >> But today we were made aware that still no OVS 2.13 builds against a
> > >> DPDK that has those changes.
> > >> Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
> > >> backported) the recent 2.13.3 does build.
> > >> They still fail with the very same issue I reported [2] back then.
> > >>
> > >> Unfortunately I have just released 19.11.7 so I can't revert them
> > >> there - but OTOH reverting and counter reverting every other release
> > >> seems wrong anyway.
> >
> > It is wrong indeed, but the main question here is why these patches was
> > backported to stable release in a first place?
> >
> > Looking at these patches, they are not actual bug fixes but more like "nice to
> > have" features that additionally breaks the way application links with DPDK.
> > Stuff like that should not be acceptable to the stable release without a strong
> > justification or, at least, testing with actual applications.

I agree, but TBH IIRC these changes were initially by OVS people :-)
One could chase down the old talks between Luca and the requesters, but I don't
think that gains us that much.

> > Since we already have a revert of revert, revert of revert of revert doesn't
> > seem so bad.

As long as we don't extend this series, yeah

> > >>
> > >> I wanted to ask if there is a set of patches that OVS would need to
> > >> backport to 2.13.x to make this work?
> > >> If they could be identified and prepared Distros could use them on
> > >> 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
> > >>
> > >> But for that we'd need a hint which OVS changes that would need to be.
> > >> All I know atm is from the testing reports on DPDK it seems that OVS
> > >> 2.14.3 and 2.15 are happy with the new DPDK code.
> > >
> > >> Do you have pointers on what 2.13.3 would need to get backported to
> > >> work again in regard to this build issue.
> > >
> > > You would need to use partial contents from patch :
> > > http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-
> > 26215
> > > -1-git-send-email-ian.stokes@intel.com/
> > >
> > > If you'd like me to send patches which would work with 2.13, 2.14, I'm
> > > ok with that too.[keeping only those parts from patch which fixes the issue
> > you see.] But we must ensure it doesn’t cause problems for OVS too.
> > > Your thoughts Ilya ?
> >
> > We had more fixes on top of this particular patch and I'd like to not cherry-
> > pick and re-check all of this again.
>
> I agree, we had more fixes on top of this. It would be risky to cherry-pick.
> So it might be a better option to revert.

I agree, as far as I assessed the situation it would mean the revert
of the following list.
And since that is a lot of "reverts" in the string, to be clear it means that
those original changes would not be present anymore in 19.11.x.

f49248a990 Revert "Revert "build/pkg-config: prevent overlinking""
39586a4cf0 Revert "Revert "build/pkg-config: improve static linking flags""
906e935a1f Revert "Revert "build/pkg-config: output drivers first for
static build""
deebf95239 Revert "Revert "build/pkg-config: move pkg-config file creation""
a3bd9a34bf Revert "Revert "build: always link whole DPDK static libraries""
d4bc124438 Revert "Revert "devtools: test static linkage with pkg-config""

But to avoid going back&forth I'd prefer to have a signed-off on that
approach from:
- Luca (for 19.11.6 which has added the changes)
- Bruce (for being involved in the old&new case in general)
- Thomas (for general master maintainer thoughts)

And finally, I wonder if I'd just push those to the 19.11 git branch OR should
also release a 19.11.8 with just those changes sometime soon - opinions?

> > For users stable releases should be
> > transparent, i.e. should not have disruptive changes that will break their
> > ability to build with version of a library that they would like to use.
> >
> > What are exact changes we're talking about?  Will it still be possible to build
> > OVS with older versions of a stable 19.11 if these changes applied?
> >
> > >
> > >
> > >>
> > >> [1]: http://git.dpdk.org/dpdk-stable/log/?h=19.11&ofs=550
> > >> [2]: http://mails.dpdk.org/archives/stable/2020-September/024796.html
> > > <snipped>
> > >
> > > Thanks and regards,
> > > Sunil
> > >



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [dpdk-dev] 19.11.4 patches review and test

[Bruce Richardson]

On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote:
> On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil <sunil.pai.g@intel.com> wrote:
> >
> > Hi Christian, Ilya
> >
> > > -----Original Message-----
> > > From: Ilya Maximets <i.maximets@ovn.org>
> > > Sent: Thursday, March 18, 2021 8:18 PM
> > > To: Pai G, Sunil <sunil.pai.g@intel.com>; Christian Ehrhardt
> > > <christian.ehrhardt@canonical.com>; Stokes, Ian <ian.stokes@intel.com>;
> > > Ilya Maximets <i.maximets@ovn.org>; Govindharajan, Hariprasad
> > > <hariprasad.govindharajan@intel.com>
> > > Cc: Richardson, Bruce <bruce.richardson@intel.com>; Luca Boccassi
> > > <bluca@debian.org>; stable@dpdk.org; dev <dev@dpdk.org>; James Page
> > > <james.page@canonical.com>
> > > Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> > >
> > > On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> > > > Hey Christian,
> > > >
> > > > <snipped>
> > > >
> > > >> back  in 19.11.4 these DPDK changes were not picked up as they have
> > > >> broken builds as discussed here.
> > > >> Later on the communication was that all this works fine now and
> > > >> thereby Luca has "reverted the reverts" in 19.11.6 [1].
> > > >>
> > > >> But today we were made aware that still no OVS 2.13 builds against a
> > > >> DPDK that has those changes.
> > > >> Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
> > > >> backported) the recent 2.13.3 does build.
> > > >> They still fail with the very same issue I reported [2] back then.
> > > >>
> > > >> Unfortunately I have just released 19.11.7 so I can't revert them
> > > >> there - but OTOH reverting and counter reverting every other release
> > > >> seems wrong anyway.
> > >
> > > It is wrong indeed, but the main question here is why these patches was
> > > backported to stable release in a first place?
> > >
> > > Looking at these patches, they are not actual bug fixes but more like "nice to
> > > have" features that additionally breaks the way application links with DPDK.
> > > Stuff like that should not be acceptable to the stable release without a strong
> > > justification or, at least, testing with actual applications.
> 
> I agree, but TBH IIRC these changes were initially by OVS people :-)
> One could chase down the old talks between Luca and the requesters, but I don't
> think that gains us that much.
> 
> > > Since we already have a revert of revert, revert of revert of revert doesn't
> > > seem so bad.
> 
> As long as we don't extend this series, yeah
> 
> > > >>
> > > >> I wanted to ask if there is a set of patches that OVS would need to
> > > >> backport to 2.13.x to make this work?
> > > >> If they could be identified and prepared Distros could use them on
> > > >> 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
> > > >>
> > > >> But for that we'd need a hint which OVS changes that would need to be.
> > > >> All I know atm is from the testing reports on DPDK it seems that OVS
> > > >> 2.14.3 and 2.15 are happy with the new DPDK code.
> > > >
> > > >> Do you have pointers on what 2.13.3 would need to get backported to
> > > >> work again in regard to this build issue.
> > > >
> > > > You would need to use partial contents from patch :
> > > > http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-
> > > 26215
> > > > -1-git-send-email-ian.stokes@intel.com/
> > > >
> > > > If you'd like me to send patches which would work with 2.13, 2.14, I'm
> > > > ok with that too.[keeping only those parts from patch which fixes the issue
> > > you see.] But we must ensure it doesn’t cause problems for OVS too.
> > > > Your thoughts Ilya ?
> > >
> > > We had more fixes on top of this particular patch and I'd like to not cherry-
> > > pick and re-check all of this again.
> >
> > I agree, we had more fixes on top of this. It would be risky to cherry-pick.
> > So it might be a better option to revert.
> 
> I agree, as far as I assessed the situation it would mean the revert
> of the following list.
> And since that is a lot of "reverts" in the string, to be clear it means that
> those original changes would not be present anymore in 19.11.x.
> 
> f49248a990 Revert "Revert "build/pkg-config: prevent overlinking""
> 39586a4cf0 Revert "Revert "build/pkg-config: improve static linking flags""
> 906e935a1f Revert "Revert "build/pkg-config: output drivers first for
> static build""
> deebf95239 Revert "Revert "build/pkg-config: move pkg-config file creation""
> a3bd9a34bf Revert "Revert "build: always link whole DPDK static libraries""
> d4bc124438 Revert "Revert "devtools: test static linkage with pkg-config""
> 
> But to avoid going back&forth I'd prefer to have a signed-off on that
> approach from:
> - Luca (for 19.11.6 which has added the changes)
> - Bruce (for being involved in the old&new case in general)
> - Thomas (for general master maintainer thoughts)
> 

If this is what is needed to ensure OVS can continue to use this release
series, then I am absolutely fine with it.

/Bruce

Re: [dpdk-dev] 19.11.4 patches review and test

[Luca Boccassi]

On Mon, 2021-03-22 at 11:41 +0000, Bruce Richardson wrote:
> On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote:
> > On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil <sunil.pai.g@intel.com> wrote:
> > > Hi Christian, Ilya
> > > 
> > > > -----Original Message-----
> > > > From: Ilya Maximets <i.maximets@ovn.org>
> > > > Sent: Thursday, March 18, 2021 8:18 PM
> > > > To: Pai G, Sunil <sunil.pai.g@intel.com>; Christian Ehrhardt
> > > > <christian.ehrhardt@canonical.com>; Stokes, Ian <ian.stokes@intel.com>;
> > > > Ilya Maximets <i.maximets@ovn.org>; Govindharajan, Hariprasad
> > > > <hariprasad.govindharajan@intel.com>
> > > > Cc: Richardson, Bruce <bruce.richardson@intel.com>; Luca Boccassi
> > > > <bluca@debian.org>; stable@dpdk.org; dev <dev@dpdk.org>; James Page
> > > > <james.page@canonical.com>
> > > > Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> > > > 
> > > > On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> > > > > Hey Christian,
> > > > > 
> > > > > <snipped>
> > > > > 
> > > > > > back  in 19.11.4 these DPDK changes were not picked up as they have
> > > > > > broken builds as discussed here.
> > > > > > Later on the communication was that all this works fine now and
> > > > > > thereby Luca has "reverted the reverts" in 19.11.6 [1].
> > > > > > 
> > > > > > But today we were made aware that still no OVS 2.13 builds against a
> > > > > > DPDK that has those changes.
> > > > > > Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
> > > > > > backported) the recent 2.13.3 does build.
> > > > > > They still fail with the very same issue I reported [2] back then.
> > > > > > 
> > > > > > Unfortunately I have just released 19.11.7 so I can't revert them
> > > > > > there - but OTOH reverting and counter reverting every other release
> > > > > > seems wrong anyway.
> > > > 
> > > > It is wrong indeed, but the main question here is why these patches was
> > > > backported to stable release in a first place?
> > > > 
> > > > Looking at these patches, they are not actual bug fixes but more like "nice to
> > > > have" features that additionally breaks the way application links with DPDK.
> > > > Stuff like that should not be acceptable to the stable release without a strong
> > > > justification or, at least, testing with actual applications.
> > 
> > I agree, but TBH IIRC these changes were initially by OVS people :-)
> > One could chase down the old talks between Luca and the requesters, but I don't
> > think that gains us that much.
> > 
> > > > Since we already have a revert of revert, revert of revert of revert doesn't
> > > > seem so bad.
> > 
> > As long as we don't extend this series, yeah
> > 
> > > > > > I wanted to ask if there is a set of patches that OVS would need to
> > > > > > backport to 2.13.x to make this work?
> > > > > > If they could be identified and prepared Distros could use them on
> > > > > > 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
> > > > > > 
> > > > > > But for that we'd need a hint which OVS changes that would need to be.
> > > > > > All I know atm is from the testing reports on DPDK it seems that OVS
> > > > > > 2.14.3 and 2.15 are happy with the new DPDK code.
> > > > > > Do you have pointers on what 2.13.3 would need to get backported to
> > > > > > work again in regard to this build issue.
> > > > > 
> > > > > You would need to use partial contents from patch :
> > > > > http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-
> > > > 26215
> > > > > -1-git-send-email-ian.stokes@intel.com/
> > > > > 
> > > > > If you'd like me to send patches which would work with 2.13, 2.14, I'm
> > > > > ok with that too.[keeping only those parts from patch which fixes the issue
> > > > you see.] But we must ensure it doesn’t cause problems for OVS too.
> > > > > Your thoughts Ilya ?
> > > > 
> > > > We had more fixes on top of this particular patch and I'd like to not cherry-
> > > > pick and re-check all of this again.
> > > 
> > > I agree, we had more fixes on top of this. It would be risky to cherry-pick.
> > > So it might be a better option to revert.
> > 
> > I agree, as far as I assessed the situation it would mean the revert
> > of the following list.
> > And since that is a lot of "reverts" in the string, to be clear it means that
> > those original changes would not be present anymore in 19.11.x.
> > 
> > f49248a990 Revert "Revert "build/pkg-config: prevent overlinking""
> > 39586a4cf0 Revert "Revert "build/pkg-config: improve static linking flags""
> > 906e935a1f Revert "Revert "build/pkg-config: output drivers first for
> > static build""
> > deebf95239 Revert "Revert "build/pkg-config: move pkg-config file creation""
> > a3bd9a34bf Revert "Revert "build: always link whole DPDK static libraries""
> > d4bc124438 Revert "Revert "devtools: test static linkage with pkg-config""
> > 
> > But to avoid going back&forth I'd prefer to have a signed-off on that
> > approach from:
> > - Luca (for 19.11.6 which has added the changes)
> > - Bruce (for being involved in the old&new case in general)
> > - Thomas (for general master maintainer thoughts)
> > 
> 
> If this is what is needed to ensure OVS can continue to use this release
> series, then I am absolutely fine with it.

This was requested by OVS, so if they don't need it anymore it's fine
by me as well

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] 19.11.4 patches review and test

[Thomas Monjalon]

22/03/2021 12:59, Luca Boccassi:
> On Mon, 2021-03-22 at 11:41 +0000, Bruce Richardson wrote:
> > On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote:
> > > On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil <sunil.pai.g@intel.com> wrote:
> > > > Hi Christian, Ilya
> > > > From: Ilya Maximets <i.maximets@ovn.org>
> > > > > On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> > > > > > Hey Christian,
> > > > > > 
> > > > > > <snipped>
> > > > > > 
> > > > > > > back  in 19.11.4 these DPDK changes were not picked up as they have
> > > > > > > broken builds as discussed here.
> > > > > > > Later on the communication was that all this works fine now and
> > > > > > > thereby Luca has "reverted the reverts" in 19.11.6 [1].
> > > > > > > 
> > > > > > > But today we were made aware that still no OVS 2.13 builds against a
> > > > > > > DPDK that has those changes.
> > > > > > > Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
> > > > > > > backported) the recent 2.13.3 does build.
> > > > > > > They still fail with the very same issue I reported [2] back then.
> > > > > > > 
> > > > > > > Unfortunately I have just released 19.11.7 so I can't revert them
> > > > > > > there - but OTOH reverting and counter reverting every other release
> > > > > > > seems wrong anyway.
> > > > > 
> > > > > It is wrong indeed, but the main question here is why these patches was
> > > > > backported to stable release in a first place?
> > > > > 
> > > > > Looking at these patches, they are not actual bug fixes but more like "nice to
> > > > > have" features that additionally breaks the way application links with DPDK.
> > > > > Stuff like that should not be acceptable to the stable release without a strong
> > > > > justification or, at least, testing with actual applications.
> > > 
> > > I agree, but TBH IIRC these changes were initially by OVS people :-)
> > > One could chase down the old talks between Luca and the requesters, but I don't
> > > think that gains us that much.
> > > 
> > > > > Since we already have a revert of revert, revert of revert of revert doesn't
> > > > > seem so bad.
> > > 
> > > As long as we don't extend this series, yeah
> > > 
> > > > > > > I wanted to ask if there is a set of patches that OVS would need to
> > > > > > > backport to 2.13.x to make this work?
> > > > > > > If they could be identified and prepared Distros could use them on
> > > > > > > 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
> > > > > > > 
> > > > > > > But for that we'd need a hint which OVS changes that would need to be.
> > > > > > > All I know atm is from the testing reports on DPDK it seems that OVS
> > > > > > > 2.14.3 and 2.15 are happy with the new DPDK code.
> > > > > > > Do you have pointers on what 2.13.3 would need to get backported to
> > > > > > > work again in regard to this build issue.
> > > > > > 
> > > > > > You would need to use partial contents from patch :
> > > > > > http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-
> > > > > 26215
> > > > > > -1-git-send-email-ian.stokes@intel.com/
> > > > > > 
> > > > > > If you'd like me to send patches which would work with 2.13, 2.14, I'm
> > > > > > ok with that too.[keeping only those parts from patch which fixes the issue
> > > > > you see.] But we must ensure it doesn’t cause problems for OVS too.
> > > > > > Your thoughts Ilya ?
> > > > > 
> > > > > We had more fixes on top of this particular patch and I'd like to not cherry-
> > > > > pick and re-check all of this again.
> > > > 
> > > > I agree, we had more fixes on top of this. It would be risky to cherry-pick.
> > > > So it might be a better option to revert.
> > > 
> > > I agree, as far as I assessed the situation it would mean the revert
> > > of the following list.
> > > And since that is a lot of "reverts" in the string, to be clear it means that
> > > those original changes would not be present anymore in 19.11.x.
> > > 
> > > f49248a990 Revert "Revert "build/pkg-config: prevent overlinking""
> > > 39586a4cf0 Revert "Revert "build/pkg-config: improve static linking flags""
> > > 906e935a1f Revert "Revert "build/pkg-config: output drivers first for
> > > static build""
> > > deebf95239 Revert "Revert "build/pkg-config: move pkg-config file creation""
> > > a3bd9a34bf Revert "Revert "build: always link whole DPDK static libraries""
> > > d4bc124438 Revert "Revert "devtools: test static linkage with pkg-config""
> > > 
> > > But to avoid going back&forth I'd prefer to have a signed-off on that
> > > approach from:
> > > - Luca (for 19.11.6 which has added the changes)
> > > - Bruce (for being involved in the old&new case in general)
> > > - Thomas (for general master maintainer thoughts)
> > > 
> > 
> > If this is what is needed to ensure OVS can continue to use this release
> > series, then I am absolutely fine with it.
> 
> This was requested by OVS, so if they don't need it anymore it's fine
> by me as well

I am not sure to understand the full story,
but I am a bit worried that our release is dictated by
a single "user" (project using DPDK).

Please do you have links of discussion history?

Re: [dpdk-dev] 19.11.4 patches review and test

[Christian Ehrhardt]

On Mon, Mar 22, 2021 at 1:25 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 22/03/2021 12:59, Luca Boccassi:
> > On Mon, 2021-03-22 at 11:41 +0000, Bruce Richardson wrote:
> > > On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote:
> > > > On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil <sunil.pai.g@intel.com> wrote:
> > > > > Hi Christian, Ilya
> > > > > From: Ilya Maximets <i.maximets@ovn.org>
> > > > > > On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> > > > > > > Hey Christian,
> > > > > > >
> > > > > > > <snipped>
> > > > > > >
> > > > > > > > back  in 19.11.4 these DPDK changes were not picked up as they have
> > > > > > > > broken builds as discussed here.
> > > > > > > > Later on the communication was that all this works fine now and
> > > > > > > > thereby Luca has "reverted the reverts" in 19.11.6 [1].
> > > > > > > >
> > > > > > > > But today we were made aware that still no OVS 2.13 builds against a
> > > > > > > > DPDK that has those changes.
> > > > > > > > Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
> > > > > > > > backported) the recent 2.13.3 does build.
> > > > > > > > They still fail with the very same issue I reported [2] back then.
> > > > > > > >
> > > > > > > > Unfortunately I have just released 19.11.7 so I can't revert them
> > > > > > > > there - but OTOH reverting and counter reverting every other release
> > > > > > > > seems wrong anyway.
> > > > > >
> > > > > > It is wrong indeed, but the main question here is why these patches was
> > > > > > backported to stable release in a first place?
> > > > > >
> > > > > > Looking at these patches, they are not actual bug fixes but more like "nice to
> > > > > > have" features that additionally breaks the way application links with DPDK.
> > > > > > Stuff like that should not be acceptable to the stable release without a strong
> > > > > > justification or, at least, testing with actual applications.
> > > >
> > > > I agree, but TBH IIRC these changes were initially by OVS people :-)
> > > > One could chase down the old talks between Luca and the requesters, but I don't
> > > > think that gains us that much.
> > > >
> > > > > > Since we already have a revert of revert, revert of revert of revert doesn't
> > > > > > seem so bad.
> > > >
> > > > As long as we don't extend this series, yeah
> > > >
> > > > > > > > I wanted to ask if there is a set of patches that OVS would need to
> > > > > > > > backport to 2.13.x to make this work?
> > > > > > > > If they could be identified and prepared Distros could use them on
> > > > > > > > 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
> > > > > > > >
> > > > > > > > But for that we'd need a hint which OVS changes that would need to be.
> > > > > > > > All I know atm is from the testing reports on DPDK it seems that OVS
> > > > > > > > 2.14.3 and 2.15 are happy with the new DPDK code.
> > > > > > > > Do you have pointers on what 2.13.3 would need to get backported to
> > > > > > > > work again in regard to this build issue.
> > > > > > >
> > > > > > > You would need to use partial contents from patch :
> > > > > > > http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-
> > > > > > 26215
> > > > > > > -1-git-send-email-ian.stokes@intel.com/
> > > > > > >
> > > > > > > If you'd like me to send patches which would work with 2.13, 2.14, I'm
> > > > > > > ok with that too.[keeping only those parts from patch which fixes the issue
> > > > > > you see.] But we must ensure it doesn’t cause problems for OVS too.
> > > > > > > Your thoughts Ilya ?
> > > > > >
> > > > > > We had more fixes on top of this particular patch and I'd like to not cherry-
> > > > > > pick and re-check all of this again.
> > > > >
> > > > > I agree, we had more fixes on top of this. It would be risky to cherry-pick.
> > > > > So it might be a better option to revert.
> > > >
> > > > I agree, as far as I assessed the situation it would mean the revert
> > > > of the following list.
> > > > And since that is a lot of "reverts" in the string, to be clear it means that
> > > > those original changes would not be present anymore in 19.11.x.
> > > >
> > > > f49248a990 Revert "Revert "build/pkg-config: prevent overlinking""
> > > > 39586a4cf0 Revert "Revert "build/pkg-config: improve static linking flags""
> > > > 906e935a1f Revert "Revert "build/pkg-config: output drivers first for
> > > > static build""
> > > > deebf95239 Revert "Revert "build/pkg-config: move pkg-config file creation""
> > > > a3bd9a34bf Revert "Revert "build: always link whole DPDK static libraries""
> > > > d4bc124438 Revert "Revert "devtools: test static linkage with pkg-config""
> > > >
> > > > But to avoid going back&forth I'd prefer to have a signed-off on that
> > > > approach from:
> > > > - Luca (for 19.11.6 which has added the changes)
> > > > - Bruce (for being involved in the old&new case in general)
> > > > - Thomas (for general master maintainer thoughts)
> > > >
> > >
> > > If this is what is needed to ensure OVS can continue to use this release
> > > series, then I am absolutely fine with it.
> >
> > This was requested by OVS, so if they don't need it anymore it's fine
> > by me as well
>
> I am not sure to understand the full story,
> but I am a bit worried that our release is dictated by
> a single "user" (project using DPDK).

Sure, fair to ask for more detail :-)

> Please do you have links of discussion history?

I ordered the events by time and added links to those occasions that I
could find:

July 2020            - Initial request by OVS - *1
July 2020            - Initial queuing     -
http://mails.dpdk.org/archives/stable/2020-July/024248.html
September 2020 - Issues identified; changes reverted    -
http://mails.dpdk.org/archives/stable/2020-September/024796.html
October 2020      - Re-applying early in 19.11.6 cycle    - *1
November 2020  - Tests didn't spot it with 19.11.6 as OVS 2.14.x (not
the 2.13 LTS) was tested    -
https://doc.dpdk.org/guides-19.11/rel_notes/release_19_11.html#id16
March 2021         - Same issue re-found in >=19.11.6    -
http://mails.dpdk.org/archives/stable/2021-March/029418.html

*1 - Luca and I looked for logs, there are no links that I'd know of
and Luca said it might have come up as a request during a meeting.





>
>


--
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [dpdk-dev] 19.11.4 patches review and test

[Thomas Monjalon]

22/03/2021 15:27, Christian Ehrhardt:
> On Mon, Mar 22, 2021 at 1:25 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 22/03/2021 12:59, Luca Boccassi:
> > > On Mon, 2021-03-22 at 11:41 +0000, Bruce Richardson wrote:
> > > > On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote:
> > > > > On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil <sunil.pai.g@intel.com> wrote:
> > > > > > Hi Christian, Ilya
> > > > > > From: Ilya Maximets <i.maximets@ovn.org>
> > > > > > > On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> > > > > > > > Hey Christian,
> > > > > > > >
> > > > > > > > <snipped>
> > > > > > > >
> > > > > > > > > back  in 19.11.4 these DPDK changes were not picked up as they have
> > > > > > > > > broken builds as discussed here.
> > > > > > > > > Later on the communication was that all this works fine now and
> > > > > > > > > thereby Luca has "reverted the reverts" in 19.11.6 [1].
> > > > > > > > >
> > > > > > > > > But today we were made aware that still no OVS 2.13 builds against a
> > > > > > > > > DPDK that has those changes.
> > > > > > > > > Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
> > > > > > > > > backported) the recent 2.13.3 does build.
> > > > > > > > > They still fail with the very same issue I reported [2] back then.
> > > > > > > > >
> > > > > > > > > Unfortunately I have just released 19.11.7 so I can't revert them
> > > > > > > > > there - but OTOH reverting and counter reverting every other release
> > > > > > > > > seems wrong anyway.
> > > > > > >
> > > > > > > It is wrong indeed, but the main question here is why these patches was
> > > > > > > backported to stable release in a first place?
> > > > > > >
> > > > > > > Looking at these patches, they are not actual bug fixes but more like "nice to
> > > > > > > have" features that additionally breaks the way application links with DPDK.
> > > > > > > Stuff like that should not be acceptable to the stable release without a strong
> > > > > > > justification or, at least, testing with actual applications.
> > > > >
> > > > > I agree, but TBH IIRC these changes were initially by OVS people :-)
> > > > > One could chase down the old talks between Luca and the requesters, but I don't
> > > > > think that gains us that much.
> > > > >
> > > > > > > Since we already have a revert of revert, revert of revert of revert doesn't
> > > > > > > seem so bad.
> > > > >
> > > > > As long as we don't extend this series, yeah
> > > > >
> > > > > > > > > I wanted to ask if there is a set of patches that OVS would need to
> > > > > > > > > backport to 2.13.x to make this work?
> > > > > > > > > If they could be identified and prepared Distros could use them on
> > > > > > > > > 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
> > > > > > > > >
> > > > > > > > > But for that we'd need a hint which OVS changes that would need to be.
> > > > > > > > > All I know atm is from the testing reports on DPDK it seems that OVS
> > > > > > > > > 2.14.3 and 2.15 are happy with the new DPDK code.
> > > > > > > > > Do you have pointers on what 2.13.3 would need to get backported to
> > > > > > > > > work again in regard to this build issue.
> > > > > > > >
> > > > > > > > You would need to use partial contents from patch :
> > > > > > > > http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-
> > > > > > > 26215
> > > > > > > > -1-git-send-email-ian.stokes@intel.com/
> > > > > > > >
> > > > > > > > If you'd like me to send patches which would work with 2.13, 2.14, I'm
> > > > > > > > ok with that too.[keeping only those parts from patch which fixes the issue
> > > > > > > you see.] But we must ensure it doesn’t cause problems for OVS too.
> > > > > > > > Your thoughts Ilya ?
> > > > > > >
> > > > > > > We had more fixes on top of this particular patch and I'd like to not cherry-
> > > > > > > pick and re-check all of this again.
> > > > > >
> > > > > > I agree, we had more fixes on top of this. It would be risky to cherry-pick.
> > > > > > So it might be a better option to revert.
> > > > >
> > > > > I agree, as far as I assessed the situation it would mean the revert
> > > > > of the following list.
> > > > > And since that is a lot of "reverts" in the string, to be clear it means that
> > > > > those original changes would not be present anymore in 19.11.x.
> > > > >
> > > > > f49248a990 Revert "Revert "build/pkg-config: prevent overlinking""
> > > > > 39586a4cf0 Revert "Revert "build/pkg-config: improve static linking flags""
> > > > > 906e935a1f Revert "Revert "build/pkg-config: output drivers first for
> > > > > static build""
> > > > > deebf95239 Revert "Revert "build/pkg-config: move pkg-config file creation""
> > > > > a3bd9a34bf Revert "Revert "build: always link whole DPDK static libraries""
> > > > > d4bc124438 Revert "Revert "devtools: test static linkage with pkg-config""
> > > > >
> > > > > But to avoid going back&forth I'd prefer to have a signed-off on that
> > > > > approach from:
> > > > > - Luca (for 19.11.6 which has added the changes)
> > > > > - Bruce (for being involved in the old&new case in general)
> > > > > - Thomas (for general master maintainer thoughts)
> > > > >
> > > >
> > > > If this is what is needed to ensure OVS can continue to use this release
> > > > series, then I am absolutely fine with it.
> > >
> > > This was requested by OVS, so if they don't need it anymore it's fine
> > > by me as well
> >
> > I am not sure to understand the full story,
> > but I am a bit worried that our release is dictated by
> > a single "user" (project using DPDK).
> 
> Sure, fair to ask for more detail :-)
> 
> > Please do you have links of discussion history?
> 
> I ordered the events by time and added links to those occasions that I
> could find:
> 
> July 2020            - Initial request by OVS - *1
> July 2020            - Initial queuing     -
> http://mails.dpdk.org/archives/stable/2020-July/024248.html
> September 2020 - Issues identified; changes reverted    -
> http://mails.dpdk.org/archives/stable/2020-September/024796.html
> October 2020      - Re-applying early in 19.11.6 cycle    - *1
> November 2020  - Tests didn't spot it with 19.11.6 as OVS 2.14.x (not
> the 2.13 LTS) was tested    -
> https://doc.dpdk.org/guides-19.11/rel_notes/release_19_11.html#id16
> March 2021         - Same issue re-found in >=19.11.6    -
> http://mails.dpdk.org/archives/stable/2021-March/029418.html
> 
> *1 - Luca and I looked for logs, there are no links that I'd know of
> and Luca said it might have come up as a request during a meeting.

First, I agree to revert the changes again if it causes a regression.
Second, do we know the root cause of the issue?
Is it a problem with the version of pkg-config?
Is it OK with DPDK 20.11?

About the process, I see multiple issues:

1/ Some patches were backported for OVS only,
but it could break other applications.

2/ It is not clear whether the patches were really needed in 19.11.

3/ There is no trace of backport requests in the mailing list.

So I feel we should be stricter on the reasons for a backport.
Note: I am not blaming anyone. Everybody tries to do the best.
I believe sharing requests and discussions on the mailing list
could help in the decision process.

Thanks for all the work.

Re: [dpdk-dev] 19.11.4 patches review and test

[Ilya Maximets]

On 3/23/21 7:17 PM, Thomas Monjalon wrote:
> 22/03/2021 15:27, Christian Ehrhardt:
>> On Mon, Mar 22, 2021 at 1:25 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>>> 22/03/2021 12:59, Luca Boccassi:
>>>> On Mon, 2021-03-22 at 11:41 +0000, Bruce Richardson wrote:
>>>>> On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote:
>>>>>> On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil <sunil.pai.g@intel.com> wrote:
>>>>>>> Hi Christian, Ilya
>>>>>>> From: Ilya Maximets <i.maximets@ovn.org>
>>>>>>>> On 3/18/21 2:36 PM, Pai G, Sunil wrote:
>>>>>>>>> Hey Christian,
>>>>>>>>>
>>>>>>>>> <snipped>
>>>>>>>>>
>>>>>>>>>> back  in 19.11.4 these DPDK changes were not picked up as they have
>>>>>>>>>> broken builds as discussed here.
>>>>>>>>>> Later on the communication was that all this works fine now and
>>>>>>>>>> thereby Luca has "reverted the reverts" in 19.11.6 [1].
>>>>>>>>>>
>>>>>>>>>> But today we were made aware that still no OVS 2.13 builds against a
>>>>>>>>>> DPDK that has those changes.
>>>>>>>>>> Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
>>>>>>>>>> backported) the recent 2.13.3 does build.
>>>>>>>>>> They still fail with the very same issue I reported [2] back then.
>>>>>>>>>>
>>>>>>>>>> Unfortunately I have just released 19.11.7 so I can't revert them
>>>>>>>>>> there - but OTOH reverting and counter reverting every other release
>>>>>>>>>> seems wrong anyway.
>>>>>>>>
>>>>>>>> It is wrong indeed, but the main question here is why these patches was
>>>>>>>> backported to stable release in a first place?
>>>>>>>>
>>>>>>>> Looking at these patches, they are not actual bug fixes but more like "nice to
>>>>>>>> have" features that additionally breaks the way application links with DPDK.
>>>>>>>> Stuff like that should not be acceptable to the stable release without a strong
>>>>>>>> justification or, at least, testing with actual applications.
>>>>>>
>>>>>> I agree, but TBH IIRC these changes were initially by OVS people :-)
>>>>>> One could chase down the old talks between Luca and the requesters, but I don't
>>>>>> think that gains us that much.
>>>>>>
>>>>>>>> Since we already have a revert of revert, revert of revert of revert doesn't
>>>>>>>> seem so bad.
>>>>>>
>>>>>> As long as we don't extend this series, yeah
>>>>>>
>>>>>>>>>> I wanted to ask if there is a set of patches that OVS would need to
>>>>>>>>>> backport to 2.13.x to make this work?
>>>>>>>>>> If they could be identified and prepared Distros could use them on
>>>>>>>>>> 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
>>>>>>>>>>
>>>>>>>>>> But for that we'd need a hint which OVS changes that would need to be.
>>>>>>>>>> All I know atm is from the testing reports on DPDK it seems that OVS
>>>>>>>>>> 2.14.3 and 2.15 are happy with the new DPDK code.
>>>>>>>>>> Do you have pointers on what 2.13.3 would need to get backported to
>>>>>>>>>> work again in regard to this build issue.
>>>>>>>>>
>>>>>>>>> You would need to use partial contents from patch :
>>>>>>>>> http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-
>>>>>>>> 26215
>>>>>>>>> -1-git-send-email-ian.stokes@intel.com/
>>>>>>>>>
>>>>>>>>> If you'd like me to send patches which would work with 2.13, 2.14, I'm
>>>>>>>>> ok with that too.[keeping only those parts from patch which fixes the issue
>>>>>>>> you see.] But we must ensure it doesn’t cause problems for OVS too.
>>>>>>>>> Your thoughts Ilya ?
>>>>>>>>
>>>>>>>> We had more fixes on top of this particular patch and I'd like to not cherry-
>>>>>>>> pick and re-check all of this again.
>>>>>>>
>>>>>>> I agree, we had more fixes on top of this. It would be risky to cherry-pick.
>>>>>>> So it might be a better option to revert.
>>>>>>
>>>>>> I agree, as far as I assessed the situation it would mean the revert
>>>>>> of the following list.
>>>>>> And since that is a lot of "reverts" in the string, to be clear it means that
>>>>>> those original changes would not be present anymore in 19.11.x.
>>>>>>
>>>>>> f49248a990 Revert "Revert "build/pkg-config: prevent overlinking""
>>>>>> 39586a4cf0 Revert "Revert "build/pkg-config: improve static linking flags""
>>>>>> 906e935a1f Revert "Revert "build/pkg-config: output drivers first for
>>>>>> static build""
>>>>>> deebf95239 Revert "Revert "build/pkg-config: move pkg-config file creation""
>>>>>> a3bd9a34bf Revert "Revert "build: always link whole DPDK static libraries""
>>>>>> d4bc124438 Revert "Revert "devtools: test static linkage with pkg-config""
>>>>>>
>>>>>> But to avoid going back&forth I'd prefer to have a signed-off on that
>>>>>> approach from:
>>>>>> - Luca (for 19.11.6 which has added the changes)
>>>>>> - Bruce (for being involved in the old&new case in general)
>>>>>> - Thomas (for general master maintainer thoughts)
>>>>>>
>>>>>
>>>>> If this is what is needed to ensure OVS can continue to use this release
>>>>> series, then I am absolutely fine with it.
>>>>
>>>> This was requested by OVS, so if they don't need it anymore it's fine
>>>> by me as well
>>>
>>> I am not sure to understand the full story,
>>> but I am a bit worried that our release is dictated by
>>> a single "user" (project using DPDK).
>>
>> Sure, fair to ask for more detail :-)
>>
>>> Please do you have links of discussion history?
>>
>> I ordered the events by time and added links to those occasions that I
>> could find:
>>
>> July 2020            - Initial request by OVS - *1
>> July 2020            - Initial queuing     -
>> http://mails.dpdk.org/archives/stable/2020-July/024248.html
>> September 2020 - Issues identified; changes reverted    -
>> http://mails.dpdk.org/archives/stable/2020-September/024796.html
>> October 2020      - Re-applying early in 19.11.6 cycle    - *1
>> November 2020  - Tests didn't spot it with 19.11.6 as OVS 2.14.x (not
>> the 2.13 LTS) was tested    -
>> https://doc.dpdk.org/guides-19.11/rel_notes/release_19_11.html#id16
>> March 2021         - Same issue re-found in >=19.11.6    -
>> http://mails.dpdk.org/archives/stable/2021-March/029418.html
>>
>> *1 - Luca and I looked for logs, there are no links that I'd know of
>> and Luca said it might have come up as a request during a meeting.
> 
> First, I agree to revert the changes again if it causes a regression.
> Second, do we know the root cause of the issue?
> Is it a problem with the version of pkg-config?
> Is it OK with DPDK 20.11?
> 

I'd like to also ask someone to test build of both OVS 2.13 and OVS 2.14
with these changes and with these changes reverted. 

Sunil, could you do that?

> About the process, I see multiple issues:
> 
> 1/ Some patches were backported for OVS only,
> but it could break other applications.
> 
> 2/ It is not clear whether the patches were really needed in 19.11.
> 
> 3/ There is no trace of backport requests in the mailing list.
> 
> So I feel we should be stricter on the reasons for a backport.
> Note: I am not blaming anyone. Everybody tries to do the best.
> I believe sharing requests and discussions on the mailing list
> could help in the decision process.

+1

> 
> Thanks for all the work.

Re: [dpdk-dev] 19.11.4 patches review and test

[Christian Ehrhardt]

On Tue, Mar 23, 2021 at 7:51 PM Ilya Maximets <i.maximets@ovn.org> wrote:
>
> On 3/23/21 7:17 PM, Thomas Monjalon wrote:
> > 22/03/2021 15:27, Christian Ehrhardt:
> >> On Mon, Mar 22, 2021 at 1:25 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >>> 22/03/2021 12:59, Luca Boccassi:
> >>>> On Mon, 2021-03-22 at 11:41 +0000, Bruce Richardson wrote:
> >>>>> On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt wrote:
> >>>>>> On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil <sunil.pai.g@intel.com> wrote:
> >>>>>>> Hi Christian, Ilya
> >>>>>>> From: Ilya Maximets <i.maximets@ovn.org>
> >>>>>>>> On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> >>>>>>>>> Hey Christian,
> >>>>>>>>>
> >>>>>>>>> <snipped>
> >>>>>>>>>
> >>>>>>>>>> back  in 19.11.4 these DPDK changes were not picked up as they have
> >>>>>>>>>> broken builds as discussed here.
> >>>>>>>>>> Later on the communication was that all this works fine now and
> >>>>>>>>>> thereby Luca has "reverted the reverts" in 19.11.6 [1].
> >>>>>>>>>>
> >>>>>>>>>> But today we were made aware that still no OVS 2.13 builds against a
> >>>>>>>>>> DPDK that has those changes.
> >>>>>>>>>> Not 2.13.1 as we have it in Ubuntu nor (if it needs some OVS changes
> >>>>>>>>>> backported) the recent 2.13.3 does build.
> >>>>>>>>>> They still fail with the very same issue I reported [2] back then.
> >>>>>>>>>>
> >>>>>>>>>> Unfortunately I have just released 19.11.7 so I can't revert them
> >>>>>>>>>> there - but OTOH reverting and counter reverting every other release
> >>>>>>>>>> seems wrong anyway.
> >>>>>>>>
> >>>>>>>> It is wrong indeed, but the main question here is why these patches was
> >>>>>>>> backported to stable release in a first place?
> >>>>>>>>
> >>>>>>>> Looking at these patches, they are not actual bug fixes but more like "nice to
> >>>>>>>> have" features that additionally breaks the way application links with DPDK.
> >>>>>>>> Stuff like that should not be acceptable to the stable release without a strong
> >>>>>>>> justification or, at least, testing with actual applications.
> >>>>>>
> >>>>>> I agree, but TBH IIRC these changes were initially by OVS people :-)
> >>>>>> One could chase down the old talks between Luca and the requesters, but I don't
> >>>>>> think that gains us that much.
> >>>>>>
> >>>>>>>> Since we already have a revert of revert, revert of revert of revert doesn't
> >>>>>>>> seem so bad.
> >>>>>>
> >>>>>> As long as we don't extend this series, yeah
> >>>>>>
> >>>>>>>>>> I wanted to ask if there is a set of patches that OVS would need to
> >>>>>>>>>> backport to 2.13.x to make this work?
> >>>>>>>>>> If they could be identified and prepared Distros could use them on
> >>>>>>>>>> 2.13.3 asap and 2.13.4 could officially release them for OVS later on.
> >>>>>>>>>>
> >>>>>>>>>> But for that we'd need a hint which OVS changes that would need to be.
> >>>>>>>>>> All I know atm is from the testing reports on DPDK it seems that OVS
> >>>>>>>>>> 2.14.3 and 2.15 are happy with the new DPDK code.
> >>>>>>>>>> Do you have pointers on what 2.13.3 would need to get backported to
> >>>>>>>>>> work again in regard to this build issue.
> >>>>>>>>>
> >>>>>>>>> You would need to use partial contents from patch :
> >>>>>>>>> http://patchwork.ozlabs.org/project/openvswitch/patch/1608142365-
> >>>>>>>> 26215
> >>>>>>>>> -1-git-send-email-ian.stokes@intel.com/
> >>>>>>>>>
> >>>>>>>>> If you'd like me to send patches which would work with 2.13, 2.14, I'm
> >>>>>>>>> ok with that too.[keeping only those parts from patch which fixes the issue
> >>>>>>>> you see.] But we must ensure it doesn’t cause problems for OVS too.
> >>>>>>>>> Your thoughts Ilya ?
> >>>>>>>>
> >>>>>>>> We had more fixes on top of this particular patch and I'd like to not cherry-
> >>>>>>>> pick and re-check all of this again.
> >>>>>>>
> >>>>>>> I agree, we had more fixes on top of this. It would be risky to cherry-pick.
> >>>>>>> So it might be a better option to revert.
> >>>>>>
> >>>>>> I agree, as far as I assessed the situation it would mean the revert
> >>>>>> of the following list.
> >>>>>> And since that is a lot of "reverts" in the string, to be clear it means that
> >>>>>> those original changes would not be present anymore in 19.11.x.
> >>>>>>
> >>>>>> f49248a990 Revert "Revert "build/pkg-config: prevent overlinking""
> >>>>>> 39586a4cf0 Revert "Revert "build/pkg-config: improve static linking flags""
> >>>>>> 906e935a1f Revert "Revert "build/pkg-config: output drivers first for
> >>>>>> static build""
> >>>>>> deebf95239 Revert "Revert "build/pkg-config: move pkg-config file creation""
> >>>>>> a3bd9a34bf Revert "Revert "build: always link whole DPDK static libraries""
> >>>>>> d4bc124438 Revert "Revert "devtools: test static linkage with pkg-config""
> >>>>>>
> >>>>>> But to avoid going back&forth I'd prefer to have a signed-off on that
> >>>>>> approach from:
> >>>>>> - Luca (for 19.11.6 which has added the changes)
> >>>>>> - Bruce (for being involved in the old&new case in general)
> >>>>>> - Thomas (for general master maintainer thoughts)
> >>>>>>
> >>>>>
> >>>>> If this is what is needed to ensure OVS can continue to use this release
> >>>>> series, then I am absolutely fine with it.
> >>>>
> >>>> This was requested by OVS, so if they don't need it anymore it's fine
> >>>> by me as well
> >>>
> >>> I am not sure to understand the full story,
> >>> but I am a bit worried that our release is dictated by
> >>> a single "user" (project using DPDK).
> >>
> >> Sure, fair to ask for more detail :-)
> >>
> >>> Please do you have links of discussion history?
> >>
> >> I ordered the events by time and added links to those occasions that I
> >> could find:
> >>
> >> July 2020            - Initial request by OVS - *1
> >> July 2020            - Initial queuing     -
> >> http://mails.dpdk.org/archives/stable/2020-July/024248.html
> >> September 2020 - Issues identified; changes reverted    -
> >> http://mails.dpdk.org/archives/stable/2020-September/024796.html
> >> October 2020      - Re-applying early in 19.11.6 cycle    - *1
> >> November 2020  - Tests didn't spot it with 19.11.6 as OVS 2.14.x (not
> >> the 2.13 LTS) was tested    -
> >> https://doc.dpdk.org/guides-19.11/rel_notes/release_19_11.html#id16
> >> March 2021         - Same issue re-found in >=19.11.6    -
> >> http://mails.dpdk.org/archives/stable/2021-March/029418.html
> >>
> >> *1 - Luca and I looked for logs, there are no links that I'd know of
> >> and Luca said it might have come up as a request during a meeting.
> >
> > First, I agree to revert the changes again if it causes a regression.
> > Second, do we know the root cause of the issue?
> > Is it a problem with the version of pkg-config?
> > Is it OK with DPDK 20.11?
> >
>
> I'd like to also ask someone to test build of both OVS 2.13 and OVS 2.14
> with these changes and with these changes reverted.

I've test built a few of those already.
- 19.11.4 (before the patches were applied)
  - OVS 2.13.1 worked
- 19.11.6/19.11.7 (patches not yet reverted)
  - OVS 2.13.1 fails
  - OVS 2.13.3 fails
- 19.11.7 patches reverted
  - OVS 2.13.3 works

I'd also be happy to hear about OVS 2.14 test builds, so yeah if you
could do so  @Sunil that would be great.
For the code, I've not yet pushed it to "real dpdk-stable" until we
are sure about it, but already to:
  https://github.com/cpaelzer/dpdk-stable-queue/tree/19.11
If you happen to build on Ubuntu there is a 19.11.7 + reverts already
available here
  https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3690/

> Sunil, could you do that?
>
> > About the process, I see multiple issues:
> >
> > 1/ Some patches were backported for OVS only,
> > but it could break other applications.

As we found it even breaks (older) OVS, but importantly the OVS LTS
which has the highest chance to be in use together with DPDK 19.11 in
many places :-/

> > 2/ It is not clear whether the patches were really needed in 19.11.
> >
> > 3/ There is no trace of backport requests in the mailing list.
> >
> > So I feel we should be stricter on the reasons for a backport.
> > Note: I am not blaming anyone. Everybody tries to do the best.
> > I believe sharing requests and discussions on the mailing list
> > could help in the decision process.

Agreed

> +1
>
> >
> > Thanks for all the work.



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd

Re: [dpdk-dev] 19.11.4 patches review and test

[Pai G, Sunil]

> -----Original Message-----
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Sent: Wednesday, March 24, 2021 1:15 PM
> To: Ilya Maximets <i.maximets@ovn.org>
> Cc: Thomas Monjalon <thomas@monjalon.net>; Luca Boccassi
> <bluca@debian.org>; Richardson, Bruce <bruce.richardson@intel.com>; Pai
> G, Sunil <sunil.pai.g@intel.com>; Stokes, Ian <ian.stokes@intel.com>;
> Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>;
> stable@dpdk.org; dev <dev@dpdk.org>; James Page
> <james.page@canonical.com>
> Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> 
> On Tue, Mar 23, 2021 at 7:51 PM Ilya Maximets <i.maximets@ovn.org>
> wrote:
> >
> > On 3/23/21 7:17 PM, Thomas Monjalon wrote:
> > > 22/03/2021 15:27, Christian Ehrhardt:
> > >> On Mon, Mar 22, 2021 at 1:25 PM Thomas Monjalon
> <thomas@monjalon.net> wrote:
> > >>> 22/03/2021 12:59, Luca Boccassi:
> > >>>> On Mon, 2021-03-22 at 11:41 +0000, Bruce Richardson wrote:
> > >>>>> On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt
> wrote:
> > >>>>>> On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil
> <sunil.pai.g@intel.com> wrote:
> > >>>>>>> Hi Christian, Ilya
> > >>>>>>> From: Ilya Maximets <i.maximets@ovn.org>
> > >>>>>>>> On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> > >>>>>>>>> Hey Christian,
> > >>>>>>>>>
> > >>>>>>>>> <snipped>
> > >>>>>>>>>
> > >>>>>>>>>> back  in 19.11.4 these DPDK changes were not picked up as
> > >>>>>>>>>> they have broken builds as discussed here.
> > >>>>>>>>>> Later on the communication was that all this works fine now
> > >>>>>>>>>> and thereby Luca has "reverted the reverts" in 19.11.6 [1].
> > >>>>>>>>>>
> > >>>>>>>>>> But today we were made aware that still no OVS 2.13 builds
> > >>>>>>>>>> against a DPDK that has those changes.
> > >>>>>>>>>> Not 2.13.1 as we have it in Ubuntu nor (if it needs some
> > >>>>>>>>>> OVS changes
> > >>>>>>>>>> backported) the recent 2.13.3 does build.
> > >>>>>>>>>> They still fail with the very same issue I reported [2] back
> then.
> > >>>>>>>>>>
> > >>>>>>>>>> Unfortunately I have just released 19.11.7 so I can't
> > >>>>>>>>>> revert them there - but OTOH reverting and counter
> > >>>>>>>>>> reverting every other release seems wrong anyway.
> > >>>>>>>>
> > >>>>>>>> It is wrong indeed, but the main question here is why these
> > >>>>>>>> patches was backported to stable release in a first place?
> > >>>>>>>>
> > >>>>>>>> Looking at these patches, they are not actual bug fixes but
> > >>>>>>>> more like "nice to have" features that additionally breaks the
> way application links with DPDK.
> > >>>>>>>> Stuff like that should not be acceptable to the stable
> > >>>>>>>> release without a strong justification or, at least, testing with
> actual applications.
> > >>>>>>
> > >>>>>> I agree, but TBH IIRC these changes were initially by OVS
> > >>>>>> people :-) One could chase down the old talks between Luca and
> > >>>>>> the requesters, but I don't think that gains us that much.
> > >>>>>>
> > >>>>>>>> Since we already have a revert of revert, revert of revert of
> > >>>>>>>> revert doesn't seem so bad.
> > >>>>>>
> > >>>>>> As long as we don't extend this series, yeah
> > >>>>>>
> > >>>>>>>>>> I wanted to ask if there is a set of patches that OVS would
> > >>>>>>>>>> need to backport to 2.13.x to make this work?
> > >>>>>>>>>> If they could be identified and prepared Distros could use
> > >>>>>>>>>> them on
> > >>>>>>>>>> 2.13.3 asap and 2.13.4 could officially release them for OVS
> later on.
> > >>>>>>>>>>
> > >>>>>>>>>> But for that we'd need a hint which OVS changes that would
> need to be.
> > >>>>>>>>>> All I know atm is from the testing reports on DPDK it seems
> > >>>>>>>>>> that OVS
> > >>>>>>>>>> 2.14.3 and 2.15 are happy with the new DPDK code.
> > >>>>>>>>>> Do you have pointers on what 2.13.3 would need to get
> > >>>>>>>>>> backported to work again in regard to this build issue.
> > >>>>>>>>>
> > >>>>>>>>> You would need to use partial contents from patch :
> > >>>>>>>>>
> http://patchwork.ozlabs.org/project/openvswitch/patch/160814
> > >>>>>>>>> 2365-
> > >>>>>>>> 26215
> > >>>>>>>>> -1-git-send-email-ian.stokes@intel.com/
> > >>>>>>>>>
> > >>>>>>>>> If you'd like me to send patches which would work with 2.13,
> > >>>>>>>>> 2.14, I'm ok with that too.[keeping only those parts from
> > >>>>>>>>> patch which fixes the issue
> > >>>>>>>> you see.] But we must ensure it doesn’t cause problems for
> OVS too.
> > >>>>>>>>> Your thoughts Ilya ?
> > >>>>>>>>
> > >>>>>>>> We had more fixes on top of this particular patch and I'd
> > >>>>>>>> like to not cherry- pick and re-check all of this again.
> > >>>>>>>
> > >>>>>>> I agree, we had more fixes on top of this. It would be risky to
> cherry-pick.
> > >>>>>>> So it might be a better option to revert.
> > >>>>>>
> > >>>>>> I agree, as far as I assessed the situation it would mean the
> > >>>>>> revert of the following list.
> > >>>>>> And since that is a lot of "reverts" in the string, to be clear
> > >>>>>> it means that those original changes would not be present
> anymore in 19.11.x.
> > >>>>>>
> > >>>>>> f49248a990 Revert "Revert "build/pkg-config: prevent
> overlinking""
> > >>>>>> 39586a4cf0 Revert "Revert "build/pkg-config: improve static linking
> flags""
> > >>>>>> 906e935a1f Revert "Revert "build/pkg-config: output drivers
> > >>>>>> first for static build""
> > >>>>>> deebf95239 Revert "Revert "build/pkg-config: move pkg-config file
> creation""
> > >>>>>> a3bd9a34bf Revert "Revert "build: always link whole DPDK static
> libraries""
> > >>>>>> d4bc124438 Revert "Revert "devtools: test static linkage with pkg-
> config""
> > >>>>>>
> > >>>>>> But to avoid going back&forth I'd prefer to have a signed-off
> > >>>>>> on that approach from:
> > >>>>>> - Luca (for 19.11.6 which has added the changes)
> > >>>>>> - Bruce (for being involved in the old&new case in general)
> > >>>>>> - Thomas (for general master maintainer thoughts)
> > >>>>>>
> > >>>>>
> > >>>>> If this is what is needed to ensure OVS can continue to use this
> > >>>>> release series, then I am absolutely fine with it.
> > >>>>
> > >>>> This was requested by OVS, so if they don't need it anymore it's
> > >>>> fine by me as well
> > >>>
> > >>> I am not sure to understand the full story, but I am a bit worried
> > >>> that our release is dictated by a single "user" (project using
> > >>> DPDK).
> > >>
> > >> Sure, fair to ask for more detail :-)
> > >>
> > >>> Please do you have links of discussion history?
> > >>
> > >> I ordered the events by time and added links to those occasions
> > >> that I could find:
> > >>
> > >> July 2020            - Initial request by OVS - *1
> > >> July 2020            - Initial queuing     -
> > >> http://mails.dpdk.org/archives/stable/2020-July/024248.html
> > >> September 2020 - Issues identified; changes reverted    -
> > >> http://mails.dpdk.org/archives/stable/2020-September/024796.html
> > >> October 2020      - Re-applying early in 19.11.6 cycle    - *1
> > >> November 2020  - Tests didn't spot it with 19.11.6 as OVS 2.14.x (not
> > >> the 2.13 LTS) was tested    -
> > >> https://doc.dpdk.org/guides-19.11/rel_notes/release_19_11.html#id16
> > >> March 2021         - Same issue re-found in >=19.11.6    -
> > >> http://mails.dpdk.org/archives/stable/2021-March/029418.html
> > >>
> > >> *1 - Luca and I looked for logs, there are no links that I'd know
> > >> of and Luca said it might have come up as a request during a meeting.
> > >
> > > First, I agree to revert the changes again if it causes a regression.
> > > Second, do we know the root cause of the issue?
> > > Is it a problem with the version of pkg-config?
> > > Is it OK with DPDK 20.11?
> > >
> >
> > I'd like to also ask someone to test build of both OVS 2.13 and OVS
> > 2.14 with these changes and with these changes reverted.
> 
> I've test built a few of those already.
> - 19.11.4 (before the patches were applied)
>   - OVS 2.13.1 worked
> - 19.11.6/19.11.7 (patches not yet reverted)
>   - OVS 2.13.1 fails
>   - OVS 2.13.3 fails
> - 19.11.7 patches reverted
>   - OVS 2.13.3 works
> 
> I'd also be happy to hear about OVS 2.14 test builds, so yeah if you could do
> so  @Sunil that would be great.

Tested 19.11 series with OVS 2.14 and observations are like your's Christian.
19.11.4 and 19.11.7 -with patches reverted works fine, 19.11.6/7(patches not yet reverted) cause linking errors.


> For the code, I've not yet pushed it to "real dpdk-stable" until we are sure
> about it, but already to:
>   https://github.com/cpaelzer/dpdk-stable-queue/tree/19.11
> If you happen to build on Ubuntu there is a 19.11.7 + reverts already available
> here
>   https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3690/
> 
> > Sunil, could you do that?
> >
> > > About the process, I see multiple issues:
> > >
> > > 1/ Some patches were backported for OVS only, but it could break
> > > other applications.
> 
> As we found it even breaks (older) OVS, but importantly the OVS LTS which
> has the highest chance to be in use together with DPDK 19.11 in many places
> :-/
> 
> > > 2/ It is not clear whether the patches were really needed in 19.11.
> > >
> > > 3/ There is no trace of backport requests in the mailing list.
> > >
> > > So I feel we should be stricter on the reasons for a backport.
> > > Note: I am not blaming anyone. Everybody tries to do the best.
> > > I believe sharing requests and discussions on the mailing list could
> > > help in the decision process.
> 
> Agreed
> 
> > +1
> >
> > >
> > > Thanks for all the work.
> 
> 
> 
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd

Re: [dpdk-dev] 19.11.4 patches review and test

[Christian Ehrhardt]

On Wed, Mar 24, 2021 at 11:28 AM Pai G, Sunil <sunil.pai.g@intel.com> wrote:
>
> > -----Original Message-----
> > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > Sent: Wednesday, March 24, 2021 1:15 PM
> > To: Ilya Maximets <i.maximets@ovn.org>
> > Cc: Thomas Monjalon <thomas@monjalon.net>; Luca Boccassi
> > <bluca@debian.org>; Richardson, Bruce <bruce.richardson@intel.com>; Pai
> > G, Sunil <sunil.pai.g@intel.com>; Stokes, Ian <ian.stokes@intel.com>;
> > Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>;
> > stable@dpdk.org; dev <dev@dpdk.org>; James Page
> > <james.page@canonical.com>
> > Subject: Re: [dpdk-dev] 19.11.4 patches review and test
> >
> > On Tue, Mar 23, 2021 at 7:51 PM Ilya Maximets <i.maximets@ovn.org>
> > wrote:
> > >
> > > On 3/23/21 7:17 PM, Thomas Monjalon wrote:
> > > > 22/03/2021 15:27, Christian Ehrhardt:
> > > >> On Mon, Mar 22, 2021 at 1:25 PM Thomas Monjalon
> > <thomas@monjalon.net> wrote:
> > > >>> 22/03/2021 12:59, Luca Boccassi:
> > > >>>> On Mon, 2021-03-22 at 11:41 +0000, Bruce Richardson wrote:
> > > >>>>> On Mon, Mar 22, 2021 at 10:49:54AM +0100, Christian Ehrhardt
> > wrote:
> > > >>>>>> On Thu, Mar 18, 2021 at 7:25 PM Pai G, Sunil
> > <sunil.pai.g@intel.com> wrote:
> > > >>>>>>> Hi Christian, Ilya
> > > >>>>>>> From: Ilya Maximets <i.maximets@ovn.org>
> > > >>>>>>>> On 3/18/21 2:36 PM, Pai G, Sunil wrote:
> > > >>>>>>>>> Hey Christian,
> > > >>>>>>>>>
> > > >>>>>>>>> <snipped>
> > > >>>>>>>>>
> > > >>>>>>>>>> back  in 19.11.4 these DPDK changes were not picked up as
> > > >>>>>>>>>> they have broken builds as discussed here.
> > > >>>>>>>>>> Later on the communication was that all this works fine now
> > > >>>>>>>>>> and thereby Luca has "reverted the reverts" in 19.11.6 [1].
> > > >>>>>>>>>>
> > > >>>>>>>>>> But today we were made aware that still no OVS 2.13 builds
> > > >>>>>>>>>> against a DPDK that has those changes.
> > > >>>>>>>>>> Not 2.13.1 as we have it in Ubuntu nor (if it needs some
> > > >>>>>>>>>> OVS changes
> > > >>>>>>>>>> backported) the recent 2.13.3 does build.
> > > >>>>>>>>>> They still fail with the very same issue I reported [2] back
> > then.
> > > >>>>>>>>>>
> > > >>>>>>>>>> Unfortunately I have just released 19.11.7 so I can't
> > > >>>>>>>>>> revert them there - but OTOH reverting and counter
> > > >>>>>>>>>> reverting every other release seems wrong anyway.
> > > >>>>>>>>
> > > >>>>>>>> It is wrong indeed, but the main question here is why these
> > > >>>>>>>> patches was backported to stable release in a first place?
> > > >>>>>>>>
> > > >>>>>>>> Looking at these patches, they are not actual bug fixes but
> > > >>>>>>>> more like "nice to have" features that additionally breaks the
> > way application links with DPDK.
> > > >>>>>>>> Stuff like that should not be acceptable to the stable
> > > >>>>>>>> release without a strong justification or, at least, testing with
> > actual applications.
> > > >>>>>>
> > > >>>>>> I agree, but TBH IIRC these changes were initially by OVS
> > > >>>>>> people :-) One could chase down the old talks between Luca and
> > > >>>>>> the requesters, but I don't think that gains us that much.
> > > >>>>>>
> > > >>>>>>>> Since we already have a revert of revert, revert of revert of
> > > >>>>>>>> revert doesn't seem so bad.
> > > >>>>>>
> > > >>>>>> As long as we don't extend this series, yeah
> > > >>>>>>
> > > >>>>>>>>>> I wanted to ask if there is a set of patches that OVS would
> > > >>>>>>>>>> need to backport to 2.13.x to make this work?
> > > >>>>>>>>>> If they could be identified and prepared Distros could use
> > > >>>>>>>>>> them on
> > > >>>>>>>>>> 2.13.3 asap and 2.13.4 could officially release them for OVS
> > later on.
> > > >>>>>>>>>>
> > > >>>>>>>>>> But for that we'd need a hint which OVS changes that would
> > need to be.
> > > >>>>>>>>>> All I know atm is from the testing reports on DPDK it seems
> > > >>>>>>>>>> that OVS
> > > >>>>>>>>>> 2.14.3 and 2.15 are happy with the new DPDK code.
> > > >>>>>>>>>> Do you have pointers on what 2.13.3 would need to get
> > > >>>>>>>>>> backported to work again in regard to this build issue.
> > > >>>>>>>>>
> > > >>>>>>>>> You would need to use partial contents from patch :
> > > >>>>>>>>>
> > http://patchwork.ozlabs.org/project/openvswitch/patch/160814
> > > >>>>>>>>> 2365-
> > > >>>>>>>> 26215
> > > >>>>>>>>> -1-git-send-email-ian.stokes@intel.com/
> > > >>>>>>>>>
> > > >>>>>>>>> If you'd like me to send patches which would work with 2.13,
> > > >>>>>>>>> 2.14, I'm ok with that too.[keeping only those parts from
> > > >>>>>>>>> patch which fixes the issue
> > > >>>>>>>> you see.] But we must ensure it doesn’t cause problems for
> > OVS too.
> > > >>>>>>>>> Your thoughts Ilya ?
> > > >>>>>>>>
> > > >>>>>>>> We had more fixes on top of this particular patch and I'd
> > > >>>>>>>> like to not cherry- pick and re-check all of this again.
> > > >>>>>>>
> > > >>>>>>> I agree, we had more fixes on top of this. It would be risky to
> > cherry-pick.
> > > >>>>>>> So it might be a better option to revert.
> > > >>>>>>
> > > >>>>>> I agree, as far as I assessed the situation it would mean the
> > > >>>>>> revert of the following list.
> > > >>>>>> And since that is a lot of "reverts" in the string, to be clear
> > > >>>>>> it means that those original changes would not be present
> > anymore in 19.11.x.
> > > >>>>>>
> > > >>>>>> f49248a990 Revert "Revert "build/pkg-config: prevent
> > overlinking""
> > > >>>>>> 39586a4cf0 Revert "Revert "build/pkg-config: improve static linking
> > flags""
> > > >>>>>> 906e935a1f Revert "Revert "build/pkg-config: output drivers
> > > >>>>>> first for static build""
> > > >>>>>> deebf95239 Revert "Revert "build/pkg-config: move pkg-config file
> > creation""
> > > >>>>>> a3bd9a34bf Revert "Revert "build: always link whole DPDK static
> > libraries""
> > > >>>>>> d4bc124438 Revert "Revert "devtools: test static linkage with pkg-
> > config""
> > > >>>>>>
> > > >>>>>> But to avoid going back&forth I'd prefer to have a signed-off
> > > >>>>>> on that approach from:
> > > >>>>>> - Luca (for 19.11.6 which has added the changes)
> > > >>>>>> - Bruce (for being involved in the old&new case in general)
> > > >>>>>> - Thomas (for general master maintainer thoughts)
> > > >>>>>>
> > > >>>>>
> > > >>>>> If this is what is needed to ensure OVS can continue to use this
> > > >>>>> release series, then I am absolutely fine with it.
> > > >>>>
> > > >>>> This was requested by OVS, so if they don't need it anymore it's
> > > >>>> fine by me as well
> > > >>>
> > > >>> I am not sure to understand the full story, but I am a bit worried
> > > >>> that our release is dictated by a single "user" (project using
> > > >>> DPDK).
> > > >>
> > > >> Sure, fair to ask for more detail :-)
> > > >>
> > > >>> Please do you have links of discussion history?
> > > >>
> > > >> I ordered the events by time and added links to those occasions
> > > >> that I could find:
> > > >>
> > > >> July 2020            - Initial request by OVS - *1
> > > >> July 2020            - Initial queuing     -
> > > >> http://mails.dpdk.org/archives/stable/2020-July/024248.html
> > > >> September 2020 - Issues identified; changes reverted    -
> > > >> http://mails.dpdk.org/archives/stable/2020-September/024796.html
> > > >> October 2020      - Re-applying early in 19.11.6 cycle    - *1
> > > >> November 2020  - Tests didn't spot it with 19.11.6 as OVS 2.14.x (not
> > > >> the 2.13 LTS) was tested    -
> > > >> https://doc.dpdk.org/guides-19.11/rel_notes/release_19_11.html#id16
> > > >> March 2021         - Same issue re-found in >=19.11.6    -
> > > >> http://mails.dpdk.org/archives/stable/2021-March/029418.html
> > > >>
> > > >> *1 - Luca and I looked for logs, there are no links that I'd know
> > > >> of and Luca said it might have come up as a request during a meeting.
> > > >
> > > > First, I agree to revert the changes again if it causes a regression.
> > > > Second, do we know the root cause of the issue?
> > > > Is it a problem with the version of pkg-config?
> > > > Is it OK with DPDK 20.11?
> > > >
> > >
> > > I'd like to also ask someone to test build of both OVS 2.13 and OVS
> > > 2.14 with these changes and with these changes reverted.
> >
> > I've test built a few of those already.
> > - 19.11.4 (before the patches were applied)
> >   - OVS 2.13.1 worked
> > - 19.11.6/19.11.7 (patches not yet reverted)
> >   - OVS 2.13.1 fails
> >   - OVS 2.13.3 fails
> > - 19.11.7 patches reverted
> >   - OVS 2.13.3 works
> >
> > I'd also be happy to hear about OVS 2.14 test builds, so yeah if you could do
> > so  @Sunil that would be great.
>
> Tested 19.11 series with OVS 2.14 and observations are like your's Christian.
> 19.11.4 and 19.11.7 -with patches reverted works fine, 19.11.6/7(patches not yet reverted) cause linking errors.

Thank you, with those tests and all the ack's in I'll push this to the
19.11 branch on the dpdk-stable repo.

> > For the code, I've not yet pushed it to "real dpdk-stable" until we are sure
> > about it, but already to:
> >   https://github.com/cpaelzer/dpdk-stable-queue/tree/19.11
> > If you happen to build on Ubuntu there is a 19.11.7 + reverts already available
> > here
> >   https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3690/
> >
> > > Sunil, could you do that?
> > >
> > > > About the process, I see multiple issues:
> > > >
> > > > 1/ Some patches were backported for OVS only, but it could break
> > > > other applications.
> >
> > As we found it even breaks (older) OVS, but importantly the OVS LTS which
> > has the highest chance to be in use together with DPDK 19.11 in many places
> > :-/
> >
> > > > 2/ It is not clear whether the patches were really needed in 19.11.
> > > >
> > > > 3/ There is no trace of backport requests in the mailing list.
> > > >
> > > > So I feel we should be stricter on the reasons for a backport.
> > > > Note: I am not blaming anyone. Everybody tries to do the best.
> > > > I believe sharing requests and discussions on the mailing list could
> > > > help in the decision process.
> >
> > Agreed
> >
> > > +1
> > >
> > > >
> > > > Thanks for all the work.
> >
> >
> >
> > --
> > Christian Ehrhardt
> > Staff Engineer, Ubuntu Server
> > Canonical Ltd



-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd