From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A27DFA0C4C; Sat, 7 Aug 2021 23:06:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 216AD4067E; Sat, 7 Aug 2021 23:06:13 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id F032340140 for ; Sat, 7 Aug 2021 23:06:11 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4C5685C0037; Sat, 7 Aug 2021 17:06:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 07 Aug 2021 17:06:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= UFfRG9Mg/zVDl4BpJByy3/Z0SegGDltTpBahSUM783o=; b=0IYQlM4fxm9yVClQ hk+V7gQUpycfoxTS5+qDQFNuF8kjcMgzm6EJnSyVVyXHRl9RMd4zyK+0frBRsOhc WGF2xKrboGYtlAbtP99JCvBorGxY2Gg07+mid0MIGNfhD3ZWHYcc9gTY8d/FBpJZ PzcwN3ol0U1ZjtbUNQAY6srHDEgnXMTdqnzUbtY8mnXhbPfjUhigADcWfeLFZnYS wpYQLa4eKnEs1XDYNqva2MCPdXuuWHFynyD44WyO26z3dxjoLI+LeIDlAIAPQYaG u7kxH+85vj3qYW+TIklC89IgJCj9rc2Tcff/jRsuexJGPtHVFVRN4ZeN5MJHWX6R IGUVNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=UFfRG9Mg/zVDl4BpJByy3/Z0SegGDltTpBahSUM78 3o=; b=fjts6ahFW9xl2apMiDGtyW42paVg4Z/7SUjJh35GmBkL+okiSKrzN/f/h WWzarO4KlBykPTquR2Zy4rmWOy44I1nKXeC7tFJTVXlWNXZY6ZeHH1mVw8zMajrf ZiBR/k0Pv1CfX7kaPO0AputXES8CkB295dPSHssL46ZEcGaqF2shlGZs5OA3SbyM MRSLCkXd888+o3MNwaUgEpNsI4lG8O4nbW3ediwzT9qWKg0p6nFpFjxhQc4qL8OW HZCQev0G/OoG7ti1Vwm4Ih8kuOc5XdO+bOmYUEWkXWpNHAgAGcgXEaXl9mAWliCi sFrd5NQptcCtztktZnzPtxYzPcCxw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeefgdduheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 7 Aug 2021 17:06:08 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Ferruh Yigit , Ori Kam , Eli Britstein , Ilya Maximets , Matan Azrad , Ivan Malov , Viacheslav Galaktionov , Ajit Khaparde Date: Sat, 07 Aug 2021 23:06:06 +0200 Message-ID: <5272083.v5ZNQeQ6Eo@thomas> In-Reply-To: References: <20210801102214.1566104-1-andrew.rybchenko@oktetlabs.ru> <20210802195723.2153114-1-andrew.rybchenko@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: announce flow API action PORT_ID changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > By its very name, action PORT_ID means that packets hit an ethdev with the > > given DPDK port ID. At least the current comments don't state the opposite. > > > > However some drivers implement it in a different way and direct traffic to > > the opposite end of the "wire" plugged to the given ethdev. For example in > > the case of a VF representor traffic is redirected to the corresponding VF > > itself rather than to the representor ethdev and OvS uses PORT_ID action > > this way. > > > > The documentation must be clarified and, likely, rte_flow_action_port_id > > structure should be extended to support both meanings. > > > > Signed-off-by: Andrew Rybchenko > > Acked-by: Ori Kam > > --- > > +* ethdev: Definition of the flow API action PORT_ID is ambiguous and needs > > + clarification. Structure rte_flow_action_port_id will be extended to > > + specify traffic direction to represented entity or ethdev port itself in > Nit! "to the represented entity"? > Otherwise > Acked-by: Ajit Khaparde I agree clarification is welcome. Acked-by: Thomas Monjalon Applied with above change, thanks.