From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7568AA0524; Fri, 19 Mar 2021 18:14:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2074114100E; Fri, 19 Mar 2021 18:14:59 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id 9809740143 for ; Fri, 19 Mar 2021 18:14:58 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id EC04C580A95; Fri, 19 Mar 2021 13:14:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 19 Mar 2021 13:14:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= scM9rpUtKzcIoyYvyw84vPUbiLmVxSuGZGhHo22fc5c=; b=wjmtWuR7KtMePa8V 4tGkRGXMT2dWT/1c+owF/ImCHyxZllFh/xykkmUxAWGFcAWn0H3ZISx8ylu3BqE4 +D5nTdPyV5pkGMvW5/c/8J1m2NtUlaagkpAf7G8qGBBtVN/q94G+GFysgqas4TpN Y9xcm7nT012gdz0trD74RwbZBP8+2pC6zZRH1IiIUfzbAvt0/aSk0TptgzhUQrAD j9/FtjuN4DJS+GRx56P4YDUFf9siiOI0JYvfambKM+T13sSPgq07JyutIayTN1PU i9mOp4bDqFJqdWZydwxp5CZbWVvVirOOof36tShN2TgT+5mHkWgM2X/oQ7+omt5M i9ucYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=scM9rpUtKzcIoyYvyw84vPUbiLmVxSuGZGhHo22fc 5c=; b=ExjQOBqOTOFHwCMqz0mgP89A6je7CitHF78FsHDmxsnvnL5gY6+iePVkn TQGU7dcB55FbEnt+ZTtf+pYuuM+g5hGa0PrLbwT9bTss9enmj5E8rrb1vbQp3xMz 4y4Yrj0sFw/lcdlh9BQOIUdHkR+7Wg28NVzqqs6VThvBR01oTI+D82U6/pNEXMwB TD0iuoXn0eqtEb2KykgUeMw3dHh7kiWQZOuQ2uWW5Ch1Haw7oceJvbBH9Wx7m3Ad lYRnsv3Vv7npm1JsJvkzgBa5xPbfLXfwyeQ37Zd3L0eUPlOa3odrhV+4u3tW97Ix nlSrLfLGYPlsflp+ciKx/EM0ViIjg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefkedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpefhuefgueefheeujeehhfejffdtkeeviedvffejudekjeduheff hefgheegudduheenucffohhmrghinhepphhmugdrnhgvthenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EF471240054; Fri, 19 Mar 2021 13:14:55 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , John Griffin , Fiona Trahe , Deepak Kumar Jain , Ajit Khaparde , Raveendra Padasalagi , Vikas Gupta , Rosen Xu , Tianfei zhang , Bruce Richardson , Nipun Gupta , Hemant Agrawal , Xiao Wang Date: Fri, 19 Mar 2021 18:14:53 +0100 Message-ID: <5273226.FjvTQ7qL0s@thomas> In-Reply-To: References: <20210310140107.2730088-1-thomas@monjalon.net> <20210310140107.2730088-4-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/3] drivers: align log names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/03/2021 17:29, David Marchand: > On Wed, Mar 10, 2021 at 3:02 PM Thomas Monjalon wrote: > > > > The log levels are configured by using the name of the logs. > > Some drivers are aligned to follow a common log name standard: > > pmd.class.driver[.sub] > > Some "common" drivers skip the "class" part: > > pmd.driver.sub > > Without a check, this is likely to happen again. > I cooked this: [...] > +RTE_LOG_REGISTER(ixgbe_logtype_init, pmd.net.ixgb.init, NOTICE); > Added logtype does not comply with pattern: pmd.net.ixgbe > +RTE_LOG_REGISTER(compressdev_logtype, lib.compressde, NOTICE); > Added logtype does not comply with pattern: lib.compressdev > > WDYT? I cannot parse awk but it looks nice. And in general, have more tools is a good thing. Would you submit this tool as a patch?