From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9EF0A0560; Sun, 26 Jun 2022 17:50:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F1E041144; Sun, 26 Jun 2022 17:50:45 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 95E7441141 for ; Sun, 26 Jun 2022 17:50:43 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DD11032007F1; Sun, 26 Jun 2022 11:50:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 26 Jun 2022 11:50:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656258641; x= 1656345041; bh=w7vDD+8MxcgF3S0TK+ob8YI/jR8e7pHPFhzDGM/1RBU=; b=n Jsa/qGkmr1Hn2M+60aBoBO9IbSNEdJDbhaD376xrZCg2YmswV+alGACwpAPq6OTd D9Gm1ZTFPJ9CYlrq4ymyOILsKWWzJhGajYqUIWvd6jJisubujfklFD6mocxwryyL AHW/5fRGoVve/LHM4a35h9XRWhJB81B09awp/PzJvn+3SNFT2mO/KHjJdv5zgXYn myuS/YEgi3gLJpJPoitlJCdpLED54XZ0PSwmIaYc5lZd0/RjSVktaUMnB/ljkNdV Zqq/DbxctvNNX/lF7oXh/LILZiCSpf4+EmZr6B36ysKxpH6VD/I7hdTsdNgbnR6Y I0LWWm074f/wt+JGXeuVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656258641; x= 1656345041; bh=w7vDD+8MxcgF3S0TK+ob8YI/jR8e7pHPFhzDGM/1RBU=; b=H 94+U3kMiRWoBD0iQnOyjS2BMUsbMvONSsQbdhDhM2x7gpEnWDxkMfcAHbv88pVF5 hBhvqzTKsWMKGaHSiGEeetpHmXWfx+OovhhYCZIaFTRzvf5VRQTGIqpc8tnIcdBy B0MBIFOt+/w0qLZ0x+QEighwPcttk8ZYcWTPrjoZ8j9hhUsFLXtGnEYZhVT5KV6m CNd1pzTyGbqR+PeQR++8BApY8B0fkH9DZRh/VdgSCKQ9i2zY0KcdJ7rSDqjyzz0r S47lC3TvUb/DMQPo5+1uyrzshZ6rZgRQS5jIki6MpW1TaRCZNsPX+xwR/Qlt5gmx mdFL2360KEjc6NzQIiqiw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudegfedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Jun 2022 11:50:39 -0400 (EDT) From: Thomas Monjalon To: "Min Hu (Connor)" , Dongdong Liu Cc: dev@dpdk.org, stephen@networkplumber.org, ferruh.yigit@amd.com, reshma.pattan@intel.com, mtahhan@redhat.com, Maryam Tahhan Subject: Re: [PATCH v4] app/procinfo: add device private info dump Date: Sun, 26 Jun 2022 17:50:38 +0200 Message-ID: <5278982.anssfa2V6d@thomas> In-Reply-To: <20220606143932.12772-1-liudongdong3@huawei.com> References: <20220602062216.25372-1-humin29@huawei.com> <20220606143932.12772-1-liudongdong3@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 06/06/2022 16:39, Dongdong Liu: > From: "Min Hu (Connor)" > > This patch adds support for dump the device private info from a running > application. It can help developers locate the problem. > > Signed-off-by: Min Hu (Connor) > Signed-off-by: Dongdong Liu > Acked-by: Reshma Pattan Applied, thanks. [...] > /**< Enable show port. */ > static uint32_t enable_shw_port; > +/**< Enable show port private info. */ > +static uint32_t enable_shw_port_priv; That's very strange this file is using some (wrong) doxygen syntax. I'll fix this one when applying. A cleanup may be needed for other comments in the file. > /**< Enable show tm. */ > static uint32_t enable_shw_tm; > /**< Enable show crypto. */