From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 25F145F25 for ; Mon, 1 Oct 2018 19:10:55 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AB08F2203B; Mon, 1 Oct 2018 13:10:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Oct 2018 13:10:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=YN6rkQS+lFJXjRp6y73zL21qrh I1kJ4NgWfjFtFZdkM=; b=A8LpGvSDRt4IUV6xN82kpqVUC5bshN1JPJGQuAc6N+ 7MynrJc9qiGFfyGPZVsmWX9QcVEuejGyH9PboLF5WjHesNCs0gvWRDi7JqJKFLHs 7bsOX3OCqikCriEQLaAcXVIA3OfF9X7uO5RfBdBado0OQ2ydt2deIALve50Cr6Qw c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=YN6rkQ S+lFJXjRp6y73zL21qrhI1kJ4NgWfjFtFZdkM=; b=JZkilBWOHc2a/UKZ+4UqrD rQvFdQZRDahZ+YLo0LCatRFDim+wA9FiDCSvMijUagkDWUj2SFeJoiRlAULoP39c t3uqIzK0+HuFkMgiGPBCg/6hGoA9ruhBiwWS1u+loCC1eFqbtwerR5pvB1zLhbHO LiQszaObVoQ5b/2eZqZLsUY8ZJLCjR9DTiyUJkCa/LTdKqSVwjmqXk3C3RMRl2/3 +398NX/4Z7nH2LCtz+vD29j5bwGZTN8lEjhiNt2vm3fKR4Act80TigUWjqWtSJZx ln43EJFWOWAAVrPYbuLWmMmCqtPoqWiyOjcYrZsOBn5aQYFNM37kgcslTwqAjHiA == X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (211.18.136.77.rev.sfr.net [77.136.18.211]) by mail.messagingengine.com (Postfix) with ESMTPA id 453B2E405E; Mon, 1 Oct 2018 13:10:52 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com, ktraynor@redhat.com Date: Mon, 01 Oct 2018 19:10:49 +0200 Message-ID: <5284368.tvJgfgGlPD@xps> In-Reply-To: <71b916a0-e3ae-3c3a-023b-77ec283a821d@solarflare.com> References: <20180907222727.20521-1-thomas@monjalon.net> <20180928162144.1972-2-thomas@monjalon.net> <71b916a0-e3ae-3c3a-023b-77ec283a821d@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/4] devargs: remove deprecated functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 17:10:55 -0000 01/10/2018 13:24, Andrew Rybchenko: > On 9/28/18 7:21 PM, Thomas Monjalon wrote: > > rte_eal_parse_devargs_str() does not support parsing the bus name > > at the start of devargs. So it has been renamed and deprecated. > > > > rte_eal_devargs_add(), rte_eal_devargs_type_count() and > > rte_eal_devargs_dump() were declared deprecated and had their > > implementation body renamed. > > > > All these functions were deprecated in release 18.05. > > > > Signed-off-by: Thomas Monjalon > > Reviewed-by: Andrew Rybchenko > > I would say that it is more fair to say that changes related to > rte_eal_devargs_add(), rte_eal_devargs_type_count() and > rte_eal_devargs_dump() fixes b65ecf19 since the changeset > simply removes these functions. May be the ideal solution > is to add changeset which adds these deprecated functions > and simply calls replacement and remove in the next changeset. > But it is too many efforts for nothing, so good to go as is. Yes, not worth the effort. > Should it be mentioned in release notes (API removal)? Yes, you're right, will add a note in v4. Thanks