From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE9C342428; Wed, 25 Jan 2023 13:55:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF6F242D3E; Wed, 25 Jan 2023 13:55:54 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 3060D42D31 for ; Wed, 25 Jan 2023 13:55:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C66A95C003F; Wed, 25 Jan 2023 07:55:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 25 Jan 2023 07:55:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674651352; x= 1674737752; bh=VSAJ7QO8v7ymGl1tZzgz86bvizSmgekkVM+Ni1qdY6Q=; b=Y Yst8XB3jHJz2W5CcIkz/3uAbzNivWNVy8Cd/rnVKPvIHqOhZzvqqpt9XUeFJmi77 hftbYwRR2wNWs/3FOT60bzVdBQm0RGhlBjPdvUaZrP3PiWdn2JGgInTI0U/MbpMV tq8rwdeYULnYF62XL+XtJiU8QwJHufgV1xoqfw+psTpWUah0chJtyT7vb5ly+YkV QR6DQQaHPuIBLKasmdVz77mWXkKI3/+oJ3ZiW0F+LgrRJ4UlfzWF658aPbBS9Z5s flokxnFovs+em1Eq9iALbkFomRrQ+BT+voCVBw6u6h6TMiNDYzEG7w+Cq9/p9ux5 bPYfIRSU/c9lZNpBjkL7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674651352; x= 1674737752; bh=VSAJ7QO8v7ymGl1tZzgz86bvizSmgekkVM+Ni1qdY6Q=; b=l 0QQ0XXk8ATq19dI92C7ZGVIGvSR6a+C1FX/hdnJFoD2cpsKdMEido+Tf1cldO4hm NQF/nDH9uBnOE1tIsaq7CU2He/MqoKE8gBkWSA3biLWL8iJtbpcit/sAcKaF+hiu mqPnt8ZPx1rm2jDDPnmsHc7PN6Xk5/7CXJI2U8k3bRTNcM+BetuGHUxZhq9qbcYx bB3wAZvbdNZekcVqOqZ/vYOwxxa4WsaPR6vpETNB0LwMBFQVwpBiK6RpckrXtGs4 g1ILfBSgxcaBXY+mniXDfjfZOsjjIDh8+SIj0jzaKH44TpuO556hPz9NTcQOYJ5V 14+fock9gwiELIHsbBjEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvvddggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Jan 2023 07:55:50 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit , Aman Singh , Yuying Zhang , Ivan Malov , Andrew Rybchenko , dev@dpdk.org, Hanumanth Reddy Pothula Cc: "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "viacheslavo@nvidia.com" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , david.marchand@redhat.com Subject: Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation Date: Wed, 25 Jan 2023 13:55:49 +0100 Message-ID: <5290135.upeRZZJTqa@thomas> In-Reply-To: References: <20221220200250.2413443-1-hpothula@marvell.com> <11fa3448-7348-09d6-b7e0-321aef1d8953@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 25/01/2023 10:30, Hanumanth Reddy Pothula: > ++ Ivan Malov and Andrew Rybchenko > > From: Ferruh Yigit > > On 12/21/2022 2:07 AM, Hanumanth Pothula wrote: > > > Presently, Rx metadata is sent to PMD by default, leading to a > > > performance drop as processing for the same in Rx path takes extra > > > cycles. > > > > > > Hence, add new testpmd command, > > > 'enable port nic_to_pmd_rx_metadata' > > > > > > This command helps in sending Rx metadata to PMD and thereby Rx > > > metadata flow command requests are processed. > > > > > > Signed-off-by: Hanumanth Pothula > > > > Hi Hanumanth, > > > > I agree with Thomas for the patch. > > > > 'eth_rx_metadata_negotiate_mp()' requests all Rx metadata offloads to be > > enabled, but at this stage if there is no flow rule for Rx metadata why it is > > consuming extra cycles? > > > > Can you update driver code to process Rx metadata when it is enabled by > > application (via 'rte_eth_rx_metadata_negotiate()') AND there is at least > > one flow rule for it? > > #1 What is the purpose of rte_eth_rx_metadata_negotiate() API if it is always called by testpmd. > We thought it was added so that when that metadata is not needed, application need not call this > thereby saving cycles/bandwidth. testpmd is for testing all features. That's why all is negotiated. Cycles should be saved if you don't enable it until a flow rule requires it. > #2 We use this API similar to Rx/Tx offload flags so that we can set things up before device is > configured. We thought that is the purpose of having this negotiate API and avoid depleting offload flags. It is just a configuration negotiation specific to metadata. > #3 Generally any new offloads added to DPDK would be in disabled state in testpmd and we would have > an option to enable it. In this case, testpmd is by default calling this negotiation. Negotiating is not enabling. > We can update the driver if the purpose of this API is clear. Please do.