From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id CEB03559A for ; Fri, 22 Jul 2016 18:06:41 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id f65so62972501wmi.0 for ; Fri, 22 Jul 2016 09:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=pdWBDb79Rwbt1ItI0aOsMgg4xvq1PK50wxipa8kavS8=; b=QgisifxBBFku7oZh/JpygvuJz8tgGdlWfYIa5P8049ZKaNecNt2glgPg3wdLI36odq 4GHRHCWj2bgw2C7m6Qa8rWyZJc9L7LK2qeohKGDg5U1T3G0ibCJo2/4X7D7WU9w3Hq6t V9I+c76C2VqHq2fSmJxcClYcEd8x5r5bydYkVPXHMzdx6doC9HT+tJGS4gPrVux1PdgM A+vwJUSbGNM4VfD4njmYuxgA48QPMvSMSWlQiltTJRkWzHSzd3cHZANuMFKUIGvSZsSH PVid+oeEzf2kjx3SGw96clKbo/b5ryQ2NzxgUdO6LojWFvD4HF4UWR0d9H/etUPLuujt KL1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=pdWBDb79Rwbt1ItI0aOsMgg4xvq1PK50wxipa8kavS8=; b=U2gu8uw0207UDBw1FYlEm61rp9VCmG9MY6hw2pT6m6dFOzsRtzvB2r1Iuh8WbnINap YCoLsJqaZn6hTZOg3yGZxJ1LEkACe7ktmrLlDHI9MfKa7xttSR75fqUVp+e46YHhi7lH 09jSGAackKCyxDsswD41C14cDbQBPdfUkti3M5hZ81OdtB+/DO2WzCb5yH6YL6QrCvTj tzfQZtEuaPCnpkvxizYGzUBVRBfh0uFWucV+PVIsyknNpeSg+x9VOrnj94rvZZbDgs1v HdB7h7bB+tP3fs7fA52ZuQ6ezDJK0qOcfdnKa2ZC3kdXLvZwOczvdNXYk8XQbDto4CiY Tm6Q== X-Gm-Message-State: AEkoouvDvwvYX35x1HHECEW6J/zZXTEyn8c0MaTRCcRWlCdTiJimJoi8zymWDhOXnyP5+YV7 X-Received: by 10.194.23.166 with SMTP id n6mr1880593wjf.36.1469203601640; Fri, 22 Jul 2016 09:06:41 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id p83sm13205341wma.18.2016.07.22.09.06.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jul 2016 09:06:40 -0700 (PDT) From: Thomas Monjalon To: Yuanhan Liu Cc: "Mcnamara, John" , dev@dpdk.org Date: Fri, 22 Jul 2016 18:06:40 +0200 Message-ID: <5291738.m2lUS8501i@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160720010835.GO5146@yliu-dev.sh.intel.com> References: <1468901869-29609-1-git-send-email-yuanhan.liu@linux.intel.com> <20160720010835.GO5146@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: note a pitfall on reconnect feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 16:06:42 -0000 2016-07-20 09:08, Yuanhan Liu: > On Tue, Jul 19, 2016 at 01:57:11PM +0000, Mcnamara, John wrote: > > > - Note: the "reconnect" feature requires **QEMU v2.7** (or above). > > > + .. Note:: > > > + * The "reconnect" feature requires **QEMU v2.7** (or above). > > > + > > > + * The vhost supported features must be exactly the same before and > > > + after the restart. For example, if TSO is disabled and then > > > enabled, > > > + nothing will work and issues undefined might happen. > > > > s/ issues undefined / undefined issues / > > Thomas, mind to fix it while apply? Yes > > Apart from that: > > > > Acked-by: John McNamara > > Thanks! Applied, thanks