From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id DCAF723B
 for <dev@dpdk.org>; Thu, 15 Jun 2017 14:48:33 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 5087E2082A;
 Thu, 15 Jun 2017 08:48:33 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Thu, 15 Jun 2017 08:48:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=6enKxo727ddBXXB
 oid1N41Lto31e779f7vOA38i3Mtc=; b=cHvTnTpxs1Elvxg2xbsqHsPFeSadk6+
 Qdr2ubkbNEwIYqDDvmWRWGFTINwKFoYPX+q4MOIsLliwQaBl5UC8EwlfOOMe1Vb9
 naLS74NT0geROA4gWH69Iu0xb6/qGLh6hNHs2AKuw10XKMrFXwjkLWKFyJCw6unp
 8mH+K2HoQTdU=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=6enKxo727ddBXXBoid1N41Lto31e779f7vOA38i3Mtc=; b=jTsMXZP2
 3NE8JswI5Nv3BEy3FzWNlpOdP4s01lFitb1hytn2T17AJdd/mtvk+tqzm8gQBQR9
 i3IOeS0vq9jJJDu7EfMGPt8SvxKFokitzoH4PIt8ZAvZdwKc1GCQ3rJI4pxa/EMP
 A7xKHtUSG4H5q8hURLeIj6769ylA6jMGkjQT6rZBWhNPAdPyD9G8srgW+CD8tH1A
 6HxDMBG3uECrgaC2g6PF34nWLaGh61Ju/coRGFy3JD3JHGoL9iQ2NjXKlVnBtMWp
 6GQ2yOLnoKY+SOsG9fdm0/pfx3JSqeUFjDRrPsjDlShCiXGuCUGi0tM9vvLKd0Zx
 1oRqQLJcvGTuTA==
X-ME-Sender: <xms:IYJCWWiwLWmR2VQ33ZPgmF6zCD6Xm6cTLDae4HaZXZoTfPPXE8DItQ>
X-Sasl-enc: 3Odxr+D1uatF6ilRbx9a8REfy0mFnjIwTIWuqRGkhf1t 1497530913
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 05CBC24A26;
 Thu, 15 Jun 2017 08:48:33 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: wenzhuo.lu@intel.com, dev@dpdk.org
Date: Thu, 15 Jun 2017 14:48:32 +0200
Message-ID: <5294711.b1ZTK55eI0@xps>
In-Reply-To: <ff6185d5-5d11-3c1b-4138-7b040ae35394@intel.com>
References: <20170615095446.2187-1-thomas@monjalon.net>
 <ff6185d5-5d11-3c1b-4138-7b040ae35394@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix build without ixgbe
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jun 2017 12:48:34 -0000

15/06/2017 13:37, Radu Nicolau:
> Looks ok to me, but why would one enable IXGBE_BYPASS without enabling 
> IXGBE?
[...]
> > -#ifdef RTE_LIBRTE_IXGBE_BYPASS
> > +#if defined RTE_LIBRTE_IXGBE_PMD && defined RTE_LIBRTE_IXGBE_BYPASS

RTE_LIBRTE_IXGBE_BYPASS should not be enabled if RTE_LIBRTE_IXGBE_PMD is disabled.
But it can happen in some scripted configuration like test-build.sh does.

Anyway we should drop the RTE_LIBRTE_IXGBE_BYPASS configuration option
and enables it always.