From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier MATZ <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Samuel Gauthier <samuel.gauthier@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] mk: fix libs installation when installing sdk
Date: Fri, 15 Dec 2017 11:32:12 +0100 [thread overview]
Message-ID: <5295568.lEBEY0ou7Q@xps> (raw)
In-Reply-To: <20171215102516.ltn5uhrglvvnb66e@platinum>
15/12/2017 11:25, Olivier MATZ:
> On Fri, Dec 15, 2017 at 11:19:57AM +0100, Thomas Monjalon wrote:
> > 14/12/2017 15:24, Olivier Matz:
> > > @@ -157,6 +157,8 @@ install-sdk:
> > > $(Q)cp -a $O/.config $(DESTDIR)$(targetdir)
> > > $(Q)cp -a $O/app/dpdk-pmdinfogen $(DESTDIR)$(targetdir)/app
> > > $(Q)$(call rte_symlink, $(DESTDIR)$(includedir), $(DESTDIR)$(targetdir)/include)
> > > + $(Q)$(call rte_mkdir, $(DESTDIR)$(libdir))
> > > + $(Q)cp -a $O/lib/* $(DESTDIR)$(libdir)
> > > $(Q)$(call rte_symlink, $(DESTDIR)$(libdir), $(DESTDIR)$(targetdir)/lib)
> >
> > The libs are already installed with "make install-runtime".
> > Either we add a dependency between install-sdk and install-runtime,
> > or we clearly document it.
>
> To me, libs are needed when installing the sdk (to compile against them)
> and when installing the runtime (to use them).
>
> Is it a problem to have it in both targets?
Yes it is a problem because the general use is to call every targets,
so the libs will be installed twice. Look at the global "install" target.
Do you want to be able to install the SDK without the runtime?
next prev parent reply other threads:[~2017-12-15 10:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 14:24 Olivier Matz
2017-12-15 10:19 ` Thomas Monjalon
2017-12-15 10:25 ` Olivier MATZ
2017-12-15 10:32 ` Thomas Monjalon [this message]
2017-12-15 10:45 ` Olivier MATZ
2017-12-15 11:00 ` Thomas Monjalon
2018-01-23 16:30 ` Olivier Matz
2018-06-25 14:46 ` Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295568.lEBEY0ou7Q@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=samuel.gauthier@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).