From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 876BD43881; Wed, 10 Jan 2024 11:22:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D38640698; Wed, 10 Jan 2024 11:22:13 +0100 (CET) Received: from smtp-gw.pt.net (smtp-gw.pt.net [206.210.192.15]) by mails.dpdk.org (Postfix) with ESMTP id CE9824013F for ; Tue, 9 Jan 2024 17:00:28 +0100 (CET) X-ASG-Debug-ID: 1704816027-09411a10bb2311ed0001-TfluYd Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by smtp-gw.pt.net with ESMTP id vThJyTpH8LZVO1wB (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 09 Jan 2024 10:00:27 -0600 (CST) X-Barracuda-Envelope-From: lew@perftech.com X-Barracuda-Effective-Source-IP: mail.pt.net[206.210.194.11] X-Barracuda-Apparent-Source-IP: 206.210.194.11 Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 0CCA91B1EB31; Tue, 9 Jan 2024 10:00:27 -0600 (CST) Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10032) with ESMTP id PVvm9mdDZNz2; Tue, 9 Jan 2024 10:00:26 -0600 (CST) Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id AF5751B1EBA4; Tue, 9 Jan 2024 10:00:26 -0600 (CST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.pt.net AF5751B1EBA4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perftech.com; s=B15A3A56-ABEA-11EE-9719-5F12F125680F; t=1704816026; bh=L71nIvGu3kJiF5E5HWdgoCwLaebEL86dWrzpeeIWewc=; h=Date:From:To:Message-ID:MIME-Version; b=PYefE6PIyX57yodfHiFb/39Jam5XVABeOJfYisce6UhVTh/i7apLZiI48CMNoeQoy KK84jZ6vWa6ViSjHFiN1GPk9bkNgshCF03eIsfuKSmcqr5hHr24WT9pCkPqrwTr+hS MSPnyGyM+XaFccZ51+omP6HCgXCBrcIkANWz5Iw4BS8+Xe/KnnNksZTTmMO2JR69h4 2QvkG9HTmnqwcjHNKlXKR3qPpqkClw6h/hoNU9qV3ZEbrfsDWpVfbcVRk/dNhTpk3x RM9te8114VwAsRCf8vTbLBdwPTJuep1Us5G/r/wJI0aBGtzEV1phRtcoMOLlajhiJp +O6AKJ8MMt5AQ== X-Virus-Scanned: amavis at pt.net Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10026) with ESMTP id bMJRa4c4RGKK; Tue, 9 Jan 2024 10:00:26 -0600 (CST) Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by mail.pt.net (Postfix) with ESMTP id 946621B1EADE; Tue, 9 Jan 2024 10:00:26 -0600 (CST) Date: Tue, 9 Jan 2024 10:00:25 -0600 (CST) From: Lewis Donzis To: Bruce Richardson Cc: dev , Jochen Behrens , Yong Wang Message-ID: <529916588.1295809.1704816025297.JavaMail.zimbra@donzis.com> In-Reply-To: <20240109142343.163814-1-bruce.richardson@intel.com> References: <12922153.12944.1704552603431.JavaMail.zimbra@donzis.com> <20240109142343.163814-1-bruce.richardson@intel.com> Subject: Re: [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD MIME-Version: 1.0 X-ASG-Orig-Subj: Re: [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: [206.210.194.11] X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - GC120 (Mac)/8.8.15_GA_4581) Thread-Topic: net/vmxnet3: fix use of interrupts on FreeBSD Thread-Index: js4spOty5YY7DPURAWAzejyjDIXReg== X-Barracuda-Connect: mail.pt.net[206.210.194.11] X-Barracuda-Start-Time: 1704816027 X-Barracuda-Encrypted: TLS_AES_256_GCM_SHA384 X-Barracuda-URL: https://smtp-gw.pt.net:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at pt.net X-Barracuda-Scan-Msg-Size: 1859 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.119192 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Mailman-Approved-At: Wed, 10 Jan 2024 11:22:09 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org ----- On Jan 9, 2024, at 8:23 AM, Bruce Richardson bruce.richardson@intel.com wrote: > DPDK does not support interrupts on FreeBSD, so the vmxnet3 driver > returns error when enabling interrupts as it initializes. We can fix > this by #ifdef'ing out the interrupt calls when building for FreeBSD, > allowing the driver to initialize correctly. > > Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt") > > Reported-by: Lewis Donzis Tested-by: Lewis Donzis > Signed-off-by: Bruce Richardson > --- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c > b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index e49191718a..7032f0e324 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -257,6 +257,7 @@ vmxnet3_disable_all_intrs(struct vmxnet3_hw *hw) > vmxnet3_disable_intr(hw, i); > } > > +#ifndef RTE_EXEC_ENV_FREEBSD > /* > * Enable all intrs used by the device > */ > @@ -280,6 +281,7 @@ vmxnet3_enable_all_intrs(struct vmxnet3_hw *hw) > vmxnet3_enable_intr(hw, i); > } > } > +#endif > > /* > * Gets tx data ring descriptor size. > @@ -1129,6 +1131,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) > /* Setting proper Rx Mode and issue Rx Mode Update command */ > vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1); > > +#ifndef RTE_EXEC_ENV_FREEBSD > /* Setup interrupt callback */ > rte_intr_callback_register(dev->intr_handle, > vmxnet3_interrupt_handler, dev); > @@ -1140,6 +1143,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) > > /* enable all intrs */ > vmxnet3_enable_all_intrs(hw); > +#endif > > vmxnet3_process_events(dev); > > -- > 2.42.0