From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57C23A0A02; Wed, 24 Mar 2021 15:08:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5819140E8A; Wed, 24 Mar 2021 15:08:33 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 0FC74140E88 for ; Wed, 24 Mar 2021 15:08:30 +0100 (CET) IronPort-SDR: n+VDdzWGZ/w32tv8f+wbgUAVSYcUagbjuF2twulRZSAASf+gu3HLvscDJuX04fqeE517vPoSU/ x60ox/ykfY6A== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="177826538" X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="177826538" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 07:08:00 -0700 IronPort-SDR: nc/34aBX2MAYIjpezHipkPg/wNQsDP8mCt/gDmrUWn1+zNq8JQ7ZZ0r5Pi+5rkFog2KHoLWhuT GzCaPYHkGZvw== X-IronPort-AV: E=Sophos;i="5.81,274,1610438400"; d="scan'208";a="408857458" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.28.141]) ([10.252.28.141]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2021 07:07:59 -0700 To: Rasesh Mody , Devendra Singh Rawat , Igor Russkikh Cc: dev@dpdk.org, "jerinj@marvell.com" References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com> <1476850306-2141-12-git-send-email-rasesh.mody@qlogic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <52d81527-8857-171a-7881-c241a22ed023@intel.com> Date: Wed, 24 Mar 2021 14:07:53 +0000 MIME-Version: 1.0 In-Reply-To: <1476850306-2141-12-git-send-email-rasesh.mody@qlogic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4 11/32] net/qede/base: update base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/2016 5:11 AM, Rasesh Mody wrote: > This patch updates the base driver and incorporates necessary changes > required to bring in the new firmware 8.10.9.0. > > In addition, it would allow driver to add new functionalities that might > be needed in future. > > Signed-off-by: Rasesh Mody <...> > +#ifndef LINUX_REMOVE > /** > * @brief ecore_cxt_qm_iids - fills the cid/tid counts for the QM configuration > * > * @param p_hwfn > * @param iids [out], a structure holding all the counters > */ > -void ecore_cxt_qm_iids(struct ecore_hwfn *p_hwfn, struct ecore_qm_iids *iids); > +void ecore_cxt_qm_iids(struct ecore_hwfn *p_hwfn, > + struct ecore_qm_iids *iids); > +#endif > Hi Rasesh, Devendra Singh, Igor, The 'LINUX_REMOVE' macro is still in the driver code, it looks like that is remainder of code strip for different platforms. What do you think cleaning up them? Although it is not functional, just to remove the noise.. Same for '__EXTRACT__LINUX__' macro.