From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0063.outbound.protection.outlook.com [104.47.38.63]) by dpdk.org (Postfix) with ESMTP id DE2831DBF for ; Tue, 19 Dec 2017 06:40:10 +0100 (CET) Received: from DM5PR03CA0048.namprd03.prod.outlook.com (10.174.189.165) by BN6PR03MB2692.namprd03.prod.outlook.com (10.173.144.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.323.15; Tue, 19 Dec 2017 05:40:09 +0000 Received: from BN1AFFO11FD039.protection.gbl (2a01:111:f400:7c10::133) by DM5PR03CA0048.outlook.office365.com (2603:10b6:4:3b::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.323.15 via Frontend Transport; Tue, 19 Dec 2017 05:40:09 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD039.mail.protection.outlook.com (10.58.52.243) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.302.6 via Frontend Transport; Tue, 19 Dec 2017 05:39:56 +0000 Received: from [10.232.133.65] ([10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vBJ5e3sf027044; Mon, 18 Dec 2017 22:40:06 -0700 To: "Wiles, Keith" References: <1513333251-4147-1-git-send-email-hemant.agrawal@nxp.com> <1513334482-4788-1-git-send-email-hemant.agrawal@nxp.com> CC: "olivier.matz@6wind.com" , "dev@dpdk.org" , Jerin Jacob , Neil Horman From: Hemant Agrawal Message-ID: <52edf0a5-f406-1773-ee52-5ca9ee4cf7fc@nxp.com> Date: Tue, 19 Dec 2017 11:10:03 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131581355968069776; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(336005)(346002)(376002)(39860400002)(39380400002)(396003)(2980300002)(1110001)(1109001)(3190300001)(339900001)(24454002)(189003)(57704003)(199004)(97736004)(86362001)(58126008)(83506002)(50466002)(229853002)(54906003)(81156014)(67846002)(81166006)(8676002)(106466001)(85426001)(31696002)(76176011)(498600001)(77096006)(23676004)(2486003)(53936002)(36756003)(6246003)(4326008)(105606002)(316002)(8936002)(65806001)(356003)(305945005)(68736007)(47776003)(65826007)(64126003)(6666003)(5660300001)(65956001)(2870700001)(2906002)(2950100002)(104016004)(31686004)(53546011)(6916009); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2692; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD039; 1:rwtsdSxj/Ypiof2mJK43gWY/xcBdxTGd8wgJUcPocUcnuNW1rh0buSYfqriW/LGsOpV1RI+L60rbBxLHk6ikvMr31mTlpxIW68qX2pyuWmFQU+xwuiiy1N3h/j7+W+37 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 187cefdf-0356-40a4-8090-08d546a2f001 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4628075)(201703131517081)(2017052603307); SRVR:BN6PR03MB2692; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2692; 3:6Hnf8/R/Xwr8R9QJIYMFUrIpI/QUDJG53p4WX87QvgP1MD9JTXyQ/cagm8irdu8+gqZ3TLwVS8wT5PLhHizNrutuv/yjX3o7Q3ZTsBe3xzw/AkMdyMkQYFY/bM1edieNO/8fcwNOZzdR3rTfSvKCGxuGzyNsPn8zDoo4ZnKxhwEIJFDAaMUBviPWJ07551SMC9ku4Xx34OAKuKIaukX/Sx9wTRt7XAn49kqTFN98Ta8nnTSlyLDx+8XBfG0WGFu8sn/vlCk/0mG6EWBRuc4UVwEvWCG3DG7yfcsGf6MeZSD+lie9vwtXlB2mI1MjrPrI+X7DnUvDw9H5xNdNaoQUTJ7twxdmOvQYMABC29qkfsQ=; 25:RdoP4QqDFxwzElQeZglV9Oy8qeLoUVQVbniksTCcopI2fpmQpxl7Bt0BTWmu7jGwHkqLSh4ASdjhaqVbk5T3xJ40Hq7qCeG3X4i55l90XpphwpyZPw4sw8qdQyt/B26vepXMFCKrpIDCL0BiGYHdhbKdRGhhSYbec1hntUmN6EzkoyjqD9aQvCXyZMaO3rJQw6EuWBeO7+NZcJ7K16aWbQ+UAc92KZmffj43u2tyvehnh/3dR1FoUOF5QFP/WtDYHHebF8xnlHvsWkMxuB2WMV8X8rswQdiBwi/mgwwCMKRtPBAe6OOCuoGea7QQrm+R0DBBid5ufCwmEzL87r5ddA== X-MS-TrafficTypeDiagnostic: BN6PR03MB2692: X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2692; 31:SXxxIEUp0Bo568Jz0peosUNjqYFpjl8/A8Z1FbD8X2xf5ZL6OZ3SRkREOVIaS3pVPL6wzpNFx2lcKEEMJ6uFIDVgOhOJzzKFKXpK/3nrCmqJZKx/oxTBfVdksFNrSv8MH9V3Ps65utI/zJd0WEkYvvZVCFHyliqga+kLJfknbIcQnLERygPuxz9IAApvi95JnY3Y22sSa70iFs4gUo6ESg/QKGu7iHucYfAW/REaZbs=; 4:1a4PrMufAQ6MzDnumGx7yqH4RZBzf54QPDPLLNp6sfza/5Nlu6vv90isoxAo1sfbz9O8INI7MS0D6UNupetTbs5pK27kSYYW+v6M64kVXtgiThA+bDeN+Rkg4nXz+FRtPdlTFGpS8F99XfoQvafkDxGmuIiiHsLcu9zor5Q8ZorFMjdacIYEfnHtwnrKPdNvYIPcKDqCnYEbFQQW7iYRARo2MhvUJk3QfI5BDh1jpP3SEZjaHNFQdOzTBNAgKznNWRWypO0Fx3s3ytcozmsFcfiHhoMQ2DYUuKhuA+z6ahOVVH7xk96TEtPOxiWmm4vd+gk84r+GYqdJlyoqO++FcC/lZocVAdTWQ0nmqqHTOh0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397)(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231023)(3002001)(6055026)(6096035)(20161123556025)(20161123559100)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123563025)(20161123561025)(20161123565025)(201708071742011); SRVR:BN6PR03MB2692; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:BN6PR03MB2692; X-Forefront-PRVS: 052670E5A4 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyNjkyOzIzOjJ6RHFRUUtra24rVytNczJsclIyWFFVS0V5?= =?utf-8?B?ZjVFVEcwS1l2Wi93MDg0Q01SRmdvMWk4VjVzdDMwWWZ4blVnanNPNzRiVlRF?= =?utf-8?B?MWRKeXlmcWlaMUZZSXJCUFFkRTh4ZEtnSitFSXVDZHhVYWRUQUw0dHJBcE5l?= =?utf-8?B?NnBWVjhYZmhtc3ZYZUFUVFArZ2hDeGQvUXRSNm1JS2dIOVNsa2xUOTlLaFRn?= =?utf-8?B?TzdvM3Z2czQ4ZElmd255STNwbTRmNm92SVpEeUVtUlZveVdSSzJVYjJIdzRl?= =?utf-8?B?SEE3Zm82VzlJd1V2WDlvNmF2c2ZRL0RwUzkzREt5c2p6SExKQ3lBQzRPa0RN?= =?utf-8?B?Ry9WcUlRNXg4ZWJJY2FVNzNmZFBsa1BjWjAvV00wbEZSMVI3MkFtNCttaERu?= =?utf-8?B?U244bkdzc0kxZENzblJQSXJiR3JYdklFZ0VtWkJORmE0OURKTGk2UkJiTUpz?= =?utf-8?B?K1lrUVhGd2dKQ1k2M21EeDJ1Vll5YkozVXVKZWpKR2NnS0MvMmZuemh2amxz?= =?utf-8?B?a1p1MmJIM3h1bitLWnBtYlJNWHh3Z05IVkxqVTB5OCtrdTJSSHliVTVUSkJ6?= =?utf-8?B?dFAwNVR6bk9teXJOalJxbEtFUFRHMDdJNVFyeTA1UVlXVmxJUGxQYU5ranNy?= =?utf-8?B?V1l4SzcwN1pLT29oN2ozeG5WS25pNlNVengxNnRIR0M5WXNwZnpCQzRFdndG?= =?utf-8?B?VzZ6WGVPKytaNTdPcHBlWEZmdkY5UElITDZPVnhSSXQrRkgwS3FhVk5RV012?= =?utf-8?B?cU8wQldrN0F3R25rTjdWN2hBSXlkcjByQVNkRzF2bm9jUkp2RmdHaEYxT2lF?= =?utf-8?B?SStXdzhQQmpaK2lXTFBWdUcyODhXY1V5d0VrdFMxKzIvTVMwZlBWNDFmWWhW?= =?utf-8?B?dmd6QUkyeWZPR3htSFJjVWdQd21OdUJlWjEzVFdYbm82bVh5YnVsdWZUVDdK?= =?utf-8?B?UDIwdit6N2pndjlaRmRvM3VzTXloTUJ6NU5wcXJsM1d2NDNRTnpjclIwUUFm?= =?utf-8?B?bHJ1QlJFZVp2elg5cnExaFcwNE1rZk9MNU9HQ3VudTNMVXhPNXhxcDlNWFVL?= =?utf-8?B?MFZRa2l6MC9hUlZGWTBFSHFyUHdhSndkMlZ5RHBjem1lN2NzZjMyb1gvdDdm?= =?utf-8?B?djZ2TFNQOUlNRHNMSUEvOGVoalUyZ1kreWtZRWUzZFlPZ3J2UHFkNU91dEhW?= =?utf-8?B?c01Nemd6eDZycUlxYXVPMUJlKzYzQmViNzNGRlRaM3ZvV3h6VmFQWlJCRVo2?= =?utf-8?B?TG9TZEViRFROajdtb1VYOFFzNFlpWC9YUFgrVTNQRk4wUEM5elZkQmhIcENY?= =?utf-8?B?LzhkVjRkOUp0UTBLd3VLcHJFbWhjN0tuTEI2MmxuQUdpMnQ4U3AvU0hzMFMz?= =?utf-8?B?Zi9jTWJEWXdpL0oxOUNQQVlkMExTa3V1dGlTSjM0cFZPUGlCVko2Q2pEOXN3?= =?utf-8?B?WHg4Y3dwU0VVcmdndDdpMjNIWmpLVUxpRi9UazZUMkFWVzZndGs1ZktTbnVi?= =?utf-8?B?Tm5NeFBkQkVLeUtrZTNNdTZjTlZIclI5c2RWWjdyeHViZ0pvbW9Vd243MHdO?= =?utf-8?B?WDEwR1hOWk9HVmFGczJ1MC9PckdyVEplaU00QnZKeHg3OCtXS05SY2gxblQ4?= =?utf-8?B?SW9sNUdoNFB0a0c0Z0tTOTR2cVlqS2V2eTVHbTArOGlsWVpvNlFsVWFEOHpk?= =?utf-8?B?aWp5cVhJelI5eWV1TXBNSU4xRVJuSENFdi9oOFU5ZlphTXdxcTFaZ3dtNVNs?= =?utf-8?B?OVZZRTBqOGY3b0dqcjBScW8wT21ObTl5NWZEakkyTGQ5WDhGUkRzTk1VOW5J?= =?utf-8?B?YlV1dm9BTDhIQkNBWCtsN0s5eDRaV291MHpQTDcyWndNNEE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2692; 6:ENe0/cn2FUdTxmGPluyp7gFeXHK5IFHvrMOVXMAubcv2tO1eYsWnW6fsGJZbV45QrSa+BwKSiwTrcMhMWUTReqOdu7p/AIW7cRUv81AE8zgde1vIWlW9VVpjJQGf/UAsVxb1s3plnLC2xXO2t5nzDKZGe+yscYeLfiYg51qbF44qw4liyH3myohN18ugXoTcpRpOCp9pjgXRqoUPb62+JB4tELW3Wkqn1qsyz7d3dIkHVRcwsZiihd0c4++vVqzEglnoIXzkaVeUxhWY3GuxRbqGtQ2IXahatD7vCQCiZju1p7G/gDdfju3kCvusNHoBE0vP8SK678l+8FLIpA/XzIQm8Ox9WeidvddmUKVGw+M=; 5:hZeQ8bimwEdzCo5f2V1znronWErvazt10YWnOXLALO9lsyXVLsr1eGbkY6qHxiayJq3mkcDqdNA33xMlEEArq7cfwMrXCg4+XVCmvXpHJlMkeweliI3FBNGeL5aOCP3SGLnncHFIlH0Lt9I8LudkSQcmnYRMoL/9fpGnyLvX368=; 24:r+F3ZTDnfbz/TizylZWUFl5FkHu0mBejG7IgyBbXB8bnvlFa4cmDZX0GEzO64s819csOU56wDyeVVVdIECcvFJR7a+7KIYMDMFvzJdsE2tE=; 7:cRkIoJzuo7HYgvfko9zxwK19/4Bn/4hkbDK+0p0r0k8yVuifCKViFCMH4N2waDNPh4Q1IQ9Q5Wkd5t88WQG+GklI64oObA6LMEjFr1ZiNOah6r0yhsKsSCtSnQZ9QSdrk/2GoWK/9EeXz3tvmT+zdIvUjvY89F/wZFwT54dErm3ii9fe7ZPvmt3DQKBhc9miYH63//lMuYyMd/VQkD6ejigoyULKE+XqAiKCZbSr/j8jf4RzeqG9+DJzwwNoiijp SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2017 05:39:56.6041 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 187cefdf-0356-40a4-8090-08d546a2f001 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2692 Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for pktmbuf pool create API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 05:40:11 -0000 On 12/18/2017 7:21 PM, Wiles, Keith wrote: > > >> On Dec 15, 2017, at 4:41 AM, Hemant Agrawal wrote: >> >> Introduce a new argument ops_name in rte_mempool_set_ops_byname >> for allowing the application to optionally specify the mempool ops. >> >> Signed-off-by: Hemant Agrawal >> --- >> v2: fix checkpatch error >> >> doc/guides/rel_notes/deprecation.rst | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst >> index 13e8543..968ca14 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -53,3 +53,6 @@ Deprecation Notices >> >> * librte_meter: The API will change to accommodate configuration profiles. >> Most of the API functions will have an additional opaque parameter. >> + >> +* librte_mbuf: a new optional parameter for representing name of mempool_ops >> + will be added to the API ``rte_pktmbuf_pool_create``. > > > Sorry, for the late response I was on vacation. > > My question is why do we need to change rte_pktmbuf_pool_create ABI yet again, why could we not add a new API to just set the name of the pool after it is created. This would allow all current applications to work without any ABI breakage and only require adding a new API call for anyone that wants the name. The rte_pktmbuf_pool_create() routine could assign a default name or some incrementing style name as the default. e.g. ‘pktmbuf_%d’ with a static incrementing variable or whatever you like. > > Sorry if this was asked and answered before. > I understand the concerns. However, the new API to just set the name will not work post create. rte_pktmbuf_pool_create is a wrapper API, which complete the mempool configuration on the basis default mempool_ops. The idea proposed is to create pktmbuf pool from a specific mempool (ops_name). We can leave "rte_pktmbuf_pool_create" as it is. and create another similar API with e.g. "rte_pktmbuf_pool_create_specific", which will also take ops_name as argument. (We can combine the internal implementation with NULL ops_name for rte_pktmbuf_pool_create.) This way we will have flexibility for the applications looking for pktmbufs from a specific mempool. any thoughts? Hemant >> -- >> 2.7.4 >> > > Regards, > Keith >