From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BE884578F; Thu, 29 Aug 2024 11:02:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED59042DDE; Thu, 29 Aug 2024 11:00:48 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by mails.dpdk.org (Postfix) with ESMTP id AA5A442DD1 for ; Thu, 29 Aug 2024 11:00:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1724922046; x=1756458046; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=ItfKWwbABnYRbxmzKAd+3MZRb/l91EhPZz9YH5FSkDI=; b=IpKYTCXIy1ErbcfGH3chwbP+GK5XS028mKgaMZiF9jgaeHfUF2vBg4w1 igdGUvipSRmQW2V+zWz/haCE/r5lpC66OgFTYUf7xGoyfnj2dDMlUOf+m d9/C/Hppqj4yd5Ox/Axj0NevTWbC8i8YXAenqCcPOKKkuhxWjwMSW3Tod pxRpDpF25ybcBnjUwO+4WuWZ+o4Vvfi4HHjbr911YUJe8CBBOblYxXB/S Xd/gofsXNevXFflxoPeYoCm7W1OjaP4NTbJXQRP2MEU1wcnqHLbiGiOu6 DDlyeFQ0fzIVCID44KT9AF+FBOIt2yKldxviW8QocS2esjUUfSPLIT8h5 g==; X-CSE-ConnectionGUID: LKiKwA6eQ1C6ePOJZW8Zfw== X-CSE-MsgGUID: n/bpmAHvSnqyKiwdaqwTLQ== X-IronPort-AV: E=McAfee;i="6700,10204,11178"; a="23663513" X-IronPort-AV: E=Sophos;i="6.10,185,1719903600"; d="scan'208";a="23663513" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2024 02:00:41 -0700 X-CSE-ConnectionGUID: FgffufmNTu+PxnihfJzF2A== X-CSE-MsgGUID: VfQW3QazR9CtcyvXRxjqyg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,185,1719903600"; d="scan'208";a="64202958" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by orviesa008.jf.intel.com with ESMTP; 29 Aug 2024 02:00:40 -0700 From: Anatoly Burakov To: dev@dpdk.org Subject: [PATCH v1 14/15] net/ixgbe/base: correct NVM access type for EEPROM writes on E610 Date: Thu, 29 Aug 2024 10:00:19 +0100 Message-ID: <52fba26db389214d9275509a9d0b0f86ddfeab24.1724921977.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Przemyslaw Gierszynski NVM acquire function was incorrectly invoked with a read-only access type when intending to perform a write operation to the EEPROM. This commit corrects the access type used during the acquisition of the NVM. The change ensures that the NVM is acquired with write access before attempting to write to the EEPROM, aligning with the intended operation. Signed-off-by: Przemyslaw Gierszynski Signed-off-by: Anatoly Burakov --- drivers/net/ixgbe/base/ixgbe_e610.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_e610.c b/drivers/net/ixgbe/base/ixgbe_e610.c index ab02b11d6a..b0d55a2411 100644 --- a/drivers/net/ixgbe/base/ixgbe_e610.c +++ b/drivers/net/ixgbe/base/ixgbe_e610.c @@ -2314,7 +2314,7 @@ s32 ixgbe_nvm_recalculate_checksum(struct ixgbe_hw *hw) struct ixgbe_aci_desc desc; s32 status; - status = ixgbe_acquire_nvm(hw, IXGBE_RES_READ); + status = ixgbe_acquire_nvm(hw, IXGBE_RES_WRITE); if (status) return status; -- 2.43.5