From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id AC0E4AAB3 for ; Thu, 26 Apr 2018 00:04:29 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 139A4211D4; Wed, 25 Apr 2018 18:04:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 25 Apr 2018 18:04:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=JRtghi+qecycD8vAahX8C5YDWS zFcjfytQ6hEAOrFL8=; b=oJ10a8GcUbTUeXQZQ07Jcn4y/9QjVczkBDDYwe7Cdl 28NzS2SoOBaRndjPzB8E5wBaBHpjwSGAvFk1oGMuwOsHnf1YdcqZyfTo6n44KULX dezN3Xs9sm5LYe2G0W0poEhtsolR5R7pY/W5NWWWXzmBHxn/CfPx2MXBmOX6GHhc M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=JRtghi +qecycD8vAahX8C5YDWSzFcjfytQ6hEAOrFL8=; b=gwsXjEkNqTCceQznsyIal4 +1shPdunhcvxpxAI3/Sr2ZjG3ev0DN5CBd0y+BHw6ebk3/EUcJ3KJAI0vfMUPddD TBDqhx0N4LhBERCj4TmW3CSffMtZQVF5oW7pwhC7D/IoPDOom4QYu0O8wM0A8O/G IQbB4ZNminzgiRddNcIwrx9l6/vh9+scmOvApntf4cfqYmc/G9qhkrcO8VLjTjtX AhRHvf1Vtx+crQvUyngJVqMJ0MI4fsZqC6fH85wiNAC2jUEg4Ee5ohybs892lrwB wHaWgXg6YwJvSiLAI0g1Fbtff7GWpX1qmMk4xNwHit714I3RnXU9ui/kXvxpCm8A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7A0E5E5092; Wed, 25 Apr 2018 18:04:28 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, Olivier MATZ Date: Thu, 26 Apr 2018 00:04:27 +0200 Message-ID: <5302029.6bfcN0d6QB@xps> In-Reply-To: <4297121.oP7HX5CK1i@xps> References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com> <1524673942-22726-7-git-send-email-arybchenko@solarflare.com> <4297121.oP7HX5CK1i@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 6/6] doc: advertise bucket mempool driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 22:04:29 -0000 25/04/2018 23:56, Thomas Monjalon: > Usually it is better to update the release notes in the main patch > implementing the feature (probably the first one in this case). > You can also update it step by step in several patches. > > 25/04/2018 18:32, Andrew Rybchenko: > > --- a/doc/guides/rel_notes/release_18_05.rst > > +++ b/doc/guides/rel_notes/release_18_05.rst > > @@ -147,7 +147,15 @@ New Features > > compatible with virtio 0.95 and 1.0. This driver registers ifcvf vDPA driver > > to vhost lib, when virtio connected, with the help of the registered vDPA > > driver the assigned VF gets configured to Rx/Tx directly to VM's virtio > > - vrings. > > Removing this last word is probably a mistake. > > > + > > +* **Added bucket mempool driver.** > > + > > + Added bucket mempool driver which provides a way to allocate contiguous > > + block of objects. > > + Number of objects in the block depends on how many objects fit in > > + RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB memory chunk which is build time option. > > + The number may be obtained using rte_mempool_ops_get_info() API. > > + Contiguous blocks may be allocated using rte_mempool_get_contig_blocks() API. Please add this feature at the beginning of the list (as the first one). If possible, I would prefer you rebase on top of the mainline (looks to be next-net here). Thanks and sorry for nit-picking, I'm testing your stamina :)