* [dpdk-dev] [PATCH] test: call timer subsystem finalize at exit
@ 2019-05-06 21:03 Erik Gabriel Carrillo
2019-05-06 21:03 ` Erik Gabriel Carrillo
2019-05-09 16:59 ` Thomas Monjalon
0 siblings, 2 replies; 4+ messages in thread
From: Erik Gabriel Carrillo @ 2019-05-06 21:03 UTC (permalink / raw)
To: rsanford, thomas; +Cc: dev
The eal_flags_autotest checks that no hugepage map files are left behind
after a process exits, which can only be the case if all allocations made
from DPDK heaps were freed back to the freelist, resulting in the
hugepage map files being unlinked automatically. Add a call to
rte_timer_subsystem_finalize() at application exit time to release
allocations now made by the timer library.
Fixes: c0749f7096c7 ("timer: allow management in shared memory")
Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
---
app/test/test.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test/test.c b/app/test/test.c
index fbe4464..ea1e98f 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -187,6 +187,9 @@ main(int argc, char **argv)
ret = 0;
out:
+#ifdef RTE_LIBRTE_TIMER
+ rte_timer_subsystem_finalize();
+#endif
rte_eal_cleanup();
return ret;
}
--
2.6.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] test: call timer subsystem finalize at exit
2019-05-06 21:03 [dpdk-dev] [PATCH] test: call timer subsystem finalize at exit Erik Gabriel Carrillo
@ 2019-05-06 21:03 ` Erik Gabriel Carrillo
2019-05-09 16:59 ` Thomas Monjalon
1 sibling, 0 replies; 4+ messages in thread
From: Erik Gabriel Carrillo @ 2019-05-06 21:03 UTC (permalink / raw)
To: rsanford, thomas; +Cc: dev
The eal_flags_autotest checks that no hugepage map files are left behind
after a process exits, which can only be the case if all allocations made
from DPDK heaps were freed back to the freelist, resulting in the
hugepage map files being unlinked automatically. Add a call to
rte_timer_subsystem_finalize() at application exit time to release
allocations now made by the timer library.
Fixes: c0749f7096c7 ("timer: allow management in shared memory")
Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
---
app/test/test.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test/test.c b/app/test/test.c
index fbe4464..ea1e98f 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -187,6 +187,9 @@ main(int argc, char **argv)
ret = 0;
out:
+#ifdef RTE_LIBRTE_TIMER
+ rte_timer_subsystem_finalize();
+#endif
rte_eal_cleanup();
return ret;
}
--
2.6.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] test: call timer subsystem finalize at exit
2019-05-06 21:03 [dpdk-dev] [PATCH] test: call timer subsystem finalize at exit Erik Gabriel Carrillo
2019-05-06 21:03 ` Erik Gabriel Carrillo
@ 2019-05-09 16:59 ` Thomas Monjalon
2019-05-09 16:59 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2019-05-09 16:59 UTC (permalink / raw)
To: Erik Gabriel Carrillo; +Cc: dev, rsanford
06/05/2019 23:03, Erik Gabriel Carrillo:
> The eal_flags_autotest checks that no hugepage map files are left behind
> after a process exits, which can only be the case if all allocations made
> from DPDK heaps were freed back to the freelist, resulting in the
> hugepage map files being unlinked automatically. Add a call to
> rte_timer_subsystem_finalize() at application exit time to release
> allocations now made by the timer library.
>
> Fixes: c0749f7096c7 ("timer: allow management in shared memory")
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] test: call timer subsystem finalize at exit
2019-05-09 16:59 ` Thomas Monjalon
@ 2019-05-09 16:59 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-05-09 16:59 UTC (permalink / raw)
To: Erik Gabriel Carrillo; +Cc: dev, rsanford
06/05/2019 23:03, Erik Gabriel Carrillo:
> The eal_flags_autotest checks that no hugepage map files are left behind
> after a process exits, which can only be the case if all allocations made
> from DPDK heaps were freed back to the freelist, resulting in the
> hugepage map files being unlinked automatically. Add a call to
> rte_timer_subsystem_finalize() at application exit time to release
> allocations now made by the timer library.
>
> Fixes: c0749f7096c7 ("timer: allow management in shared memory")
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-09 16:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-06 21:03 [dpdk-dev] [PATCH] test: call timer subsystem finalize at exit Erik Gabriel Carrillo
2019-05-06 21:03 ` Erik Gabriel Carrillo
2019-05-09 16:59 ` Thomas Monjalon
2019-05-09 16:59 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).