From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71032A053A; Mon, 3 Aug 2020 18:12:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BCA8E2BE1; Mon, 3 Aug 2020 18:12:31 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B9AB42952 for ; Mon, 3 Aug 2020 18:12:29 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 112C85C0074; Mon, 3 Aug 2020 12:12:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 03 Aug 2020 12:12:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= w+8Oh64iDO9Gg6JupENtwKVGwoeR/dH2fzc/Zmi/TuI=; b=xjxoUKJY9/gXGnsl bgj76tOKXK2nNuKSbr2ATqCDZ12c6Y7xccKWbsh79Vodp2uWu8CF/asxgMaW/vSx Fr47BIKoRj43TK0/U8nkzt+8aLLBIOLfSH9ct9p0vdU6R0Kho7KFgEqNU4kJ5Xaq LUo3gVqeQNyjrSqgVFhwnJghAIGr86/WEnpjxSCPrej9dIWxEa3NRSqqdpzMw+xq 579HB3gWhgXIUpfn/mEuBwIgQYwS6a7DT0f2xill0WCf7Kuiriy4EGF1EaWy/SCy lnKAxY0V0mPXJB9lncqYMd2ryM3so4SPuPHWZygVIslkoEExm0dernGgJYYPjXZx V/am+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=w+8Oh64iDO9Gg6JupENtwKVGwoeR/dH2fzc/Zmi/T uI=; b=bp+hWQSD5MdibyRP+MaESnBUezl4Ng6y+BnooEVPamGhHT1xG+AJh7zwf FPy8MOBqCyqPjaUP8AxeYrQafkddfRVrIPuowUR35Jv9KowhxMNw5xxS4HRUHe1k zkxS/uEh2RhtTjrKfT+FimD491cIj3msA1b216XeH4z06hg8+T91KhqVRLAhjRmV NnmYcTcNcagISrNu3Ufdmg+c/1XDPsG+z6inOnr8GIQBWP3JslkBjoywr1jCokFb Qz/m6Tw9n7eYtALg6w8NsACzghhwGunPXVhbvaWS+jTrsow1jczXRAzZbhZVYHgL d/8Og0uMI2BNw06ZiekDMkNO9wA+g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeeggdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 19DC530600DC; Mon, 3 Aug 2020 12:12:28 -0400 (EDT) From: Thomas Monjalon To: Ori Kam , David Marchand , Andrew Rybchenko Cc: "dev@dpdk.org" Date: Mon, 03 Aug 2020 18:12:27 +0200 Message-ID: <5309847.jfmgeefGoo@thomas> In-Reply-To: <5b902c08-69b3-905b-3b95-2ce12e94a63b@solarflare.com> References: <1596464905-43867-1-git-send-email-orika@mellanox.com> <5b902c08-69b3-905b-3b95-2ce12e94a63b@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc: update RSS action with best effort X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/08/2020 17:55, Andrew Rybchenko: > On 8/3/20 6:49 PM, Ori Kam wrote: > > From: David Marchand > >> On Mon, Aug 3, 2020 at 5:23 PM Ori Kam wrote: > >>>>> + > >>>>> +- Hashing on types that are not supported by the PMD. > >>>> Shouldn't it return error to the caller? > >>>> > >>> That=E2=80=99s depends, if for example the application requested eth = and IPv4, > >>> and the PMD can do only IPv4 so according to this, the PMD will just = do IPv4. > >> We should have some validation in ethdev to catch this. > >> Is it not the case? > >> > > Like I said in my reply to Andrew, in rte_flow we don't have such caps. > > Maybe we should think about adding them for the RSS case, but again it = is tricky > > What if one RSS type is supported depending on the flow or other types? >=20 > Also I'd like to add that ethdev layer is dummy for rte_flow API. > It does not parse pattern/actions etc. May be should change it one day. =46or now, what we can do is to have "best effort" (sic) checks. In the case we are 100% sure a rule cannot be fully supported, I think we should reject the rule. If there are more complex cases to handle, we can accept the rule and support it with "best effort" handling. The other appropriate action is to implement tests in DTS to check the behaviour of the PMDs, validating the compliance of the accepted rules with real flows.