From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 76DD82B83 for ; Fri, 20 Jan 2017 19:05:35 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id d140so15940513wmd.0 for ; Fri, 20 Jan 2017 10:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=LJUANiJDctuohYVdWjSBphkMlcgpsuCdwUA9KIiMbOU=; b=huZyOztNbrts0VKjytGAgzkoCiMg2Q1mUF6dVY3CC81orBinovLZ5sb6F1LU4K37te xJ2AuSLmxXclJpK+vbXlqCYojzSKP9SUfFF8+fOq8LXe86AJJv2VafcyWGXhkfOVbuzL ASVouqho8SMdpD7b6LuqpqVfMPTedX2PcN+T6EW+axFFntoT8rBEG9Hml3EqJA+UZ8lS fTQMQRS3bUw1jDF0pT4fjzh4SWIczMzPYMF14cxqWawl/+A76U5hr26fZq5akkaZzuOG zS+/tf8Rkk+m0X60j9XaR8s7zsiRuc/kNq//PHtOFrBcsweoNDYCKKujH+oQfxoyOJEH bDNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=LJUANiJDctuohYVdWjSBphkMlcgpsuCdwUA9KIiMbOU=; b=YA6sUpR2vN+Unbbe64kHiZWZoQfzr6MBVyhhK1efSfa7CDpHd4XTjBD38VjtM5fP2Q aG2p9kZysGDUT7D8CIIPp6LW+Rph+veJoe5PgIF88uXDKrv8JbnH59lKT63TqWWgYu53 PPfHp+ceDIB842JdftNim+Kq/gqCXtX38pM1ak6rWb00/8WMHH4OhXlOe2i1Qh49cS0W nF/ashg1kI7F4p2wclapGyPYxhVp9tkS4VWVlgEXNVX/pgpRop3aFg52Cxp0sENYHJl6 +L+VuGU3ZhccRd4QiTqlUjWIpBXg+nmkzzNTXLPwsxikgmfUPHaOQsHsTNstblj39AKI +Eug== X-Gm-Message-State: AIkVDXJbJuyrU2v+aDATqDxl/rIkfVlO60LytZaH5m9F/vx+yV21zelaFQTezon34xrze+hd X-Received: by 10.28.225.215 with SMTP id y206mr4200127wmg.138.1484935535154; Fri, 20 Jan 2017 10:05:35 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id c187sm7237263wmd.13.2017.01.20.10.05.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jan 2017 10:05:34 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Cc: dev@dpdk.org, Ferruh Yigit Date: Fri, 20 Jan 2017 19:05:33 +0100 Message-ID: <5310778.TcToBiVDlW@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170120103428.GY10293@yliu-dev.sh.intel.com> References: <1484899493-11051-1-git-send-email-yuanhan.liu@linux.intel.com> <2005966.sVKUI0LeEs@xps13> <20170120103428.GY10293@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix wrong memset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 18:05:35 -0000 2017-01-20 18:34, Yuanhan Liu: > On Fri, Jan 20, 2017 at 11:20:06AM +0100, Thomas Monjalon wrote: > > 2017-01-20 16:04, Yuanhan Liu: > > > Fix an silly error by auto-complete while managing the merge conflicts. > > > It's the eth_dev_data (but not eth_dev) entry should be memset. > > > > > > Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process model") > > > > You should describe the impact on this bug. > > Honestly, I don't know. I didn't met any issue while testing vhost. > Maybe Ferruh knows what might be wrong, since it's him spotted this > bug? > > > It will be helpful for those testing the RC1. > > > > > - memset(&rte_eth_devices[port_id], 0, sizeof(*eth_dev->data)); > > > + memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data)); > > > > The title should be contain the scope of the bug. > > I suggest "fix data reset when allocating port". > > Yeah, that's better. Thanks. Applied, thanks