From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5DECA00E6 for ; Tue, 6 Aug 2019 13:18:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9EF9E1BE55; Tue, 6 Aug 2019 13:18:47 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 3B1A01BDED; Tue, 6 Aug 2019 13:18:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 1748C456; Tue, 6 Aug 2019 07:18:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 06 Aug 2019 07:18:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BcAT6/5cIFE/eQBtDQrp8qYTGTIiVwxgeLxfyIjShHY=; b=HXV5aEyl1+ZJ 1RekTpr5iRlqQYx6YxIaLQI6vhfV/40yXuZkLqIqrlzWLhdNxyKp0z/B1HDcIK9J oA/dfkXufeM4oFocJheaA/bypq81G++8mmkBNmlNydMnw9nj3118uq+JpWvoOgJJ B3nDIet+9HLTJKMmEIzcIH1CdUnC3Dw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=BcAT6/5cIFE/eQBtDQrp8qYTGTIiVwxgeLxfyIjSh HY=; b=oB3DXvnqPKayXDg88lDMUAuEwcpiZnpveQzSSQ6DAYSO/F8EBdssjgZgY eJXDJjisZ8uu7dKLfAwARJKFvD7S55mg9r3Iz6ApIyIXBF8e/vYdVMnSlxgtGJIw XA0UkTVB84VN2NOjVAm1bbZ9UZ4BuWjNx9aaLtrMM45jaCrOtPd3V3rdclcMfZ7I HufljA8Vk3Hw4O/rqC3jV/fIdidUm3KF4NyD30jihSML9jLF7hbWLqgf/XLLpDrq KuZRR+EhdC0p+SsZixLHw6tPwnqD60twnyiLOhBVMgtUOYRW9WOViJm/4IuMJZAu Th/SUaeTQEc/v9pwv/2xrAEANp9+g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddutddgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedriedrudegledruddugeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 6996580061; Tue, 6 Aug 2019 07:18:43 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" , David Hunt Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 06 Aug 2019 13:18:42 +0200 Message-ID: <5316435.KtOK4V2HBz@xps> In-Reply-To: References: <20190724131803.30066-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] examples/power: fix oob frequency oscillations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/07/2019 12:15, Burakov, Anatoly: > So it's biased towards scaling up quickly, but it's doing that over a > period. Please correct me if i'm wrong as i'm not really familiar with > this codebase, but, assuming the window size is long enough, you could > be missing opportunities to scale down? For example, if you get a short > burst of 1's followed by a long burst of zeroes, you're not scaling down > until you go through the entire buffer and overwrite all of the values. > I guess that's the point of oscillation prevention, but maybe you could > improve the "scale-up" part by only checking a few recent values, rather > than the entire buffer? This patch is deferred to 19.11.