From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75F70A053A; Wed, 5 Aug 2020 22:03:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 471CC2C23; Wed, 5 Aug 2020 22:03:09 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 9CC0A2BF2 for ; Wed, 5 Aug 2020 22:03:07 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 679B5581; Wed, 5 Aug 2020 16:03:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 16:03:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= aKvNl4pRjbsa51dWBZHHnxul6bkUyZCTk1iDnGABcuU=; b=WGZc5S+GiwiH9ItU 3RPSJ8CFDr22iOey2Wu6VeIqJupsXV9yIn95CDy0Ez2bWJ5UUxkKi2g20aCKxX7x LItjPAnaY+ni09tMLrGarbVMZmjbQnEGcHPfBuslvlZmOuXX5Qg8/XfGjB+Nz2Mr 9WTwKsxFK+wNMvTzva32W6CpjAbtLDkp2ILVs2y71cdNPUndTtX/EW0QxseKQZDx YHc5I6umnzVI2zX7HvQdWGFXoBe+XJ4yX6QqpiJW1wPmQQZzrhZjD4ZfKDiArBHh WBfIvXpBttbdU/4fxo2x7sfquQl0+Zrrw5sA7Pn015aqhjxcvjO0oP2JmEsEzyYJ lWU87Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=aKvNl4pRjbsa51dWBZHHnxul6bkUyZCTk1iDnGABc uU=; b=WV3sgqyPrCn6ZadLRq1qDh5AEqfzrUHpom2eqr4BT5NAYPq4ONjNgGQI8 H1fxNNTIJ6bBQExGG8iqy54iPL1kZVtRikA3ISkMo4ObYOf5F5yOCC8kGKbS0rGN OLkYhkprANN5nK5ZzmOuMeVxP17FxQl/cvNmXnKJaM6lwCq7/hS/3ZDK+pLp6Zmz v0xrDQ/Oex0fpX/hgh6bWQu+gU80lr7KvSLCiM95FamrmREKF6/F1DLc+rhT1heg PAcj7gO2G52klPozgoZ3m3SlLZy2V97gEWe/JhOjr/UGxCriYFmvUWA+KTtTkRIF jTbRBRg9Lo6zC+LpV1dMh4N7zRH3A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgddugeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AFAD530600A6; Wed, 5 Aug 2020 16:03:04 -0400 (EDT) From: Thomas Monjalon To: Somnath Kotur Cc: dev@dpdk.org, ferruh.yigit@intel.com, ajit.khaparde@broadcom.com Date: Wed, 05 Aug 2020 22:03:03 +0200 Message-ID: <5320795.Xbk6jbSQu1@thomas> In-Reply-To: <20200803141219.5682-1-somnath.kotur@broadcom.com> References: <20200803141219.5682-1-somnath.kotur@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fixes in flow counter mgr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/08/2020 16:12, Somnath Kotur: > OVS-DPDK seems to set the reset bit for every flow query. Honor > the bit by resetting the SW counter values after assigning them. > Also set the 'hit' bit only if the counter value retrieved by HW > is non-zero. > While querying flow stats, use max possible entries in the fc table scan > for valid entries instead of active entries as the active entry can be in > any slot in the table. > > This is a critical fix for OVS-DPDK flow aging. > > Fixes: 306c2d28e247 ("net/bnxt: support count action in flow query") > > Reviewed-by: Venkat Duvvuru > Signed-off-by: Somnath Kotur Tags must be in chronological order (Reviewed-by after Signed-off-by). > --- > drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) That's not a small change. The title does not convey the impact of the change. Applied anyway because you insisted on the criticality.