From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58E33A0535; Tue, 4 Feb 2020 15:27:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C2B51C1BC; Tue, 4 Feb 2020 15:27:55 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 92EC11C0BC for ; Tue, 4 Feb 2020 15:27:53 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2A7FA21EC3; Tue, 4 Feb 2020 09:27:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 04 Feb 2020 09:27:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=snD66yLCDqQ6oNPHWR8pGsUWsjefADWBNHXRIVh8MxU=; b=FjNQvpBLqBAs UQRFDUH5achg0f0igGH7QWf3Y6w3hQvlKzoyRSW2CSwBYjWTXtdu73dE6AZi4xXL V6j30PtqQxj++2Utn6jZ92tTNosw718BNrkl2oEDY7Y9nyDS0R9TyeD7Wcl2J8tc somKM47Aex0NR5hUnQHoYla8jQXfrdQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=snD66yLCDqQ6oNPHWR8pGsUWsjefADWBNHXRIVh8M xU=; b=Cgri89PkQnlvCW0Tru86xbqrLkLDh8J64ytUrY+MU7oa2qsgYElWRaTB4 ndtm43jaDF63zUP8tUTNM47h86Se/Eso8ndJO+1WbF1TttYeh1mDp2XiVti2r4x9 7STt5+2pQsInLcmI4HRJ/Oh2dE+dgUU1sc/Ca2h4uCv70Q1DrU9zGa86PGPtpC/l meQhuxJCKyklbizbPpMkI0HZMsFH0uLXqXoIkpqAT5KNmXtwwmxMuNx8YYqkUHuE arS4qom4kV6xAVEDorMiQiDK9x1ffZFGhH7uWP90iDXvHp9zKpyZBlo+gnaGERWl 1mqVQovbKxMJ+p/SNoHU36EVRzNFA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrgeelgdeigecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 823813060840; Tue, 4 Feb 2020 09:27:51 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Date: Tue, 04 Feb 2020 15:27:50 +0100 Message-ID: <5323608.DvuYhMxLoT@xps> In-Reply-To: <20200204114838.GC637@bricha3-MOBL.ger.corp.intel.com> References: <20200116071656.1663967-1-thomas@monjalon.net> <20200127154402.4008069-1-thomas@monjalon.net> <20200204114838.GC637@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/4] add static ibverbs in meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/02/2020 12:48, Bruce Richardson: > as we discussed offline, I really don't like the necessity of the > hidden_deps part of this, so I've tried coming up with some other > solutions. Thanks for looking closely at these patches. > For example, in my testing I get the same result with the > following diff instead of the second two patches (just showing for mlx5 - > changes for mlx4 are identical): [...] > - # Build without adding shared libs to Requires.private > - hidden_deps += lib.partial_dependency(compile_args:true) [...] > + ibv_cflags = run_command(find_program('pkg-config'), '--cflags', 'libibverbs').stdout() [...] > By doing things this way - assuming it works in your tests too - we avoid > any need to change anything in the common drivers code. Yes, you hide the dependency by getting cflags directly with pkg-config. I wanted to avoid such solution because I was trying to use as much as possible the meson infrastructure. I think your solution relying on one more call to pkg-config is acceptable. I will test it and will review whether we get all corner cases. In the meantime I discovered we are overlinking with meson when using the dlopen linking option. I will try to fix it as well with the same method. Thanks