From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 15ADF5A06 for ; Sun, 1 Nov 2015 23:20:25 +0100 (CET) Received: by wicfx6 with SMTP id fx6so39266007wic.1 for ; Sun, 01 Nov 2015 14:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=drRUzBNYzYSaQzDB/oamvUPlqBUmYwkHUXwL71XOhfE=; b=YcR3R+KxIC3XFiwjEB0Oc3KnsBsDtqf2g0Ogy4Dtuvo7FJE1YElBB3DgigHNcEyaM3 zxB/QwuVsm/Uc9T4/CRXmCSDzJio1taOYRPP1dAXXpATmyv56RSmMINkfUAYZli55kbV RpqZyCFHEBydfuScoszfM+xfNqk0nuXHhWOhWp0pnE1690YKdt8DymXiyj6uOrCKuhE+ kU2zct6V65K8ug8GQx4myXbNd9jnZKLBSRbFaIfBOui2GKPd74fE6ua4d5KUynRqBgUK RwaluSIoqK42tPw5cAH3t+hbd0QQjtyhg1jn5Eys/1P5cPQbYIFRYdv6XqGi3JeQP5vb rcKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=drRUzBNYzYSaQzDB/oamvUPlqBUmYwkHUXwL71XOhfE=; b=J21IsLxohPCGitaUkCPdDqYvrgZqZdQ6ZjjkPshn/BgRIn4Iqscbc64kseWpCeo5i5 716K//Q/G6+FJ+czKFRiIZU+2Uo4AW/vg3o/bcP9bb8D6VJ0G3ADTkYHyzvmJy3hOGf7 3GMpYmf72PbQvQnOxZpUjOW7lAXOkBVTH+U8JbhxR00EjaaHorErbCPHyXyTXYYIrGV8 t3LcoHoFz8TQTa4cUwCkktOQziTLOecPlMr68N+aBrKKKZpqs9PMX4w7zZbtsVpu6Avf q17r2kHdKY/QdKp8JL0IiS1MAjpa4VpuGDlrhEHSFBy5iD6aqGxpQQhgpUL7B7qwLchH tVXQ== X-Gm-Message-State: ALoCoQkx2kFiJ5ipBOrxnlu7mL3qBE8dqNfCnQem8q9my1Ng1b2xrh8RpwczyHuxaRlxBvTbM1bc X-Received: by 10.194.9.33 with SMTP id w1mr19997276wja.103.1446416424843; Sun, 01 Nov 2015 14:20:24 -0800 (PST) Received: from xps13.localnet (123.26.90.92.rev.sfr.net. [92.90.26.123]) by smtp.gmail.com with ESMTPSA id h198sm14742850wmd.9.2015.11.01.14.20.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Nov 2015 14:20:24 -0800 (PST) From: Thomas Monjalon To: Marc Sune Date: Sun, 01 Nov 2015 23:16:29 +0100 Message-ID: <5329031.lkkhyj5zos@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1445810400-8978-4-git-send-email-marcdevel@gmail.com> References: <1443993003-1059-1-git-send-email-marcdevel@gmail.com> <1445810400-8978-1-git-send-email-marcdevel@gmail.com> <1445810400-8978-4-git-send-email-marcdevel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 3/5] ethdev: redesign link speed config API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2015 22:20:25 -0000 2015-10-25 22:59, Marc Sune: > This patch redesigns the API to set the link speed/s configure > for an ethernet port. Specifically: > > - it allows to define a set of advertised speeds for > auto-negociation. > - it allows to disable link auto-negociation (single fixed speed). > - default: auto-negociate all supported speeds. > > Other changes: > > * Added utility MACROs ETH_SPEED_NUM_XXX with the numeric > values of all supported link speeds, in Mbps. > * Converted link_speed to uint32_t to accomodate 100G speeds > (bug). > * Added autoneg flag in struct rte_eth_link to indicate if > link speed was a result of auto-negociation or was fixed > by configuration. > * Added utility function to convert numeric speeds to bitmap > fields. Having it split in several commits may help to understand the changes. And it must be explained in the release notes in the "API changes".