From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A97DA034F; Fri, 4 Feb 2022 15:37:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6B604013F; Fri, 4 Feb 2022 15:37:04 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 4D49C40041 for ; Fri, 4 Feb 2022 15:37:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643985423; x=1675521423; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=15xyciGKnBr98Ti+nUAxNN0AFtNCwIcd0IXHDTZ7zX4=; b=Vsu+5JtUvKjPIU6y2qRt8ENZwNmpGGulv96A22nYPQoOWiWR7AAwx1KR Qg4sZB58huVgD/gxCtRZtPhxw2mW1drbS8dd1L13ikK2UnXMe7Qdc5Ko2 4mr6YBOZIKhmIJhPoVXHmLyOK8DsAPSR7A4PQ1cYaKasJbNIDGMde9SUs GYIJel3J1Q0E4poe0WQLaXazuXCYWSs0uR3yzwvaOLwdVw2I8Xb++1btK KatTSkMLgdSrwmCQwan8bUktUqdtq9EdJsN0sWIRuqSFJk714IDXcsIZT 7jKIZ/hylOu2eWAapr+zLRDNRbq8xl1dhf5L8jtbQ4Nj7Y/4nS9Zs2fYE Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10247"; a="272877096" X-IronPort-AV: E=Sophos;i="5.88,343,1635231600"; d="scan'208";a="272877096" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2022 06:37:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,343,1635231600"; d="scan'208";a="631720021" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga004.jf.intel.com with ESMTP; 04 Feb 2022 06:37:02 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 4 Feb 2022 06:37:01 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 4 Feb 2022 06:37:01 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 4 Feb 2022 06:37:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z+UXj0ygLrerf8Ei1fXLkN2e5qh/ikS79KGP1geDvFWkeQjcbJOv7ZvdwRyfx4KeKko/GP6wDBuIJ3ksUR2FRTL90B4xLW2+LsDj1N/HoifxicMcIQxXr06V9WzQIZbWEWpej68L/Hl1OpqDzIbgx6I1Tsp+dcB/ZZqk5YcRU3phnuJS3Qe4SU/SSqK5smDbMGzZdc1Ku1mRT7NrcmcQk56xTFDvB7XX7Pot6A5IRsXow6A1YA4Q8qNWQq0AmD+MgfrbvBYe7apOBkduoJQlYQqtPB/Ejc+f+D/+g9IkTomKRFrjhrMjSnkwO4NvxS/tHbrx0jPdHe1omnbM3GqawQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6s6FywwrQve3kcitt/UlrPYJuLs+2EL8Cxa/ZAscMmE=; b=ZFuwQXbrj9rcV2ecny628P41keNBRNPhE7hMTv4gh8Rv2nRmv+8e/awJ756ROrWtnEIHZTzCN4OghSWW1DFliMUzwnoqFg53YEv/lIzwWR+SChi13gImvFWvTUEjMfbr8j65HUcgYXG6TWUbOqJYhLbX7+vXMhYoWADRp8xam25T0Tdk0XZNFxBOVnFCJzMtMtTmLT+7ibeZyKQn9TkIxaLZInuw4s/mGnaedmuiHFBQgG+uvdNhGwY0X8x1oORaKLXbIYeaDkPJIQo+TVdkcHuvxjJLSdgbWU3yOYtwokQqLK+LVurtnRuEXkozerNoQqXTUXekdnXPyxEsmTXZWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by MN2PR11MB3934.namprd11.prod.outlook.com (2603:10b6:208:152::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb 2022 14:36:52 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.012; Fri, 4 Feb 2022 14:36:52 +0000 Message-ID: <532bfd7f-34ff-620f-8a9a-487864d40754@intel.com> Date: Fri, 4 Feb 2022 14:36:47 +0000 Content-Language: en-US To: Robert Sanford , , CC: , References: <1639592401-56845-2-git-send-email-rsanford@akamai.com> <1640116650-3475-1-git-send-email-rsanford@akamai.com> <1640116650-3475-8-git-send-email-rsanford@akamai.com> From: Ferruh Yigit Subject: Re: [PATCH v2 7/8] net/ring: add promisc and all-MC stubs X-User: ferruhy In-Reply-To: <1640116650-3475-8-git-send-email-rsanford@akamai.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0478.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 096973fc-5508-4164-2e65-08d9e7ebc905 X-MS-TrafficTypeDiagnostic: MN2PR11MB3934:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3383; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2smD03csWLneZj8m7fYln9jYvcjb/AuUS6jam88I9kldLx/jifRusizT58z2SSOPocwyEvc8aqDgR8KLLzK3ZQ3M46i9owQhs7PXrQfx+2YVeNAQQroDV6p9j/3IAcuRzvf4mao2hAZp43V2pb3I4jFcDBJF4mOHVUhP08XesQPcqYKS3sCYXOBDqRTYVx9CXWB3TRDabHtkN9M0RbJdpT7mpCmp82GbF0jwk1C2lokRHzUPec3TDg3NySQcWSh3rCauf59auE4SDHxgzokACkLC8pFylWZbGTGWgaZhazzQMU/AYVvUAc7pjIuTPU9SSwSfnLXIX2Z+ZotQhxPSTHvTja/551CDHQC+gPG2Rka46zwngg2S5h+MtRw5ah09WMFAHmbxhIRUVnSLJo6Mfaf+Uymh82VTCNpQibiLTqrKocGMcIcqAERArBqfUgp/NIx5X3O3iQQ6M/a7DP8Z+jYxfO8Qb9B3JpJhyM6HQRHPBZLXacqiAKBkfuyHkHMGmtdUZhCiPE+gqxwoWV/QB9374sEvNBqrcSycnP8vQ3T3Me5LCeu9yANdDottYymoiDld1JAH1jOY1MLuznwaWjX0ELvvuMW7bbtAGyOcceAPg4bzyKYUWTSlHKeDdvOySg6H6XkP9JMo1H4nmmxIzN96P/UubQgK+Yueh865t9So/lhLY+u158n7Ou6LAHMiYtlf2LQYCp8VHz+VYRP6TA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(4326008)(38100700002)(83380400001)(2906002)(31686004)(44832011)(36756003)(5660300002)(8936002)(6636002)(66556008)(6486002)(86362001)(316002)(8676002)(26005)(55236004)(53546011)(6506007)(66946007)(6512007)(66476007)(2616005)(82960400001)(31696002)(508600001)(6666004)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWthaGp0eFBaTURiTUpJVCtoVHNJV2g5WTR2dGtqNlB2TzhCQXFlTzluRWkw?= =?utf-8?B?eC83RW0wVFRwa1Zmb3gyd0h4Yi8vWDB3c0paQmZ6aGx5dlV6WUQwMy9jRzQy?= =?utf-8?B?d3E3V2o5THZDa3oyamtJRzVxY21zTC82dWlyclFZNGF5V0lXMmlJYUVXalF2?= =?utf-8?B?aEJtWWdyNGE1cmhVV1VCRUhGSDZRTStGWjRCcFZ1aHNJVXVqMTVPQm9VcnFn?= =?utf-8?B?NjNoNDVieFBjdFlYakkvRWFFYkU3ZUJ3VkpsZWhaVUVVOS9PTmYyMytRb2dO?= =?utf-8?B?S3cxRHNKVnRpQnNIM2tJVkt2QW1sMytXV3JlSnk2NXhmeFdodko1OVpKbTB5?= =?utf-8?B?dFIzeVM5bDRuZHdmY0luS1hYc1dwYm1RSHlWQ2ZYUmk0eE9hZFVSN3R2QWx4?= =?utf-8?B?eHN0Y2RhVlBvVnBoNkNXMFNXdm9ZV2xpQXRVN3M0SzlmMGt6NWJ0T1hwcmlJ?= =?utf-8?B?T2h4SzcxdnVlbGxVQzBucUJmenVwUzdSdFFXVmY1bHZUNS9KVkttOW5nQit2?= =?utf-8?B?TUJBWFQ0cnlSenZXWFpTUHFHL0tnYnFrTVR0amxNNURIbFZ6MWVZcEhkaWx0?= =?utf-8?B?dlFLZUZqUmhmNjF0ckVlTmlHYXl5Um82QytKYnRoT2poR0dJd2w2Y3E5dmx1?= =?utf-8?B?akh6N01lUTdFNytoZ0g0TVBZSnV3R0NsOVFBVVlNUVBuTU9rSFRXYzhJZzF0?= =?utf-8?B?Y2dveTdteHl4Q1FZeXhuc1pFOXh3L29YMlEySytLVW1mVk9GUW8ySkNpVWMz?= =?utf-8?B?emVKQWd5SFl5a3R2MVE3QnJpbEZHRUhuSERMTHJXbExzcDZpUjMvZy9Ud29O?= =?utf-8?B?Z2J2NzRhaU1pSmNFeVpISExyRnZPS1pISTIwREgxa1R3V095L0ZLcnRiRmtz?= =?utf-8?B?d0E5VC8vMmY4ZG5TS0VvOUlkSkdrdXFyNFhGVDlLcmUzeXNjT2hOYUFuWHVO?= =?utf-8?B?Z2NzQm1hMmN2NVgyUEpOdi9JNTNIanZLM1Jpc2dSdWtBMSsxMU9Rdmd1cnlE?= =?utf-8?B?eGhNSlN1M2JqYy9Ea01sQUZMWk11RlRWRUVKL3dZYlMwWWIzNldNOG1HVnlP?= =?utf-8?B?Q0VTZkZMMmF1R1o2SDB6Z3djcm1GMVdRckt5cEZsdWpiOEhYSytDK2dyR2ZZ?= =?utf-8?B?WWNnS1BML2toQWtJRjNjS3hCV1QxOGlkdUROZFJqejB1UUtXc3FuYkVkbllh?= =?utf-8?B?TC8rS2F3SC8vM2NObG1XKytOaFBlR3JMVGRaeHFWeHQxM1pPUHd6Q1NqeG1I?= =?utf-8?B?ckRUbEdDakhiLzdGd2hqbHVJbmVCZmtuaG5zdlZnNW5WWFJ0TTlyeHhFNllo?= =?utf-8?B?b0Z3WHgrTFVZUUxqOFpWdEJKSkhNZkVVYkg4YnJjTG5pdjF5QmZFVjQ5QmlO?= =?utf-8?B?d0dYODBDQ1RVK213M2c1S0M3SjJCU1FYa1grd2xnbXZBbWt5c3hzc2Z3Z3Rz?= =?utf-8?B?cHZVbzJQVTFEakx1WlJWUi83S2h1NjNERVZzbCtXVjV3a0ZGekw3SXhGQmc4?= =?utf-8?B?bWI4Ty8ycTlpT3J4WElYSlBjWDh5MERHMStGaVlrbHNpWTB2QzcvWm1vbWR2?= =?utf-8?B?djdWTmZEbzl4STI2Mk1aN1FlcVFVYWRIbjE0aVlSSTVBdkFKZElJUnlzQ244?= =?utf-8?B?NlZkd1prY1lhdUlLYTFnTkdvejE0WS9xMzdKNlJPQWw3cUlPSFhZTitSQWZM?= =?utf-8?B?b3JCcXVwTm9vZk40NmQzTEJwUG1sZEVyUnpIRVBJaHh6T3dtK0o1enFTT0Zw?= =?utf-8?B?cnlPbkY5bC9aN0RGemdhSWloQnlJcnlKeVlvaDF6NUhScmZNWWpabnRnZ3Js?= =?utf-8?B?V3ZXQkNMQjJ3aEh4NStpOUxCZ2ROb1VYSzNrdlRubFQrMW82M09RdUdzK0F5?= =?utf-8?B?TjQ5QWJBalY2aGVYeit0QTd4clRwbFhnRlJkTDltalJVZ3J3c1BoVElOR01G?= =?utf-8?B?MzFTeEVCRG4ra2RrcVE1SldQckFjS1NJYVNEaHVDenZwZ1VoT0J2VmY2c0hJ?= =?utf-8?B?eEFTdGFCbVZaSUN5UEhXeERJcjF1czRmN3NiUlVIY2NlMXc1ZmQrNWZKU3FM?= =?utf-8?B?NjJHTFZzbEp1bmkzMHRJY1dHUGZieGh2R244cVRBdVZEdEdOYWpnR1NrUm1O?= =?utf-8?B?Tlg3UEtxdnBXUE9uWjY5OTRxbkhxeWJ4b0dxSkFyeXhrQXA2TFN6UTQxQ0ZC?= =?utf-8?Q?ql6QHnfNuCBLUOIRPIchypo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 096973fc-5508-4164-2e65-08d9e7ebc905 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 14:36:52.8182 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UnQZG0/v+OZlEsqZH5EIfHnRiRTCvwi8X6xZd6tvOEWrdSJ41EfsfccqmxufhADd7El2cZgCANuijanDvQlWdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3934 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/21/2021 7:57 PM, Robert Sanford wrote: > Add promiscuous_enable, promiscuous_disable, allmulticast_enable, > and allmulticast_disable API stubs. > This helps clean up errors in dpdk-test link_bonding_mode4_autotest. > > Signed-off-by: Robert Sanford > --- > drivers/net/ring/rte_eth_ring.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c > index db10f03..cfb81da 100644 > --- a/drivers/net/ring/rte_eth_ring.c > +++ b/drivers/net/ring/rte_eth_ring.c > @@ -226,6 +226,30 @@ eth_mac_addr_add(struct rte_eth_dev *dev __rte_unused, > } > > static int > +eth_promiscuous_enable(struct rte_eth_dev *dev __rte_unused) > +{ > + return 0; > +} > + > +static int > +eth_promiscuous_disable(struct rte_eth_dev *dev __rte_unused) > +{ > + return 0; > +} > + > +static int > +eth_allmulticast_enable(struct rte_eth_dev *dev __rte_unused) > +{ > + return 0; > +} > + > +static int > +eth_allmulticast_disable(struct rte_eth_dev *dev __rte_unused) > +{ > + return 0; > +} > + > +static int > eth_link_update(struct rte_eth_dev *dev __rte_unused, > int wait_to_complete __rte_unused) { return 0; } > > @@ -275,6 +299,10 @@ static const struct eth_dev_ops ops = { > .stats_reset = eth_stats_reset, > .mac_addr_remove = eth_mac_addr_remove, > .mac_addr_add = eth_mac_addr_add, > + .promiscuous_enable = eth_promiscuous_enable, > + .promiscuous_disable = eth_promiscuous_disable, > + .allmulticast_enable = eth_allmulticast_enable, > + .allmulticast_disable = eth_allmulticast_disable, not sure about adding dummy dev_ops to the driver for the unit test, what about updating 'link_bonding_mode4_autotest' accordingly? Bruce (net/ring maintainer), what do you think about dummy dev_ops?