From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CFC651B8BA
for <dev@dpdk.org>; Fri, 29 Jun 2018 23:56:43 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 36A9B21BF8;
Fri, 29 Jun 2018 17:56:43 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Fri, 29 Jun 2018 17:56:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=kvgsxgn6zAKcim8mBY7mIkZxoO
yS/2/+rxsjj2XhcSk=; b=iQDB+m+Xz2ES1AMjXEn7LxlICCb0lrMQVVQOFpWO37
dfwTRb5igUCJyvDN/ts/Zm8GNIblCMsjltP1O+bp3wHNg+4q8qZVM+76wL5yh2Jv
OQ+ASp2aMAJPridPLx/goB0LdaTnjZU4Lh7PS9ttJDcT+l6p9cvdJld1Btls8nGO
c=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=kvgsxg
n6zAKcim8mBY7mIkZxoOyS/2/+rxsjj2XhcSk=; b=tbLbSSJFP3lVPY21NcVDZe
z4BNPP/EDhlENm/eQSKrtfesCiX0DCMyteNcTMIk9GXI0R2hrBT59M0ZZ4Cibb8n
rBoFzDZ7WRfkoZA91Sqsx2jgx5bp7psnjZ5f16glF+mnhHNGInlIYJ2aJElUgulv
+kAhdxERbHpaARVIJtUnb39knBz0Z8vA1WgxxrAQZ7r40nwKZoz9UAGcYQkmCFg7
ofx9nShYGhKO8lfN8tgbkTrGtKYlqmKJohFmmAvFtC4TjLoY4xcagyA4f4KfTdCp
AHhDnmkdBdySnjfPbSiWJP3vY41gJaC5C99KqOU1CxxKcPBhbaod85A4L+uT3c/w
==
X-ME-Proxy: <xmx:Gqs2W2OJD5iik73WHs9CazUe5zuJU1r2TtESfWEcbl777Td2f5vBxQ>
<xmx:Gqs2W4pkFtNR4rplu-fAC5OqpALET2lugltBrP1LgM8_p6QYIuAPgw>
<xmx:Gqs2W14YjCFTicYjRvfJCJoE32IJCPkHkbNt1UVnsNtL5w7XnufIuA>
<xmx:Gqs2W4Ebs1GzGNtVOp08Imzm6ToaEINNyZsoCQ1WbhJpzTS80eWkwA>
<xmx:Gqs2W_0jTwxCEMd21tB-jA7nzmnj6p7DQhF1V4BMLIVVyUEyAzQGew>
<xmx:G6s2W_iUN3c3Ii64dLnpdljWFXsMbQmuRJ99xN8bokH29bUyr-J4Dw>
X-ME-Sender: <xms:Gqs2W_thokGmyMaZ5mUyO1fCHamUNJS5zJfxHjJFlFJpP6dpFJoI8g>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id B1F121025D;
Fri, 29 Jun 2018 17:56:41 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
john.mcnamara@intel.com, bluca@debian.org, yskoh@mellanox.com,
christian.ehrhardt@canonical.com, aconole@redhat.com
Date: Fri, 29 Jun 2018 23:56:40 +0200
Message-ID: <5332944.6YUZ7rFQxA@xps>
In-Reply-To: <3f70448c-9bd5-59b6-7231-3a747ec79062@redhat.com>
References: <1529596827-14756-1-git-send-email-ktraynor@redhat.com>
<17794913.e2HM90q5a3@xps> <3f70448c-9bd5-59b6-7231-3a747ec79062@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] docs: add default that all fixes are
backported
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jun 2018 21:56:44 -0000
29/06/2018 23:39, Kevin Traynor:
> On 06/29/2018 05:15 PM, Thomas Monjalon wrote:
> > 21/06/2018 18:45, Ferruh Yigit:
> >> On 6/21/2018 5:00 PM, Kevin Traynor wrote:
> >>> Set the starting point that all commits on master branch
> >>> with Fixes tag are backported to relevant stable/LTS branches.
> >>>
> >>> Of course there will be exceptions that will crop up from time
> >>> to time that need discussion, so also add a sentence for that.
> >>>
> >>> This is to ensure that there is consistency between what is
> >>> backported to stable/LTS branches, remove some subjectivity
> >>> as to what constitutes "a fix" and avoid possible conflicts
> >>> for future backports.
> >>>
> >>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> >>> ---
> >>> doc/guides/contributing/stable.rst | 4 +++-
> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/doc/guides/contributing/stable.rst b/doc/guides/contributing/stable.rst
> >>> index 0f2f1f3..bbafc37 100644
> >>> --- a/doc/guides/contributing/stable.rst
> >>> +++ b/doc/guides/contributing/stable.rst
> >>> @@ -58,5 +58,7 @@ What changes should be backported
> >>> ---------------------------------
> >>>
> >>> -Backporting should be limited to bug fixes.
> >>> +Backporting should be limited to bug fixes. All patches accepted on the master
> >>> +branch with Fixes tags will be backported to the relevant stable/LTS branches.
> >>> +If there are exceptions, they will be discussed on the mailing lists.
> >>
> >> Just to highlight, there are some cased fix is not applicable for stable trees,
> >> for that case "Cc: stable@dpdk.org" tag explicitly omitted.
> >>
> >> a) Fix with backport request:
> >> Fixes: ############ ("...")
> >> Cc: stable@dpdk.org
> >>
> >> b) Fix but backport not applicable/requested:
> >> Fixes: ############ ("...")
> >>
> >>
> >> So I agree there may be a confusion in b) if the backport is not requested or it
> >> has been forgotten.
> >> Is there anything we can do/change to help stable tree maintainers on this issue?
> >
> > I agree with Ferruh that fixes without Cc: stable@dpdk.org
> > should not be backported, except if it is confirmed that it is a miss.
> >
> > Can we change the wording to "all patches with Cc: stable@dpdk.org tag" ?
> >
> >
>
> I agree this case should be catered for. That approach will work fine as
> long as most people remember the tags :-)
As maintainers, our role is to make sure the tag is not forgotten.
We use the tool devtools/check-git-log.sh.
> I reworded it a little bit differently to try and also keep the essence
> that as many Fixes as possible should be backported. Otherwise devs may
> use the Cc: stable@dpdk.org based on wildly different opinions about the
> stable branches and what types of fixes are backported.
Yes the most important is to explain the intent.
Thanks