From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id BD1933F9
 for <dev@dpdk.org>; Thu, 27 Mar 2014 09:33:14 +0100 (CET)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa
 (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80)
 (envelope-from <olivier.matz@6wind.com>)
 id 1WT5nB-0005Sy-VA; Thu, 27 Mar 2014 09:36:08 +0100
Message-ID: <5333E2F3.6060503@6wind.com>
Date: Thu, 27 Mar 2014 09:36:03 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20131103 Icedove/17.0.10
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1391529271-24606-1-git-send-email-thomas.monjalon@6wind.com>
 <1391529271-24606-14-git-send-email-thomas.monjalon@6wind.com>
In-Reply-To: <1391529271-24606-14-git-send-email-thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [memnic PATCH 13/16] pmd: rename doc when installing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Mar 2014 08:33:15 -0000

Hi Thomas,

On 02/04/2014 04:54 PM, Thomas Monjalon wrote:
> MEMNIC doc may be installed with other DPDK docs.
> So more descriptive naming is required.
>
> A rule is created in order to have the same rule style for lib and doc.
>
> Signed-off-by: Thomas Monjalon<thomas.monjalon@6wind.com>
> ---
>   pmd/Makefile |    9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/pmd/Makefile b/pmd/Makefile
> index 7f96af1..1e24a15 100644
> --- a/pmd/Makefile
> +++ b/pmd/Makefile

  [...]

> +install : $(DESTDIR)$(docdir)/$(DOC)
> +$(DESTDIR)$(docdir)/$(DOC) : $S/README.rst
> +	install -D -m 644 $< $@
> +

What about renaming README.rst in dpdk-memnic.rst in source ?
The rest of the patch looks good to me.

Reviewed-by: Olivier Matz <olivier.matz@6wind.com>