From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 1EA6268C0
 for <dev@dpdk.org>; Thu, 27 Mar 2014 09:43:03 +0100 (CET)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa
 (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80)
 (envelope-from <olivier.matz@6wind.com>)
 id 1WT5wg-0005TM-3A; Thu, 27 Mar 2014 09:45:57 +0100
Message-ID: <5333E53F.2050209@6wind.com>
Date: Thu, 27 Mar 2014 09:45:51 +0100
From: Olivier MATZ <olivier.matz@6wind.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:17.0) Gecko/20131103 Icedove/17.0.10
MIME-Version: 1.0
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1391529271-24606-1-git-send-email-thomas.monjalon@6wind.com>
 <1391529271-24606-16-git-send-email-thomas.monjalon@6wind.com>
In-Reply-To: <1391529271-24606-16-git-send-email-thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [memnic PATCH 15/16] pmd: remove useless makefile
 variables
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Mar 2014 08:43:03 -0000

On 02/04/2014 04:54 PM, Thomas Monjalon wrote:
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>   pmd/Makefile |    7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/pmd/Makefile b/pmd/Makefile
> index 730b126..5edc44e 100644
> --- a/pmd/Makefile
> +++ b/pmd/Makefile
> @@ -29,10 +29,7 @@
>   # ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
>   # OF THE POSSIBILITY OF SUCH DAMAGE.
>
> -PKG = librte_pmd_memnic_copy
> -
> -RTE_CONFIG = $(RTE_INCLUDE)/rte_config.h
> -SOLIB = $(PKG).so
> +SOLIB = librte_pmd_memnic_copy.so
>   DOC = dpdk-memnic.rst
>
>   S ?= .
> @@ -59,7 +56,7 @@ ifeq '$(RTE_INCLUDE)' ''
>   	@ echo 'ERROR: RTE_INCLUDE is not set' && false
>   endif
>   	$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) \
> -		-I$(RTE_INCLUDE) -include $(RTE_CONFIG) \
> +		-I$(RTE_INCLUDE) -include $(RTE_INCLUDE)/rte_config.h \
>   		-I$S/../common -o $@ $<
>
>   install : $(DESTDIR)$(libdir)/$(SOLIB)
>

Reviewed-by: Olivier Matz <olivier.matz@6wind.com>