DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: stable@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
	"Glynn, Michael J" <michael.j.glynn@intel.com>,
	"Liu, Yu Y" <yu.y.liu@intel.com>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/librte_cmdline: fix CLI parsing issue
Date: Mon, 01 May 2017 00:18:47 +0200	[thread overview]
Message-ID: <5335581.HtrMrUQc5L@xps> (raw)
In-Reply-To: <20170428111325.7f0d2ab2@platinum>

28/04/2017 11:13, Olivier Matz:
> Hi Wenzhuo,
> 
> On Fri, 28 Apr 2017 08:38:21 +0000, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> wrote:
> > Hi Oilvier,
> > As we discussed before, I send this patch. Would you like to take a look at it? Better fix it before release 17.05, thanks.
> > 
> > 
> > > When parsing a CLI, all the CLI instances are checked one by one. Even if an
> > > instance already matches the CLI, the parsing will not stop for ambiguous
> > > check.
> > > The problem is that the following check may change the parsing result of the
> > > previous one even if the following instance doesn't match.
> > > 
> > > Use a temporary validate for the parsing result when trying to match an
> > > instance and only store the result when it matches, so the previous result
> > > has no chance to be changed.
> > > 
> > > Fixes: af75078fece3 ("first public release")
> > > CC: stable@dpdk.org
> > > 
> > > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> 
> Sorry for the delay,
> 
> Acked-by: Olivier Matz <olivier.matz@6wind.com>

Applied, thanks

      reply	other threads:[~2017-04-30 22:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25  3:11 [dpdk-dev] " Wenzhuo Lu
2017-04-28  8:38 ` Lu, Wenzhuo
2017-04-28  9:13   ` Olivier Matz
2017-04-30 22:18     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5335581.HtrMrUQc5L@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=michael.j.glynn@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=yu.y.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).