From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 323E62A58 for ; Tue, 14 Jul 2015 07:16:45 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 13 Jul 2015 22:16:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,469,1432623600"; d="scan'208";a="728389634" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by orsmga001.jf.intel.com with ESMTP; 13 Jul 2015 22:16:43 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 14 Jul 2015 13:15:58 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.157]) with mapi id 14.03.0224.002; Tue, 14 Jul 2015 13:15:57 +0800 From: "Qiu, Michael" To: Tetsuya Mukawa , Thomas Monjalon , "Iremonger, Bernard" Thread-Topic: [dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function. Thread-Index: AQHQuGZ2n8VMGX2c2UGd/sqfXzmeTQ== Date: Tue, 14 Jul 2015 05:15:57 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286046BA609@SHSMSX101.ccr.corp.intel.com> References: <8CEF83825BEC744B83065625E567D7C204A46F17@IRSMSX108.ger.corp.intel.com> <3983969.nNQCjP6QHn@xps13> <559DEB39.5080808@igel.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] librte_ether: release memory in uninit function. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 05:16:45 -0000 On 7/9/2015 11:32 AM, Tetsuya Mukawa wrote:=0A= > On 2015/07/08 18:59, Thomas Monjalon wrote:=0A= >> 2015-07-08 09:49, Iremonger, Bernard:=0A= >>> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]=0A= >>>> On 2015/07/07 19:53, Iremonger, Bernard wrote:=0A= >>>>> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]=0A= >>>>>> On 2015/07/06 20:35, Qiu, Michael wrote:=0A= >>>>>>> Hi, all=0A= >>>>>>>=0A= >>>>>>> As we has gap on the memory release action to be done in which step= ,=0A= >>>>>>> I appreciate all your comments on this patch.=0A= >>>>>>>=0A= >>>>>>> Currently, the correct quit sequence for testpmd is stop() --->=0A= >>>>>>> port_stop() --> port_close() --> quit(). This will lead lots of=0A= >>>>>>> memory not released by default, like queues.=0A= =0A= [.../...]=0A= =0A= >> It appears that the API is not defined.=0A= >> None of these assumptions is written in rte_ethdev.h.=0A= >> Please continue the discussion by submitting a patch fixing the doxygen= =0A= >> comments of these functions.=0A= >> How an application developper is supposed to use these functions without= =0A= >> having a clear explanation of their roles in doxygen?=0A= > Yes, this assumption is only written in DPDK user's guide.=0A= > So we should add description to doxygen. I will take care of it.=0A= >=0A= > Anyway, I will add description to doxygen like user's guide.=0A= > (A) stop() and close() must be called before detach().=0A= > (B) close() releases all most all resources.=0A= > Probably Bernard and Michael patches are fit for above restrictions.=0A= >=0A= > It may be good to add below in DPDK-2.2, though supporting below feature= =0A= > will be more user friendly.=0A= > (C) Even if stop() and close() are not called, detach() will take care= =0A= > of it.=0A= >=0A= > Probably, it's not so much time left before releasing DPDK-2.1.=0A= > So how about keeping current restriction written in user's guide, then=0A= > add a new feature in DPDK-2.2.=0A= =0A= Yes, agree.=0A= =0A= Thanks,=0A= Michael=0A= > Regards,=0A= > Tetsuya=0A= >=0A= =0A=