From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 801698E7E for ; Mon, 2 Nov 2015 06:30:29 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 01 Nov 2015 21:30:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,233,1444719600"; d="scan'208";a="840354988" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 01 Nov 2015 21:30:25 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 1 Nov 2015 21:29:39 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 1 Nov 2015 21:29:38 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id 14.03.0248.002; Mon, 2 Nov 2015 13:28:50 +0800 From: "Qiu, Michael" To: "Iremonger, Bernard" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v7 00/28] remove pci driver from vdevs Thread-Index: AQHREyT7arY75J6140Kg9H4rK+3AEg== Date: Mon, 2 Nov 2015 05:28:50 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E6028621B5A5E8@SHSMSX101.ccr.corp.intel.com> References: <1446217733-9887-1-git-send-email-bernard.iremonger@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 00/28] remove pci driver from vdevs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 05:30:30 -0000 Hi, Bernard=0A= =0A= Could we merge some patch together? I see lots of patches are simple and=0A= doing the same thing but in different NIC, merge them almost have no=0A= affect of review, what's more it will make reviewers more comfortable=0A= with less and simple patches.=0A= =0A= Then we could have a clean patch set with almost 5 patches, not totally 28.= =0A= =0A= librte_eal: add RTE_KDRV_NONE for vdevs=0A= librte_ether: add fields from rte_pci_driver to rte_eth_dev_data=0A= drivers: copy pci device info to eth_dev data=0A= librte_ether: remove branches on pci_dev=0A= drivers: remove pci device=0A= =0A= At least, we could merge serial patches "xxxx:copy pci device info to=0A= eth_dev data" to "drivers: copy pci device info to eth_dev data" in my mind= .=0A= =0A= Just an advise, but better to have.=0A= =0A= Thanks,=0A= Michael=0A= On 2015/10/30 23:09, Bernard Iremonger wrote:=0A= > There is a dummy pci driver in the vdev PMD's at present.=0A= > This patch set removes the pci driver from the vdev PMD's.=0A= > Changes have been made to librte_ether to handle vdevs and pdevs in the s= ame way.=0A= >=0A= > The following vdev PMD's have had the pci driver removed:=0A= >=0A= > null=0A= > ring=0A= > bonding=0A= > pcap=0A= > af_packet=0A= > xenvirt=0A= > mpipe=0A= >=0A= > All the pdev PMD's have been modified to copy the pci device info into et= h_dev data.=0A= >=0A= > Changes in v7:=0A= > rebase to latest code.=0A= >=0A= > Changes in v6:=0A= > Initialise data->drv_name with the PMD driver name in the vdevs.=0A= > Remove two more branches on pci_dev from the bonding vdev.=0A= >=0A= > Changes in v5:=0A= > rebase to latest code.=0A= > refactor patches to avoid potential problems with git bisect.=0A= >=0A= > Changes in v4:=0A= > rebase to latest code.=0A= > add doxygen comments to rte_ethdev.h=0A= > update release notes in patch 0002.=0A= >=0A= > Changes in v3:=0A= > rebase to latest code.=0A= > restructure patches 0002 and 0003 to fix compile issue in patch 0002.=0A= >=0A= > Changes in V2:=0A= > rebase to latest code.=0A= > fix compile error in rte_ethdev.c when debug disabled.=0A= > remove Intel copyright from bnx2x, cxgbe, enic, mlx4, mpipe and null PMD'= s.=0A= >=0A= > Bernard Iremonger (28):=0A= > librte_eal: add RTE_KDRV_NONE for vdevs=0A= > librte_ether: add fields from rte_pci_driver to rte_eth_dev_data=0A= > librte_ether: add function rte_eth_copy_dev_info=0A= > ixgbe: copy pci device info to eth_dev data=0A= > e1000: copy pci device info to eth_dev data=0A= > i40e: copy pci device info to eth_dev data=0A= > fm10k: copy pci device info to eth_dev data=0A= > bnx2x: copy pci device info to eth_dev data=0A= > cxgbe: copy pci device info to eth_dev data=0A= > enic: copy pci device info to eth_dev data=0A= > mlx4: copy pci device info to eth_dev data=0A= > virtio: copy pci device info to eth_dev data=0A= > vmxnet3: copy pci device info to eth_dev data=0A= > null: copy device info to eth_dev data=0A= > ring: copy device info to eth_dev data=0A= > pcap: copy device info to eth_dev data=0A= > af_packet: copy device info to eth_dev data=0A= > xenvirt: copy device info to eth_dev data=0A= > mpipe: copy device info to eth_dev data=0A= > bonding: copy device info to eth_dev data=0A= > librte_ether: remove branches on pci_dev=0A= > null: remove pci device=0A= > ring: remove pci device=0A= > pcap: remove pci device=0A= > af_packet: remove pci device=0A= > xenvirt: remove pci device=0A= > mpipe: remove pci device=0A= > bonding: remove pci device=0A= >=0A= > doc/guides/rel_notes/release_2_2.rst | 4 ++=0A= > drivers/net/af_packet/rte_eth_af_packet.c | 20 ++++------=0A= > drivers/net/bnx2x/bnx2x_ethdev.c | 3 ++=0A= > drivers/net/bonding/rte_eth_bond_8023ad.c | 4 +-=0A= > drivers/net/bonding/rte_eth_bond_alb.c | 2 +-=0A= > drivers/net/bonding/rte_eth_bond_api.c | 60 +++++++++---------------= ------=0A= > drivers/net/bonding/rte_eth_bond_pmd.c | 18 ++++-----=0A= > drivers/net/bonding/rte_eth_bond_private.h | 2 +-=0A= > drivers/net/cxgbe/cxgbe_ethdev.c | 3 ++=0A= > drivers/net/e1000/em_ethdev.c | 3 ++=0A= > drivers/net/e1000/igb_ethdev.c | 5 +++=0A= > drivers/net/enic/enic_ethdev.c | 1 +=0A= > drivers/net/fm10k/fm10k_ethdev.c | 2 +=0A= > drivers/net/i40e/i40e_ethdev.c | 3 ++=0A= > drivers/net/i40e/i40e_ethdev_vf.c | 2 +=0A= > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++=0A= > drivers/net/mlx4/mlx4.c | 3 ++=0A= > drivers/net/mpipe/mpipe_tilegx.c | 10 +++--=0A= > drivers/net/null/rte_eth_null.c | 29 ++++-----------=0A= > drivers/net/pcap/rte_eth_pcap.c | 31 +++++----------=0A= > drivers/net/ring/rte_eth_ring.c | 37 ++++--------------=0A= > drivers/net/virtio/virtio_ethdev.c | 3 ++=0A= > drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +=0A= > drivers/net/xenvirt/rte_eth_xenvirt.c | 18 ++++-----=0A= > lib/librte_eal/common/include/rte_pci.h | 3 +-=0A= > lib/librte_ether/rte_ethdev.c | 54 +++++++++++++++---------= ---=0A= > lib/librte_ether/rte_ethdev.h | 29 +++++++++++++++=0A= > lib/librte_ether/rte_ether_version.map | 7 ++++=0A= > 28 files changed, 185 insertions(+), 177 deletions(-)=0A= >=0A= =0A=