From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.qiu@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id E5A4058F1
 for <dev@dpdk.org>; Fri, 27 Nov 2015 03:26:20 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP; 26 Nov 2015 18:26:21 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,349,1444719600"; d="scan'208";a="695220060"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga003.jf.intel.com with ESMTP; 26 Nov 2015 18:26:19 -0800
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Thu, 26 Nov 2015 18:26:19 -0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.83]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.138]) with mapi id 14.03.0248.002;
 Fri, 27 Nov 2015 10:26:17 +0800
From: "Qiu, Michael" <michael.qiu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4
Thread-Index: AQHRKDg57BqI5b3QlEW4GN52pAAdOA==
Date: Fri, 27 Nov 2015 02:26:17 +0000
Message-ID: <533710CFB86FA344BFBF2D6802E6028621B8CCF5@SHSMSX101.ccr.corp.intel.com>
References: <1448534997-24297-1-git-send-email-michael.qiu@intel.com>
 <40264692.U54vlS2tjY@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_sched: Fix compile with gcc 4.3.4
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Nov 2015 02:26:21 -0000

On 2015/11/27 5:29, Thomas Monjalon wrote:=0A=
> 2015-11-26 18:49, Michael Qiu:=0A=
>> gcc 4.3.4 does not include "immintrin.h", and will post below error:=0A=
>>     lib/librte_sched/rte_sched.c:56:23: error:=0A=
>>     immintrin.h: No such file or directory=0A=
>>=0A=
>> To avoid this issue, a gcc version check is need and a flag to indicate=
=0A=
>> vector ablility.=0A=
> [...]=0A=
>> +#if (defined(__ICC) || (__GNUC__ =3D=3D 4 &&  __GNUC_MINOR__ < 4))=0A=
>> +=0A=
>> +#if defined(__AVX__)=0A=
>>  #include <immintrin.h>=0A=
>> +#define SCHED_VECTOR_ENABLE=0A=
>> +#endif=0A=
>> +=0A=
>> +#else=0A=
>> +=0A=
>> +#include <x86intrin.h>=0A=
>> +#define SCHED_VECTOR_ENABLE=0A=
>> +=0A=
>> +#endif=0A=
> This kind of complication is managed by EAL.=0A=
> I think we should include rte_vect.h.=0A=
=0A=
As I know here it needs a flag to identify whether the platform support=0A=
AVX, if not it will not use it, so I don't know if we could only simply=0A=
include rte_vect.h?=0A=
=0A=
Thanks,=0A=
Michael=0A=
>=0A=
>=0A=
=0A=