From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.qiu@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 1251358DB
 for <dev@dpdk.org>; Wed,  2 Dec 2015 03:29:29 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga103.fm.intel.com with ESMTP; 01 Dec 2015 18:29:28 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,371,1444719600"; d="scan'208";a="862673331"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
 by orsmga002.jf.intel.com with ESMTP; 01 Dec 2015 18:29:28 -0800
Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 1 Dec 2015 18:29:27 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 1 Dec 2015 18:29:27 -0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.83]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.92]) with mapi id 14.03.0248.002;
 Wed, 2 Dec 2015 10:29:25 +0800
From: "Qiu, Michael" <michael.qiu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [PATCH v2] lib/librte_sched: Fix compile with gcc 4.3.4
Thread-Index: AQHRLKaT5WQojdrH2kOzeH6Huz88cA==
Date: Wed, 2 Dec 2015 02:29:24 +0000
Message-ID: <533710CFB86FA344BFBF2D6802E6028621B90ECB@SHSMSX101.ccr.corp.intel.com>
References: <1448534997-24297-1-git-send-email-michael.qiu@intel.com>
 <1449022194-25510-1-git-send-email-michael.qiu@intel.com>
 <5915028.hIVKuBcS7U@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] lib/librte_sched: Fix compile with gcc
	4.3.4
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Dec 2015 02:29:30 -0000

I will make v3 patch to fix the issue.=0A=
=0A=
Thanks,=0A=
Michael=0A=
=0A=
On 2015/12/2 10:19, Thomas Monjalon wrote:=0A=
> 2015-12-02 10:09, Michael Qiu:=0A=
>> gcc 4.3.4 does not include "immintrin.h", and will post below error:=0A=
>>     lib/librte_sched/rte_sched.c:56:23: error:=0A=
>>     immintrin.h: No such file or directory=0A=
> This compiler issue is fixed with rte_vect.h.=0A=
>=0A=
>> To avoid this issue, a gcc version check is need and a flag to indicate=
=0A=
>> vector ablility.=0A=
> It is another issue: we need SSE2 support.=0A=
>=0A=
>> --- a/lib/librte_sched/rte_sched.c=0A=
>> +++ b/lib/librte_sched/rte_sched.c=0A=
>> @@ -42,6 +42,7 @@=0A=
>>  #include <rte_prefetch.h>=0A=
>>  #include <rte_branch_prediction.h>=0A=
>>  #include <rte_mbuf.h>=0A=
>> +#include <rte_vect.h>=0A=
> Shouldn't be in #ifdef RTE_SCHED_VECTOR ?=0A=
>=0A=
>>  #include "rte_sched.h"=0A=
>>  #include "rte_bitmap.h"=0A=
>> @@ -53,7 +54,11 @@=0A=
>>  #endif=0A=
>>  =0A=
>>  #ifdef RTE_SCHED_VECTOR=0A=
>> -#include <immintrin.h>=0A=
>> +=0A=
>> +#if defined(__SSE2__)=0A=
>> +#define SCHED_VECTOR_ENABLE=0A=
>> +#endif=0A=
> I think the flag should SCHED_VECTOR_SSE2=0A=
>=0A=
> With this fix, the need for disabling SCHED_VECTOR for non-x86 platforms=
=0A=
> should disappear.=0A=
> But it may be safe to disable it (another patch).=0A=
> Thanks=0A=
>=0A=
=0A=