From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7E2E25A49 for ; Mon, 28 Dec 2015 05:40:59 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 27 Dec 2015 20:40:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,489,1444719600"; d="scan'208";a="849310582" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 27 Dec 2015 20:40:58 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 27 Dec 2015 20:40:57 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.110.15) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 27 Dec 2015 20:40:57 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.111]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.183]) with mapi id 14.03.0248.002; Mon, 28 Dec 2015 12:40:50 +0800 From: "Qiu, Michael" To: "Pattan, Reshma" , "Doherty, Declan" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 1/3] librte_ether: remove RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET Thread-Index: AQHRPXw+2giVuH0E3EilIDEcavWXmA== Date: Mon, 28 Dec 2015 04:40:49 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E6028622F04D4E@SHSMSX101.ccr.corp.intel.com> References: <1450873172-21932-1-git-send-email-reshma.pattan@intel.com> <533710CFB86FA344BFBF2D6802E6028622F0018D@SHSMSX101.ccr.corp.intel.com> <3AEA2BF9852C6F48A459DA490692831FF8E2AD@IRSMSX109.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/3] librte_ether: remove RTE_PROC_PRIMARY_OR_ERR_RET and RTE_PROC_PRIMARY_OR_RET X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2015 04:40:59 -0000 On 12/25/2015 1:40 AM, Pattan, Reshma wrote:=0A= >=0A= >> -----Original Message-----=0A= >> From: Qiu, Michael=0A= >> On 12/23/2015 8:19 PM, Reshma Pattan wrote:=0A= >>> Macros RTE_PROC_PRIMARY_OR_ERR_RET and=0A= >> RTE_PROC_PRIMARY_OR_RET are=0A= >>> blocking the secondary process from using the APIs.=0A= >>> API access should be given to both secondary and primary.=0A= >> Just as the log says, is it safe to do so?=0A= >=0A= > Hi,=0A= >=0A= > Some parts of the code still need these macros, which I am not sure yet. = But as and when we identify those we have to add the macros to the needed p= laces. =0A= > But it is safe to remove from start of function to allow secondary proces= s to do device configuration and queue setups for vdev. =0A= > Please let me know if you know any of such cases where these macros shoul= d be added.=0A= =0A= You you have removed almost all secondary check, and as I know, with=0A= your patch, secondary almost has full control of a device, what's the=0A= exact demand for secondary to have full API access?=0A= =0A= It's a big change for DPDK I think, but patch set itself is good for me:)= =0A= =0A= Thanks,=0A= Michael=0A= > Thanks,=0A= > Reshma=0A= > =0A= >=0A= =0A=