From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.qiu@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 1AF6493C8
 for <dev@dpdk.org>; Wed, 27 Jan 2016 04:11:08 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 26 Jan 2016 19:11:09 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,353,1449561600"; d="scan'208";a="901873162"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
 by fmsmga002.fm.intel.com with ESMTP; 26 Jan 2016 19:11:07 -0800
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 26 Jan 2016 19:11:07 -0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.215]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.231]) with mapi id 14.03.0248.002;
 Wed, 27 Jan 2016 11:10:55 +0800
From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH 4/4] virtio/vdev: add a new vdev named eth_cvio
Thread-Index: AQHRS9bN7ugI22Nzu0CX5CWDdRaOxg==
Date: Wed, 27 Jan 2016 03:10:54 +0000
Message-ID: <533710CFB86FA344BFBF2D6802E6028622F23310@SHSMSX101.ccr.corp.intel.com>
References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com>
 <1452426182-86851-1-git-send-email-jianfeng.tan@intel.com>
 <1452426182-86851-5-git-send-email-jianfeng.tan@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "nakajima.yoshihiro@lab.ntt.co.jp" <nakajima.yoshihiro@lab.ntt.co.jp>,
 "mst@redhat.com" <mst@redhat.com>,
 "ann.zhuangyanying@huawei.com" <ann.zhuangyanying@huawei.com>
Subject: Re: [dpdk-dev] [PATCH 4/4] virtio/vdev: add a new vdev named
	eth_cvio
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Jan 2016 03:11:09 -0000

On 1/11/2016 2:43 AM, Tan, Jianfeng wrote:=0A=
> Add a new virtual device named eth_cvio, it can be used just like=0A=
> eth_ring, eth_null, etc.=0A=
>=0A=
> Configured parameters include:=0A=
>     - rx (optional, 1 by default): number of rx, only allowed to be=0A=
> 				   1 for now.=0A=
>     - tx (optional, 1 by default): number of tx, only allowed to be=0A=
> 				   1 for now.=0A=
=0A=
=0A=
>>From APP side, virtio is something HW, in your implementation rx/tx is=0A=
max queue numbers virtio supported. Does it make sense?=0A=
=0A=
Why need user tell HW, how much queues it support? We'd better make it=0A=
un-configurable, only let users query it like the real HW, and then=0A=
decide how much queues it need to enable.=0A=
=0A=
=0A=
>     - cq (optional, 0 by default): if ctrl queue is enabled, not=0A=
> 				   supported for now.=0A=
>     - mac (optional): mac address, random value will be given if not=0A=
> 		      specified.=0A=
>     - queue_num (optional, 256 by default): size of virtqueue.=0A=
=0A=
Better change it to queue_size.=0A=
=0A=
Thanks,=0A=
Michael=0A=
=0A=
>     - path (madatory): path of vhost, depends on the file type:=0A=
> 		       vhost-user is used if the given path points to=0A=
> 	               a unix socket; vhost-net is used if the given=0A=
> 		       path points to a char device.=0A=
>=0A=
> The major difference with original virtio for vm is that, here we=0A=
> use virtual address instead of physical address for vhost to=0A=
> calculate relative address.=0A=
>=0A=
> When enable CONFIG_RTE_VIRTIO_VDEV (enabled by default), the compiled=0A=
> library can be used in both VM and container environment.=0A=
>=0A=
> Examples:=0A=
> a. Use vhost-net as a backend=0A=
> sudo numactl -N 1 -m 1 ./examples/l2fwd/build/l2fwd -c 0x100000 -n 4 \=0A=
>     -m 1024 --no-pci --single-file --file-prefix=3Dl2fwd \=0A=
>     --vdev=3Deth_cvio0,mac=3D00:01:02:03:04:05,path=3D/dev/vhost-net \=0A=
>     -- -p 0x1=0A=
>=0A=
> b. Use vhost-user as a backend=0A=
> numactl -N 1 -m 1 ./examples/l2fwd/build/l2fwd -c 0x100000 -n 4 -m 1024 \=
=0A=
>     --no-pci --single-file --file-prefix=3Dl2fwd \=0A=
>     --vdev=3Deth_cvio0,mac=3D00:01:02:03:04:05,path=3D<path_to_vhost_user=
> \=0A=
>     -- -p 0x1=0A=
>=0A=
> Signed-off-by: Huawei Xie <huawei.xie@intel.com>=0A=
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>=0A=
> ---=0A=
>=0A=
=0A=