From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Liu, Jijiang" <jijiang.liu@intel.com>,
"Zang, Zhida" <zhida.zang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] i40e: fixed tx packets stats bug
Date: Fri, 21 Nov 2014 06:54:28 +0000 [thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286C996A4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9D71A@SHSMSX101.ccr.corp.intel.com>
On 2014/11/21 14:33, Liu, Jijiang wrote:
> This patch V2 updated commit log.
Not only updated commit log, but also the code :)
Thanks,
Michael
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of zhida zang
>> Sent: Thursday, November 20, 2014 4:40 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH v2] i40e: fixed tx packets stats bug
>>
>> From: zzang <zhida.zang@intel.com>
>>
>> i40e only count tx packets that sent by pf. But in some condition packet can be
>> sent by NIC without being counted by pf. So count vsi tx packets instead.
>>
>> Signed-off-by: zhida zang <zhida.zang@intel.com>
>> ---
>> lib/librte_pmd_i40e/i40e_ethdev.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
>> b/lib/librte_pmd_i40e/i40e_ethdev.c
>> index 4b7a827..c1ea37e 100644
>> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
>> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
>> @@ -1102,6 +1102,7 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct
>> rte_eth_stats *stats)
>> struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data-
>>> dev_private);
>> struct i40e_hw_port_stats *ns = &pf->stats; /* new stats */
>> struct i40e_hw_port_stats *os = &pf->stats_offset; /* old stats */
>> + struct i40e_eth_stats *ves = &pf->main_vsi->eth_stats; /* vsi stats */
>>
>> /* Get statistics of struct i40e_eth_stats */
>> i40e_stat_update_48(hw, I40E_GLPRT_GORCH(hw->port), @@ -1277,15
>> +1278,18 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats
>> *stats)
>> /* GLPRT_MSPDC not supported */
>> /* GLPRT_XEC not supported */
>>
>> - pf->offset_loaded = true;
>> -
>> if (pf->main_vsi)
>> i40e_update_vsi_stats(pf->main_vsi);
>>
>> stats->ipackets = ns->eth.rx_unicast + ns->eth.rx_multicast +
>> ns->eth.rx_broadcast;
>> - stats->opackets = ns->eth.tx_unicast + ns->eth.tx_multicast +
>> + if (pf->offset_loaded)
>> + stats->opackets = ves->tx_unicast + ves->tx_multicast +
>> + ves->tx_broadcast;
>> + else
>> + stats->opackets = ns->eth.tx_unicast + ns->eth.tx_multicast +
>> ns->eth.tx_broadcast;
>> + pf->offset_loaded = true;
>> stats->ibytes = ns->eth.rx_bytes;
>> stats->obytes = ns->eth.tx_bytes;
>> stats->oerrors = ns->eth.tx_errors;
>> --
>> 1.9.3
> Acked-by: Jijiang Liu < Jijiang.liu@intel.com>
>
prev parent reply other threads:[~2014-11-21 6:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 8:40 zhida zang
2014-11-21 6:32 ` Liu, Jijiang
2014-11-21 6:54 ` Qiu, Michael [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533710CFB86FA344BFBF2D6802E60286C996A4@SHSMSX101.ccr.corp.intel.com \
--to=michael.qiu@intel.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
--cc=zhida.zang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).