From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id E730E3B5 for ; Tue, 16 Dec 2014 08:51:31 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 15 Dec 2014 23:51:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,585,1413270000"; d="scan'208";a="648293248" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by fmsmga002.fm.intel.com with ESMTP; 15 Dec 2014 23:51:29 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 16 Dec 2014 15:51:17 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by shsmsx102.ccr.corp.intel.com ([169.254.2.216]) with mapi id 14.03.0195.001; Tue, 16 Dec 2014 15:51:16 +0800 From: "Qiu, Michael" To: "Sujith Sankar (ssujith)" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT Thread-Index: AQHQFeR7GqqDPByGJUys4dRN5kOqUQ== Date: Tue, 16 Dec 2014 07:51:16 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CA02DA@SHSMSX101.ccr.corp.intel.com> References: <1418372303-31565-1-git-send-email-ssujith@cisco.com> <5911790.4rCTPaIceN@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Dec 2014 07:51:32 -0000 On 12/16/2014 12:13 PM, Sujith Sankar (ssujith) wrote:=0A= > On 16/12/14 4:54 am, "Thomas Monjalon" wrote:= =0A= >=0A= >> 2014-12-12 13:48, Sujith Sankar:=0A= >>> This patch corrects the usage of the flag VFIO_PRESENT in enic driver.= =0A= >> Please, could you explain why the flag VFIO_PRESENT was not well used?= =0A= > Without including eal_vfio.h, VFIO_PRESENT is not available in enic.=0A= > Hence VFIO specific code in enic was not getting compiled and some errors= =0A= > were generated during run-time.=0A= >=0A= >>> This has uncovered a few warnings, and this patch corrects those too.= =0A= >> [...]=0A= >>> --- a/lib/librte_pmd_enic/enic_main.c=0A= >>> +++ b/lib/librte_pmd_enic/enic_main.c=0A= >>> @@ -39,6 +39,7 @@=0A= >>> #include =0A= >>> #include =0A= >>> #include =0A= >>> +#include =0A= >>> =0A= >>> #include =0A= >>> #include =0A= >>> @@ -46,6 +47,7 @@=0A= >>> #include =0A= >>> #include =0A= >>> #include =0A= >>> +#include =0A= >> This header was not designed to be included by PMDs.=0A= >> It will break compilation on BSD.=0A= > Is there an alternative to make VFIO_PRESENT available in enic? Please= =0A= > advise.=0A= =0A= You can remove VFIO_PRESENT check, it all been done in eal, you can=0A= check other nic pmds for reference.=0A= And seems you done the interrupt logic all by your self?=0A= =0A= Thanks,=0A= Michael=0A= > =0A= > Thanks,=0A= > -Sujith=0A= >=0A= >>> #include "enic_compat.h"=0A= >>> #include "enic.h"=0A= >>> @@ -561,6 +563,7 @@ enic_free_consistent(__rte_unused struct=0A= >>> rte_pci_device *hwdev,=0A= >>> /* Nothing to be done */=0A= >>> }=0A= >>> =0A= >>> +#ifndef VFIO_PRESENT=0A= >>> static void=0A= >>> enic_intr_handler(__rte_unused struct rte_intr_handle *handle,=0A= >>> void *arg)=0A= >>> @@ -572,6 +575,7 @@ enic_intr_handler(__rte_unused struct=0A= >>> rte_intr_handle *handle,=0A= >>> =0A= >>> enic_log_q_error(enic);=0A= >>> }=0A= >>> +#endif=0A= >> -- =0A= >> Thomas=0A= >=0A= =0A=