From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id F37D42A9 for ; Thu, 25 Dec 2014 04:28:34 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 24 Dec 2014 19:28:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,641,1413270000"; d="scan'208";a="659812693" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by orsmga002.jf.intel.com with ESMTP; 24 Dec 2014 19:28:33 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 25 Dec 2014 11:27:11 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.110]) by shsmsx102.ccr.corp.intel.com ([169.254.2.216]) with mapi id 14.03.0195.001; Thu, 25 Dec 2014 11:27:10 +0800 From: "Qiu, Michael" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe driver to new API Thread-Index: AQHQH/D3zsuN0/0nzkaSTMZmTI5IAw== Date: Thu, 25 Dec 2014 03:27:09 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CA27E3@SHSMSX101.ccr.corp.intel.com> References: <1419477270-14611-1-git-send-email-jingjing.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/4] Integrate ethertype filter in igb/ixgbe driver to new API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Dec 2014 03:28:35 -0000 Hi Jingjing,=0A= =0A= Would you mind to tell me why need new APIs? Any functional or=0A= performance increase?=0A= Better to state in commit log.=0A= =0A= You know it should be careful to change APIs, especially for user=0A= interface. =0A= =0A= Thanks,=0A= Michael=0A= On 12/25/2014 11:14 AM, Jingjing Wu wrote:=0A= > The patch set uses new filter_ctrl API to replace old ethertype filter AP= Is.=0A= > It uses new functions and structure to replace old ones in igb/ixgbe driv= er,=0A= > new commands to replace old ones in testpmd, and removes the old APIs. = =0A= >=0A= > Jingjing Wu (4):=0A= > ixgbe: new functions replaces old ones for ethertype filters=0A= > e1000: new functions replaces old ones for ethertype filters=0A= > testpmd: new commands for ethertype filter=0A= > ethdev: remove old APIs and structures of ethertype filters=0A= >=0A= > app/test-pmd/cmdline.c | 253 ++++++++++++--------------=0A= > app/test-pmd/config.c | 27 ---=0A= > lib/librte_ether/rte_ethdev.c | 57 ------=0A= > lib/librte_ether/rte_ethdev.h | 88 ---------=0A= > lib/librte_pmd_e1000/e1000_ethdev.h | 13 ++=0A= > lib/librte_pmd_e1000/igb_ethdev.c | 332 +++++++++++++++++++++---------= ---=0A= > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 354 +++++++++++++++++++++++-------= ------=0A= > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 13 ++=0A= > 8 files changed, 579 insertions(+), 558 deletions(-)=0A= >=0A= =0A=