From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <michael.qiu@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 703521288 for <dev@dpdk.org>; Mon, 19 Jan 2015 10:30:40 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP; 19 Jan 2015 01:25:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,425,1418112000"; d="scan'208";a="639245090" Received: from pgsmsx105.gar.corp.intel.com ([10.221.44.96]) by orsmga001.jf.intel.com with ESMTP; 19 Jan 2015 01:30:32 -0800 Received: from kmsmsx154.gar.corp.intel.com (172.21.73.14) by PGSMSX105.gar.corp.intel.com (10.221.44.96) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 19 Jan 2015 17:30:31 +0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by KMSMSX154.gar.corp.intel.com (172.21.73.14) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 19 Jan 2015 17:30:31 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.64]) by shsmsx102.ccr.corp.intel.com ([169.254.2.238]) with mapi id 14.03.0195.001; Mon, 19 Jan 2015 17:30:31 +0800 From: "Qiu, Michael" <michael.qiu@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com>, David Marchand <david.marchand@6wind.com> Thread-Topic: [dpdk-dev] [PATCH v2] Fix rte_is_power_of_2 Thread-Index: AQHQIena5agmnQPVLkW1rokxyi5D6Q== Date: Mon, 19 Jan 2015 09:30:30 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CB74C5@SHSMSX101.ccr.corp.intel.com> References: <1419694115-1892-1-git-send-email-rkerur@gmail.com> <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7EA935@SHSMSX104.ccr.corp.intel.com> <CALwxeUu2YOFUeQ3urHxFk+3mYef0zyiZMCDnYTsiJ7o9K0Pzhw@mail.gmail.com> <7022282.sJULtgJP1R@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v2] Fix rte_is_power_of_2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 19 Jan 2015 09:30:40 -0000 On 2015/1/19 17:14, Thomas Monjalon wrote:=0A= > 2015-01-19 08:21, David Marchand:=0A= >> On Mon, Jan 19, 2015 at 3:45 AM, Zhang, Helin <helin.zhang@intel.com> wr= ote:=0A= >>=0A= >>> It seems that your fix result in cannot launching applications.=0A= >>> I don't suspect the correction of your fix, but somewhere else needs to= be=0A= >>> corrected together with your fix.=0A= >>>=0A= >>> Logs:=0A= >>> /************************************************************=0A= >>> RING: Cannot reserve memory for tailq=0A= >> I have a quick fix for this one (rte_malloc_socket refuses 0 alignment),= =0A= >> but looking at the change, I would say there are a lot of places to be= =0A= >> checked.=0A= >> Were those places checked during review ?=0A= > http://dpdk.org/browse/dpdk/commit/?id=3D2fc8d6daa4c7a=0A= > This case demonstrates that an Acked-by line is not always sufficient=0A= > to apply a patch.=0A= >=0A= >> Kerur, did you run a make test ?=0A= >> All tests fail for me because of rte_malloc_socket.=0A= > My dream would be to have a machine receiving patches, applying them in a= sandbox,=0A= > run some basic tests and reports failures.=0A= =0A= This could be, but I hope every contributor could do basic check like=0A= build and run of at lease one app like test-pmd, then it will reduce=0A= most of failure we faced.=0A= =0A= Then I think we can have one next branch, all patches first been=0A= reviewed and basic verified then applied to next, after all tested then=0A= merge to master(more stable)=0A= =0A= Then all the release could based on master branch, it also could avoid=0A= lots of unstable RC release(like compile error we see before, it should=0A= not happen in RC release in my mind).=0A= =0A= Thanks,=0A= Michael=0A= >=0A= > It should be fixed now:=0A= > http://dpdk.org/browse/dpdk/commit/?id=3D8e3e06501660=0A= >=0A= =0A=