DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix assertion check warnings
@ 2020-11-17 11:01 Xueming Li
  2020-11-17 20:53 ` Raslan Darawsheh
  0 siblings, 1 reply; 3+ messages in thread
From: Xueming Li @ 2020-11-17 11:01 UTC (permalink / raw)
  To: Matan Azrad, Viacheslav Ovsiienko; +Cc: dev, xuemingl, Asaf Penso, stable

Fix assertion check warnings.

Fixes: 8bb81f2649b1 ("net/mlx5: use thread specific flow workspace")

Cc: stable@dpdk.org
Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Reviewed-by: Slava Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h
index f64384217f..afddcfc12c 100644
--- a/drivers/net/mlx5/mlx5_flow.h
+++ b/drivers/net/mlx5/mlx5_flow.h
@@ -1108,7 +1108,7 @@ struct mlx5_flow_workspace {
 	struct mlx5_flow flows[MLX5_NUM_MAX_DEV_FLOWS];
 	struct mlx5_flow_rss_desc rss_desc;
 	uint32_t rssq_num; /* Allocated queue num in rss_desc. */
-	int flow_idx; /* Intermediate device flow index. */
+	uint32_t flow_idx; /* Intermediate device flow index. */
 };
 
 struct mlx5_flow_split_info {
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix assertion check warnings
  2020-11-17 11:01 [dpdk-dev] [PATCH] net/mlx5: fix assertion check warnings Xueming Li
@ 2020-11-17 20:53 ` Raslan Darawsheh
  2020-11-21 11:36   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Raslan Darawsheh @ 2020-11-17 20:53 UTC (permalink / raw)
  To: Xueming(Steven) Li, Matan Azrad, Slava Ovsiienko
  Cc: dev, Xueming(Steven) Li, Asaf Penso, stable

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xueming Li
> Sent: Tuesday, November 17, 2020 1:01 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Asaf Penso
> <asafp@nvidia.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix assertion check warnings
> 
> Fix assertion check warnings.
> 
> Fixes: 8bb81f2649b1 ("net/mlx5: use thread specific flow workspace")
> 
> Cc: stable@dpdk.org
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> Reviewed-by: Slava Ovsiienko <viacheslavo@nvidia.com>
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix assertion check warnings
  2020-11-17 20:53 ` Raslan Darawsheh
@ 2020-11-21 11:36   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2020-11-21 11:36 UTC (permalink / raw)
  To: Xueming(Steven) Li, Slava Ovsiienko, Raslan Darawsheh
  Cc: Matan Azrad, dev, Asaf Penso

> > Fix assertion check warnings.
> > 
> > Fixes: 8bb81f2649b1 ("net/mlx5: use thread specific flow workspace")
> > 
> > Cc: stable@dpdk.org
> > Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> > Reviewed-by: Slava Ovsiienko <viacheslavo@nvidia.com>
> 
> Patch applied to next-net-mlx,

I know this patch is minor, but we should not write, review and apply
a fix which does not explain the issue, not even referencing the warning.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 11:01 [dpdk-dev] [PATCH] net/mlx5: fix assertion check warnings Xueming Li
2020-11-17 20:53 ` Raslan Darawsheh
2020-11-21 11:36   ` Thomas Monjalon

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox