From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D63A43250; Wed, 17 Jan 2018 15:06:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6CEFC20E71; Wed, 17 Jan 2018 09:06:40 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 17 Jan 2018 09:06:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=b/SGK3bll8df5p06Ov3XW89rw/ iACo6wAW6nitnvC2g=; b=gQPijAD7pIckwck0D7b9ZwR8hYOfOn6TzN2F4geBQB 7fsA017Yj+9A9nnJcG0pdT1xzvC8n5/IYrxmajNc8J3Vq8WThphwndKrKgi2oIkr iN3byXhIYHiYPnRwgU/+98duXyWrC1lb5qV8pa3g4IaAoCMlWMJ5C7bZSambznJO k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=b/SGK3 bll8df5p06Ov3XW89rw/iACo6wAW6nitnvC2g=; b=a/5zKNsW+rcAl4hoHVmJLO XtRktn6VUN4X/5+agIj1THGJ2eX5l1jFLmR+nMduJURK2kiVLOuLtXMmj6OIqC9X I8igB8zVEKMPXCCiJqTSSpXN5hNUld03oFZW9jFPoTfbWgCFdhZUBmN0pUb4nV3z UszzrM/trKWwies8r6v30mRTIbdJ4niwD6nhdnLX18sVqwhKaNhcXwgudLv1Xmfq vpA2SM0+Pd3iJn778BgE7fVYb7s37pzyk3f2XBn8/8/zuTPPP4xvgvX8lDIpshyC RMuwGJcBJJySa5pLVQz2EfsYC4SgSQzvZPlhMT2Wc4F0bgXYyPHSuyT35z7EX2JA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1A0C87E322; Wed, 17 Jan 2018 09:06:40 -0500 (EST) From: Thomas Monjalon To: Wei Dai Cc: dev@dpdk.org, ferruh.yigit@intel.com, yuan.peng@intel.com, konstantin.ananyev@intel.com, wenzhuo.lu@intel.com, jingjing.wu@intel.com, stable@dpdk.org Date: Wed, 17 Jan 2018 15:06:07 +0100 Message-ID: <5342816.T2QiQ58HNc@xps> In-Reply-To: <1515756682-69016-1-git-send-email-wei.dai@intel.com> References: <1515744603-60457-1-git-send-email-wei.dai@intel.com> <1515756682-69016-1-git-send-email-wei.dai@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 0/2] app/testpmd: fix invalid rxq and txq nubmer settings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jan 2018 14:06:41 -0000 12/01/2018 12:31, Wei Dai: > If an invlaid number of RX or TX queues is configured from testpmd > command like "port config all rxq number" or "port config all txq > number" or from --rxq and --txq in the command to start testpmd. > The global variable nb_rxq or nb_txq is updated by the invalid > input. This can cause testpmd crash. For example, if the maximum > number of RX or TX queues is 4, testpmd will crash after running > commands "port config all rxq 5", "port config all txq 5" and > "start" in sequence. > With these 2 patches, if an invalid input is detected, it is refused > and testpmd keeps last correct values of nb_rxq and nb_txq. > > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > Cc: stable@dpdk.org > > Signed-off-by: Wei Dai > Aced-by: Konstantin Ananyev > Tested-by: Yuan Peng Applied, thanks