From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BA6FA0561; Tue, 21 Apr 2020 04:13:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8AD71D67C; Tue, 21 Apr 2020 04:12:59 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7CFBD1C1AE for ; Tue, 21 Apr 2020 04:12:58 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 0D7935C010F; Mon, 20 Apr 2020 22:12:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 20 Apr 2020 22:12:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= t51u+kRw7K6KSjtkwPy1QNY7jRX+XT/g7gPVtMTKRVc=; b=j1FZxQW29oQfcNPY sVCJ27YfV0P5/W+LVV0PD7g/IOjPCcJDUJQoVBcZW/+UPVpMEGpZd9J5QmEGhI0z eb6Mkh3XNMsdXr59eRo4RIqqpha7KwYmsWDI23ltBcs3f/1uGYsDv+bqu81uVzSj dyVf6Gfl8OGUrb5qPzdKdC2TchxBIZ0N/o/ts4anA1j5gVkSo1Z1WKC1y1F2h3GW I6RqTN6sm3ynNX/LaHkHoPNMQStKm2U+5sU+i+LBNPlomjTSgdmnjn0ghKNP44wY a2GInw7xrVo6L7SnplNfQvaxg3UWkzuq3DQYSUNnL4YZvuYp8tA5hgTpVZdIR2bU yjDBjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=t51u+kRw7K6KSjtkwPy1QNY7jRX+XT/g7gPVtMTKR Vc=; b=gUx56t8eNfhZ8oQtzXYZzrAgAy4qdMxjVA3ivK10RIooVx9cMhuNnn3cw exuRX5F0Y7rZrzDzfkwKkZ8GjnoEiioI+8B6oa7qJk6R5wa37BeKFgtSOt6NP+NZ jIn02o/Q7glq4LlxtOcFCo1DVst8ZttWo/ZeqsLqHUzCLqHIcxNYzvsxBR9r3ZBD a9iEmPf5LdobVaqZPKKTBJSyUY/r3+07XNpZ/oMNCrOKh7Jn8fFuIdJb9PJh9huC ckHNZ4o+/lLO0qUQ5B9v9yv0mWhtjYa78TVAnlKBK/SkkgSoh24LqyZIKebg4FBu kI0sdYucySqwY/BDsNcERr6ryANUg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeeggdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrsh esmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9241E3065C49; Mon, 20 Apr 2020 22:12:55 -0400 (EDT) From: Thomas Monjalon To: David Marchand , "Wang, Haiyue" Cc: Neil Horman , dev , "Burakov, Anatoly" , Vamsi Attunuru , Jerin Jacob Kollanukkaran , "Yigit, Ferruh" , "Richardson, Bruce" , "Kinsella, Ray" Date: Tue, 21 Apr 2020 04:12:54 +0200 Message-ID: <5346011.DvuYhMxLoT@thomas> In-Reply-To: References: <20200305043311.17065-1-vattunuru@marvell.com> <3886348.YqazSvReao@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/04/2020 03:38, Wang, Haiyue: > From: Thomas Monjalon > > 20/04/2020 19:37, Wang, Haiyue: > > > From: Thomas Monjalon > > > > 20/04/2020 19:02, Wang, Haiyue: > > > > > From: David Marchand > > > > > > I had a look at the CI, I can see we are still missing bits to handle > > > > > > the ABI failure on rte_vfio_setup_device. > > > > > > > > > > Yes, not handle it now. > > > > > > > > > > If 'rte_vfio_setup_device' can be internal, not official DPDK API, then __rte_internal > > > > > is the best way to handle ABI issue. > > > > > > > > Please could you help finishing integration of __rte_internal? > > > > > > I thought it should be Neil ? "Yes, I'll get back to this today" ;-) > > > http://inbox.dpdk.org/dev/CAJFAV8ydLkV0afEHqbh6KeA3Box0Yxb3N0MNGtMD4S9bmSgT0A@mail.gmail.com/ > > > > It did not happen after several months. > > If you want to unblock your patches, I think it is safer to finish yourself. > > > > Unfortunately, this __rte_internal will still make the ci fail to run when move the function > to INTERNAL session: [...] > +INTERNAL { > + global: > + > + # added in 20.05 > + rte_vfio_setup_device; > +}; Why do you need to move the symbol explicitly in .map? The tool should ignore symbols moving to internal, as an exception until 20.11.