From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF35743261; Wed, 1 Nov 2023 14:13:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 98A5340151; Wed, 1 Nov 2023 14:13:20 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2059.outbound.protection.outlook.com [40.107.93.59]) by mails.dpdk.org (Postfix) with ESMTP id 20965400EF for ; Wed, 1 Nov 2023 14:13:19 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5PJAf3wfYfZjEtG3VBBna80+qrLVieGlSGk0sXcudzGbuIcptkJx0MjlPIicDwsP2fxg++Gz8HslFGQVKZf7Le7CZSBipW6zoh5YsOq7DUckUIdJfP+zEgzB9YAgYbl4Qmq9Wg3znCw6RL8b9hs23etLeR5NfFg82u33OR7wIZzupk88CAbvzlntwdQNDQx8xyfmLXha/mSeBXcAMFrxeSabimywGMVZFCacGAvQGoP8Sv9SugAY+8XldI3pYPZSMHpxuvwumrgsOdzVFt0MYaHNWR7kSx7lNI8ytn20NhT3MahNngyNFvtZVbdHyNy/1gThIyov3jOhR0CkYsaEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=13wuMMHH4PxmBi9ZM7lk+A2v4rt5Uh7DnwgxODoIQaM=; b=UOTIIGFVzIpdPgYBcJxrKtaQfYbDLFh5KKftvYR+3qx5FonDh1aDlfXKN0EABOTok0R8SdKm23v5Lq3OkYt7XrNRoT4vRlVME6uYCmvrfCf+q2Qzu2soOzt+Pu7z9dPH0RNe0f6B4vKRh88mETJW4WtfpvMj4NVZi8z8z3QtdhmpzKeCUd/yWLygQ8s065mYfkbgu0q2onsssLbJLr/1PQIPNlkVUdiqIbQtLraNpsysMa2QAGa3C2qbj03G2MlBcRQYalWR4IDxUBexPxDtNCyYLU0DP6w/Zqv7tz5dtQ7DnfIN1aB5aFj590sNLOgMR/ivxNj5atSxUz7pp5qJWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=13wuMMHH4PxmBi9ZM7lk+A2v4rt5Uh7DnwgxODoIQaM=; b=XERlMnR/szCDW5cjtTLnVVayUOPKcWYZDXsBZWpB3fHXNyijAbCPrLcRUtSkSfoF/m9RqdxzbS4A+LvpxemXl3lAi0Cpa4oiouDnITqTdaklOOMkciiyYtZS0QH5MRY2nu1USsCG0kduruIT/s20T8oNxws61XEE6ZO2c9YLmYA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ2PR12MB9240.namprd12.prod.outlook.com (2603:10b6:a03:563::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Wed, 1 Nov 2023 13:13:15 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.019; Wed, 1 Nov 2023 13:13:14 +0000 Message-ID: <53497412-9211-47c1-a57a-27ee19ada312@amd.com> Date: Wed, 1 Nov 2023 13:13:07 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 01/10] ethdev: overwrite some comment related to RSS Content-Language: en-US To: Jie Hai , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Ori Kam Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com References: <20230315110033.30143-1-liudongdong3@huawei.com> <20231101074039.3088716-1-haijie1@huawei.com> <20231101074039.3088716-2-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20231101074039.3088716-2-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ2PR12MB9240:EE_ X-MS-Office365-Filtering-Correlation-Id: f85314d2-fceb-462c-977e-08dbdadc4e55 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R1FVsdjEEraEc5DLrK33xDJaCSlcd7NDoDSKSvBUKPek6UvNEKzKQj08iDR5RoE6cK/6asdBiNrCO5PB5dam85WkOoqkPF68lh39/bUIQd4GJmIoPDGc5VoofJmZ2Lo+Uymz7sYioc9ieXHiwRt9lVxZ6k68B1VlW1D7QxPUy2uSV8IKPl4cBGjRdiEdYyw9UE9rWwlVyZBhCFsqvP9DSODWZT8dl7dSDAbfaCf8xIpKc77VVhZN2913IISU6kg6kt/7qB/EL9fhI+BSTzLc2DfSPRSpKIHIjJ73hBtAJjpOMtqQvVi5Wl/nq/6ma+QENaHduC7MecU6b54f1kGqIRlE78qKav867OqqGMu2x/mTwGZl+sVgy3oeOolkrybjd5lTxUW1kvfmuxzA4+X4g8yr3OwWNZKi73cGBJLGBBo4PIJve2rWnfHQLcXtqKM8wjIdsjXlpPr0dJtzuXj5VDa3bxkjyvaDrpDpudarPZGcMNueVCqaGFrJqAOwvhLvqIlccOC39L71/78jyLGn9Nzs1VYdQmLR8orQwtQZiHv2X7SLlB48Sbf8WKZNhjjomDvuU2Zlv7L8ntZluVZSFap8Igdqn4FxxOvrMZXZNlU9Cv0FJ6hB5NcMe7+k4BV8rZNv3RuDKlGt37BgK+Avtw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(396003)(366004)(346002)(39860400002)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(478600001)(26005)(6512007)(2616005)(53546011)(6506007)(6666004)(83380400001)(2906002)(5660300002)(110136005)(41300700001)(8936002)(4326008)(66946007)(8676002)(44832011)(6486002)(66476007)(66556008)(316002)(31696002)(38100700002)(86362001)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?am45aXB1alN2dWVsb21IMHF3T1FURmkvcUNZSTVqeVBsQjNjOHlSR1FndUds?= =?utf-8?B?OEU1dkJ3Sm1uQkVoM3VSL2VNY0ZwOFdFcEh2UDROeVFUa3FXVWRiNlNETFlS?= =?utf-8?B?Wi9DQTkzNS9oczBScXdIQ0YvQVVTNmE0K1l3OXdCUWNDV09lemV1NzAwUlY2?= =?utf-8?B?MG44anBvazZ2dER5L21NT1RLOU1UbCtRZDIzYUNIdXRuRTZwUTExTUF3Z0hn?= =?utf-8?B?eUYzYkh5eGo3d1dqT1Nac09IN2srWGNZSEs1MU0zUjJsc2V0bEprUllVTXlr?= =?utf-8?B?dnd4ZmpSSlBiU1hXV0tBRU5BUVhNWkZRNjhNSFVxTVpKV0F1M0t5TjVrRXN3?= =?utf-8?B?RS9GTWtqVjdBdWpyYTRJSmJGSGRzTit2TFAxZ0pOM1lZSU9VOWtiUzJiOU1T?= =?utf-8?B?K3NiV2pScHFVVTRiazRpUUpjSTR3SStub1d1NGRMWDA0Z2JiT0Z2THZ4dERj?= =?utf-8?B?VWZxaHJtTnFucVdLWVdDVGxMb0xicGdvUFRIUktIdjhHY1V6Y2x6bi96eHA3?= =?utf-8?B?RTJsa1c2YTRuVFRURFRwbWhEaWp0RGdUczVUamhnOGFHWEEvQ3gwamFxRDNM?= =?utf-8?B?bmxEbldkM3ZGVVB2S1ErMkwrd2tYQ3NnUjkySTdMY1UvVXNUZzk4SXN3LzlD?= =?utf-8?B?UUtLMVRMeTc0RlBlY1FDZlBpYkFLNjlybE85WXFRaDFyODBEYTN5U3hMaGpS?= =?utf-8?B?WXp1NzVnUFdEZXJ3akNFTE4wcnZObHNOSmJWVkFBSUFONVozeUE4L1RxSmRa?= =?utf-8?B?Y0dxNnUzeXJ6R3AzeXJ2MnQvMnk5K2xaRGh1KzBwN2dGMVZhWjdYbHZrTUxN?= =?utf-8?B?UlhneTJsTTBid2NtRkZNTnlOUWI5SzVTRjhzRSs0QUFieU5qT3BWUlBvL0NY?= =?utf-8?B?Yy9CcUIxSU45SHowWmxvM0tqWFdLYjRETXRzVktVOXNqS1o5aWtDZGIydnV6?= =?utf-8?B?blBpT2FWNWhzd01UOS84eWU2MVNYMTJ5UnVqdy81bW9JakJUTkc0Sy9iTnZa?= =?utf-8?B?UHFDaFJraDRUVlEwNkJadUtrVW1oYzBlUWp0cVFhdjU4d2p0eW5SVlpGV1pC?= =?utf-8?B?QloxZlU5ZytlRTBlbVVJZCtBaXQzTUhsSExaN3FtODJIemlRbmpBRFhrUGdO?= =?utf-8?B?ZmpwUUtoQjB2Q01JS0dYUGl0MkdKZ2hFR09ocVZWUXZsS3ZmNVhPSGJ6RTVF?= =?utf-8?B?ZldhVllXS1lQWTB3eUlqekFsNWZJUnBPY09KRXNtdis3bGdiS2lmYk1JaU5x?= =?utf-8?B?SEk1aFlrNjA4NU1jeUJrcG0rNW40NTZDQ3pYb1VFUG9oVzNrNzducGprYThr?= =?utf-8?B?dXlDNUcyRU0vdzdNNXc1eW16TlRnRU1Ba1o4bTcxMTNsNU5kRHZXY3VGUGo0?= =?utf-8?B?TC90ME94MHE3a3ZCVk1rdExaSE9xZW1ISWlMcllYOU16NU84NHZiaGdMWW1v?= =?utf-8?B?N2RYOU5zYUxENG5OZ3NNU0E0UFN3ZHVyNUswd3Q2WjBVakVqcmkvM0Z1T1JX?= =?utf-8?B?Q0s4Q0E4QlNLRjhPMjIzYjJ1L0RRWkx1TzVPeWx4OSttTnVWQWFjYWhiQ21m?= =?utf-8?B?OTZvQjVHeDdUYjhqS0ZkUlpuQnU0eFBLdVRpd3FmNVZKVHhBTlhDajh5dmdm?= =?utf-8?B?eDJiM1l5R3E2dXg0bGxCU2MrMUkrSTBha0gyWWV3OWhmcW4yQnYvQjl4bkFR?= =?utf-8?B?RlovbmdNVHZzMkIrRk9KZ0N3ekJpdWhmNkxnYzkvT3NrWW5CblhSb3U5VXJR?= =?utf-8?B?UGFpZUJzc3ZTNStrYndSampCNHBhWHhDQkxOZmYxUU9wSXQ2LzVoUkF5RUNL?= =?utf-8?B?alpESE9tY0tleG5mbEF3UWdTTkpxZ3haRUhoSlh2WXAyeCttWWRvQ1pjOStw?= =?utf-8?B?UVRhSkZOcDdFZVoyclk3aVNxZDdlMkVVelZRN1ZFNUJEdE1CNUZ4ZHEwclN3?= =?utf-8?B?T3drRWl2NURYUk9JVmRPclJXVVZsczZwend1WlJRTDhERVZZdW4zbFFRNmFl?= =?utf-8?B?VHR5UzAzWVRIRTU4WTFVWnpJYXJPY3hBNUl0YUF2VE5LU3Z3V1h0M3hraG9s?= =?utf-8?B?SFo4R0traU1OeU5nQ2JSLzNOR2lCb1VNZmZSRzJCdnlqL3R6d0xrd24yaU8x?= =?utf-8?Q?RGK3ghuobT7dw89Vrd9zletks?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f85314d2-fceb-462c-977e-08dbdadc4e55 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 13:13:14.7192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qAP5IjHDhyNBdY+gKjV2tPTBoHJeM1ppFqgTsAMPauLNeHVdJ2bOcfS/Iayz86Kx X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9240 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/1/2023 7:40 AM, Jie Hai wrote: > 1. overwrite the comments of fields of 'rte_eth_rss_conf'. > 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev.h | 34 +++++++++++++++++++--------------- > lib/ethdev/rte_flow.h | 1 + > 2 files changed, 20 insertions(+), 15 deletions(-) > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index a53dd5a1efec..343a134fdd12 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -448,24 +448,28 @@ struct rte_vlan_filter_conf { > /** > * A structure used to configure the Receive Side Scaling (RSS) feature > * of an Ethernet port. > - * If not NULL, the *rss_key* pointer of the *rss_conf* structure points > - * to an array holding the RSS key to use for hashing specific header > - * fields of received packets. The length of this array should be indicated > - * by *rss_key_len* below. Otherwise, a default random hash key is used by > - * the device driver. > - * > - * The *rss_key_len* field of the *rss_conf* structure indicates the length > - * in bytes of the array pointed by *rss_key*. To be compatible, this length > - * will be checked in i40e only. Others assume 40 bytes to be used as before. > - * > - * The *rss_hf* field of the *rss_conf* structure indicates the different > - * types of IPv4/IPv6 packets to which the RSS hashing must be applied. > - * Supplying an *rss_hf* equal to zero disables the RSS feature. > */ > struct rte_eth_rss_conf { > - uint8_t *rss_key; /**< If not NULL, 40-byte hash key. */ > + /** > + * In rte_eth_dev_rss_hash_conf_get(), the *rss_key_len* should be > + * greater than or equal to the *hash_key_size* which get from > + * rte_eth_dev_info_get() API. And the *rss_key* should contain at least > + * *hash_key_size* bytes. If not meet these requirements, the query > + * result is unreliable even if the operation returns success. > + * > + * In rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(), if > + * *rss_key* is not NULL, the *rss_key_len* indicates the length of the > + * *rss_key* in bytes of the array pointed by *rss_key*, > I think it is sufficient to say "length of the *rss_key* in bytes". > and it should > + * be equal to *hash_key_size*. > I don't know if we missed something here, first driver reports key size via 'rte_eth_dev_info_get()::hash_key_size', later other APIs require 'rss_key_len' parameter that should be same as 'hash_key_size', as driver already know this parameter why we are requesting it back from the application? >> Otherwise, drivers are free to use a > + * random or a default key or to ignore this configuration. > + */ > I guess above clause describes when 'rss_key' is null, can you please clarify it as following, perhaps with a line break: "If *rss_key* is NULL, drivers are free to use a random or a default key." For the "Drivers are free to ignore the *rss_key_len* and assume key length is 40 bytes." part, as checks in ethdev layer now forces application to provide 'rss_key_len' as 'hash_key_size', I think we can remove above, as application will provide 40 bytes when it is the case. My concern is this check now can break some applications, because 'rss_key_len' wasn't mandatory previously, but it became now. Overall it becomes: " In rte_eth_dev_rss_hash_update() or rte_eth_dev_configure(), if *rss_key* is not NULL, the *rss_key_len* indicates the length of the *rss_key* in bytes and it should be equal to *hash_key_size*. If *rss_key* is NULL, drivers are free to use a random or a default key. " > + uint8_t *rss_key; > uint8_t rss_key_len; /**< hash key length in bytes. */ > - uint64_t rss_hf; /**< Hash functions to apply - see below. */ > + /** > + * Indicates the type of packets or the specific part of packets to > + * which RSS hashing is to be applied. > + */ > + uint64_t rss_hf; > }; > > /* > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index c16fe8c21f2f..751c29a0f3f3 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -3226,6 +3226,7 @@ struct rte_flow_query_count { > * Hash function types. > */ > enum rte_eth_hash_function { > + /** DEFAULT means driver decides which hash algorithm to pick. */ > RTE_ETH_HASH_FUNCTION_DEFAULT = 0, > RTE_ETH_HASH_FUNCTION_TOEPLITZ, /**< Toeplitz */ > RTE_ETH_HASH_FUNCTION_SIMPLE_XOR, /**< Simple XOR */